Page MenuHomePhabricator

[AArch64] Add missing UINT_TO_FP promotions for v16i8
ClosedPublic

Authored by joechrisellis on Thu, Apr 22, 3:12 AM.

Diff Detail

Event Timeline

joechrisellis created this revision.Thu, Apr 22, 3:12 AM
joechrisellis requested review of this revision.Thu, Apr 22, 3:12 AM
Herald added a project: Restricted Project. · View Herald TranscriptThu, Apr 22, 3:12 AM
david-arm added inline comments.
llvm/test/CodeGen/AArch64/sve-fixed-length-fp-converts.ll
175

Shouldn't we have some CHECK lines for the codegen in these functions?

joechrisellis added inline comments.Mon, Apr 26, 3:30 AM
llvm/test/CodeGen/AArch64/sve-fixed-length-fp-converts.ll
175

Hi @david-arm -- the codegen here is not particularly interesting at the moment (and is actually quite poor). These functions are actually defending against selection failures. At this point I'm not entirely convinced that writing CHECK lines for the codegen here is valuable. Do we definitely need them? 🙂

paulwalker-arm added inline comments.Mon, Apr 26, 3:42 AM
llvm/test/CodeGen/AArch64/sve-fixed-length-fp-converts.ll
175

@joechrisellis This is true for much of this file. If you look at the other tests you'll see reference to CHECK-COUNT-### to ensure the code generation is somewhat sensible. I recommend following this same pattern.

Address review comments.

Gentle ping. 🙂

paulwalker-arm accepted this revision.Tue, Apr 27, 5:10 AM

Looks fine to me given this is more a "compiler shouldn't crash" test that will be updated once we have support to custom lower these nodes.

This revision is now accepted and ready to land.Tue, Apr 27, 5:10 AM