Software engineer at Arm.
User Details
- User Since
- Oct 15 2020, 5:36 AM (25 w, 5 d)
Today
Fix failing llvm/test/CodeGen/AArch64/sve-fixed-length-int-rem.ll test.
Yesterday
Thu, Apr 8
Gentle ping. 🙂
Wed, Apr 7
LGTM. 😄
Tue, Apr 6
Address comments.
Thu, Apr 1
Thanks for the patch @junparser! Just a few minor comments from me. 🙂
Wed, Mar 31
Improve test and address review comments.
Minor change to x86-predication.ll test.
Tue, Mar 30
Hmm. I anticipated there might be some test failures for this one.
Mon, Mar 29
LGTM. 😄
Apply @paulwalker-arm's comments from D98625 -- just test updates.
Address comments.
Hi, thank you for the patch! The optimisation seems sound to me -- just a few comments on the test side. 😄
Tue, Mar 23
Address review comments.
Mon, Mar 22
Wed, Mar 17
Hi @kmclaughlin -- looks good to me modulo @david-arm's and @CarolineConcatto's comments. 🙂
Address review comments.
Tue, Mar 16
Address code review comments.
Address comments:
Amend labels.
Remove the -aarch64-sve-vector-bits-min=4096 case; the architectural maximum is 2048 bits, so this case is erroneous.
Mon, Mar 15
Politely pinging this. 🙂
Politely pinging this. 🙂
Mar 12 2021
Mar 8 2021
Address review comments.
Address comments.
Mar 5 2021
LGTM -- the test is a little noisy but I suppose that's par for the course for this kind of check. 🙂
Address review comments.
After some discussion with @paulwalker-arm we think this might be better placed as an IR-level optimisation in SVEIntrinsicOpts.cpp. Therefore, I am going to abandon this revision and create a new one. 🙂
Mar 4 2021
Address comments.
Mar 3 2021
Feb 23 2021
Address linter comments.
Feb 22 2021
Address @c-rhodes's comment.
Address comments.
Feb 19 2021
Address @david-arm's comments.
Feb 18 2021
Ideas for more tests appreciated. 😄
Feb 17 2021
Use inline instead of inline.
That makes sense and suggests we're missing some additional C++ testing?
Speaking to @DavidTruby about this, it appears that this fix is insufficient -- inline has important semantic meaning in C++ that means that we can't simply omit the keyword here.
Feb 11 2021
ACK, fair point!
Address @david-arm's comments.
Feb 10 2021
Feb 5 2021
Feb 4 2021
@asl -- yes -- doh! Muscle memory. Sorry about that.
Feb 3 2021
Hi @david-arm, thanks for the review!
Address @david-arm's comments.
Jan 28 2021
Jan 25 2021
Jan 20 2021
Thanks for the comments @fhahn! 😄
Address @fhahn's comments.
Jan 14 2021
@fhahn: thanks for your comments -- you have persuaded me. 🙂
Address @fhahn's comments.