No longer working on LLVM.
User Details
- User Since
- Oct 15 2020, 5:36 AM (154 w, 4 h)
Jun 24 2021
Bugfixes.
Jun 23 2021
Jun 21 2021
Bugfixes.
Update insertion indices. The old insertion indices will be reported as invalid
when D104468 is merged.
Address review comments.
Jun 18 2021
Address review comments:
Address review comments.
Jun 17 2021
Thanks for the reviews guys.
Thanks for the reviews guys.
Jun 9 2021
Looks good to me. 😄
Jun 4 2021
Apologies @bsmith, ignore my last comment. The pattern matching stuff is only for IR -- I had mistakenly thought that it could be used in this context, but it can't. Sorry! 😅
Gentle ping. 🙂
Jun 3 2021
LGTM, one small suggestion.
Jun 2 2021
Remove CFI entries from test.
Scale index by vscale.
Jun 1 2021
Address review comments.
Fixup RISCV tests.
Address review comments.
May 21 2021
Fold in D102765 + address nits.
This change will be folded into D102766.
@paulwalker-arm ACK -- will fold this into D102766. 🙂
Address review comments.
May 20 2021
Reviewers, especially @david-arm: there are still additional verifier checks to be implemented. In particular, we can add a verifier check for 'overrunning' the vectors with an insert/extract. This is currently handled by spawning an undef at the moment, but where we can determine this statically it makes sense to have the verifier spit an error. 🙂
Address review comments.
May 19 2021
May 18 2021
Remove unused %pg variable in test.
May 17 2021
May 13 2021
May 6 2021
Address review comments.
May 5 2021
One nit, otherwise LGTM.
May 4 2021
Bugfix: check that UserPg's intrinsic ID is a ptrue, otherwise we crash in some circumstances.
Apr 28 2021
LGTM!
Apr 27 2021
Gentle ping. 🙂
Apr 26 2021
Address review comments.
Hello! This looks good to me modulo a few nits.
Apr 23 2021
Apr 22 2021
Address review comments:
Apr 21 2021
Apr 20 2021
Address review comments.
Apr 19 2021
Address review comments.
Address review comments.
Gentle ping. 🙂
Apr 16 2021
Address review comments.
LGTM!
Address review comments.
Address review comments.
Address review comments.
Apr 15 2021
@dmgreen -- I hear you, makes sense to me. There might be some functionality already in SVEIntrinsicOpts.cpp that we can pull out, but I guess that can wait for later. In any case I'll move the functionality here to the other passes to reflect your suggestions.
Hi @dmgreen! This is SVE-specific, and SVEIntrinsicOpts.cpp is where such transformations are typically placed (at least for now). I did a quick grep and it seems SVE intrinsics don't currently have much of a presence in generic passes like instcombine/constant folding, perhaps because some SVE optimisations are more complex than others and I guess it makes sense to keep them all in the same place.
Apr 14 2021
Hi @fhahn -- thanks for the review!
Address review comments.
Apr 13 2021
Fix failing llvm/test/CodeGen/AArch64/sve-fixed-length-int-rem.ll test.