Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
llvm/test/CodeGen/AArch64/sve-fixed-length-extract-vector-elt.ll | ||
---|---|---|
29 | The tests that take 64/128 bit vectors should pass the vector parameter directly rather than by reference. | |
56 | Can the tests use a variable index instead? I ask because for all these tests 2 fits within the NEON range and thus when some future work lands none of these tests will emit SVE instructions. FYI: This is also generally true as in future I'd even the variable index variants to just emit a scalar load, but this will change once all the tests are updated to use pass by value. This is not something you need to worry about though so updating them to use a variable index is sufficient. |
Address review comments.
- @paulwalker-arm:
- tests that take 64/128 bit vectors now pass the vector parameter directly rather than by reference.
- as discussed offline, use a higher index for tests.
llvm/lib/Target/AArch64/AArch64ISelLowering.cpp | ||
---|---|---|
10002 | Are there any uses of this? If not then you may as well preserve the original EVT VT = Op.getOperand(0).getValueType(); | |
llvm/test/CodeGen/AArch64/sve-fixed-length-extract-vector-elt.ll | ||
94 | This falls under my previous "The tests that take 64/128 bit vectors should pass the vector parameter directly rather than by reference." comment. There should also be a <2 x float> test. | |
151 | You're missing tests for <1 x double> and <2 x double>. |
Address comments.
- @paulwalker-arm:
- do not use pass-by-reference for 64-/128-bit tests.
- add tests for <2 x float>, <1 x double>, and <2 x double>.
Are there any uses of this? If not then you may as well preserve the original EVT VT = Op.getOperand(0).getValueType();