[obj2yaml][yaml2obj] - Add AArch64 STO_AARCH64_VARIANT_PCS support

[MaskRay]

Looks great! Please wait for @grimar who initially requested the separate patch.

llvm/test/tools/obj2yaml/ELF/aarch64-sym-other.yaml

2

Period after a complete sentence.

[grimar]

LGTM with 2 minor nits. Thanks!

llvm/test/tools/obj2yaml/ELF/aarch64-sym-other.yaml

11

nit:
in yaml2obj/obj2yaml tests we usually remove excessive indentations:

# CHECK: Symbols:
# CHECK:  - Name:  foo1
# CHECK:    Other: [ STO_AARCH64_VARIANT_PCS ]
# CHECK:  - Name:  foo2
# CHECK:    Other: [ STO_AARCH64_VARIANT_PCS, 64 ]

23

nit: in yaml2obj/obj2yaml tests we usually align values of YAML inputs

- Name:  foo1
  Other: [ STO_AARCH64_VARIANT_PCS ]
- Name:  foo2
  Other: [ STO_AARCH64_VARIANT_PCS, 0x40 ]

[zatrazz]

In D93235#2454115, @grimar wrote:

LGTM with 2 minor nits. Thanks!

Ack, I will fix it.

llvm/lib/ObjectYAML/ELFYAML.cpp

MapVector<StringRef, uint8_t> getFlags(unsigned EMachine) {
     // any other flags that have the same bits instead.
     if (EMachine == ELF::EM_MIPS) {
       Map["STO_MIPS_MIPS16"] = ELF::STO_MIPS_MIPS16;
       Map["STO_MIPS_MICROMIPS"] = ELF::STO_MIPS_MICROMIPS;
       Map["STO_MIPS_PIC"] = ELF::STO_MIPS_PIC;
       Map["STO_MIPS_PLT"] = ELF::STO_MIPS_PLT;
       Map["STO_MIPS_OPTIONAL"] = ELF::STO_MIPS_OPTIONAL;
     }
+
+    if (EMachine == ELF::EM_AARCH64)
+      Map["STO_AARCH64_VARIANT_PCS"] = ELF::STO_AARCH64_VARIANT_PCS;
     return Map;
   }
 
   IO &YamlIO;
   Optional<std::vector<StOtherPiece>> Other;
   std::string UnknownFlagsHolder;
 };
 

llvm/test/tools/obj2yaml/ELF/aarch64-sym-other.yaml

+## Check AArch64 st_other extension support.
+
+# RUN: yaml2obj %s -o %t
+# RUN: obj2yaml %t | FileCheck %s
+
+# CHECK: Symbols:
+# CHECK:  - Name:  foo1
+# CHECK:    Other: [ STO_AARCH64_VARIANT_PCS ]
+# CHECK:  - Name:  foo2
+# CHECK:    Other: [ STO_AARCH64_VARIANT_PCS, 64 ]
+
+--- !ELF
+FileHeader:
+  Class:   ELFCLASS64
+  Data:    ELFDATA2LSB
+  Type:    ET_REL
+  Machine: EM_AARCH64
+Symbols:
+  - Name:  foo1
+    Other: [ STO_AARCH64_VARIANT_PCS ]
+  - Name:  foo2
+    Other: [ STO_AARCH64_VARIANT_PCS, 0x40 ]