Page MenuHomePhabricator

[obj2yaml][yaml2obj] - Add AArch64 STO_AARCH64_VARIANT_PCS support
ClosedPublic

Authored by zatrazz on Dec 14 2020, 10:03 AM.

Diff Detail

Event Timeline

zatrazz created this revision.Dec 14 2020, 10:03 AM
zatrazz requested review of this revision.Dec 14 2020, 10:03 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 14 2020, 10:03 AM
MaskRay accepted this revision.Dec 14 2020, 10:24 AM

Looks great! Please wait for @grimar who initially requested the separate patch.

llvm/test/tools/obj2yaml/ELF/aarch64-sym-other.yaml
2

Period after a complete sentence.

This revision is now accepted and ready to land.Dec 14 2020, 10:24 AM
grimar accepted this revision.Dec 14 2020, 11:39 PM

LGTM with 2 minor nits. Thanks!

llvm/test/tools/obj2yaml/ELF/aarch64-sym-other.yaml
11

nit:
in yaml2obj/obj2yaml tests we usually remove excessive indentations:

# CHECK: Symbols:
# CHECK:  - Name:  foo1
# CHECK:    Other: [ STO_AARCH64_VARIANT_PCS ]
# CHECK:  - Name:  foo2
# CHECK:    Other: [ STO_AARCH64_VARIANT_PCS, 64 ]
23

nit: in yaml2obj/obj2yaml tests we usually align values of YAML inputs

- Name:  foo1
  Other: [ STO_AARCH64_VARIANT_PCS ]
- Name:  foo2
  Other: [ STO_AARCH64_VARIANT_PCS, 0x40 ]

LGTM with 2 minor nits. Thanks!

Ack, I will fix it.

This revision was landed with ongoing or failed builds.Dec 17 2020, 6:34 AM
This revision was automatically updated to reflect the committed changes.