Page MenuHomePhabricator

zatrazz (Adhemerval Zanella)
User

Projects

User Details

User Since
Mar 10 2015, 12:58 PM (196 w, 6 d)

Recent Activity

Yesterday

zatrazz added a comment to D55427: [libcxx] Call __count_bool_true for bitset count.

Getting a bit late in this discussion, as we had an internal one just recently.

The change to remove always_inline in a number of libc++ template functions is a good one, especially when the inliner can guess and does a good job already.

In this case, however, because the type is a reference, the inliner would require a lot more effort to inspect the uses (and side-effects).

Improving the inliner here would be a huge hammer, probably increasing compile time for all codes for the minimal benefit of this very special case.

Then perhaps, it would be beneficial and pragmatic, to revert that removal in this special case.

The issue I have to define it per symbol is the hackery it would require to handle _LIBCPP_INTERNAL_LINKAGE and its implications,
or at least add *another* macro to inline some symbols depending of the configuration/etc.

Mon, Dec 17, 3:58 AM

Fri, Dec 14

zatrazz added a comment to D55427: [libcxx] Call __count_bool_true for bitset count.

Getting a bit late in this discussion, as we had an internal one just recently.

The change to remove always_inline in a number of libc++ template functions is a good one, especially when the inliner can guess and does a good job already.

In this case, however, because the type is a reference, the inliner would require a lot more effort to inspect the uses (and side-effects).

Improving the inliner here would be a huge hammer, probably increasing compile time for all codes for the minimal benefit of this very special case.

Then perhaps, it would be beneficial and pragmatic, to revert that removal in this special case.

Fri, Dec 14, 8:20 AM

Thu, Dec 13

zatrazz added a comment to D55427: [libcxx] Call __count_bool_true for bitset count.

This patch aims to help clang with better information so it can inline
__bit_reference count function usage for both std::biset. Current clang
inliner can not infer that the passed typed will be used only to select
the optimized variant, it evaluates the type argument and type check as
a load plus compare (although later optimization phases correctly
optimized this out).

I'm unclear on the magnitude of the improvement here.
Are we talking a single load + compare instruction in the call to std::count ?
Or something inside the loop?

[ I'm pretty sure that the patch is correct now - but I don't understand how important it is ]

Thu, Dec 13, 10:23 AM
zatrazz added a comment to D55427: [libcxx] Call __count_bool_true for bitset count.

Ping.

Thu, Dec 13, 3:34 AM

Mon, Dec 10

zatrazz updated the diff for D55427: [libcxx] Call __count_bool_true for bitset count.

This patch aims to help clang with better information so it can inline
__bit_reference count function usage for both std::biset. Current clang
inliner can not infer that the passed typed will be used only to select
the optimized variant, it evaluates the type argument and type check as
a load plus compare (although later optimization phases correctly
optimized this out).

Mon, Dec 10, 5:29 AM
zatrazz added a comment to D55427: [libcxx] Call __count_bool_true for bitset count.

This looks like a behavior change to me.
The old code calls __count_bool_true if the _Tp can be static_cast to bool, and __count_bool_false otherwise.
The new code calls __count_bool_true if the _Tp is exactly bool, and __count_bool_false otherwise.

Sorry; the old code calls __count_bool_true if the static_cast<bool>(value) is true, and __count_bool_false otherwise.

Mon, Dec 10, 5:28 AM

Fri, Dec 7

zatrazz created D55427: [libcxx] Call __count_bool_true for bitset count.
Fri, Dec 7, 5:08 AM

Jun 27 2018

zatrazz closed D48332: [AArch64] Add custom lowering for v4i8 trunc store.
Jun 27 2018, 7:04 AM

Jun 26 2018

zatrazz added a comment to D48332: [AArch64] Add custom lowering for v4i8 trunc store.

Ping?

Jun 26 2018, 11:00 AM

Jun 22 2018

zatrazz updated the diff for D48332: [AArch64] Add custom lowering for v4i8 trunc store.

Update patch from previous comments.

Jun 22 2018, 11:43 AM
zatrazz updated the diff for D48332: [AArch64] Add custom lowering for v4i8 trunc store.

Updated patch based on previous comments. Indeed, changing AArch64TTIImpl::getMemoryOpCost for both load and store was wrong, since <4 x i8> loads are still scalarized. I have changed to just adjust cost for stores.

Jun 22 2018, 5:25 AM

Jun 21 2018

zatrazz added inline comments to D48332: [AArch64] Add custom lowering for v4i8 trunc store.
Jun 21 2018, 2:01 PM
zatrazz updated the diff for D48332: [AArch64] Add custom lowering for v4i8 trunc store.

Updated patch based from previous comment.

Jun 21 2018, 5:49 AM

Jun 20 2018

zatrazz updated the diff for D48332: [AArch64] Add custom lowering for v4i8 trunc store.

Updated patch from previous comments.

Jun 20 2018, 12:52 PM
zatrazz added inline comments to D48332: [AArch64] Add custom lowering for v4i8 trunc store.
Jun 20 2018, 11:54 AM
zatrazz added a comment to D48332: [AArch64] Add custom lowering for v4i8 trunc store.

I wonder if we should prefer to widen <2 x i8> and <4 x i8> to <8 x i8> instead of promoting to <4 x i16>. It would make stores like this a bit cheaper. Maybe an interesting experiment at some point (mostly just modifying AArch64TargetLowering::getPreferredVectorAction, I think, and seeing what happens to the generated code).

Jun 20 2018, 11:50 AM

Jun 19 2018

zatrazz created D48332: [AArch64] Add custom lowering for v4i8 trunc store.
Jun 19 2018, 12:38 PM

Jun 1 2018

zatrazz added a comment to D46283: [AArch64] Set vectorizer-maximize-bandwidth as default true.

Indeed the machine was using for speccpu2006 was not best suitable, I used a different one now (tx1, A57) with extra care to lower variance (cpu binding, services disabled, etc) and it indeed showed a better result:

Jun 1 2018, 6:25 AM

May 21 2018

zatrazz added a comment to D46283: [AArch64] Set vectorizer-maximize-bandwidth as default true.

For some reason I did not attach the meant comments in this update. This is an update of the previous patch with an extended analysis. I checked a bootstrap build TargetTransformation::shouldMaximizeVectorBandwidth enabled for both armhf (r332595) and powerpc64le (r332840). On armhf I did not see any regression, however on powerpc64le I found an issue related on how current code handles the MaximizeBandwidth option. The testcase 'Transforms/LoopVectorize/PowerPC/pr30990.ll' explicit sets vectorizer-maximize-bandwidth to 0, however the code checks for:

May 21 2018, 2:33 PM
zatrazz updated the diff for D46283: [AArch64] Set vectorizer-maximize-bandwidth as default true.
May 21 2018, 10:41 AM

May 9 2018

zatrazz closed D46010: [AArch64] Improve cost of vector division by constant.
May 9 2018, 6:21 AM
zatrazz added a comment to D46010: [AArch64] Improve cost of vector division by constant.

In fact I couldn't find any code generation different with and without this patch on speccpu2000. Most likely the performance difference is expected runtime variance from speccpu2000 (I do see a lot in some components).

May 9 2018, 4:42 AM

May 7 2018

zatrazz added a comment to D46010: [AArch64] Improve cost of vector division by constant.

I tired this patch on Exynos and the performance of SPEC CPU2000 was virtually neutral, even if slightly negative overall in the integer score. Perhaps the defaults costs are too optimistic about the relative difference between multiply and add?

May 7 2018, 8:31 AM

May 4 2018

zatrazz added inline comments to D46010: [AArch64] Improve cost of vector division by constant.
May 4 2018, 10:36 AM
zatrazz updated the diff for D46010: [AArch64] Improve cost of vector division by constant.

But I do agree that there is not much gain in making the division by constant cost logic generic. I changed by moving the logic on aarch64 target cost class.

May 4 2018, 10:36 AM
zatrazz added a comment to D46010: [AArch64] Improve cost of vector division by constant.

I should not change other architectures than AArch64 because 'isArithmeticDivFast' is a new method (only used by this patch).

This still looks very AArch64-y to me. Those two ISD nodes are specific to the case you're working on. I'm sure there are a lot more "divs" than that. :)

but since the division by constant is a platform agnostic transformation I though it would make sense to check the same check on a platform agnostic manner.

It is platform agnostic if you cover all cases that a platform agnostic constant divide function should. Right now, it's specific to this one issue in this one arch.

May 4 2018, 9:34 AM
zatrazz added a comment to D46010: [AArch64] Improve cost of vector division by constant.

Ping now that https://reviews.llvm.org/D46009 has been committed.

May 4 2018, 7:40 AM
zatrazz abandoned D40134: [asan] Add support for AArch64 ILP32.
May 4 2018, 7:40 AM · Restricted Project

May 2 2018

zatrazz updated the diff for D46009: [AArch64] Custom Lower MULLH{S,U} for v16i8, v8i16, and v4i32.

Update patch from previous comments.

May 2 2018, 10:20 AM
zatrazz added a comment to D46009: [AArch64] Custom Lower MULLH{S,U} for v16i8, v8i16, and v4i32.

Sorry, I needed to get up to speed here, also with this hacker's delight trick.
I think it would be good if you add some comments to LowerMULH what we are trying to do here.

May 2 2018, 10:19 AM

Apr 30 2018

zatrazz added a comment to D46283: [AArch64] Set vectorizer-maximize-bandwidth as default true.

This seems like an improvement, but we have to be careful with wide variations and little gain. The geomean is almost null but the standard deviation is higher than 75% of the results.

This is not a good sign and is a reflection of what I have complained about exchanging numbers and not tracking which benchmarks get worse/better, then risking hurting more one side than another in the long term.

The patch sets the default to *all* AArch64 cores, which is a wide range and you have only tested on one.

To enable such flag by default, we'd need to run on more cores (preferably including A53) as well as other vendors (like Apple, Samsung, Qualcomm), which this patch is likely to impact.

@t.p.northover @evandro @mcrosier please have a look.

Apr 30 2018, 1:55 PM
zatrazz created D46283: [AArch64] Set vectorizer-maximize-bandwidth as default true.
Apr 30 2018, 1:13 PM
zatrazz updated the diff for D46009: [AArch64] Custom Lower MULLH{S,U} for v16i8, v8i16, and v4i32.

Update patch from previous comments.

Apr 30 2018, 5:40 AM
zatrazz added inline comments to D46009: [AArch64] Custom Lower MULLH{S,U} for v16i8, v8i16, and v4i32.
Apr 30 2018, 5:39 AM

Apr 26 2018

zatrazz removed a watcher for lld: zatrazz.
Apr 26 2018, 11:48 AM

Apr 25 2018

zatrazz added a comment to D46010: [AArch64] Improve cost of vector division by constant.

Do we have similar cost tests for x86, Arm and others? It would be nice to make sure the change to BasicTTIImplBase didn't break other targets' costs.

Apr 25 2018, 11:31 AM

Apr 24 2018

zatrazz created D46010: [AArch64] Improve cost of vector division by constant.
Apr 24 2018, 6:46 AM
zatrazz created D46009: [AArch64] Custom Lower MULLH{S,U} for v16i8, v8i16, and v4i32.
Apr 24 2018, 6:46 AM

Jan 5 2018

zatrazz added a comment to D40134: [asan] Add support for AArch64 ILP32.

Ping (x4)

Jan 5 2018, 4:11 AM · Restricted Project

Dec 8 2017

zatrazz added a comment to D40134: [asan] Add support for AArch64 ILP32.

Ping (x3).

Dec 8 2017, 11:30 AM · Restricted Project

Nov 30 2017

zatrazz added a comment to D40134: [asan] Add support for AArch64 ILP32.

Is there a bot that builds for this architecture?

Nov 30 2017, 3:39 AM · Restricted Project

Nov 29 2017

zatrazz added a comment to D40134: [asan] Add support for AArch64 ILP32.

Ping (x2).

Nov 29 2017, 3:52 AM · Restricted Project

Nov 27 2017

zatrazz added inline comments to D40423: [ARM][AArch64] Workaround ARM/AArch64 percularity in clearing icache..
Nov 27 2017, 3:26 AM

Nov 24 2017

zatrazz added a comment to D40134: [asan] Add support for AArch64 ILP32.

Ping.

Nov 24 2017, 12:40 PM · Restricted Project

Nov 16 2017

zatrazz created D40134: [asan] Add support for AArch64 ILP32.
Nov 16 2017, 8:47 AM · Restricted Project

May 10 2017

zatrazz closed D32800: [msan] Fix getmntent{_r} for empty /etc/fstab.
May 10 2017, 5:32 AM · Restricted Project

May 8 2017

zatrazz added inline comments to D32800: [msan] Fix getmntent{_r} for empty /etc/fstab.
May 8 2017, 2:26 PM · Restricted Project

May 4 2017

zatrazz added inline comments to D32800: [msan] Fix getmntent{_r} for empty /etc/fstab.
May 4 2017, 10:30 AM · Restricted Project
zatrazz updated the diff for D32800: [msan] Fix getmntent{_r} for empty /etc/fstab.
May 4 2017, 10:30 AM · Restricted Project

May 3 2017

zatrazz created D32800: [msan] Fix getmntent{_r} for empty /etc/fstab.
May 3 2017, 6:33 AM · Restricted Project

Feb 13 2017

zatrazz added a comment to D29586: [lsan] Enable LSan for arm Linux.

So, it seems that LSan's operability depends on what compiler is used to build it :(.

It is a know issue [1] [2] and in fact it a little more complicated, it depends on the flags used as well:

if you mix thumb and arm code fast unwinder won't work. I am not sure which option would be better,

but I am afraid to get a reliable stacktrack on arm (with mixed objects and function built with different compilers)
we will need to use a external unwinder (maybe libunwinder). But it will have the side-effect of making
backtrace way slower.

[1] https://llvm.org/bugs/show_bug.cgi?id=22741
[2] https://llvm.org/bugs/show_bug.cgi?id=18505

Right, but I thought it affects only Thumb (that might be mixed with arm) but it seems that even arm mode is affected depending on GCC version. This complicates enabling tests on arm targets, but still, It would be nice to have LSan available on arm.

Feb 13 2017, 10:17 AM · Restricted Project

Feb 9 2017

zatrazz added a comment to D29586: [lsan] Enable LSan for arm Linux.

You seem to be enabling it on soft and hard float. Did you test on both environments? What type of hardware did you test this?

I've tested the patch on two configurations:

  1. Linaro Ubuntu 14.04 (Trusty) on Arndale board. It's a hard float system, right?

Oh, things become more complicated... I see many test failures with host GCC 4.8 because fast unwinder failed to get backtraces for mallocs. This happens because __interceptor_malloc, compiled by GCC 4.8, didn't properly save frame pointer register:

00000000 <__interceptor_malloc>:
   0:   e92d 47f0       stmdb   sp!, {r4, r5, r6, r7, r8, r9, sl, lr}
   4:   f5ad 6d85       sub.w   sp, sp, #1064   ; 0x428
   8:   4d29            ldr     r5, [pc, #164]  ; (b0 <__interceptor_malloc+0xb0>)
   a:   4b2a            ldr     r3, [pc, #168]  ; (b4 <__interceptor_malloc+0xb4>)
   c:   af04            add     r7, sp, #16
   e:   447d            add     r5, pc

But if compile with clang (3.3, 3.5 or trunk) or GCC 4.9, the fp is saved properly:

00000000 <__interceptor_malloc>:
   0:   e92d4ff0        push    {r4, r5, r6, r7, r8, r9, sl, fp, lr}
   4:   e28db01c        add     fp, sp, #28
   8:   e24dd024        sub     sp, sp, #36     ; 0x24
   c:   e24ddb01        sub     sp, sp, #1024   ; 0x400
  10:   e1a08000        mov     r8, r0

So, it seems that LSan's operability depends on what compiler is used to build it :(.

Feb 9 2017, 11:38 AM · Restricted Project

Feb 7 2017

zatrazz added inline comments to D29586: [lsan] Enable LSan for arm Linux.
Feb 7 2017, 12:16 PM · Restricted Project

Dec 19 2016

zatrazz closed D27711: ELF/AArch64: Fix dynamic relocation against local symbol in shared objects.
Dec 19 2016, 5:24 AM · lld

Dec 16 2016

zatrazz updated the diff for D27711: ELF/AArch64: Fix dynamic relocation against local symbol in shared objects.

Updated patch based on previous comments.

Dec 16 2016, 4:29 AM · lld
zatrazz added a comment to D27711: ELF/AArch64: Fix dynamic relocation against local symbol in shared objects.
In D27711#624244, @ruiu wrote:

Looks like Rafael made a comment?

Dec 16 2016, 3:21 AM · lld

Dec 15 2016

zatrazz added a comment to D27711: ELF/AArch64: Fix dynamic relocation against local symbol in shared objects.

Ping.

Dec 15 2016, 11:57 AM · lld

Dec 13 2016

zatrazz edited reviewers for D27711: ELF/AArch64: Fix dynamic relocation against local symbol in shared objects, added: ruiu; removed: rui314.
Dec 13 2016, 6:42 AM · lld
zatrazz retitled D27711: ELF/AArch64: Fix dynamic relocation against local symbol in shared objects from to ELF/AArch64: Fix dynamic relocation against local symbol in shared objects.
Dec 13 2016, 6:41 AM · lld

Dec 7 2016

zatrazz closed D27479: ELF/AArch64: Refactor R_AARCH64_LDST{8,15,32,64,128}_ABS_LO12_NC Relocations.
Dec 7 2016, 9:42 AM · lld
zatrazz updated the diff for D27479: ELF/AArch64: Refactor R_AARCH64_LDST{8,15,32,64,128}_ABS_LO12_NC Relocations.

Updated patch based on previous comments.

Dec 7 2016, 5:24 AM · lld
zatrazz added inline comments to D27479: ELF/AArch64: Refactor R_AARCH64_LDST{8,15,32,64,128}_ABS_LO12_NC Relocations.
Dec 7 2016, 4:05 AM · lld

Dec 6 2016

zatrazz retitled D27479: ELF/AArch64: Refactor R_AARCH64_LDST{8,15,32,64,128}_ABS_LO12_NC Relocations from to ELF/AArch64: Refactor R_AARCH64_LDST{8,15,32,64,128}_ABS_LO12_NC Relocations.
Dec 6 2016, 1:03 PM · lld

Dec 5 2016

zatrazz closed D27306: ELF: consolidate getAArch64Page implementation.
Dec 5 2016, 8:20 AM · lld
zatrazz closed D27307: ELF/AArch64: Simplify R_AARCH64_ADD_ABS_LO12_NC relocation.
Dec 5 2016, 8:20 AM · lld
zatrazz closed D27308: ELF/AArch64: Fix R_AARCH64_LDST16_ABS_LO12_NC mask.
Dec 5 2016, 8:20 AM · lld

Dec 2 2016

zatrazz added a comment to D27308: ELF/AArch64: Fix R_AARCH64_LDST16_ABS_LO12_NC mask.

LGTM. It is constant with my understanding of: http://infocenter.arm.com/help/topic/com.arm.doc.ihi0056b/IHI0056B_aaelf64.pdf

In looking at the surrounding similar relocations, shouldn't R_AARCH64_LDST128_ABS_LO12_NC be 0xFF0?

Dec 2 2016, 12:34 PM · lld

Dec 1 2016

zatrazz retitled D27308: ELF/AArch64: Fix R_AARCH64_LDST16_ABS_LO12_NC mask from to ELF/AArch64: Fix R_AARCH64_LDST16_ABS_LO12_NC mask.
Dec 1 2016, 10:06 AM · lld
zatrazz retitled D27307: ELF/AArch64: Simplify R_AARCH64_ADD_ABS_LO12_NC relocation from to ELF/AArch64: Simplify R_AARCH64_ADD_ABS_LO12_NC relocation.
Dec 1 2016, 10:05 AM · lld
zatrazz retitled D27306: ELF: consolidate getAArch64Page implementation from to ELF: consolidate getAArch64Page implementation.
Dec 1 2016, 10:03 AM · lld
zatrazz resigned from D18174: Fix libcxx build on musl.
Dec 1 2016, 9:59 AM

Sep 30 2016

zatrazz added a comment to D25079: [ELF] Set maximum page size to 65536 on AArch64.
  • LLD doesn't have a concept of common-page-size and max-page-size so if 64k page size is chosen all output sections are aligned to 64k boundary as well as program segments.
Sep 30 2016, 12:18 PM · lld
zatrazz added a comment to D25079: [ELF] Set maximum page size to 65536 on AArch64.

I do not seem any impending issue with this patch, however we must be aware that since max alignment is used as the default one for page alignment for some sections it might interfere with both memory utilization and relro setup. There is some information on a recent powerpc64le issue that occurred from a similar change in binutils [1].

Sep 30 2016, 11:56 AM · lld

Aug 25 2016

zatrazz closed D23811: dfsan: Enable 48-bit VMA support on aarch64.
Aug 25 2016, 10:16 AM · Restricted Project
zatrazz closed D23806: msan: Enable 48-bit VMA support on aarch64.
Aug 25 2016, 10:14 AM · Restricted Project

Aug 23 2016

zatrazz closed D23420: libcxx: Fix libcxx test on aarch64 with libunwind.
Aug 23 2016, 12:33 PM
zatrazz retitled D23811: dfsan: Enable 48-bit VMA support on aarch64 from to dfsan: Enable 48-bit VMA support on aarch64.
Aug 23 2016, 11:51 AM · Restricted Project
zatrazz retitled D23806: msan: Enable 48-bit VMA support on aarch64 from to msan: Enable 48-bit VMA support on aarch64.
Aug 23 2016, 8:26 AM · Restricted Project

Aug 22 2016

zatrazz added a comment to D23420: libcxx: Fix libcxx test on aarch64 with libunwind.

Ping (x2).

Aug 22 2016, 6:22 AM

Aug 15 2016

zatrazz closed D23449: libcxx: Fix path.compare.pass expected result.
Aug 15 2016, 2:32 PM
zatrazz added a comment to D23449: libcxx: Fix path.compare.pass expected result.

Ping.

Aug 15 2016, 10:04 AM
zatrazz added a comment to D23420: libcxx: Fix libcxx test on aarch64 with libunwind.

Ping.

Aug 15 2016, 10:04 AM

Aug 12 2016

zatrazz updated the diff for D23420: libcxx: Fix libcxx test on aarch64 with libunwind.

I think patch should be safe now.

Aug 12 2016, 10:02 AM
zatrazz added a comment to D23420: libcxx: Fix libcxx test on aarch64 with libunwind.

Yes, although in pratice for shared libraries this is not an issue (at least on Linux with current linker strategies). And I open for suggestion on how to proceed in this case since we have some other options:

  1. Add the required soft-sp implementations when building for Linux (this might happen not only on aarch64, but any other ABI that defines long double using fallback soft-fp)

Are the softfp symbols you need not contained in libgcc.a?

Aug 12 2016, 8:27 AM
zatrazz added a comment to D23420: libcxx: Fix libcxx test on aarch64 with libunwind.

Yes, although in pratice for shared libraries this is not an issue (at least on Linux with current linker strategies). And I open for suggestion on how to proceed in this case since we have some other options:

Aug 12 2016, 8:10 AM
zatrazz added a comment to D23420: libcxx: Fix libcxx test on aarch64 with libunwind.

Yes, but my understaning is the proposed link order will force libc++ to link against _Unwind* symbols from libunwind (this is what I am observing also).

Aug 12 2016, 7:45 AM
zatrazz retitled D23449: libcxx: Fix path.compare.pass expected result from to libcxx: Fix path.compare.pass expected result.
Aug 12 2016, 7:15 AM
zatrazz updated the diff for D23420: libcxx: Fix libcxx test on aarch64 with libunwind.

What about this version? The only difference is for libunwind libgcc is still included.

Aug 12 2016, 7:13 AM

Aug 11 2016

zatrazz added a comment to D23420: libcxx: Fix libcxx test on aarch64 with libunwind.

I tried to find why exactly libgcc has to appear before and after but I couldn't get any information from commit history. On my system (aarch64/linux) I am also getting "-lc++" "-lm" "-lgcc_s" "-lgcc" "-lpthread" "-lc" "-lgcc_s" "-lgcc".

Aug 11 2016, 4:21 PM
zatrazz retitled D23420: libcxx: Fix libcxx test on aarch64 with libunwind from to libcxx: Fix libcxx test on aarch64 with libunwind.
Aug 11 2016, 1:00 PM

Aug 10 2016

zatrazz closed D23318: [PATCH] tsan: Remove __pointer_chk_guard@GLIBC_PRIVATE requirement for AArch64.
Aug 10 2016, 2:47 PM · Restricted Project

Aug 9 2016

zatrazz added a comment to D23318: [PATCH] tsan: Remove __pointer_chk_guard@GLIBC_PRIVATE requirement for AArch64.

Reading again, it seems you're just reimplementing a similar logic, with a known global, which is safer than relying on glibc's own copy. So, even for gcc using TSAN, there will be no deviation.

Aug 9 2016, 1:50 PM · Restricted Project
zatrazz added inline comments to D23318: [PATCH] tsan: Remove __pointer_chk_guard@GLIBC_PRIVATE requirement for AArch64.
Aug 9 2016, 11:26 AM · Restricted Project
zatrazz added a comment to D23318: [PATCH] tsan: Remove __pointer_chk_guard@GLIBC_PRIVATE requirement for AArch64.

Adding a few people, as I'm on holiday.

I worry that we'll end up with our own private implementation, and create problems for TSAN in the future. Or maybe I didn't understand the problem... :-)

Aug 9 2016, 11:24 AM · Restricted Project
zatrazz retitled D23318: [PATCH] tsan: Remove __pointer_chk_guard@GLIBC_PRIVATE requirement for AArch64 from to [PATCH] tsan: Remove __pointer_chk_guard@GLIBC_PRIVATE requirement for AArch64.
Aug 9 2016, 7:22 AM · Restricted Project

Jul 29 2016

zatrazz closed D22595: [tsan] Enable 48-bit VMA support on aarch64.
Jul 29 2016, 7:00 AM · Restricted Project

Jul 26 2016

zatrazz updated the diff for D22595: [tsan] Enable 48-bit VMA support on aarch64.

I simplified the patch a bit by removing the allocator64 define usage. I also updated the sync comments.

Jul 26 2016, 2:34 PM · Restricted Project

Jul 25 2016

zatrazz added a comment to D22595: [tsan] Enable 48-bit VMA support on aarch64.

Ping.

Jul 25 2016, 9:27 AM · Restricted Project

Jul 20 2016

zatrazz retitled D22595: [tsan] Enable 48-bit VMA support on aarch64 from to [tsan] Enable 48-bit VMA support on aarch64.
Jul 20 2016, 2:28 PM · Restricted Project

Jul 18 2016

zatrazz closed D22095: [asan] Enable 48-bit VMA support on aarch64.
Jul 18 2016, 10:24 AM · Restricted Project