Page MenuHomePhabricator

zatrazz (Adhemerval Zanella)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 10 2015, 12:58 PM (420 w, 4 d)

Recent Activity

Jan 20 2023

zatrazz added a comment to D137268: [clang][Headers] Do not define varargs macros for __need___va_list.

I think I have caught this because your standard conformance tests checks for gnuc_va_list
on wchar.h, wich is always defined on on GCC (git log shows it was changed to fix XPG7
tests, but I am not sure exactly why the author has changed the va_list to
gnuc_va_list).

bionic's tests check for va_list, because that's what POSIX says will be visible. ISO C doesn't say that, so i think the _intention_ for glibc -- musl seems to do this correctly -- is to say "if we're only compiling C source, you don't get va_list, but if we're compiling POSIX source, you do get va_list". so i think this __gnuc_va_list thing is their workaround to still export the _functions_ without exporting the _type_ for ISO C?

Jan 20 2023, 12:32 PM · Restricted Project, Restricted Project, Restricted Project
zatrazz added a comment to D137268: [clang][Headers] Do not define varargs macros for __need___va_list.

is there a corresponding glibc change so that va_list is exported for _POSIX_SOURCE cases? see https://android-review.git.corp.google.com/c/platform/bionic/+/2397313 where i'm having to disable some bionic testing against glibc because the glibc (2.17!) <wchar.h> now no longer exports va_list. i did look for a ToT glibc patch to backport (until we've _actually_ switched from glibc to musl for the host), but couldn't obviously find it?

https://pubs.opengroup.org/onlinepubs/9699919799.2018edition/basedefs/wchar.h.html says:
"""
The <wchar.h> header shall define the following types:
...
va_list
[CX] As described in <stdarg.h>.
"""
which is why i think our "<wchar.h> exports va_list" test is correct. (Android doesn't support an "ISO only" mode --- you're effectively always in _POSIX_SOURCE mode, so we build the test against glibc with _POSIX_SOURCE defined.)

Jan 20 2023, 11:43 AM · Restricted Project, Restricted Project, Restricted Project

Jan 3 2023

zatrazz added a comment to D135402: [LLD] Enable --no-undefined-version by default..

Another project that is also breaks with this change is glibc. Although I could be fixed on glibc side, the undefined symbols are used to simplify the version symbol for multiple ABI with different base ABIs.

Jan 3 2023, 10:14 AM · Restricted Project, Restricted Project

Nov 8 2022

zatrazz committed rG9e956995db1f: [clang][Headers] Do not define varargs macros for __need___va_list (authored by zatrazz).
[clang][Headers] Do not define varargs macros for __need___va_list
Nov 8 2022, 11:30 AM · Restricted Project, Restricted Project, Restricted Project
zatrazz closed D137268: [clang][Headers] Do not define varargs macros for __need___va_list.
Nov 8 2022, 11:30 AM · Restricted Project, Restricted Project, Restricted Project
zatrazz updated the diff for D137268: [clang][Headers] Do not define varargs macros for __need___va_list.

Update review based on reviewers comments.

Nov 8 2022, 9:21 AM · Restricted Project, Restricted Project, Restricted Project
zatrazz added inline comments to D137268: [clang][Headers] Do not define varargs macros for __need___va_list.
Nov 8 2022, 9:21 AM · Restricted Project, Restricted Project, Restricted Project
zatrazz committed rG92e172309cf6: [clang][Headers] Only define FLT_EVAL_METHOD for C99 and later (authored by zatrazz).
[clang][Headers] Only define FLT_EVAL_METHOD for C99 and later
Nov 8 2022, 8:59 AM · Restricted Project, Restricted Project
zatrazz closed D137267: [clang][Headers] Only define FLT_EVAL_METHOD for C99 and later.
Nov 8 2022, 8:59 AM · Restricted Project, Restricted Project

Nov 2 2022

zatrazz requested review of D137268: [clang][Headers] Do not define varargs macros for __need___va_list.
Nov 2 2022, 10:04 AM · Restricted Project, Restricted Project, Restricted Project
zatrazz requested review of D137267: [clang][Headers] Only define FLT_EVAL_METHOD for C99 and later.
Nov 2 2022, 10:03 AM · Restricted Project, Restricted Project

Oct 26 2022

zatrazz added inline comments to D135565: MIPS/compiler_rt: use synci to flush icache on r6.
Oct 26 2022, 10:08 AM · Restricted Project, Restricted Project
zatrazz added a comment to D135565: MIPS/compiler_rt: use synci to flush icache on r6.

On a Gentoo mips64 machine, libgcc.a:_clear_cache.o defines __clear_cache as a no-op:

0000000000000000 <__clear_cache>:
   0:   03e00008        jr      ra
   4:   00000000        nop
        ...

This should be a gcc's bug.
Luckily, we can use rdhwr+synci for llvm, since we only support r2+.
I will try to fix gcc, too.

Oct 26 2022, 5:44 AM · Restricted Project, Restricted Project
zatrazz added a comment to D135565: MIPS/compiler_rt: use synci to flush icache on r6.

OK, I see that syscall is not defined in -std=c* modes (in glibc and musl) without _DEFAULT_SOURCE/_GNU_SOURCE. Is cacheflush a better API than _flush_cache? In musl it's always available, but in glibc, it requires _DEFAULT_SOURCE like syscall:

Oct 26 2022, 4:29 AM · Restricted Project, Restricted Project

Aug 25 2022

zatrazz committed rGabcb3d58d999: [MC][ELF] Mark GNU ABI if ifunc are used (authored by zatrazz).
[MC][ELF] Mark GNU ABI if ifunc are used
Aug 25 2022, 2:19 PM · Restricted Project, Restricted Project
zatrazz closed D131162: [MC][ELF] Mark GNU ABI if ifunc are used.
Aug 25 2022, 2:19 PM · Restricted Project, Restricted Project

Aug 24 2022

zatrazz added a comment to D131162: [MC][ELF] Mark GNU ABI if ifunc are used.

The SHF_GNU_RETAIN change is more so that GNU ld recognizes its semantics, less about the readelf -s output. With many systems adopting GNU ABI features, I do not know whether it makes significant sense to "upgrade" ELFOSABI_NONE to ELFOSABI_GNU.

Aug 24 2022, 5:44 AM · Restricted Project, Restricted Project

Aug 10 2022

zatrazz added a comment to D131528: [Clang] Restrict non fixed enum to a value outside the range of the enumeration values warning to context requiring a constant expression.

It does help on test-suite, thanks.

Aug 10 2022, 7:30 AM · Restricted Project, Restricted Project

Aug 9 2022

zatrazz added a comment to D131307: [Clang] Allow downgrading to a warning the diagnostic for setting a non fixed enum to a value outside the range of the enumeration values.

This commit seems to have broken test-suite on aarch64 [1]. The warning shows:

Aug 9 2022, 5:57 AM · Restricted Project, Restricted Project

Aug 4 2022

zatrazz requested review of D131162: [MC][ELF] Mark GNU ABI if ifunc are used.
Aug 4 2022, 6:28 AM · Restricted Project, Restricted Project

Jul 28 2022

zatrazz accepted D130702: [ARM] Disable llvm's use of threads for armv8-lld-2stage.

LGTM, thanks.

Jul 28 2022, 5:18 AM · Restricted Project

Jul 15 2022

zatrazz committed rG81bffdf6a5d0: [libcxx] Temporarily skip Arm configs (authored by zatrazz).
[libcxx] Temporarily skip Arm configs
Jul 15 2022, 5:12 AM · Restricted Project, Restricted Project
zatrazz closed D129847: [libcxx] Temporarily skip Arm configs.
Jul 15 2022, 5:12 AM · Restricted Project, Restricted Project
zatrazz requested review of D129847: [libcxx] Temporarily skip Arm configs.
Jul 15 2022, 5:01 AM · Restricted Project, Restricted Project

Jul 11 2022

zatrazz added a comment to D129471: [sanitizer] Remove #include <linux/fs.h> to resolve fsconfig_command/mount_attr conflict with glibc 2.36.

LGTM, the kernel exported value is same for all architectures. Anther possibility would be to split the sanitizer_platform_limits_posix.cpp and add a sanitizer_platform_limits_posix_linux.cpp which only add linux includes.

If we are going to do this, sanitizer_platform_limits_linux.cpp may be the choice.

Do you think other #include <linux/*.h> in this file may cause a potential conflict in the future?

Jul 11 2022, 11:43 AM · Restricted Project, Restricted Project
zatrazz accepted D129471: [sanitizer] Remove #include <linux/fs.h> to resolve fsconfig_command/mount_attr conflict with glibc 2.36.
Jul 11 2022, 4:48 AM · Restricted Project, Restricted Project
zatrazz added a comment to D129471: [sanitizer] Remove #include <linux/fs.h> to resolve fsconfig_command/mount_attr conflict with glibc 2.36.

LGTM, the kernel exported value is same for all architectures. Anther possibility would be to split the sanitizer_platform_limits_posix.cpp and add a sanitizer_platform_limits_posix_linux.cpp which only add linux includes.

Jul 11 2022, 4:48 AM · Restricted Project, Restricted Project

Apr 7 2022

zatrazz added a comment to D123283: [MC] Improve st_size propagation rule.

I tested this patch on my glibc clang branch and while it has fixed the st_value aliases issues, it now triggers another regression:

Apr 7 2022, 11:11 AM · Restricted Project, Restricted Project

Oct 5 2021

zatrazz added a comment to D110931: [compiler-rt][lsan] Add backup AArch64 register for use_registers test.

Would avoid calling sched_yield() help in this situation? Depending of the system default, calling the glibc symbol might result in a lazy-resolution and thus invoke a lot of loader's code (which might clobber temporary registers).

Oct 5 2021, 4:22 AM · Restricted Project
zatrazz added a comment to D109963: [AArch64] Split bitmask immediate of bitwise AND operation.

This has caused a regression on stage2 buildbot [1], more specifically the test FAIL: Clang::p4-0x.cpp (but I think the other others might be related).

Oct 5 2021, 3:54 AM · Restricted Project

Aug 23 2021

zatrazz added a comment to D107938: [hwasan] Don't report short-granule shadow as overwritten..

Hi, I am not 100% sure but it seems to trigger a regression on aarch64 bot [1]. I can reproduce with current master as well:

Aug 23 2021, 1:48 PM · Restricted Project

Jun 9 2021

zatrazz added inline comments to D103470: [zorg] Add AArch64 SVE vector-length-specific (VLS) bot.
Jun 9 2021, 5:47 AM
zatrazz accepted D103469: [zorg] Build all targets on Linaro-maintained bots.

The change look reasonable to me, I will increase build time but it increase test coverage.

Jun 9 2021, 5:45 AM

Jun 2 2021

zatrazz accepted D103463: [compiler-rt][asan] Enable unwind-tables for Arm Linux.

LGTM, thanks.

Jun 2 2021, 4:49 AM · Restricted Project

Mar 1 2021

zatrazz abandoned D96803: EntryExitInstrumenter: Enable at all optimization levels (PR49143).
Mar 1 2021, 6:33 AM · Restricted Project, Restricted Project

Feb 19 2021

zatrazz updated the diff for D96803: EntryExitInstrumenter: Enable at all optimization levels (PR49143).

Updated patch based on previous comments.

Feb 19 2021, 9:04 AM · Restricted Project, Restricted Project

Feb 18 2021

zatrazz added a comment to D96803: EntryExitInstrumenter: Enable at all optimization levels (PR49143).

why is this now a module pass?

Mainly to avoid the default rule from new pass manager to *not* apply any FunctionPass for optnone (which is the main issue for PR49143). Is there a better way to accomplish it? I noted also that createModuleToFunctionPassAdaptor basically creates a adaptor that applies the pass to all function on the module.

It's always good to make the pass as specific as possible (e.g. prefer a function pass rather than a module pass) so it doesn't have to worry about infra. For example, just iterating over functions doesn't skip declarations.

Feb 18 2021, 5:40 AM · Restricted Project, Restricted Project

Feb 17 2021

zatrazz added a comment to D96803: EntryExitInstrumenter: Enable at all optimization levels (PR49143).

why is this now a module pass?

Feb 17 2021, 4:02 AM · Restricted Project, Restricted Project

Feb 16 2021

zatrazz requested review of D96803: EntryExitInstrumenter: Enable at all optimization levels (PR49143).
Feb 16 2021, 11:15 AM · Restricted Project, Restricted Project

Feb 15 2021

zatrazz committed rGb9d3234c7058: [sanitizer] [arm] Disable some LSAN tests for arm-linux-gnueabihf (authored by zatrazz).
[sanitizer] [arm] Disable some LSAN tests for arm-linux-gnueabihf
Feb 15 2021, 4:35 AM
zatrazz committed rTbcda8fc240c5: [test-suite] Remove GCC-C-execute-eeprof-1 (authored by zatrazz).
[test-suite] Remove GCC-C-execute-eeprof-1
Feb 15 2021, 4:26 AM
zatrazz closed D96521: [test-suite] Remove GCC-C-execute-eeprof-1.
Feb 15 2021, 4:26 AM
zatrazz added inline comments to D96521: [test-suite] Remove GCC-C-execute-eeprof-1.
Feb 15 2021, 4:18 AM

Feb 12 2021

zatrazz accepted D96617: DebugInfo/Symbolize: Exclude ARM mapping symbols for .symtab symbolization after D95916.

LGTM, it fixes the arm sanitizer regressions.

Feb 12 2021, 10:57 AM · Restricted Project
zatrazz added a comment to D95916: DebugInfo/Symbolize: Allow STT_NOTYPE/STT_GNU_IFUNC symbols for .symtab symbolization.

This change broke arm32 llvm-symbolizer which triggered some sanitizer regression. Previously, ARM mapping symbols [1] were ignored but after this change they are shown as the function name.

Feb 12 2021, 10:06 AM · Restricted Project

Feb 11 2021

zatrazz committed rG88d1724d9b56: [sanitizer] Fix suffix-log-path_test.c on arm-linux-gnu (authored by zatrazz).
[sanitizer] Fix suffix-log-path_test.c on arm-linux-gnu
Feb 11 2021, 9:26 AM
zatrazz closed D96337: [sanitizer] Fix suffix-log-path_test.c on arm-linux-gnu.
Feb 11 2021, 9:26 AM · Restricted Project
zatrazz requested review of D96521: [test-suite] Remove GCC-C-execute-eeprof-1.
Feb 11 2021, 9:19 AM
zatrazz abandoned D96489: [zorg] Fix test-suite regression on arm bots.
Feb 11 2021, 8:57 AM · Restricted Project
zatrazz abandoned D96490: [zorg] Disable test-suite for arm global-isel bots.
Feb 11 2021, 8:57 AM · Restricted Project
zatrazz added a reviewer for D96337: [sanitizer] Fix suffix-log-path_test.c on arm-linux-gnu: ostannard.
Feb 11 2021, 6:26 AM · Restricted Project
zatrazz added a reviewer for D96489: [zorg] Fix test-suite regression on arm bots: ostannard.
Feb 11 2021, 6:25 AM · Restricted Project
zatrazz added a comment to D96490: [zorg] Disable test-suite for arm global-isel bots.

The test-suite is the only thing this bot does to test global-isel, so I don't think there's any point in running the bot with this change. I think our options here are:

  • Disable just the tests which are failing (looks like it's just test-suite::GCC-C-execute-eeprof-1.test?)
  • Convert this to a 2-stage bot with the second stage built using global-isel, so that we are still doing some useful testing
  • Disable this bot completely until https://bugs.llvm.org/show_bug.cgi?id=49143 is fixed.
Feb 11 2021, 5:58 AM · Restricted Project
zatrazz updated the diff for D96337: [sanitizer] Fix suffix-log-path_test.c on arm-linux-gnu.

Updated patch based on previous comments.

Feb 11 2021, 5:17 AM · Restricted Project
zatrazz requested review of D96490: [zorg] Disable test-suite for arm global-isel bots.
Feb 11 2021, 4:54 AM · Restricted Project
zatrazz requested review of D96489: [zorg] Fix test-suite regression on arm bots.
Feb 11 2021, 4:53 AM · Restricted Project
zatrazz added inline comments to D96337: [sanitizer] Fix suffix-log-path_test.c on arm-linux-gnu.
Feb 11 2021, 4:17 AM · Restricted Project
zatrazz added a comment to D96337: [sanitizer] Fix suffix-log-path_test.c on arm-linux-gnu.

Could this also affect regular users of the sanitizers, or is it specific to the way we are running the tests? If it could affect users, then could we fix this in the clang driver, so that unwind tables are turned on by default whenever the sanitizers need them?

Feb 11 2021, 4:12 AM · Restricted Project

Feb 9 2021

zatrazz requested review of D96337: [sanitizer] Fix suffix-log-path_test.c on arm-linux-gnu.
Feb 9 2021, 6:20 AM · Restricted Project

Jan 26 2021

zatrazz committed rGdad55c22182e: [ARM] [ELF] Fix ARMMaterializeGV for Indirect calls (authored by zatrazz).
[ARM] [ELF] Fix ARMMaterializeGV for Indirect calls
Jan 26 2021, 10:58 AM
zatrazz closed D95379: [ARM] [ELF] Fix ARMMaterializeGV for Indirect calls.
Jan 26 2021, 10:58 AM · Restricted Project
zatrazz added a watcher for lld: zatrazz.
Jan 26 2021, 5:11 AM
zatrazz closed D94612: [LLD][ELF][AArch64] Add support for R_AARCH64_LD64_GOTPAGE_LO15 relocation.
Jan 26 2021, 4:43 AM · Restricted Project
zatrazz committed rG988cc0a08334: [LLD][ELF][AArch64] Add support for R_AARCH64_LD64_GOTPAGE_LO15 relocation (authored by zatrazz).
[LLD][ELF][AArch64] Add support for R_AARCH64_LD64_GOTPAGE_LO15 relocation
Jan 26 2021, 4:20 AM

Jan 25 2021

zatrazz updated the diff for D94612: [LLD][ELF][AArch64] Add support for R_AARCH64_LD64_GOTPAGE_LO15 relocation.

Updated patch based on previous comments. The R_AARCH64_GOT_PAGE is added on
the isStaticLinkTimeConstant and the test is changed to check for shared build as well.

Jan 25 2021, 12:27 PM · Restricted Project
zatrazz requested review of D95379: [ARM] [ELF] Fix ARMMaterializeGV for Indirect calls.
Jan 25 2021, 10:43 AM · Restricted Project

Jan 21 2021

zatrazz added a comment to D94612: [LLD][ELF][AArch64] Add support for R_AARCH64_LD64_GOTPAGE_LO15 relocation.

Ping.

Jan 21 2021, 4:14 AM · Restricted Project
zatrazz closed D94611: MC: AArch64: Add support for gotpage_lo15.
Jan 21 2021, 3:31 AM · Restricted Project
zatrazz committed rGff41ae8b3677: MC: AArch64: Add support for gotpage_lo15 (authored by zatrazz).
MC: AArch64: Add support for gotpage_lo15
Jan 21 2021, 3:31 AM

Jan 19 2021

zatrazz updated the diff for D94611: MC: AArch64: Add support for gotpage_lo15.

Updated patch based on previous comments.

Jan 19 2021, 6:34 AM · Restricted Project

Jan 18 2021

zatrazz closed D94809: [LLD][ELF][AArch64] Set _GLOBAL_OFFSET_TABLE_ at the start of .got.
Jan 18 2021, 10:06 AM · Restricted Project
zatrazz committed rG2f92386e721a: [LLD][ELF][AArch64] Set _GLOBAL_OFFSET_TABLE_ at the start of .got (authored by zatrazz).
[LLD][ELF][AArch64] Set _GLOBAL_OFFSET_TABLE_ at the start of .got
Jan 18 2021, 9:51 AM

Jan 15 2021

zatrazz updated the diff for D94612: [LLD][ELF][AArch64] Add support for R_AARCH64_LD64_GOTPAGE_LO15 relocation.

Patch updated from comments, main changes are:

Jan 15 2021, 10:33 AM · Restricted Project
zatrazz added a comment to D94612: [LLD][ELF][AArch64] Add support for R_AARCH64_LD64_GOTPAGE_LO15 relocation.

I will update the patch, since it is incomplete and requires https://reviews.llvm.org/D94809 .

Jan 15 2021, 10:27 AM · Restricted Project
zatrazz requested review of D94809: [LLD][ELF][AArch64] Set _GLOBAL_OFFSET_TABLE_ at the start of .got.
Jan 15 2021, 10:24 AM · Restricted Project

Jan 13 2021

zatrazz requested review of D94612: [LLD][ELF][AArch64] Add support for R_AARCH64_LD64_GOTPAGE_LO15 relocation.
Jan 13 2021, 9:35 AM · Restricted Project
zatrazz requested review of D94611: MC: AArch64: Add support for gotpage_lo15.
Jan 13 2021, 9:33 AM · Restricted Project

Dec 17 2020

zatrazz committed rG978eb3b87bca: [lld] [ELF] AArch64: Handle DT_AARCH64_VARIANT_PCS (authored by zatrazz).
[lld] [ELF] AArch64: Handle DT_AARCH64_VARIANT_PCS
Dec 17 2020, 6:35 AM
zatrazz committed rGe04dc5f557c5: [llvm-readobj/elf] - AArch64: Handle AARCH64_VARIANT_PCS for GNUStyle (authored by zatrazz).
[llvm-readobj/elf] - AArch64: Handle AARCH64_VARIANT_PCS for GNUStyle
Dec 17 2020, 6:35 AM
zatrazz committed rGef9dc51cd4af: [obj2yaml][yaml2obj] - Add AArch64 STO_AARCH64_VARIANT_PCS support (authored by zatrazz).
[obj2yaml][yaml2obj] - Add AArch64 STO_AARCH64_VARIANT_PCS support
Dec 17 2020, 6:34 AM
zatrazz closed D93045: [ELF] AArch64: Handle DT_AARCH64_VARIANT_PCS.
Dec 17 2020, 6:34 AM · Restricted Project
zatrazz closed D93044: [llvm-readobj/elf] - AArch64: Handle AARCH64_VARIANT_PCS.
Dec 17 2020, 6:34 AM · Restricted Project
zatrazz closed D93235: [obj2yaml][yaml2obj] - Add AArch64 STO_AARCH64_VARIANT_PCS support.
Dec 17 2020, 6:34 AM · Restricted Project

Dec 16 2020

zatrazz updated the diff for D93045: [ELF] AArch64: Handle DT_AARCH64_VARIANT_PCS.

Updated patch based on previous version.

Dec 16 2020, 10:21 AM · Restricted Project
zatrazz added inline comments to D93045: [ELF] AArch64: Handle DT_AARCH64_VARIANT_PCS.
Dec 16 2020, 9:59 AM · Restricted Project
zatrazz added a comment to D93045: [ELF] AArch64: Handle DT_AARCH64_VARIANT_PCS.

Both https://reviews.llvm.org/D93044 and https://reviews.llvm.org/D93235 have been approved, so the prerequisites of this patch are ok to land.

Dec 16 2020, 4:15 AM · Restricted Project
zatrazz added inline comments to D93044: [llvm-readobj/elf] - AArch64: Handle AARCH64_VARIANT_PCS.
Dec 16 2020, 4:13 AM · Restricted Project

Dec 15 2020

zatrazz added a comment to D93235: [obj2yaml][yaml2obj] - Add AArch64 STO_AARCH64_VARIANT_PCS support.

LGTM with 2 minor nits. Thanks!

Dec 15 2020, 8:36 AM · Restricted Project
zatrazz updated the diff for D93045: [ELF] AArch64: Handle DT_AARCH64_VARIANT_PCS.

Updated patch based on previous comment:

Dec 15 2020, 6:28 AM · Restricted Project
zatrazz updated the diff for D93044: [llvm-readobj/elf] - AArch64: Handle AARCH64_VARIANT_PCS.

Updated patch based on previous comments:

Dec 15 2020, 6:25 AM · Restricted Project

Dec 14 2020

zatrazz updated the diff for D93044: [llvm-readobj/elf] - AArch64: Handle AARCH64_VARIANT_PCS.

Updated patch based on previous comments. It depends on https://reviews.llvm.org/D93235 for YAML STO_AARCH64_VARIANT_PCS support.

Dec 14 2020, 10:05 AM · Restricted Project
zatrazz requested review of D93235: [obj2yaml][yaml2obj] - Add AArch64 STO_AARCH64_VARIANT_PCS support.
Dec 14 2020, 10:03 AM · Restricted Project
zatrazz added inline comments to D93044: [llvm-readobj/elf] - AArch64: Handle AARCH64_VARIANT_PCS.
Dec 14 2020, 9:02 AM · Restricted Project
zatrazz updated the diff for D93044: [llvm-readobj/elf] - AArch64: Handle AARCH64_VARIANT_PCS.

Updated patch based on previous comment.

Dec 14 2020, 7:28 AM · Restricted Project

Dec 11 2020

zatrazz updated the diff for D93045: [ELF] AArch64: Handle DT_AARCH64_VARIANT_PCS.

Updated patch based on previous comments. For in.relaIplt / R_AARCH64_IRELATIVE
I decided to not include since it seems to what binutils is done currently. I will raise with
them if this is the intended behaviour or if R_AARCH64_IRELATIVE should also create
the dynamic tag (and fix is accordingly on lld if it were the case).

Dec 11 2020, 11:57 AM · Restricted Project
zatrazz updated the diff for D93044: [llvm-readobj/elf] - AArch64: Handle AARCH64_VARIANT_PCS.

Updated patch based on previous comments.

Dec 11 2020, 11:55 AM · Restricted Project
zatrazz added inline comments to D93045: [ELF] AArch64: Handle DT_AARCH64_VARIANT_PCS.
Dec 11 2020, 10:53 AM · Restricted Project
zatrazz added inline comments to D93045: [ELF] AArch64: Handle DT_AARCH64_VARIANT_PCS.
Dec 11 2020, 10:43 AM · Restricted Project
zatrazz added inline comments to D93044: [llvm-readobj/elf] - AArch64: Handle AARCH64_VARIANT_PCS.
Dec 11 2020, 10:37 AM · Restricted Project
zatrazz updated the diff for D93045: [ELF] AArch64: Handle DT_AARCH64_VARIANT_PCS.

Updated patch based on previous comments.

Dec 11 2020, 5:12 AM · Restricted Project