Page MenuHomePhabricator

zatrazz (Adhemerval Zanella)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 10 2015, 12:58 PM (306 w, 4 d)

Recent Activity

Thu, Jan 21

zatrazz added a comment to D94612: [LLD][ELF][AArch64] Add support for R_AARCH64_LD64_GOTPAGE_LO15 relocation.

Ping.

Thu, Jan 21, 4:14 AM · Restricted Project
zatrazz closed D94611: MC: AArch64: Add support for gotpage_lo15.
Thu, Jan 21, 3:31 AM · Restricted Project
zatrazz committed rGff41ae8b3677: MC: AArch64: Add support for gotpage_lo15 (authored by zatrazz).
MC: AArch64: Add support for gotpage_lo15
Thu, Jan 21, 3:31 AM

Tue, Jan 19

zatrazz updated the diff for D94611: MC: AArch64: Add support for gotpage_lo15.

Updated patch based on previous comments.

Tue, Jan 19, 6:34 AM · Restricted Project

Mon, Jan 18

zatrazz closed D94809: [LLD][ELF][AArch64] Set _GLOBAL_OFFSET_TABLE_ at the start of .got.
Mon, Jan 18, 10:06 AM · Restricted Project
zatrazz committed rG2f92386e721a: [LLD][ELF][AArch64] Set _GLOBAL_OFFSET_TABLE_ at the start of .got (authored by zatrazz).
[LLD][ELF][AArch64] Set _GLOBAL_OFFSET_TABLE_ at the start of .got
Mon, Jan 18, 9:51 AM

Fri, Jan 15

zatrazz updated the diff for D94612: [LLD][ELF][AArch64] Add support for R_AARCH64_LD64_GOTPAGE_LO15 relocation.

Patch updated from comments, main changes are:

Fri, Jan 15, 10:33 AM · Restricted Project
zatrazz added a comment to D94612: [LLD][ELF][AArch64] Add support for R_AARCH64_LD64_GOTPAGE_LO15 relocation.

I will update the patch, since it is incomplete and requires https://reviews.llvm.org/D94809 .

Fri, Jan 15, 10:27 AM · Restricted Project
zatrazz requested review of D94809: [LLD][ELF][AArch64] Set _GLOBAL_OFFSET_TABLE_ at the start of .got.
Fri, Jan 15, 10:24 AM · Restricted Project

Wed, Jan 13

zatrazz requested review of D94612: [LLD][ELF][AArch64] Add support for R_AARCH64_LD64_GOTPAGE_LO15 relocation.
Wed, Jan 13, 9:35 AM · Restricted Project
zatrazz requested review of D94611: MC: AArch64: Add support for gotpage_lo15.
Wed, Jan 13, 9:33 AM · Restricted Project

Dec 17 2020

zatrazz committed rG978eb3b87bca: [lld] [ELF] AArch64: Handle DT_AARCH64_VARIANT_PCS (authored by zatrazz).
[lld] [ELF] AArch64: Handle DT_AARCH64_VARIANT_PCS
Dec 17 2020, 6:35 AM
zatrazz committed rGe04dc5f557c5: [llvm-readobj/elf] - AArch64: Handle AARCH64_VARIANT_PCS for GNUStyle (authored by zatrazz).
[llvm-readobj/elf] - AArch64: Handle AARCH64_VARIANT_PCS for GNUStyle
Dec 17 2020, 6:35 AM
zatrazz committed rGef9dc51cd4af: [obj2yaml][yaml2obj] - Add AArch64 STO_AARCH64_VARIANT_PCS support (authored by zatrazz).
[obj2yaml][yaml2obj] - Add AArch64 STO_AARCH64_VARIANT_PCS support
Dec 17 2020, 6:34 AM
zatrazz closed D93045: [ELF] AArch64: Handle DT_AARCH64_VARIANT_PCS.
Dec 17 2020, 6:34 AM · Restricted Project
zatrazz closed D93044: [llvm-readobj/elf] - AArch64: Handle AARCH64_VARIANT_PCS.
Dec 17 2020, 6:34 AM · Restricted Project
zatrazz closed D93235: [obj2yaml][yaml2obj] - Add AArch64 STO_AARCH64_VARIANT_PCS support.
Dec 17 2020, 6:34 AM · Restricted Project

Dec 16 2020

zatrazz updated the diff for D93045: [ELF] AArch64: Handle DT_AARCH64_VARIANT_PCS.

Updated patch based on previous version.

Dec 16 2020, 10:21 AM · Restricted Project
zatrazz added inline comments to D93045: [ELF] AArch64: Handle DT_AARCH64_VARIANT_PCS.
Dec 16 2020, 9:59 AM · Restricted Project
zatrazz added a comment to D93045: [ELF] AArch64: Handle DT_AARCH64_VARIANT_PCS.

Both https://reviews.llvm.org/D93044 and https://reviews.llvm.org/D93235 have been approved, so the prerequisites of this patch are ok to land.

Dec 16 2020, 4:15 AM · Restricted Project
zatrazz added inline comments to D93044: [llvm-readobj/elf] - AArch64: Handle AARCH64_VARIANT_PCS.
Dec 16 2020, 4:13 AM · Restricted Project

Dec 15 2020

zatrazz added a comment to D93235: [obj2yaml][yaml2obj] - Add AArch64 STO_AARCH64_VARIANT_PCS support.

LGTM with 2 minor nits. Thanks!

Dec 15 2020, 8:36 AM · Restricted Project
zatrazz updated the diff for D93045: [ELF] AArch64: Handle DT_AARCH64_VARIANT_PCS.

Updated patch based on previous comment:

Dec 15 2020, 6:28 AM · Restricted Project
zatrazz updated the diff for D93044: [llvm-readobj/elf] - AArch64: Handle AARCH64_VARIANT_PCS.

Updated patch based on previous comments:

Dec 15 2020, 6:25 AM · Restricted Project

Dec 14 2020

zatrazz updated the diff for D93044: [llvm-readobj/elf] - AArch64: Handle AARCH64_VARIANT_PCS.

Updated patch based on previous comments. It depends on https://reviews.llvm.org/D93235 for YAML STO_AARCH64_VARIANT_PCS support.

Dec 14 2020, 10:05 AM · Restricted Project
zatrazz requested review of D93235: [obj2yaml][yaml2obj] - Add AArch64 STO_AARCH64_VARIANT_PCS support.
Dec 14 2020, 10:03 AM · Restricted Project
zatrazz added inline comments to D93044: [llvm-readobj/elf] - AArch64: Handle AARCH64_VARIANT_PCS.
Dec 14 2020, 9:02 AM · Restricted Project
zatrazz updated the diff for D93044: [llvm-readobj/elf] - AArch64: Handle AARCH64_VARIANT_PCS.

Updated patch based on previous comment.

Dec 14 2020, 7:28 AM · Restricted Project

Dec 11 2020

zatrazz updated the diff for D93045: [ELF] AArch64: Handle DT_AARCH64_VARIANT_PCS.

Updated patch based on previous comments. For in.relaIplt / R_AARCH64_IRELATIVE
I decided to not include since it seems to what binutils is done currently. I will raise with
them if this is the intended behaviour or if R_AARCH64_IRELATIVE should also create
the dynamic tag (and fix is accordingly on lld if it were the case).

Dec 11 2020, 11:57 AM · Restricted Project
zatrazz updated the diff for D93044: [llvm-readobj/elf] - AArch64: Handle AARCH64_VARIANT_PCS.

Updated patch based on previous comments.

Dec 11 2020, 11:55 AM · Restricted Project
zatrazz added inline comments to D93045: [ELF] AArch64: Handle DT_AARCH64_VARIANT_PCS.
Dec 11 2020, 10:53 AM · Restricted Project
zatrazz added inline comments to D93045: [ELF] AArch64: Handle DT_AARCH64_VARIANT_PCS.
Dec 11 2020, 10:43 AM · Restricted Project
zatrazz added inline comments to D93044: [llvm-readobj/elf] - AArch64: Handle AARCH64_VARIANT_PCS.
Dec 11 2020, 10:37 AM · Restricted Project
zatrazz updated the diff for D93045: [ELF] AArch64: Handle DT_AARCH64_VARIANT_PCS.

Updated patch based on previous comments.

Dec 11 2020, 5:12 AM · Restricted Project
zatrazz updated the diff for D93044: [llvm-readobj/elf] - AArch64: Handle AARCH64_VARIANT_PCS.

Updated patch based on previous comments.

Dec 11 2020, 5:11 AM · Restricted Project
zatrazz abandoned D93107: [llvm-readobj/elf] - AArch64: Handle AARCH64_VARIANT_PCS for GNUStyle.
Dec 11 2020, 5:07 AM · Restricted Project
zatrazz requested review of D93107: [llvm-readobj/elf] - AArch64: Handle AARCH64_VARIANT_PCS for GNUStyle.
Dec 11 2020, 5:07 AM · Restricted Project

Dec 10 2020

zatrazz added inline comments to D93045: [ELF] AArch64: Handle DT_AARCH64_VARIANT_PCS.
Dec 10 2020, 12:05 PM · Restricted Project
zatrazz added a comment to D93045: [ELF] AArch64: Handle DT_AARCH64_VARIANT_PCS.

st_other marked with STO_AARCH64_VARIANT_PCS indicates a may follow a variant

a -> it

Dec 10 2020, 11:56 AM · Restricted Project
zatrazz added inline comments to D93045: [ELF] AArch64: Handle DT_AARCH64_VARIANT_PCS.
Dec 10 2020, 11:49 AM · Restricted Project
zatrazz requested review of D93045: [ELF] AArch64: Handle DT_AARCH64_VARIANT_PCS.
Dec 10 2020, 8:39 AM · Restricted Project
zatrazz requested review of D93044: [llvm-readobj/elf] - AArch64: Handle AARCH64_VARIANT_PCS.
Dec 10 2020, 8:36 AM · Restricted Project

Dec 8 2020

zatrazz committed rGdb61b1844e11: [compiler-rt] [builtins] Support conversion between fp16 and fp128 (authored by zatrazz).
[compiler-rt] [builtins] Support conversion between fp16 and fp128
Dec 8 2020, 6:52 AM
zatrazz closed D92242: [compiler-rt] [builtins] Support conversion between fp16 and fp128.
Dec 8 2020, 6:52 AM · Restricted Project

Dec 3 2020

zatrazz committed rGc288715e952f: [compiler-rt] [builtins] Use _Float16 on extendhfsf2, truncdfhf2 __truncsfhf2… (authored by zatrazz).
[compiler-rt] [builtins] Use _Float16 on extendhfsf2, truncdfhf2 __truncsfhf2…
Dec 3 2020, 11:10 AM
zatrazz closed D92241: [compiler-rt] [builtins] Use _Float16 on extendhfsf2, truncdfhf2 __truncsfhf2 if available.
Dec 3 2020, 11:10 AM · Restricted Project

Nov 30 2020

zatrazz added a comment to D92241: [compiler-rt] [builtins] Use _Float16 on extendhfsf2, truncdfhf2 __truncsfhf2 if available.
Nov 30 2020, 4:06 AM · Restricted Project

Nov 27 2020

zatrazz requested review of D92242: [compiler-rt] [builtins] Support conversion between fp16 and fp128.
Nov 27 2020, 11:47 AM · Restricted Project
zatrazz requested review of D92241: [compiler-rt] [builtins] Use _Float16 on extendhfsf2, truncdfhf2 __truncsfhf2 if available.
Nov 27 2020, 11:47 AM · Restricted Project

Nov 26 2020

zatrazz added a comment to D91733: [compiler-rt] [builtins] Use _Float16 on extendhfsf2, truncdfhf2 __truncsfhf2 if available.

Isn't COMPILER_RT_HAS_FLOAT16 generated using the host compiler? If so, using the same flag for a compiler_rt test could fail if the host compiler supports f16 and the target compiler does not.

Nov 26 2020, 3:29 AM · Restricted Project

Nov 19 2020

zatrazz committed rG7a948298813c: [compiler-rt] [builtins] Use _Float16 on extendhfsf2, truncdfhf2 __truncsfhf2… (authored by zatrazz).
[compiler-rt] [builtins] Use _Float16 on extendhfsf2, truncdfhf2 __truncsfhf2…
Nov 19 2020, 10:15 AM
zatrazz committed rG1fb91fcf9cfe: [compiler-rt] [builtins] Support conversion between fp16 and fp128 (authored by zatrazz).
[compiler-rt] [builtins] Support conversion between fp16 and fp128
Nov 19 2020, 10:15 AM
zatrazz committed rG807320119fbb: [AArch64] Lower fptrunc/fpext from/to FP128t to/from FP16 (authored by zatrazz).
[AArch64] Lower fptrunc/fpext from/to FP128t to/from FP16
Nov 19 2020, 10:15 AM
zatrazz closed D91733: [compiler-rt] [builtins] Use _Float16 on extendhfsf2, truncdfhf2 __truncsfhf2 if available.
Nov 19 2020, 10:15 AM · Restricted Project
zatrazz closed D91732: [compiler-rt] [builtins] Support conversion between fp16 and fp128.
Nov 19 2020, 10:15 AM · Restricted Project
zatrazz closed D91731: [AArch64] Lower fptrunc/fpext from/to FP128t to/from FP16.
Nov 19 2020, 10:15 AM · Restricted Project
zatrazz added a comment to D91732: [compiler-rt] [builtins] Support conversion between fp16 and fp128.

LGTM

Also, __fp16 is a storage format and promoted to 'float' for argument passing

It doesn't affect this patch, but for all of the ARM and AArch64 ABIs, __fp16 arguments are passed in the bottom half of an integer or FP register, not promoted to float. There was an old version of the AArch32 ABI (I think) which did that, but I don't think any compiler implemented it before it was changed.

Nov 19 2020, 3:17 AM · Restricted Project

Nov 18 2020

zatrazz abandoned D90175: [AArch64] Support conversion between fp16 and fp128.
Nov 18 2020, 11:36 AM · Restricted Project, Restricted Project
zatrazz requested review of D91733: [compiler-rt] [builtins] Use _Float16 on extendhfsf2, truncdfhf2 __truncsfhf2 if available.
Nov 18 2020, 11:36 AM · Restricted Project
zatrazz requested review of D91732: [compiler-rt] [builtins] Support conversion between fp16 and fp128.
Nov 18 2020, 11:35 AM · Restricted Project
zatrazz requested review of D91731: [AArch64] Lower fptrunc/fpext from/to FP128t to/from FP16.
Nov 18 2020, 11:34 AM · Restricted Project
zatrazz added a comment to D90175: [AArch64] Support conversion between fp16 and fp128.

They are enabled iff the compiler supports _Float16.

Why are these not enabled for compilers which don't support _Float16? There is also the __fp16 type, which has been supported for much longer and could also generate code like this.

Nov 18 2020, 5:18 AM · Restricted Project, Restricted Project
zatrazz added a comment to D90175: [AArch64] Support conversion between fp16 and fp128.

Apologies for my slow response.

Patches need to have a large context (see https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface I prefer arc diff)

Nov 18 2020, 3:59 AM · Restricted Project, Restricted Project

Nov 17 2020

zatrazz added a comment to D90175: [AArch64] Support conversion between fp16 and fp128.

Ping (x2).

Nov 17 2020, 12:15 PM · Restricted Project, Restricted Project

Nov 11 2020

zatrazz added a comment to D90175: [AArch64] Support conversion between fp16 and fp128.

Ping.

Nov 11 2020, 5:48 AM · Restricted Project, Restricted Project

Nov 5 2020

zatrazz closed D90627: [sanitizer] Assume getrandom might not be supported by the kernel.
Nov 5 2020, 3:38 AM · Restricted Project
zatrazz closed D90628: [lsan] Disable some LSAN tests for arm-linux-gnueabi{hf}.
Nov 5 2020, 3:38 AM · Restricted Project
zatrazz committed rGd025df3c1dec: [lsan] Disable some LSAN tests for arm-linux-gnueabi{hf} (authored by zatrazz).
[lsan] Disable some LSAN tests for arm-linux-gnueabi{hf}
Nov 5 2020, 3:37 AM
zatrazz committed rG0ad3cb8c2675: [sanitizer] Assume getrandom might not be supported by the kernel (authored by zatrazz).
[sanitizer] Assume getrandom might not be supported by the kernel
Nov 5 2020, 3:37 AM

Nov 2 2020

zatrazz requested review of D90628: [lsan] Disable some LSAN tests for arm-linux-gnueabi{hf}.
Nov 2 2020, 9:53 AM · Restricted Project
zatrazz requested review of D90627: [sanitizer] Assume getrandom might not be supported by the kernel.
Nov 2 2020, 9:51 AM · Restricted Project
zatrazz added a comment to D90175: [AArch64] Support conversion between fp16 and fp128.

Ping.

Nov 2 2020, 9:47 AM · Restricted Project, Restricted Project

Oct 29 2020

zatrazz closed D90400: [sanitizer] Disable ASLR for release_shadow_space.
Oct 29 2020, 12:09 PM · Restricted Project
zatrazz committed rGf93c2b64ed38: [sanitizer] Disable ASLR for release_shadow_space (authored by zatrazz).
[sanitizer] Disable ASLR for release_shadow_space
Oct 29 2020, 12:09 PM
zatrazz requested review of D90400: [sanitizer] Disable ASLR for release_shadow_space.
Oct 29 2020, 8:16 AM · Restricted Project

Oct 26 2020

zatrazz requested review of D90175: [AArch64] Support conversion between fp16 and fp128.
Oct 26 2020, 11:00 AM · Restricted Project, Restricted Project
zatrazz abandoned D86453: [AArch64] Support conversion between fp16 and fp128.
Oct 26 2020, 11:00 AM · Restricted Project, Restricted Project

Oct 12 2020

zatrazz added a comment to D86453: [AArch64] Support conversion between fp16 and fp128.

Ping (x3).

Oct 12 2020, 10:37 AM · Restricted Project, Restricted Project
zatrazz committed rG039126c97d39: [sanitizer] Disable fast_unwind_on_malloc as default for arm-linux-gnu (authored by zatrazz).
[sanitizer] Disable fast_unwind_on_malloc as default for arm-linux-gnu
Oct 12 2020, 10:36 AM
zatrazz closed D88958: [sanitizer] Disable fast_unwind_on_malloc as default for arm-linux-gnu.
Oct 12 2020, 10:36 AM · Restricted Project

Oct 7 2020

zatrazz requested review of D88958: [sanitizer] Disable fast_unwind_on_malloc as default for arm-linux-gnu.
Oct 7 2020, 5:14 AM · Restricted Project
zatrazz abandoned D83134: [asan] Disable fast unwinder on arm-linux-gnueabi with thumb.
Oct 7 2020, 5:14 AM · Restricted Project

Oct 5 2020

zatrazz added a comment to D86453: [AArch64] Support conversion between fp16 and fp128.

Ping (x2).

Oct 5 2020, 6:35 AM · Restricted Project, Restricted Project

Sep 29 2020

zatrazz added a comment to D86453: [AArch64] Support conversion between fp16 and fp128.

Ping.

Sep 29 2020, 5:33 AM · Restricted Project, Restricted Project

Sep 8 2020

zatrazz added inline comments to D86453: [AArch64] Support conversion between fp16 and fp128.
Sep 8 2020, 12:58 PM · Restricted Project, Restricted Project
zatrazz added inline comments to D86453: [AArch64] Support conversion between fp16 and fp128.
Sep 8 2020, 11:51 AM · Restricted Project, Restricted Project
zatrazz added a comment to D86453: [AArch64] Support conversion between fp16 and fp128.

Ping.

Sep 8 2020, 4:58 AM · Restricted Project, Restricted Project

Sep 1 2020

zatrazz updated the diff for D86453: [AArch64] Support conversion between fp16 and fp128.

I have adapted the news files using clang-format and fixed minor style issues pointed by previous comments.

Sep 1 2020, 10:43 AM · Restricted Project, Restricted Project

Aug 31 2020

zatrazz updated the diff for D86453: [AArch64] Support conversion between fp16 and fp128.

Updated patch based on previous comments.

Aug 31 2020, 10:46 AM · Restricted Project, Restricted Project
zatrazz added inline comments to D86453: [AArch64] Support conversion between fp16 and fp128.
Aug 31 2020, 10:43 AM · Restricted Project, Restricted Project

Aug 27 2020

zatrazz added a comment to D86453: [AArch64] Support conversion between fp16 and fp128.

Hi atrosinenko, do you think this patch need any more change on the testing side?
The fp_lib.h/int_lib.h change would most likely require in a more complex without
much gain in organization imho.

Aug 27 2020, 4:45 AM · Restricted Project, Restricted Project

Aug 25 2020

zatrazz added inline comments to D86453: [AArch64] Support conversion between fp16 and fp128.
Aug 25 2020, 6:47 AM · Restricted Project, Restricted Project

Aug 24 2020

zatrazz updated the diff for D86453: [AArch64] Support conversion between fp16 and fp128.

Updated version based on previous comments.

Aug 24 2020, 1:57 PM · Restricted Project, Restricted Project
zatrazz added inline comments to D86453: [AArch64] Support conversion between fp16 and fp128.
Aug 24 2020, 1:47 PM · Restricted Project, Restricted Project
zatrazz requested review of D86453: [AArch64] Support conversion between fp16 and fp128.
Aug 24 2020, 6:07 AM · Restricted Project, Restricted Project
zatrazz added a comment to D83134: [asan] Disable fast unwinder on arm-linux-gnueabi with thumb.

Is this patch still needed?

Aug 24 2020, 6:00 AM · Restricted Project

Jul 8 2020

zatrazz added a comment to D83134: [asan] Disable fast unwinder on arm-linux-gnueabi with thumb.

Is unwinding actually broken on an all-clang, all-thumb system?

Jul 8 2020, 5:21 AM · Restricted Project

Jul 3 2020

zatrazz created D83134: [asan] Disable fast unwinder on arm-linux-gnueabi with thumb.
Jul 3 2020, 8:02 AM · Restricted Project

Jan 10 2020

zatrazz abandoned D72449: [PATCH] [llvm-ranlib] Take in consideration UTC offset for D-flag.test.
Jan 10 2020, 12:24 PM · Restricted Project

Jan 9 2020

zatrazz added a comment to D72449: [PATCH] [llvm-ranlib] Take in consideration UTC offset for D-flag.test.

I'm fine with this workaround although I'm very surprised that the test is not working. Especially since deterministic-archive.test and replace-update.test also set TZ to get reproducible output

Do you have access to any of the failing bots? If so what happens there if you change the TZ variable?
I get the following on all systems I have access to when I run something like date && date -u && env TZ=CET date && env TZ=CET date -u && env TZ=BST date && env TZ=BST date -u I get the following output:

Thu  9 Jan 2020 20:18:10 GMT
Thu  9 Jan 2020 20:18:10 UTC
Thu  9 Jan 2020 21:18:10 CET
Thu  9 Jan 2020 20:18:10 UTC
Thu  9 Jan 2020 20:18:10 UTC
Thu  9 Jan 2020 20:18:10 UTC
Jan 9 2020, 1:32 PM · Restricted Project