User Details
- User Since
- Mar 10 2015, 12:58 PM (420 w, 4 d)
Jan 20 2023
Jan 3 2023
Another project that is also breaks with this change is glibc. Although I could be fixed on glibc side, the undefined symbols are used to simplify the version symbol for multiple ABI with different base ABIs.
Nov 8 2022
Update review based on reviewers comments.
Nov 2 2022
Oct 26 2022
Aug 25 2022
Aug 24 2022
Aug 10 2022
It does help on test-suite, thanks.
Aug 9 2022
This commit seems to have broken test-suite on aarch64 [1]. The warning shows:
Aug 4 2022
Jul 28 2022
LGTM, thanks.
Jul 15 2022
Jul 11 2022
LGTM, the kernel exported value is same for all architectures. Anther possibility would be to split the sanitizer_platform_limits_posix.cpp and add a sanitizer_platform_limits_posix_linux.cpp which only add linux includes.
Apr 7 2022
I tested this patch on my glibc clang branch and while it has fixed the st_value aliases issues, it now triggers another regression:
Oct 5 2021
Would avoid calling sched_yield() help in this situation? Depending of the system default, calling the glibc symbol might result in a lazy-resolution and thus invoke a lot of loader's code (which might clobber temporary registers).
This has caused a regression on stage2 buildbot [1], more specifically the test FAIL: Clang::p4-0x.cpp (but I think the other others might be related).
Aug 23 2021
Hi, I am not 100% sure but it seems to trigger a regression on aarch64 bot [1]. I can reproduce with current master as well:
Jun 9 2021
The change look reasonable to me, I will increase build time but it increase test coverage.
Jun 2 2021
LGTM, thanks.
Mar 1 2021
Feb 19 2021
Updated patch based on previous comments.
Feb 18 2021
Feb 17 2021
Feb 16 2021
Feb 15 2021
Feb 12 2021
LGTM, it fixes the arm sanitizer regressions.
This change broke arm32 llvm-symbolizer which triggered some sanitizer regression. Previously, ARM mapping symbols [1] were ignored but after this change they are shown as the function name.
Feb 11 2021
Updated patch based on previous comments.
Feb 9 2021
Jan 26 2021
Jan 25 2021
Updated patch based on previous comments. The R_AARCH64_GOT_PAGE is added on
the isStaticLinkTimeConstant and the test is changed to check for shared build as well.
Jan 21 2021
Ping.
Jan 19 2021
Updated patch based on previous comments.
Jan 18 2021
Jan 15 2021
Patch updated from comments, main changes are:
I will update the patch, since it is incomplete and requires https://reviews.llvm.org/D94809 .
Jan 13 2021
Dec 17 2020
Dec 16 2020
Updated patch based on previous version.
Both https://reviews.llvm.org/D93044 and https://reviews.llvm.org/D93235 have been approved, so the prerequisites of this patch are ok to land.
Dec 15 2020
Updated patch based on previous comment:
Updated patch based on previous comments:
Dec 14 2020
Updated patch based on previous comments. It depends on https://reviews.llvm.org/D93235 for YAML STO_AARCH64_VARIANT_PCS support.
Updated patch based on previous comment.
Dec 11 2020
Updated patch based on previous comments. For in.relaIplt / R_AARCH64_IRELATIVE
I decided to not include since it seems to what binutils is done currently. I will raise with
them if this is the intended behaviour or if R_AARCH64_IRELATIVE should also create
the dynamic tag (and fix is accordingly on lld if it were the case).
Updated patch based on previous comments.
Updated patch based on previous comments.