I had manually removed unused prefixes from CodeGen/X86 directory for more than 100 tests.
I checked the change history for each of them at the beginning, and then I mainly focused on the format since I found all of the unused prefixes were result from either insensible copy or residuum after functional update.
I think it's OK to remove the remaining X86 tests by script now. I wrote a rough script which works for me in most tests. I put it in llvm/utils temporarily for review and hope it may help other components owners.
The tests in this patch are all generated by the tool and checked by update tool for the autogenerated tests. I skimmed them and checked about 30 tests and didn't find any unexpected changes.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
For these utils/update_llc_test_checks.py tests, have you verified that running them does not give warnings? (update_llc_test_checks.py reports warnings if there are unsatisfied check prefixes)
Comment Actions
LGTM - please can you reply to llvm-dev's unused-prefix thread mentioning your script (and how to use it) to help others still working on this?
Comment Actions
The script checks conflicting warning for them and put those tests into Failed list. I only added the Done ones in this patch. I also run update_llc/mir_test_checks.py manually for all autogenerated tests in this patch. No warning been reported except a unparseable one for error check.