Page MenuHomePhabricator

[AArch64] Add CPU Cortex-R82
ClosedPublic

Authored by SjoerdMeijer on Oct 1 2020, 7:52 AM.

Details

Summary

This basically does what it says on the tin.

One note about the system register: that is a bit of a refactoring because of small differences between v8.4-A AArch64 and v8-R AArch64.

This is based on patches from Mark Murray and Mikhail Maltsev.

Diff Detail

Event Timeline

SjoerdMeijer created this revision.Oct 1 2020, 7:52 AM
SjoerdMeijer requested review of this revision.Oct 1 2020, 7:52 AM
SjoerdMeijer added a reviewer: ostannard.
SjoerdMeijer edited the summary of this revision. (Show Details)Oct 1 2020, 7:54 AM
SjoerdMeijer added inline comments.Oct 1 2020, 8:01 AM
clang/lib/Driver/ToolChains/Arch/AArch64.cpp
310

Adding v8.5 and v8.6 here are unrelated changes, but I think they were missed, and I will follow up after this to add tests for this.

ostannard accepted this revision.Oct 2 2020, 3:00 AM

LGTM, but please split the unrelated change out into a separate patch.

clang/lib/Driver/ToolChains/Arch/AArch64.cpp
310

Please move these (v8.5/6) changes into the patch with the tests.

This revision is now accepted and ready to land.Oct 2 2020, 3:00 AM
chill added a subscriber: chill.Oct 2 2020, 3:09 AM
chill added inline comments.
clang/lib/Driver/ToolChains/Arch/AArch64.cpp
357

This is redundant, because of line 309.

Thanks for reviewing!

clang/lib/Driver/ToolChains/Arch/AArch64.cpp
310

yeah, cheers, will do.

357

Thanks, I will look at this as a follow up; don't want to touch this monstrosity too much at the same time.

This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptOct 2 2020, 4:48 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript