This is an archive of the discontinued LLVM Phabricator instance.

Differential D88530

Remove `Ops` suffix from dialect library names
ClosedPublic

Authored by GMNGeoffrey on Sep 29 2020, 11:04 PM.

Details

Reviewers
stephenneuendorffer
mehdi_amini
mravishankar
antiagainst
aartbik
ftynse
silvas
nicolasvasilache
herhut
stellaraccident
Commits
rGd4e889f1f572: Remove `Ops` suffix from dialect library names
Summary

Dialects include more than just ops, so this suffix is outdated. Follows
discussion in
https://llvm.discourse.group/t/rfc-canonical-file-paths-to-dialects/621

Diff Detail

Event Timeline

GMNGeoffrey created this revision.Sep 29 2020, 11:04 PM
Herald added a reviewer: mravishankar. · View Herald TranscriptSep 29 2020, 11:04 PM
Herald added a reviewer: antiagainst. · View Herald Transcript
Herald added a reviewer: aartbik. · View Herald Transcript
Herald added a reviewer: ftynse. · View Herald Transcript
Herald added a reviewer: silvas. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: tatianashp, ThomasRaoux, AlexeySotkin and 16 others. · View Herald Transcript
GMNGeoffrey requested review of this revision.Sep 29 2020, 11:04 PM
Herald added a reviewer: nicolasvasilache. · View Herald TranscriptSep 29 2020, 11:04 PM
Herald added a reviewer: herhut. · View Herald Transcript
Herald added a subscriber: nicolasvasilache. · View Herald Transcript
GMNGeoffrey added inline comments.Sep 29 2020, 11:11 PM
mlir/docs/Tutorials/CreatingADialect.md
29

Side note: why is this file wrapped at 72 characters?

stellaraccident accepted this revision.Sep 29 2020, 11:16 PM
stellaraccident added a subscriber: stellaraccident.

I just got tripped up by the opacity of this today in npcomp. Thanks for making it more explicit. May want to give it a bit for others to respond.

This revision is now accepted and ready to land.Sep 29 2020, 11:16 PM
Harbormaster completed remote builds in B73457: Diff 295178.Sep 29 2020, 11:16 PM
jpienaar added a comment.Sep 30 2020, 6:36 AM
In D88530#2302439, @stellaraccident wrote:

I just got tripped up by the opacity of this today in npcomp. Thanks for making it more explicit. May want to give it a bit for others to respond.

What opacity? Meaning, this seems like changing one convention for another, not sure what it makes more transparent. Is there documentation of the convention missing? (It was inconsistent but I never relied on me typing these directly so probably this refers to not needing to look up things)

mlir/docs/Tutorials/CreatingADialect.md
41

Did you miss this one?

GMNGeoffrey added inline comments.Sep 30 2020, 10:22 AM
mlir/docs/Tutorials/CreatingADialect.md
41

Unfortunately this actually references the td file which frequently is called FooOps :-/ There's some discussion in the discourse thread. We could make this example assume all one TD file rather than a FooOps.td file

GMNGeoffrey added a comment.Sep 30 2020, 10:23 AM

Oh huh, I broke flang :-D I was just replacing in the MLIR directory

GMNGeoffrey updated this revision to Diff 295360.Sep 30 2020, 11:20 AM
  • Fix flang
Harbormaster completed remote builds in B73553: Diff 295360.Sep 30 2020, 11:30 AM
stellaraccident added a comment.Sep 30 2020, 5:40 PM
In D88530#2303271, @jpienaar wrote:
In D88530#2302439, @stellaraccident wrote:

I just got tripped up by the opacity of this today in npcomp. Thanks for making it more explicit. May want to give it a bit for others to respond.

What opacity? Meaning, this seems like changing one convention for another, not sure what it makes more transparent. Is there documentation of the convention missing? (It was inconsistent but I never relied on me typing these directly so probably this refers to not needing to look up things)

Sorry for the half comment. "This" was referring to the multi-step cleanup referenced on the originating Discourse post.

stellaraccident updated this revision to Diff 295446.Sep 30 2020, 6:01 PM

Rebase and fix additional instance that came in.

This revision was landed with ongoing or failed builds.Sep 30 2020, 6:02 PM
Closed by commit rGd4e889f1f572: Remove `Ops` suffix from dialect library names (authored by GMNGeoffrey, committed by stellaraccident). · Explain Why
This revision was automatically updated to reflect the committed changes.
stellaraccident added a commit: rGd4e889f1f572: Remove `Ops` suffix from dialect library names.
Harbormaster completed remote builds in B73597: Diff 295446.Sep 30 2020, 6:08 PM

Revision Contents

PathSize
flang/
lib/
Lower/
2 lines
mlir/
docs/
Tutorials/
51 lines
lib/
Analysis/
4 lines
Conversion/
AffineToStandard/
4 lines
GPUToSPIRV/
2 lines
GPUToVulkan/
2 lines
LinalgToLLVM/
2 lines
LinalgToSPIRV/
2 lines
LinalgToStandard/
2 lines
SCFToGPU/
6 lines
SCFToSPIRV/
6 lines
StandardToSPIRV/
2 lines
Dialect/
Affine/
EDSC/
4 lines
IR/
4 lines
Transforms/
4 lines
Utils/
2 lines
GPU/
2 lines
Linalg/
Analysis/
6 lines
EDSC/
6 lines
IR/
4 lines
Transforms/
6 lines
Utils/
6 lines
Quant/
2 lines
SCF/
2 lines
Transforms/
4 lines
Shape/
IR/
2 lines
StandardOps/
2 lines
Transforms/
2 lines
Vector/
6 lines
ExecutionEngine/
2 lines
Transforms/
4 lines
Utils/
4 lines
test/
EDSC/
6 lines
lib/
Dialect/
Test/
2 lines
Transforms/
4 lines

Diff 295360

flang/lib/Lower/CMakeLists.txt

Show All 24 Linesadd_flang_library(FortranLower
${dialect_libs} ${dialect_libs}
FortranCommon FortranCommon
FortranParser FortranParser
FortranEvaluate FortranEvaluate
FortranSemantics FortranSemantics
MLIRAffineToStandard MLIRAffineToStandard
MLIRLLVMIR MLIRLLVMIR
MLIRSCFToStandard MLIRSCFToStandard
MLIRStandardOps MLIRStandard
LINK_COMPONENTS LINK_COMPONENTS
Support Support
) )

mlir/docs/Tutorials/CreatingADialect.md

Show All 20 Lines
typically defined in FooDialect.cpp, which includes FooOps.cpp.inc and typically defined in FooDialect.cpp, which includes FooOps.cpp.inc and
FooOpsInterfaces.h.inc. FooOpsInterfaces.h.inc.
The 'Transforms' directory contains rewrite rules for the dialect, The 'Transforms' directory contains rewrite rules for the dialect,
typically described in TableGen file using the [DDR typically described in TableGen file using the [DDR
format](DeclarativeRewrites.md). format](DeclarativeRewrites.md).
Note that dialect names should not generally be suffixed with “Ops”, Note that dialect names should not generally be suffixed with “Ops”,
although some files pertaining to the operations of a dialect (e.g. although some files pertaining only to the operations of a dialect (e.g.
GMNGeoffreyAuthorUnsubmitted
Done
ReplyInline Actions

Side note: why is this file wrapped at 72 characters?

GMNGeoffrey: Side note: why is this file wrapped at 72 characters?
FooOps.cpp) might be. FooOps.cpp) might be.
## CMake best practices ## CMake best practices
### TableGen Targets ### TableGen Targets
Operations in dialects are typically declared using the ODS format in Operations in dialects are typically declared using the ODS format in
tablegen in a file FooOps.td. This file forms the core of a dialect and tablegen in a file FooOps.td. This file forms the core of a dialect and
is declared using add_mlir_dialect(). is declared using add_mlir_dialect().
```cmake ```cmake
add_mlir_dialect(FooOps foo) add_mlir_dialect(FooOps foo)
jpienaarUnsubmitted
Not Done
ReplyInline Actions

Did you miss this one?

jpienaar: Did you miss this one?
GMNGeoffreyAuthorUnsubmitted
Done
ReplyInline Actions

Unfortunately this actually references the td file which frequently is called FooOps :-/ There's some discussion in the discourse thread. We could make this example assume all one TD file rather than a FooOps.td file

GMNGeoffrey: Unfortunately this actually references the td file which frequently is called FooOps :-/…
add_mlir_doc(FooOps -gen-dialect-doc FooDialect Dialects/) add_mlir_doc(FooOps -gen-dialect-doc FooDialect Dialects/)
``` ```
This generates the correct rules to run mlir-tblgen, along with a This generates the correct rules to run mlir-tblgen, along with a
'MLIRFooOpsIncGen' target which can be used to declare dependencies. 'MLIRFooOpsIncGen' target which can be used to declare dependencies.
Dialect transformations are typically declared in a file FooTransforms.td. Dialect transformations are typically declared in a file FooTransforms.td.
Targets for TableGen are described in typical llvm fashion. Targets for TableGen are described in typical llvm fashion.
```cmake ```cmake
set(LLVM_TARGET_DEFINITIONS FooTransforms.td) set(LLVM_TARGET_DEFINITIONS FooTransforms.td)
mlir_tablegen(FooTransforms.h.inc -gen-rewriters) mlir_tablegen(FooTransforms.h.inc -gen-rewriters)
add_public_tablegen_target(MLIRFooTransformIncGen) add_public_tablegen_target(MLIRFooTransformIncGen)
``` ```
The result is another 'IncGen' target, which runs mlir-tblgen. The result is another 'IncGen' target, which runs mlir-tblgen.
### Library Targets ### Library Targets
Dialects may have multiple libraries. Each library is typically Dialects may have multiple libraries. Each library is typically
declared with add_mlir_dialect_library(). Dialect libraries often declared with add_mlir_dialect_library(). Dialect libraries often
depend on the generation of header files from TableGen (specified depend on the generation of header files from TableGen (specified
using the DEPENDS keyword). Dialect libraries may also depend on using the DEPENDS keyword). Dialect libraries may also depend on
other dialect libraries. Typically this dependence is declared using other dialect libraries. Typically this dependence is declared using
target_link_libraries() and the PUBLIC keyword. For instance: target_link_libraries() and the PUBLIC keyword. For instance:
```cmake ```cmake
add_mlir_dialect_library(MLIRFoo
add_mlir_dialect_library(FooOps
DEPENDS DEPENDS
MLIRFooOpsIncGen MLIRFooOpsIncGen
MLIRFooTransformsIncGen MLIRFooTransformsIncGen
LINK_COMPONENTS LINK_COMPONENTS
Core Core
LINK_LIBS PUBLIC LINK_LIBS PUBLIC
BarOps MLIRBar
<some-other-library> <some-other-library>
) )
``` ```
add_mlir_dialect_library() is a thin wrapper around add_llvm_library() add_mlir_dialect_library() is a thin wrapper around add_llvm_library()
which collects a list of all the dialect libraries. This list is which collects a list of all the dialect libraries. This list is
often useful for linking tools (e.g. mlir-opt) which should have often useful for linking tools (e.g. mlir-opt) which should have
access to all dialects. This list is also linked into libMLIR.so. access to all dialects. This list is also linked into libMLIR.so.
The list can be retrieved from the MLIR_DIALECT_LIBS global property: The list can be retrieved from the MLIR_DIALECT_LIBS global property:
```cmake ```cmake
get_property(dialect_libs GLOBAL PROPERTY MLIR_DIALECT_LIBS) get_property(dialect_libs GLOBAL PROPERTY MLIR_DIALECT_LIBS)
``` ```
Note that although the Bar dialect also uses TableGen to declare its Note that although the Bar dialect also uses TableGen to declare its
operations, it is not necessary to explicitly depend on the operations, it is not necessary to explicitly depend on the
corresponding IncGen targets. The PUBLIC link dependency is corresponding IncGen targets. The PUBLIC link dependency is
sufficient. Also note that we avoid using add_dependencies sufficient. Also note that we avoid using add_dependencies
explicitly, since the dependencies need to be available to the explicitly, since the dependencies need to be available to the
underlying add_llvm_library() call, allowing it to correctly create underlying add_llvm_library() call, allowing it to correctly create
Show All 30 Lines
Each conversion typically exists in a separate library, declared with Each conversion typically exists in a separate library, declared with
add_mlir_conversion_library(). Conversion libraries typically depend add_mlir_conversion_library(). Conversion libraries typically depend
on their source and target dialects, but may also depend on other on their source and target dialects, but may also depend on other
dialects (e.g. MLIRStandard). Typically this dependence is specified dialects (e.g. MLIRStandard). Typically this dependence is specified
using target_link_libraries() and the PUBLIC keyword. For instance: using target_link_libraries() and the PUBLIC keyword. For instance:
```cmake ```cmake
add_mlir_conversion_library(MLIRBarToFoo add_mlir_conversion_library(MLIRBarToFoo
BarToFoo.cpp BarToFoo.cpp
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
${MLIR_MAIN_INCLUDE_DIR}/mlir/Conversion/BarToFoo ${MLIR_MAIN_INCLUDE_DIR}/mlir/Conversion/BarToFoo
LINK_LIBS PUBLIC LINK_LIBS PUBLIC
BarOps MLIRBar
FooOps MLIRFoo
) )
``` ```
add_mlir_conversion_library() is a thin wrapper around add_mlir_conversion_library() is a thin wrapper around
add_llvm_library() which collects a list of all the conversion add_llvm_library() which collects a list of all the conversion
libraries. This list is often useful for linking tools libraries. This list is often useful for linking tools
(e.g. mlir-opt) which should have access to all dialects. This list (e.g. mlir-opt) which should have access to all dialects. This list
is also linked in libMLIR.so. The list can be retrieved from the is also linked in libMLIR.so. The list can be retrieved from the
MLIR_CONVERSION_LIBS global property: MLIR_CONVERSION_LIBS global property:
```cmake ```cmake
get_property(dialect_libs GLOBAL PROPERTY MLIR_CONVERSION_LIBS) get_property(dialect_libs GLOBAL PROPERTY MLIR_CONVERSION_LIBS)
``` ```
Note that it is only necessary to specify a PUBLIC dependence against Note that it is only necessary to specify a PUBLIC dependence against
dialects to generate compile-time and link-time dependencies, and it dialects to generate compile-time and link-time dependencies, and it
is not necessary to explicitly depend on the dialects' IncGen targets. is not necessary to explicitly depend on the dialects' IncGen targets.
However, conversions that directly include LLVM IR header files may However, conversions that directly include LLVM IR header files may
need to depend on the LLVM 'intrinsics_gen' target to ensure that need to depend on the LLVM 'intrinsics_gen' target to ensure that
tablegen'd LLVM header files have been generated. tablegen'd LLVM header files have been generated.

mlir/lib/Analysis/CMakeLists.txt

Show All 15 Linesadd_mlir_library(MLIRAnalysis
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
${MLIR_MAIN_INCLUDE_DIR}/mlir/Analysis ${MLIR_MAIN_INCLUDE_DIR}/mlir/Analysis
DEPENDS DEPENDS
mlir-headers mlir-headers
LINK_LIBS PUBLIC LINK_LIBS PUBLIC
MLIRAffineOps MLIRAffine
MLIRCallInterfaces MLIRCallInterfaces
MLIRControlFlowInterfaces MLIRControlFlowInterfaces
MLIRInferTypeOpInterface MLIRInferTypeOpInterface
MLIRPresburger MLIRPresburger
MLIRSCF MLIRSCF
) )
add_mlir_library(MLIRLoopAnalysis add_mlir_library(MLIRLoopAnalysis
AffineAnalysis.cpp AffineAnalysis.cpp
AffineStructures.cpp AffineStructures.cpp
LoopAnalysis.cpp LoopAnalysis.cpp
NestedMatcher.cpp NestedMatcher.cpp
Utils.cpp Utils.cpp
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
${MLIR_MAIN_INCLUDE_DIR}/mlir/Analysis ${MLIR_MAIN_INCLUDE_DIR}/mlir/Analysis
DEPENDS DEPENDS
mlir-headers mlir-headers
LINK_LIBS PUBLIC LINK_LIBS PUBLIC
MLIRAffineOps MLIRAffine
MLIRCallInterfaces MLIRCallInterfaces
MLIRControlFlowInterfaces MLIRControlFlowInterfaces
MLIRInferTypeOpInterface MLIRInferTypeOpInterface
MLIRPresburger MLIRPresburger
MLIRSCF MLIRSCF
) )
add_subdirectory(Presburger) add_subdirectory(Presburger)

mlir/lib/Conversion/AffineToStandard/CMakeLists.txt

add_mlir_conversion_library(MLIRAffineToStandard add_mlir_conversion_library(MLIRAffineToStandard
AffineToStandard.cpp AffineToStandard.cpp
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
${MLIR_MAIN_INCLUDE_DIR}/mlir/Conversion/AffineToStandard ${MLIR_MAIN_INCLUDE_DIR}/mlir/Conversion/AffineToStandard
DEPENDS DEPENDS
MLIRConversionPassIncGen MLIRConversionPassIncGen
LINK_COMPONENTS LINK_COMPONENTS
Core Core
LINK_LIBS PUBLIC LINK_LIBS PUBLIC
MLIRAffineOps MLIRAffine
MLIRSCF MLIRSCF
MLIRPass MLIRPass
MLIRStandardOps MLIRStandard
MLIRTransforms MLIRTransforms
MLIRIR MLIRIR
) )

mlir/lib/Conversion/GPUToSPIRV/CMakeLists.txt

Show All 10 Linesadd_mlir_conversion_library(MLIRGPUToSPIRVTransforms
MLIRGPUToSPIRVIncGen MLIRGPUToSPIRVIncGen
LINK_LIBS PUBLIC LINK_LIBS PUBLIC
MLIRGPU MLIRGPU
MLIRIR MLIRIR
MLIRPass MLIRPass
MLIRSCFToSPIRV MLIRSCFToSPIRV
MLIRSPIRV MLIRSPIRV
MLIRStandardOps MLIRStandard
MLIRStandardToSPIRVTransforms MLIRStandardToSPIRVTransforms
MLIRSupport MLIRSupport
MLIRTransforms MLIRTransforms
) )

mlir/lib/Conversion/GPUToVulkan/CMakeLists.txt

add_mlir_conversion_library(MLIRGPUToVulkanTransforms add_mlir_conversion_library(MLIRGPUToVulkanTransforms
ConvertLaunchFuncToVulkanCalls.cpp ConvertLaunchFuncToVulkanCalls.cpp
ConvertGPULaunchFuncToVulkanLaunchFunc.cpp ConvertGPULaunchFuncToVulkanLaunchFunc.cpp
DEPENDS DEPENDS
MLIRConversionPassIncGen MLIRConversionPassIncGen
LINK_LIBS PUBLIC LINK_LIBS PUBLIC
MLIRGPU MLIRGPU
MLIRIR MLIRIR
MLIRLLVMIR MLIRLLVMIR
MLIRPass MLIRPass
MLIRSPIRV MLIRSPIRV
MLIRSPIRVSerialization MLIRSPIRVSerialization
MLIRStandardOps MLIRStandard
MLIRSupport MLIRSupport
MLIRTransforms MLIRTransforms
MLIRTranslation MLIRTranslation
) )

mlir/lib/Conversion/LinalgToLLVM/CMakeLists.txt

Show All 9 Linesadd_mlir_conversion_library(MLIRLinalgToLLVM
LINK_COMPONENTS LINK_COMPONENTS
Core Core
LINK_LIBS PUBLIC LINK_LIBS PUBLIC
MLIRAffineToStandard MLIRAffineToStandard
MLIREDSC MLIREDSC
MLIRIR MLIRIR
MLIRLinalgOps MLIRLinalg
MLIRLLVMIR MLIRLLVMIR
MLIRSCFToStandard MLIRSCFToStandard
MLIRStandardToLLVM MLIRStandardToLLVM
MLIRTransforms MLIRTransforms
MLIRVectorToLLVM MLIRVectorToLLVM
MLIRVectorToSCF MLIRVectorToSCF
) )

mlir/lib/Conversion/LinalgToSPIRV/CMakeLists.txt

add_mlir_conversion_library(MLIRLinalgToSPIRVTransforms add_mlir_conversion_library(MLIRLinalgToSPIRVTransforms
LinalgToSPIRV.cpp LinalgToSPIRV.cpp
LinalgToSPIRVPass.cpp LinalgToSPIRVPass.cpp
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
${MLIR_MAIN_INCLUDE_DIR}/mlir/Dialect/SPIRV ${MLIR_MAIN_INCLUDE_DIR}/mlir/Dialect/SPIRV
${MLIR_MAIN_INCLUDE_DIR}/mlir/IR ${MLIR_MAIN_INCLUDE_DIR}/mlir/IR
DEPENDS DEPENDS
MLIRConversionPassIncGen MLIRConversionPassIncGen
LINK_LIBS PUBLIC LINK_LIBS PUBLIC
MLIRIR MLIRIR
MLIRLinalgOps MLIRLinalg
MLIRLinalgUtils MLIRLinalgUtils
MLIRPass MLIRPass
MLIRSPIRV MLIRSPIRV
MLIRSupport MLIRSupport
) )

mlir/lib/Conversion/LinalgToStandard/CMakeLists.txt

add_mlir_conversion_library(MLIRLinalgToStandard add_mlir_conversion_library(MLIRLinalgToStandard
LinalgToStandard.cpp LinalgToStandard.cpp
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
${MLIR_MAIN_INCLUDE_DIR}/mlir/Conversion/LinalgToStandard ${MLIR_MAIN_INCLUDE_DIR}/mlir/Conversion/LinalgToStandard
DEPENDS DEPENDS
MLIRConversionPassIncGen MLIRConversionPassIncGen
LINK_COMPONENTS LINK_COMPONENTS
Core Core
LINK_LIBS PUBLIC LINK_LIBS PUBLIC
MLIREDSC MLIREDSC
MLIRIR MLIRIR
MLIRLinalgOps MLIRLinalg
MLIRPass MLIRPass
MLIRSCF MLIRSCF
MLIRTransforms MLIRTransforms
) )

mlir/lib/Conversion/SCFToGPU/CMakeLists.txt

add_mlir_conversion_library(MLIRSCFToGPU add_mlir_conversion_library(MLIRSCFToGPU
SCFToGPU.cpp SCFToGPU.cpp
SCFToGPUPass.cpp SCFToGPUPass.cpp
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
${MLIR_MAIN_INCLUDE_DIR}/mlir/Conversion/SCFToGPU ${MLIR_MAIN_INCLUDE_DIR}/mlir/Conversion/SCFToGPU
DEPENDS DEPENDS
MLIRConversionPassIncGen MLIRConversionPassIncGen
LINK_LIBS PUBLIC LINK_LIBS PUBLIC
MLIRAffineOps MLIRAffine
MLIRAffineToStandard MLIRAffineToStandard
MLIRGPU MLIRGPU
MLIRIR MLIRIR
MLIRLinalgOps MLIRLinalg
MLIRPass MLIRPass
MLIRStandardOps MLIRStandard
MLIRSupport MLIRSupport
MLIRTransforms MLIRTransforms
) )

mlir/lib/Conversion/SCFToSPIRV/CMakeLists.txt

add_mlir_conversion_library(MLIRSCFToSPIRV add_mlir_conversion_library(MLIRSCFToSPIRV
SCFToSPIRV.cpp SCFToSPIRV.cpp
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
${MLIR_MAIN_INCLUDE_DIR}/mlir/Conversion/SCFToSPIRV ${MLIR_MAIN_INCLUDE_DIR}/mlir/Conversion/SCFToSPIRV
DEPENDS DEPENDS
MLIRConversionPassIncGen MLIRConversionPassIncGen
LINK_LIBS PUBLIC LINK_LIBS PUBLIC
MLIRAffineOps MLIRAffine
MLIRAffineToStandard MLIRAffineToStandard
MLIRSPIRV MLIRSPIRV
MLIRIR MLIRIR
MLIRLinalgOps MLIRLinalg
MLIRPass MLIRPass
MLIRStandardOps MLIRStandard
MLIRSupport MLIRSupport
MLIRTransforms MLIRTransforms
) )

mlir/lib/Conversion/StandardToSPIRV/CMakeLists.txt

Show All 11 Linesadd_mlir_conversion_library(MLIRStandardToSPIRVTransforms
LINK_LIBS PUBLIC LINK_LIBS PUBLIC
MLIRIR MLIRIR
MLIRPass MLIRPass
MLIRSPIRV MLIRSPIRV
MLIRSupport MLIRSupport
MLIRTransformUtils MLIRTransformUtils
MLIRSPIRV MLIRSPIRV
MLIRStandardOps MLIRStandard
) )

mlir/lib/Dialect/Affine/EDSC/CMakeLists.txt

add_mlir_dialect_library(MLIRAffineEDSC add_mlir_dialect_library(MLIRAffineEDSC
Builders.cpp Builders.cpp
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
${MLIR_MAIN_INCLUDE_DIR}/mlir/Dialect/Affine ${MLIR_MAIN_INCLUDE_DIR}/mlir/Dialect/Affine
DEPENDS DEPENDS
MLIRAffineOpsIncGen MLIRAffineOpsIncGen
LINK_LIBS PUBLIC LINK_LIBS PUBLIC
MLIRAffineOps MLIRAffine
MLIREDSC MLIREDSC
MLIRIR MLIRIR
MLIRLoopLikeInterface MLIRLoopLikeInterface
MLIRSideEffectInterfaces MLIRSideEffectInterfaces
MLIRStandardOps MLIRStandard
) )

mlir/lib/Dialect/Affine/IR/CMakeLists.txt

add_mlir_dialect_library(MLIRAffineOps add_mlir_dialect_library(MLIRAffine
AffineMemoryOpInterfaces.cpp AffineMemoryOpInterfaces.cpp
AffineOps.cpp AffineOps.cpp
AffineValueMap.cpp AffineValueMap.cpp
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
${MLIR_MAIN_INCLUDE_DIR}/mlir/Dialect/Affine ${MLIR_MAIN_INCLUDE_DIR}/mlir/Dialect/Affine
DEPENDS DEPENDS
MLIRAffineMemoryOpInterfacesIncGen MLIRAffineMemoryOpInterfacesIncGen
MLIRAffineOpsIncGen MLIRAffineOpsIncGen
LINK_LIBS PUBLIC LINK_LIBS PUBLIC
MLIREDSC MLIREDSC
MLIRIR MLIRIR
MLIRLoopLikeInterface MLIRLoopLikeInterface
MLIRSideEffectInterfaces MLIRSideEffectInterfaces
MLIRStandardOps MLIRStandard
) )

mlir/lib/Dialect/Affine/Transforms/CMakeLists.txt

Show All 12 Linesadd_mlir_dialect_library(MLIRAffineTransforms
${MLIR_MAIN_INCLUDE_DIR}/mlir/Dialect/Affine ${MLIR_MAIN_INCLUDE_DIR}/mlir/Dialect/Affine
DEPENDS DEPENDS
MLIRAffineOpsIncGen MLIRAffineOpsIncGen
MLIRAffinePassIncGen MLIRAffinePassIncGen
MLIRLoopLikeInterfaceIncGen MLIRLoopLikeInterfaceIncGen
LINK_LIBS PUBLIC LINK_LIBS PUBLIC
MLIRAffineOps MLIRAffine
MLIRAffineUtils MLIRAffineUtils
MLIREDSC MLIREDSC
MLIRIR MLIRIR
MLIRPass MLIRPass
MLIRSideEffectInterfaces MLIRSideEffectInterfaces
MLIRStandardOps MLIRStandard
MLIRTransformUtils MLIRTransformUtils
MLIRVector MLIRVector
MLIRVectorToLLVM MLIRVectorToLLVM
) )

mlir/lib/Dialect/Affine/Utils/CMakeLists.txt

add_mlir_dialect_library(MLIRAffineUtils add_mlir_dialect_library(MLIRAffineUtils
Utils.cpp Utils.cpp
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
${MLIR_MAIN_INCLUDE_DIR}/mlir/Dialect/Affine ${MLIR_MAIN_INCLUDE_DIR}/mlir/Dialect/Affine
LINK_LIBS PUBLIC LINK_LIBS PUBLIC
MLIRAffineOps MLIRAffine
MLIRTransformUtils MLIRTransformUtils
) )

mlir/lib/Dialect/GPU/CMakeLists.txt

Show All 15 Linesadd_mlir_dialect_library(MLIRGPU
LINK_LIBS PUBLIC LINK_LIBS PUBLIC
MLIREDSC MLIREDSC
MLIRIR MLIRIR
MLIRLLVMIR MLIRLLVMIR
MLIRSCF MLIRSCF
MLIRPass MLIRPass
MLIRSideEffectInterfaces MLIRSideEffectInterfaces
MLIRStandardOps MLIRStandard
MLIRSupport MLIRSupport
MLIRTransformUtils MLIRTransformUtils
) )

mlir/lib/Dialect/Linalg/Analysis/CMakeLists.txt

add_mlir_dialect_library(MLIRLinalgAnalysis add_mlir_dialect_library(MLIRLinalgAnalysis
DependenceAnalysis.cpp DependenceAnalysis.cpp
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
${MLIR_MAIN_INCLUDE_DIR}/mlir/Dialect/Linalg ${MLIR_MAIN_INCLUDE_DIR}/mlir/Dialect/Linalg
LINK_LIBS PUBLIC LINK_LIBS PUBLIC
MLIRIR MLIRIR
MLIRLinalgOps MLIRLinalg
MLIRStandardOps MLIRStandard
) )

mlir/lib/Dialect/Linalg/EDSC/CMakeLists.txt

add_mlir_dialect_library(MLIRLinalgEDSC add_mlir_dialect_library(MLIRLinalgEDSC
Builders.cpp Builders.cpp
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
${MLIR_MAIN_INCLUDE_DIR}/mlir/Dialect/Linalg ${MLIR_MAIN_INCLUDE_DIR}/mlir/Dialect/Linalg
LINK_LIBS PUBLIC LINK_LIBS PUBLIC
MLIREDSC MLIREDSC
MLIRIR MLIRIR
MLIRAffineOps MLIRAffine
MLIRAffineEDSC MLIRAffineEDSC
MLIRLinalgOps MLIRLinalg
MLIRSCF MLIRSCF
MLIRStandardOps MLIRStandard
) )

mlir/lib/Dialect/Linalg/IR/CMakeLists.txt

add_mlir_dialect_library(MLIRLinalgOps add_mlir_dialect_library(MLIRLinalg
LinalgOps.cpp LinalgOps.cpp
LinalgTypes.cpp LinalgTypes.cpp
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
${MLIR_MAIN_INCLUDE_DIR}/mlir/Dialect/Linalg ${MLIR_MAIN_INCLUDE_DIR}/mlir/Dialect/Linalg
DEPENDS DEPENDS
MLIRLinalgOpsIncGen MLIRLinalgOpsIncGen
MLIRLinalgStructuredOpsIncGen MLIRLinalgStructuredOpsIncGen
MLIRLinalgStructuredOpsInterfaceIncGen MLIRLinalgStructuredOpsInterfaceIncGen
LINK_LIBS PUBLIC LINK_LIBS PUBLIC
MLIRIR MLIRIR
MLIRSideEffectInterfaces MLIRSideEffectInterfaces
MLIRViewLikeInterface MLIRViewLikeInterface
MLIRStandardOps MLIRStandard
) )

mlir/lib/Dialect/Linalg/Transforms/CMakeLists.txt

Show All 11 Linesadd_mlir_dialect_library(MLIRLinalgTransforms
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
${MLIR_MAIN_INCLUDE_DIR}/mlir/Dialect/Linalg ${MLIR_MAIN_INCLUDE_DIR}/mlir/Dialect/Linalg
DEPENDS DEPENDS
MLIRLinalgPassIncGen MLIRLinalgPassIncGen
LINK_LIBS PUBLIC LINK_LIBS PUBLIC
MLIRAffineOps MLIRAffine
MLIRAnalysis MLIRAnalysis
MLIREDSC MLIREDSC
MLIRIR MLIRIR
MLIRLinalgAnalysis MLIRLinalgAnalysis
MLIRLinalgEDSC MLIRLinalgEDSC
MLIRLinalgOps MLIRLinalg
MLIRLinalgUtils MLIRLinalgUtils
MLIRSCF MLIRSCF
MLIRSCFTransforms MLIRSCFTransforms
MLIRPass MLIRPass
MLIRStandardOps MLIRStandard
MLIRStandardToLLVM MLIRStandardToLLVM
MLIRTransformUtils MLIRTransformUtils
MLIRVector MLIRVector
) )

mlir/lib/Dialect/Linalg/Utils/CMakeLists.txt

add_mlir_dialect_library(MLIRLinalgUtils add_mlir_dialect_library(MLIRLinalgUtils
Utils.cpp Utils.cpp
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
${MLIR_MAIN_INCLUDE_DIR}/mlir/Dialect/Linalg ${MLIR_MAIN_INCLUDE_DIR}/mlir/Dialect/Linalg
LINK_LIBS PUBLIC LINK_LIBS PUBLIC
MLIRAffineOps MLIRAffine
MLIREDSC MLIREDSC
MLIRIR MLIRIR
MLIRLinalgEDSC MLIRLinalgEDSC
MLIRLinalgOps MLIRLinalg
MLIRSCF MLIRSCF
MLIRPass MLIRPass
MLIRStandardOps MLIRStandard
MLIRTransformUtils MLIRTransformUtils
) )

mlir/lib/Dialect/Quant/CMakeLists.txt

Show All 15 Linesadd_mlir_dialect_library(MLIRQuant
MLIRQuantOpsIncGen MLIRQuantOpsIncGen
MLIRQuantPassIncGen MLIRQuantPassIncGen
LINK_LIBS PUBLIC LINK_LIBS PUBLIC
MLIRIR MLIRIR
MLIRPass MLIRPass
MLIRSideEffectInterfaces MLIRSideEffectInterfaces
MLIRSupport MLIRSupport
MLIRStandardOps MLIRStandard
MLIRTransformUtils MLIRTransformUtils
) )

mlir/lib/Dialect/SCF/CMakeLists.txt

add_mlir_dialect_library(MLIRSCF add_mlir_dialect_library(MLIRSCF
SCF.cpp SCF.cpp
EDSC/Builders.cpp EDSC/Builders.cpp
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
${MLIR_MAIN_INCLUDE_DIR}/mlir/LoopOps ${MLIR_MAIN_INCLUDE_DIR}/mlir/LoopOps
DEPENDS DEPENDS
MLIRSCFOpsIncGen MLIRSCFOpsIncGen
LINK_LIBS PUBLIC LINK_LIBS PUBLIC
MLIREDSC MLIREDSC
MLIRIR MLIRIR
MLIRLoopLikeInterface MLIRLoopLikeInterface
MLIRSideEffectInterfaces MLIRSideEffectInterfaces
MLIRStandardOps MLIRStandard
) )
add_subdirectory(Transforms) add_subdirectory(Transforms)

mlir/lib/Dialect/SCF/Transforms/CMakeLists.txt

add_mlir_dialect_library(MLIRSCFTransforms add_mlir_dialect_library(MLIRSCFTransforms
LoopSpecialization.cpp LoopSpecialization.cpp
ParallelLoopFusion.cpp ParallelLoopFusion.cpp
ParallelLoopTiling.cpp ParallelLoopTiling.cpp
Utils.cpp Utils.cpp
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
${MLIR_MAIN_INCLUDE_DIR}/mlir/Dialect/SCF ${MLIR_MAIN_INCLUDE_DIR}/mlir/Dialect/SCF
DEPENDS DEPENDS
MLIRSCFPassIncGen MLIRSCFPassIncGen
LINK_LIBS PUBLIC LINK_LIBS PUBLIC
MLIRAffineOps MLIRAffine
MLIRIR MLIRIR
MLIRPass MLIRPass
MLIRSCF MLIRSCF
MLIRStandardOps MLIRStandard
MLIRSupport MLIRSupport
MLIRTransformUtils MLIRTransformUtils
) )

mlir/lib/Dialect/Shape/IR/CMakeLists.txt

Show All 11 Linesadd_mlir_dialect_library(MLIRShape
MLIRShapeOpsIncGen MLIRShapeOpsIncGen
LINK_LIBS PUBLIC LINK_LIBS PUBLIC
MLIRControlFlowInterfaces MLIRControlFlowInterfaces
MLIRDialect MLIRDialect
MLIRInferTypeOpInterface MLIRInferTypeOpInterface
MLIRIR MLIRIR
MLIRSideEffectInterfaces MLIRSideEffectInterfaces
MLIRStandardOps MLIRStandard
) )

mlir/lib/Dialect/StandardOps/CMakeLists.txt

add_mlir_dialect_library(MLIRStandardOps add_mlir_dialect_library(MLIRStandard
IR/Ops.cpp IR/Ops.cpp
EDSC/Builders.cpp EDSC/Builders.cpp
EDSC/Intrinsics.cpp EDSC/Intrinsics.cpp
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
${MLIR_MAIN_INCLUDE_DIR}/mlir/Dialect/StandardOps ${MLIR_MAIN_INCLUDE_DIR}/mlir/Dialect/StandardOps
DEPENDS DEPENDS
Show All 13 Lines

mlir/lib/Dialect/StandardOps/Transforms/CMakeLists.txt

add_mlir_dialect_library(MLIRStandardOpsTransforms add_mlir_dialect_library(MLIRStandardOpsTransforms
ExpandAtomic.cpp ExpandAtomic.cpp
ExpandTanh.cpp ExpandTanh.cpp
FuncConversions.cpp FuncConversions.cpp
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
${MLIR_MAIN_INCLUDE_DIR}/mlir/Dialect/StandardOps/Transforms ${MLIR_MAIN_INCLUDE_DIR}/mlir/Dialect/StandardOps/Transforms
DEPENDS DEPENDS
MLIRStandardTransformsIncGen MLIRStandardTransformsIncGen
LINK_LIBS PUBLIC LINK_LIBS PUBLIC
MLIRIR MLIRIR
MLIRPass MLIRPass
MLIRStandardOps MLIRStandard
MLIRTransforms MLIRTransforms
) )

mlir/lib/Dialect/Vector/CMakeLists.txt

add_mlir_dialect_library(MLIRVector add_mlir_dialect_library(MLIRVector
VectorOps.cpp VectorOps.cpp
VectorTransforms.cpp VectorTransforms.cpp
VectorUtils.cpp VectorUtils.cpp
EDSC/Builders.cpp EDSC/Builders.cpp
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
${MLIR_MAIN_INCLUDE_DIR}/mlir/Dialect/Vector ${MLIR_MAIN_INCLUDE_DIR}/mlir/Dialect/Vector
DEPENDS DEPENDS
MLIRVectorOpsIncGen MLIRVectorOpsIncGen
LINK_LIBS PUBLIC LINK_LIBS PUBLIC
MLIRAffineEDSC MLIRAffineEDSC
MLIREDSC MLIREDSC
MLIRIR MLIRIR
MLIRStandardOps MLIRStandard
MLIRAffineOps MLIRAffine
MLIRLinalgOps MLIRLinalg
MLIRSCF MLIRSCF
MLIRLoopAnalysis MLIRLoopAnalysis
MLIRSideEffectInterfaces MLIRSideEffectInterfaces
MLIRVectorInterfaces MLIRVectorInterfaces
) )

mlir/lib/ExecutionEngine/CMakeLists.txt

Show First 20 Lines • Show All 54 Lines • ▼ Show 20 Linesadd_mlir_library(MLIRJitRunner
Core Core
OrcJIT OrcJIT
JITLink JITLink
LINK_LIBS PUBLIC LINK_LIBS PUBLIC
MLIRExecutionEngine MLIRExecutionEngine
MLIRIR MLIRIR
MLIRParser MLIRParser
MLIRStandardOps MLIRStandard
MLIRTargetLLVMIR MLIRTargetLLVMIR
MLIRTransforms MLIRTransforms
MLIRStandardToLLVM MLIRStandardToLLVM
MLIRSupport MLIRSupport
) )
add_mlir_library(mlir_c_runner_utils add_mlir_library(mlir_c_runner_utils
SHARED SHARED
Show All 24 Lines

mlir/lib/Transforms/CMakeLists.txt

Show All 24 Linesadd_mlir_library(MLIRTransforms
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
${MLIR_MAIN_INCLUDE_DIR}/mlir/Transforms ${MLIR_MAIN_INCLUDE_DIR}/mlir/Transforms
DEPENDS DEPENDS
MLIRStandardOpsIncGen MLIRStandardOpsIncGen
MLIRTransformsPassIncGen MLIRTransformsPassIncGen
LINK_LIBS PUBLIC LINK_LIBS PUBLIC
MLIRAffineOps MLIRAffine
MLIRAnalysis MLIRAnalysis
MLIRCopyOpInterface MLIRCopyOpInterface
MLIRLinalgOps MLIRLinalg
MLIRLoopLikeInterface MLIRLoopLikeInterface
MLIRSCF MLIRSCF
MLIRPass MLIRPass
MLIRTransformUtils MLIRTransformUtils
MLIRVector MLIRVector
) )

mlir/lib/Transforms/Utils/CMakeLists.txt

add_mlir_library(MLIRTransformUtils add_mlir_library(MLIRTransformUtils
FoldUtils.cpp FoldUtils.cpp
GreedyPatternRewriteDriver.cpp GreedyPatternRewriteDriver.cpp
InliningUtils.cpp InliningUtils.cpp
LoopFusionUtils.cpp LoopFusionUtils.cpp
LoopUtils.cpp LoopUtils.cpp
RegionUtils.cpp RegionUtils.cpp
Utils.cpp Utils.cpp
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
${MLIR_MAIN_INCLUDE_DIR}/mlir/Transforms ${MLIR_MAIN_INCLUDE_DIR}/mlir/Transforms
DEPENDS DEPENDS
MLIRStandardOpsIncGen MLIRStandardOpsIncGen
LINK_LIBS PUBLIC LINK_LIBS PUBLIC
MLIRAffineOps MLIRAffine
MLIRAnalysis MLIRAnalysis
MLIRLoopAnalysis MLIRLoopAnalysis
MLIRSCF MLIRSCF
MLIRPass MLIRPass
MLIRStandardOps MLIRStandard
) )

mlir/test/EDSC/CMakeLists.txt

set(LLVM_LINK_COMPONENTS set(LLVM_LINK_COMPONENTS
Core Core
Support Support
) )
add_llvm_executable(mlir-edsc-builder-api-test add_llvm_executable(mlir-edsc-builder-api-test
builder-api-test.cpp builder-api-test.cpp
) )
llvm_update_compile_flags(mlir-edsc-builder-api-test) llvm_update_compile_flags(mlir-edsc-builder-api-test)
target_link_libraries(mlir-edsc-builder-api-test target_link_libraries(mlir-edsc-builder-api-test
PRIVATE PRIVATE
MLIRAffineOps MLIRAffine
MLIRAffineEDSC MLIRAffineEDSC
MLIREDSC MLIREDSC
MLIRIR MLIRIR
MLIRLinalg
MLIRLinalgEDSC MLIRLinalgEDSC
MLIRLinalgOps
MLIRSCF MLIRSCF
MLIRStandardOps MLIRStandard
MLIRTransforms MLIRTransforms
MLIRVector MLIRVector
) )
target_include_directories(mlir-edsc-builder-api-test PRIVATE ..) target_include_directories(mlir-edsc-builder-api-test PRIVATE ..)

mlir/test/lib/Dialect/Test/CMakeLists.txt

Show All 32 Linesadd_mlir_library(MLIRTestDialect
LINK_LIBS PUBLIC LINK_LIBS PUBLIC
MLIRControlFlowInterfaces MLIRControlFlowInterfaces
MLIRDerivedAttributeOpInterface MLIRDerivedAttributeOpInterface
MLIRDialect MLIRDialect
MLIRIR MLIRIR
MLIRInferTypeOpInterface MLIRInferTypeOpInterface
MLIRLinalgTransforms MLIRLinalgTransforms
MLIRPass MLIRPass
MLIRStandardOps MLIRStandard
MLIRStandardOpsTransforms MLIRStandardOpsTransforms
MLIRTransformUtils MLIRTransformUtils
MLIRTransforms MLIRTransforms
) )

mlir/test/lib/Transforms/CMakeLists.txt

Show All 32 Linesadd_mlir_library(MLIRTestTransforms
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
${MLIR_MAIN_INCLUDE_DIR}/mlir/Transforms ${MLIR_MAIN_INCLUDE_DIR}/mlir/Transforms
DEPENDS DEPENDS
MLIRStandardOpsIncGen MLIRStandardOpsIncGen
LINK_LIBS PUBLIC LINK_LIBS PUBLIC
MLIRAffineOps MLIRAffine
MLIRAnalysis MLIRAnalysis
MLIREDSC MLIREDSC
MLIRGPU MLIRGPU
MLIRGPUToGPURuntimeTransforms MLIRGPUToGPURuntimeTransforms
MLIRLinalgOps MLIRLinalg
MLIRLinalgTransforms MLIRLinalgTransforms
MLIRNVVMIR MLIRNVVMIR
MLIRSCF MLIRSCF
MLIRSCFTransforms MLIRSCFTransforms
MLIRGPU MLIRGPU
MLIRPass MLIRPass
MLIRROCDLIR MLIRROCDLIR
MLIRStandardOpsTransforms MLIRStandardOpsTransforms
Show All 10 Lines