Page MenuHomePhabricator

GMNGeoffrey (Geoffrey Martin-Noble)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 15 2020, 6:41 PM (128 w, 6 d)

Recent Activity

Thu, Jun 9

GMNGeoffrey added a comment to D127459: [mlir][NFC] Rename Bazel target aliases and consolidate targets.

Yes, I'll be taking at look at the CMake names afterwards. This one goes after the low-hanging fruit, mostly, in the bazel targets. I'll probably do a comprehensive review to make sure everything lines up in bazel and CMake

Thu, Jun 9, 5:04 PM · Restricted Project, Restricted Project
GMNGeoffrey added a comment to D127459: [mlir][NFC] Rename Bazel target aliases and consolidate targets.

Thank you! Can you confirm that the names we're switching to are actually the consistent pattern in CMake as well? One issue I encountered before when cleaning this up was that the CMake names weren't consistent with each other across the project, so it was a little unclear what should be changed.

Thu, Jun 9, 4:57 PM · Restricted Project, Restricted Project

Jun 1 2022

GMNGeoffrey updated subscribers of D126581: [Bazel][GN] Reuse the GN LLVM config file generation code.

I see you've already landed and reverted this. Apologies I didn't get to review in time. In previous iterations, we did have a python script for writing these config files that came from TensorFlow. I think it was less good than this one in terms of error detection. @chandlerc had strong opinions about not using a custom script here, I believe arguing that behavior that is "like CMake but not quite CMake" was likely to be error-prone. FWIW, I think this is overall an improvement (especially with its error detection instead of our existing config file copies), but I think it's worth bringing this up again. I think I even looked at using the GN script in Bazel and Chandler was against it.

Jun 1 2022, 9:36 AM · Restricted Project, Restricted Project

May 26 2022

GMNGeoffrey accepted D126489: Add llvm-debuginfod-find tool to Bazel build.

LGTM, thanks :-)

May 26 2022, 2:19 PM · Restricted Project, Restricted Project, Restricted Project

May 20 2022

GMNGeoffrey updated subscribers of D124830: [Bazel] Add support for targeting Linux riscv64.

To add it, we'd need to upgrade to 5.x, which is nontrivial because of the current use of remote execution, unfortunately. We're looking into moving these builders over to building locally, but when I tried it out I ran into some issues: https://github.com/google/llvm-premerge-checks/pull/394. @goncharov is working on making this all better supported, I believe

May 20 2022, 4:53 PM · Restricted Project, Restricted Project
GMNGeoffrey added a comment to D124830: [Bazel] Add support for targeting Linux riscv64.

The CI is still using Bazel 4.0, so it doesn't have linux_riscv64

May 20 2022, 4:49 PM · Restricted Project, Restricted Project

May 16 2022

GMNGeoffrey accepted D123481: Do not build with Werror by default (Bazel build).

LGTM

May 16 2022, 9:13 AM · Restricted Project, Restricted Project

May 13 2022

GMNGeoffrey added a comment to D123481: Do not build with Werror by default (Bazel build).

https://github.com/google/llvm-premerge-checks/pull/400 turns this on for the pre-merge checks and I've updated the continuous build. I want to make sure the pre-merge checks are doing what we expect. Mehdi, perhaps you could push an update to this change? That should re-run the pre-merge checks and we can confirm they're using -Werror. Alternatively, any patch that touches the bazel files or is by someone in the Bazel project would do it. I just didn't want to send draft patches because people have griped about email traffic in the past.

May 13 2022, 12:49 PM · Restricted Project, Restricted Project

May 12 2022

GMNGeoffrey added inline comments to D123481: Do not build with Werror by default (Bazel build).
May 12 2022, 12:01 PM · Restricted Project, Restricted Project
GMNGeoffrey added a comment to D125096: [Bazel] Add support for s390x build target.

Hi @GMNGeoffrey sorry for the trouble, I uploaded the patch using GUI, and possibly something might have been missed. Will take care next time. Thanks :)

May 12 2022, 10:14 AM · Restricted Project, Restricted Project

May 11 2022

GMNGeoffrey committed rG6b6e796b7462: [Bazel] Add support for s390x build target (authored by vibhutisawant).
[Bazel] Add support for s390x build target
May 11 2022, 9:23 AM · Restricted Project
GMNGeoffrey closed D125096: [Bazel] Add support for s390x build target.
May 11 2022, 9:23 AM · Restricted Project, Restricted Project
GMNGeoffrey added a comment to D125096: [Bazel] Add support for s390x build target.

However you created this patch, it's causing me issues when trying to arc patch it. It looks like it's missing a lot of a metadata (in particular, a base revision). I've manually recreated the revision and reuploaded it here, but FYI for future reference

May 11 2022, 9:19 AM · Restricted Project, Restricted Project
GMNGeoffrey updated the diff for D125096: [Bazel] Add support for s390x build target.

Recreating the patch with appropriate metadata

May 11 2022, 9:19 AM · Restricted Project, Restricted Project

May 10 2022

GMNGeoffrey accepted D125096: [Bazel] Add support for s390x build target.

Let me know if you need me to land this for you (see https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access)

May 10 2022, 5:32 PM · Restricted Project, Restricted Project
GMNGeoffrey added a comment to D123481: Do not build with Werror by default (Bazel build).

+1, I had to patch this locally in my project for exactly the reasons you mentioned

May 10 2022, 5:28 PM · Restricted Project, Restricted Project

Mar 28 2022

GMNGeoffrey committed rG224e9be1f469: [Bazel] Update zlib to 1.2.12 (authored by GMNGeoffrey).
[Bazel] Update zlib to 1.2.12
Mar 28 2022, 3:17 PM · Restricted Project
GMNGeoffrey closed D122619: [Bazel] Update zlib to 1.2.12.
Mar 28 2022, 3:16 PM · Restricted Project, Restricted Project
GMNGeoffrey requested review of D122619: [Bazel] Update zlib to 1.2.12.
Mar 28 2022, 2:49 PM · Restricted Project, Restricted Project

Mar 9 2022

GMNGeoffrey added a comment to D119547: [libc][bazel] Add tests to the bazel build.

@GMNGeoffrey I'm having an issue that you may know how to solve.
.bazelrc automatically appends -Wall -Werror to everything that is built.

  • Math tests depend on mpfr,
  • mpfr (and gmp) are built from source using rules_foreign_cc,
  • For hermeticity rules_foreign_cc compiles make

I could tweak the ./configure options for mpfr and gmp and explicitly disable -Werror (see file "mpfr.BUILD" and "gmp.BUILD") but I cannot tweak the compile options for when rules_foreign_cc compiles make.
I could work around this by preventing rules_foreign_cc to compiles make in the first place, but then the build is not hermetic anymore...

register_built_tools = False,
register_default_tools = False,

What do you think? Is .bazelrc too strict? Is there a clean way to work around this without lowering the error level?

Mar 9 2022, 11:14 AM · Restricted Project, Restricted Project

Feb 17 2022

GMNGeoffrey added a comment to D120039: [Bazel] Fix build after ObjCopy move..

LGTM, thanks

Feb 17 2022, 8:48 AM · Restricted Project

Feb 11 2022

GMNGeoffrey updated subscribers of D119547: [libc][bazel] Add tests to the bazel build.

@chandlerc any opinions on having multiple methods for depending on external libraries? Version 0.7 doesn't inspire confidence

Feb 11 2022, 1:56 PM · Restricted Project, Restricted Project
GMNGeoffrey added a comment to D119547: [libc][bazel] Add tests to the bazel build.

I think we should provide at least the option for users to use these from their system, as we do with zlib

Feb 11 2022, 10:05 AM · Restricted Project, Restricted Project

Feb 4 2022

GMNGeoffrey added inline comments to D119037: Fix target dependencies for libtool in Bazel build files..
Feb 4 2022, 2:26 PM

Feb 3 2022

GMNGeoffrey accepted D118955: Update Symbolize dependencies in bazel build file..

Seems like the relevant patch was reverted? https://github.com/llvm/llvm-project/commit/dbf47d227d080e4eb7239b589660f51d7b08afa9 -> https://buildkite.com/llvm-project/upstream-bazel-rbe/builds/19349. Probably good to keep this around anyway, since I suspect it will be re-landed at some point. This looks like a reasonable fix for that, so I'll go ahead and approve, but if you need to land again, please rebase and wait for pre-merge checks to pass (for some reason they're taking a while on this commit).

Feb 3 2022, 4:55 PM

Feb 2 2022

GMNGeoffrey added a comment to D118863: Update mlir bazel build file with appropriate math header dependencies..

Looks like this was fixed in https://github.com/llvm/llvm-project/commit/4a6c9b5686. You also generally don't want to list headers in multiple places. Rather, have those things depend on targets providing that header (as was done in the linked commit).

Feb 2 2022, 4:58 PM
GMNGeoffrey added a comment to D112353: [bazel] fixes for windows build.

If you'd like to rebase this and see what's still outstanding, I can take another look :-)

Feb 2 2022, 10:49 AM · Restricted Project

Feb 1 2022

GMNGeoffrey added inline comments to D117764: [AArch64][SelectionDAG] CodeGen for Armv8.8/9.3 MOPS.
Feb 1 2022, 9:27 AM · Restricted Project

Jan 31 2022

GMNGeoffrey committed rGef72739eac18: [Bazel] Don't fail the build on usage of deprecated APIs (authored by GMNGeoffrey).
[Bazel] Don't fail the build on usage of deprecated APIs
Jan 31 2022, 6:10 PM
GMNGeoffrey closed D118671: [Bazel] Don't fail the build on usage of deprecated APIs.
Jan 31 2022, 6:10 PM · Restricted Project
GMNGeoffrey added a reviewer for D118671: [Bazel] Don't fail the build on usage of deprecated APIs: rupprecht.
Jan 31 2022, 6:02 PM · Restricted Project
GMNGeoffrey requested review of D118671: [Bazel] Don't fail the build on usage of deprecated APIs.
Jan 31 2022, 5:54 PM · Restricted Project
GMNGeoffrey added inline comments to D117764: [AArch64][SelectionDAG] CodeGen for Armv8.8/9.3 MOPS.
Jan 31 2022, 5:32 PM · Restricted Project

Jan 26 2022

GMNGeoffrey committed rG4691f00a6375: Initialize terminfo.bzl linkopts to None (authored by jonmeow).
Initialize terminfo.bzl linkopts to None
Jan 26 2022, 11:03 AM
GMNGeoffrey closed D118270: Initialize terminfo.bzl linkopts to None.
Jan 26 2022, 11:03 AM · Restricted Project
GMNGeoffrey accepted D118270: Initialize terminfo.bzl linkopts to None.

LGTM. Thanks for the fix. Can you add the explanation to the description? Also, do you need me to land this for you? If so, do you want it committed with the author information from this commit "jonmeow <46229924+jonmeow@users.noreply.github.com>"?

Jan 26 2022, 9:55 AM · Restricted Project
GMNGeoffrey added a comment to D118221: [mlir][Bazel] Remove unnecessary dependencies.

Thanks for the cleanup :-)

Jan 26 2022, 9:35 AM · Restricted Project

Jan 25 2022

GMNGeoffrey accepted D118125: [bazel] Enable layering_check for MLIR test directory.

LGTM, thanks

Jan 25 2022, 9:25 AM · Restricted Project

Jan 12 2022

GMNGeoffrey added inline comments to D117176: [bazel] Separate capi_deps from deps in mlir_c_api_cc_library..
Jan 12 2022, 6:01 PM · Restricted Project
GMNGeoffrey created Image Macro "dont-cross-the-streams".
Jan 12 2022, 6:00 PM
GMNGeoffrey added inline comments to D117176: [bazel] Separate capi_deps from deps in mlir_c_api_cc_library..
Jan 12 2022, 5:57 PM · Restricted Project
GMNGeoffrey accepted D117176: [bazel] Separate capi_deps from deps in mlir_c_api_cc_library..

This LGTM, but I would wait for Peter to weigh in to make sure.

Jan 12 2022, 5:46 PM · Restricted Project

Jan 5 2022

GMNGeoffrey added a comment to D115533: [docs] [tools] Document and alphabetize all llvm-config command-line options.

@GMNGeoffrey, (or anybody else) did you land this change yet? If not, I can probably arrange for it this week.

Jan 5 2022, 10:02 AM · Restricted Project, Restricted Project
GMNGeoffrey added a comment to D116661: Fold certain ops during dialect conversion.

IMO it would be better to have a way for the person specifying the conversion target to say "get rid of these ops if you can". Unrealized conversion cast is a bit of an odd duck, but it seems that "get rid of this during dialect conversion if possible" is more often a property of the conversion than a property of the op. I guess it could be either or both (where unrealized conversion is the relatively special case where it makes sense to have it on the op). It also feels like an arbitrary limitation that such an op can only be removed with folding and not with canonicalization or some other pattern.

Jan 5 2022, 9:54 AM · Restricted Project

Dec 23 2021

GMNGeoffrey accepted D116222: [Bazel] Add target for llvm-tli-checker.

LGTM

Dec 23 2021, 9:59 AM · Restricted Project

Dec 20 2021

GMNGeoffrey committed rGe8b5b7218263: [lit] Support relative path arguments (authored by GMNGeoffrey).
[lit] Support relative path arguments
Dec 20 2021, 11:50 AM
GMNGeoffrey closed D115486: [lit] Support relative path arguments.
Dec 20 2021, 11:50 AM · Restricted Project
GMNGeoffrey added a comment to D115486: [lit] Support relative path arguments.

The only pre-merge failure is LLVM :: Bindings/Go/go.test which is failing for lots of people, as discussed in https://groups.google.com/g/llvm-dev/c/o07dxO7Y-CA. Going to land past that

Dec 20 2021, 11:49 AM · Restricted Project
GMNGeoffrey accepted D116046: [mlir] Add `mlir/unittests/BUILD.bazel`.

Other than that, LGTM

Dec 20 2021, 11:40 AM · Restricted Project
GMNGeoffrey added inline comments to D116046: [mlir] Add `mlir/unittests/BUILD.bazel`.
Dec 20 2021, 11:20 AM · Restricted Project
GMNGeoffrey updated the diff for D115486: [lit] Support relative path arguments.

Rebase on head

Dec 20 2021, 10:57 AM · Restricted Project
GMNGeoffrey added inline comments to D115533: [docs] [tools] Document and alphabetize all llvm-config command-line options.
Dec 20 2021, 10:36 AM · Restricted Project, Restricted Project

Dec 15 2021

GMNGeoffrey added inline comments to D115486: [lit] Support relative path arguments.
Dec 15 2021, 2:35 PM · Restricted Project
GMNGeoffrey updated the diff for D115486: [lit] Support relative path arguments.

Use type=os.path.abspath

Dec 15 2021, 2:33 PM · Restricted Project
GMNGeoffrey updated the summary of D115486: [lit] Support relative path arguments.
Dec 15 2021, 12:37 PM · Restricted Project
GMNGeoffrey added inline comments to D115533: [docs] [tools] Document and alphabetize all llvm-config command-line options.
Dec 15 2021, 12:18 PM · Restricted Project, Restricted Project

Dec 13 2021

GMNGeoffrey accepted D114712: [libc] Bazel overlay for libc.

Thanks, LGTM 🙂 (The previous accept was intended to indicate "please fix these nits then gtg")

Dec 13 2021, 9:58 AM · Restricted Project

Dec 10 2021

GMNGeoffrey accepted D115558: [mlir] Update BUILD rule for AffineUtils.
Dec 10 2021, 3:48 PM · Restricted Project

Dec 9 2021

GMNGeoffrey added a comment to D115486: [lit] Support relative path arguments.

Pre-merge failures are due to a buildkite outage: https://www.buildkitestatus.com/incidents/5xlht1w0p780

Dec 9 2021, 7:19 PM · Restricted Project
GMNGeoffrey added a comment to D115487: [mlir] Add filegroup for Conversion/PassDetail.

Could you note in the description what caused us to grow the ROCDL dependency?

Dec 9 2021, 5:50 PM · Restricted Project
GMNGeoffrey added inline comments to D115053: [Bazel] Switch LLVM targets based on configuration flags..
Dec 9 2021, 5:48 PM · Restricted Project
GMNGeoffrey updated the diff for D115486: [lit] Support relative path arguments.

Return absolute paths from which

Dec 9 2021, 5:34 PM · Restricted Project
GMNGeoffrey requested review of D115486: [lit] Support relative path arguments.
Dec 9 2021, 5:24 PM · Restricted Project
GMNGeoffrey accepted D114712: [libc] Bazel overlay for libc.

Nice! Thanks for iterating on this. It looks like the Bazel build has been broken since yesterday evening. The error looks unrelated to libc, but would still be good to have a clean build. Maybe wait till @dblaikie or @mtrofin get a chance to fix it or rebase on the last passing commit (https://github.com/llvm/llvm-project/commit/a556ec8861) so we can make sure this is all working properly. I don't see the libc targets showing up in the build logs, but I think that's just because it's a bazel test invocation so the final summary just prints tests (even though it does also build the targets specified). Have you double checked that these targets show up in bazel query @llvm-project//... as expected (I can check, if you'd like).

Dec 9 2021, 10:55 AM · Restricted Project

Dec 3 2021

GMNGeoffrey added a comment to D114977: [Bazel] Update to 4.2.1.

I don't think you need to abandon :-) I'm happy to do the bump: I just really hate warning spam and would prefer we fix that first

Dec 3 2021, 3:30 PM · Restricted Project
GMNGeoffrey added a comment to D114977: [Bazel] Update to 4.2.1.

I'll need to install 4.2.1 on the CI machines. I also don't like the warnings and would prefer that we wait until that's fixed upstream. In the meantime, you can actually run this fine with bazel-4.2.1, you just have to invoke the binary directly instead of the bazel shell script that comes with the bazel install by default and picks a bazel version based on the .bazelversion file

Dec 3 2021, 3:24 PM · Restricted Project
GMNGeoffrey added a reviewer for D115053: [Bazel] Switch LLVM targets based on configuration flags.: chandlerc.
Dec 3 2021, 11:30 AM · Restricted Project
GMNGeoffrey added a comment to D115053: [Bazel] Switch LLVM targets based on configuration flags..

This overall seems like an improvement. Some thoughts:

Dec 3 2021, 11:29 AM · Restricted Project
GMNGeoffrey added a comment to D115053: [Bazel] Switch LLVM targets based on configuration flags..

I think you need to rebase for the build to pass

Dec 3 2021, 10:51 AM · Restricted Project

Dec 2 2021

GMNGeoffrey committed rGdc5e1d06b917: [Bazel] Set the right default for LLVM_WINDOWS_PREFER_FORWARD_SLASH on Windows (authored by GMNGeoffrey).
[Bazel] Set the right default for LLVM_WINDOWS_PREFER_FORWARD_SLASH on Windows
Dec 2 2021, 5:45 PM
GMNGeoffrey closed D114065: [Bazel] Set the right default for LLVM_WINDOWS_PREFER_FORWARD_SLASH on Windows.
Dec 2 2021, 5:45 PM · Restricted Project
GMNGeoffrey updated the diff for D114065: [Bazel] Set the right default for LLVM_WINDOWS_PREFER_FORWARD_SLASH on Windows.

Diff against the right base

Dec 2 2021, 5:36 PM · Restricted Project
GMNGeoffrey updated the diff for D114065: [Bazel] Set the right default for LLVM_WINDOWS_PREFER_FORWARD_SLASH on Windows.

Explicitly set to 0. I missed this was a cmakedefine01, not a cmakedefine

Dec 2 2021, 5:33 PM · Restricted Project
GMNGeoffrey updated the diff for D114065: [Bazel] Set the right default for LLVM_WINDOWS_PREFER_FORWARD_SLASH on Windows.

Avoid configuring in Bazel at all

Dec 2 2021, 5:29 PM · Restricted Project
GMNGeoffrey commandeered D114065: [Bazel] Set the right default for LLVM_WINDOWS_PREFER_FORWARD_SLASH on Windows.
Dec 2 2021, 5:27 PM · Restricted Project
GMNGeoffrey added a comment to D114976: [Bazel] Remove old macho lld port.

I think I did confirm that bazel build @llvm-project//lld/... didn't work before my change, and began working afterwards. Thanks for following up on it, though.

Dec 2 2021, 1:41 PM · Restricted Project
GMNGeoffrey added a comment to D114976: [Bazel] Remove old macho lld port.

Looks like all these targets are excluded from CI currently

Dec 2 2021, 11:45 AM · Restricted Project
GMNGeoffrey accepted D114976: [Bazel] Remove old macho lld port.
Dec 2 2021, 11:38 AM · Restricted Project
GMNGeoffrey added a comment to D114976: [Bazel] Remove old macho lld port.

How did that other commit build if it didn't remove references to the deleted targets 🤨

Dec 2 2021, 11:38 AM · Restricted Project
GMNGeoffrey added a comment to D114970: [bazel][mlgo] Remove the mlgo-related build excludes.

LGTM. Please wait for the Bazel pre-merge check to pass before landing

Dec 2 2021, 9:42 AM · Restricted Project
GMNGeoffrey accepted D114970: [bazel][mlgo] Remove the mlgo-related build excludes.
Dec 2 2021, 9:41 AM · Restricted Project

Nov 29 2021

GMNGeoffrey added a comment to D114712: [libc] Bazel overlay for libc.

Overall LGTM but one question: Will the file libc/BUILD.bazel interfere with downstream BUILD files?

Nov 29 2021, 10:43 AM · Restricted Project

Nov 23 2021

GMNGeoffrey accepted D114471: Move dependency llvm:AllTargetsAsmParsers from Translation to ExecutionEngine..

LGTM, thanks

Nov 23 2021, 1:46 PM · Restricted Project

Nov 17 2021

GMNGeoffrey added inline comments to D114065: [Bazel] Set the right default for LLVM_WINDOWS_PREFER_FORWARD_SLASH on Windows.
Nov 17 2021, 3:36 PM · Restricted Project
GMNGeoffrey added inline comments to D114065: [Bazel] Set the right default for LLVM_WINDOWS_PREFER_FORWARD_SLASH on Windows.
Nov 17 2021, 3:05 PM · Restricted Project
GMNGeoffrey added a comment to D114065: [Bazel] Set the right default for LLVM_WINDOWS_PREFER_FORWARD_SLASH on Windows.

Thanks for catching this! This functionally does the right thing, but I think for consistency it would be better to spell it slightly differently

Nov 17 2021, 1:42 PM · Restricted Project

Nov 16 2021

GMNGeoffrey committed rG00e11fdf09f1: [Bazel] Ignore both old and new benchmark directories (authored by GMNGeoffrey).
[Bazel] Ignore both old and new benchmark directories
Nov 16 2021, 4:50 PM
GMNGeoffrey closed D114043: [Bazel] Ignore both old and new benchmark directories.
Nov 16 2021, 4:49 PM · Restricted Project
GMNGeoffrey requested review of D114043: [Bazel] Ignore both old and new benchmark directories.
Nov 16 2021, 4:44 PM · Restricted Project
GMNGeoffrey committed rG7bfa9bd15574: [Bazel] Update .bazelignore for moved google/benchmark (authored by GMNGeoffrey).
[Bazel] Update .bazelignore for moved google/benchmark
Nov 16 2021, 10:50 AM
GMNGeoffrey closed D114014: [Bazel] Update .bazelignore for moved google/benchmark.
Nov 16 2021, 10:50 AM · Restricted Project
GMNGeoffrey requested review of D114014: [Bazel] Update .bazelignore for moved google/benchmark.
Nov 16 2021, 10:42 AM · Restricted Project

Nov 15 2021

GMNGeoffrey committed rGd4238fbf6a69: [Bazel] Enable layering_check for MLIR build (authored by GMNGeoffrey).
[Bazel] Enable layering_check for MLIR build
Nov 15 2021, 3:53 PM
GMNGeoffrey closed D113952: [Bazel] Enable layering_check for MLIR build.
Nov 15 2021, 3:53 PM · Restricted Project
GMNGeoffrey added a reviewer for D113952: [Bazel] Enable layering_check for MLIR build: jpienaar.
Nov 15 2021, 3:46 PM · Restricted Project
GMNGeoffrey requested review of D113952: [Bazel] Enable layering_check for MLIR build.
Nov 15 2021, 3:46 PM · Restricted Project

Nov 12 2021

GMNGeoffrey committed rG5074a20dec70: Don't define //mlir:MLIRBindingsPythonCore in terms of the NoCAPI and CAPIDeps… (authored by phawkins).
Don't define //mlir:MLIRBindingsPythonCore in terms of the NoCAPI and CAPIDeps…
Nov 12 2021, 12:05 PM
GMNGeoffrey closed D113773: Don't define //mlir:MLIRBindingsPythonCore in terms of the NoCAPI and CAPIDeps targets..
Nov 12 2021, 12:05 PM · Restricted Project
GMNGeoffrey added a comment to D113773: Don't define //mlir:MLIRBindingsPythonCore in terms of the NoCAPI and CAPIDeps targets..

Updated the PR description to clarify that this problem might be seen generally. Please take a look!

Nov 12 2021, 12:01 PM · Restricted Project
GMNGeoffrey accepted D113773: Don't define //mlir:MLIRBindingsPythonCore in terms of the NoCAPI and CAPIDeps targets..

Is there something special about Google's internal version of Bazel that would make this different? Or just that's where you noticed it and it's a potential problem in OSS as well? I want to make sure we're making the decisions that make the most sense for Bazel users (the differences between Bazel and Blaze are on Google(rs) to figure out IMO)

Nov 12 2021, 10:42 AM · Restricted Project