- User Since
- Jan 15 2020, 6:41 PM (20 w, 21 h)
Wed, May 27
Fri, May 8
Pardon my phabricator ignorance, but why is the comment here "This revision was not accepted when it landed; it landed in state Needs Review" immediately below "mehdi_amini accepted this revision"? Is that because River is marked as a blocking reviewer? Seems like a fragile system to have one person be the only one who can approve some set of code. What if they go on vacation?
Mehdi, can you land this?
May 4 2020
Thanks Mehdi :-)
Can someone land this for me, since I don't have commit access?
Apr 24 2020
Mar 18 2020
Break templates declaration to placate clang format pre-merge.
Looks like the failure is a clang format diff. I think this is related to the discussion in https://llvm.discourse.group/t/remove-mlir-custom-clang-format-configuration/647/4? I can reformat as needed, but +1 for unifying LLVM and MLIR configs
River if this LGTY, could you please commit it?
Stable maps and private registration.
Mar 17 2020
Yeah I'd also like Rivers' review
I am not sure what you mean with:
This potentially introduces some issues if callers using non-standard dialect registration functions passed to registerDialectAllocator and they are silently overridden.
If people call registerDialect<Foo>() we're all good as if there's a duplicate, it would have been the same thing anyway. If someone is directly calling registerDialectAllocator (which I don't think anyone is right now) and they pass in their custom allocator that they expect to do something and someone else also registers the same dialect (either with registerDialect or registerDialectAllocator) then we might have surprising behavior. We could move registerDialectAllocator out of the public API, although it's used by the template function, so a bit tricky (maybe just an impl/detail namespace?), but I wanted to hear from others before doing that.
Jan 15 2020
Remove LinalgUtils dependency from test transforms
LinalgToSpirv is only in the IREE project, but I removed the extra dependency from the test transforms, which I think was masking this error as you describe.
This is my first contribution now that MLIR has moved to the monorepo. Feedback on what I got wrong welcome