- User Since
- Jan 15 2020, 6:41 PM (46 w, 6 h)
Thu, Nov 19
FYI this leaves an unused function
FYI this results in unused private fields which causes diagnostic errors for -Wunused-private-field.
Mon, Nov 16
- Add coverage info and usage instructions
- Add README
- Pull in new changes from llvm-bazel repository
Thu, Nov 12
Thanks for adding this Renato :-) I was out the first part of this week, but LGTM
Fri, Nov 6
LGTM, but please wait for others' review, obviously :-)
Thu, Nov 5
Wed, Nov 4
Overall LGTM, with some wording nits. One thing I think is missing is guidance for how a peripheral component gets added. Experimental targets already have their own documentation, and my impression is that editor bindings are just a matter of sending a patch (which seems reasonable to me). What about something like:
Oct 30 2020
FYI this breaks the build with shared libs https://buildkite.com/mlir/mlir-core/builds/8988#e3d966b9-ea43-492e-a192-b28e71e9a15b. I'm investigating a fix.
Oct 29 2020
Oct 28 2020
Oct 26 2020
Oct 24 2020
Oct 23 2020
Rebase on master again
Oct 20 2020
Landing with failed builds. Looks like the same test is failing at HEAD: https://buildkite.com/llvm-project/llvm-master-build/builds/1281#df0e1b85-07a8-4199-8c41-79b6b38bd099
Update commit message
Hmmm seems this breaks lld on windows somehow... @lhames could you investigate a more principled fix? I think the approach of providing an alternative implementation if LLVM_ENABLE_THREADS is false would be consistent with other places in the file
Rebase on master
Oct 19 2020
- Improve error message
Note that I'm not familiar with this part of the codebase, so if there's a better fix (like we can add a guard to the std::promise usage) then I'm happy to do that instead. I'm just trying to maintain a LLVM_ENABLE_THREADS=0 build because of https://bugs.llvm.org/show_bug.cgi?id=44211.
Oct 16 2020
Oct 15 2020
Oct 13 2020
Oct 10 2020
Oct 7 2020
Hey JFYI this created some unused variables. I fixed with https://reviews.llvm.org/D89022
Sep 30 2020
- Fix flang
Whoops meant to upload a patch to an existing revision
Oh huh, I broke flang :-D I was just replacing in the MLIR directory
Sep 29 2020
Sep 10 2020
Thanks for improving error messages Mehdi!
Sep 3 2020
Sep 2 2020
Thanks for reviewing!
If y'all are good with this now (and think that others will not have objects), could one of you land it for me? I don't have commit access.
Use #else after throwing exception
Suppress pre-existing clang-tidy warnings
Sep 1 2020
And one more typo...
Fix lint. Switch to explicit const char *
Aug 31 2020
Use auto for local string vars.
Throw a std::length_error when exceptions are enabled.
Apply same behavior to SmallVector::grow
LGTM, but would like to make sure others are OK with this.