[clang] Fix typo in comment

[gousemoodhin]

Summary

In the handleIntToFloatConversion() function, 6th parameter is ConvertFloat, 7th parameter is ConvertInt.

[xbolva00]

clang/lib/Sema/SemaExpr.cpp

1154–1155

Shouldn’t some clang based tool warn us that the comment is wrong?

[gousemoodhin]

clang/lib/Sema/SemaExpr.cpp

1154–1155

I did not check with clang based tool, while debugging other issue, I figured out this typo.

[njames93]

clang/lib/Sema/SemaExpr.cpp

1154–1155

There is one that does just that. https://clang.llvm.org/extra/clang-tidy/checks/bugprone-argument-comment.html

[gousemoodhin]

clang/lib/Sema/SemaExpr.cpp

1154–1155

Yes, clang-tidy tool catches this bug.

clang-tidy SemaExpr.cpp -checks="-*,bugprone-argument-comment"

SemaExpr.cpp:1145:37: warning: argument name 'convertFloat' in comment does not match parameter name 'ConvertInt' [bugprone-argument-comment] /*convertFloat=*/!IsCompAssign);

[xbolva00]

Ok, thanks!

[gousemoodhin]

In D85568#2204482, @xbolva00 wrote:

Ok, thanks!

I don't have commit access. Could you or someone else commit this patch?
My Github username: gousemoodhin
My GitHub email id: [e-mail]

[njames93]

LG, pretty trivial fix. Side note running that check over the code base leads to a lot of warnings, however most of false positives, like using abbreviations in the comment or parameter.

clang/lib/Sema/SemaExpr.cpp

if (LHSType->isHalfType() && !S.getLangOpts().NativeHalfType)
       LHSType = S.Context.FloatTy;
 
     return handleIntToFloatConversion(S, LHS, RHS, LHSType, RHSType,
                                       /*ConvertFloat=*/!IsCompAssign,
                                       /*ConvertInt=*/ true);
   }
   assert(RHSFloat);
   return handleIntToFloatConversion(S, RHS, LHS, RHSType, LHSType,
-                                    /*convertInt=*/ true,
-                                    /*convertFloat=*/!IsCompAssign);
+                                    /*ConvertFloat=*/ true,
+                                    /*ConvertInt=*/!IsCompAssign);
 }
 
 /// Diagnose attempts to convert between __float128 and long double if
 /// there is no support for such conversion. Helper function of
 /// UsualArithmeticConversions().
 static bool unsupportedTypeConversion(const Sema &S, QualType LHSType,
                                       QualType RHSType) {
   /*  No issue converting if at least one of the types is not a floating point