Page MenuHomePhabricator

gousemoodhin (Gousemoodhin Nadaf)
User

Projects

User does not belong to any projects.

User Details

User Since
May 31 2020, 9:54 AM (20 w, 6 d)

Recent Activity

Aug 30 2020

gousemoodhin added a comment to D86677: [clang] Display error if _Fract fixed point literals overflow.

This needs a few tests.

Testing it myself also shows that

unsigned _Fract f = 1.0ur;

seems to get an error, which it shouldn't.

Aug 30 2020, 8:30 PM

Aug 26 2020

gousemoodhin requested review of D86677: [clang] Display error if _Fract fixed point literals overflow.
Aug 26 2020, 9:52 PM

Aug 24 2020

gousemoodhin added a comment to D85961: [Fixed Point] Add floating point methods to APFixedPoint..

@gousemoodhin I just want to check; are you working on or planning to work on float-fixed support in the near future? Floating point conversions are the next step for the fixed-point support, so if you aren't immediately looking at it, I would like to take a shot at it.

If you want a suggestion for something fixed-point related to work on, there's a bug I filed a while back here: https://bugs.llvm.org/show_bug.cgi?id=46554

Aug 24 2020, 8:44 AM · Restricted Project

Aug 20 2020

gousemoodhin added a comment to D83929: [clang]: Remove assertion which checks explicit declaration.

Please add a corresponding test case. Other than that this looks good. Thanks!

Done.

Aug 20 2020, 4:08 PM · Restricted Project

Aug 11 2020

gousemoodhin added a comment to D83929: [clang]: Remove assertion which checks explicit declaration.

Please add a corresponding test case. Other than that this looks good. Thanks!

Aug 11 2020, 3:35 PM · Restricted Project
gousemoodhin updated the diff for D83929: [clang]: Remove assertion which checks explicit declaration.
Aug 11 2020, 3:34 PM · Restricted Project

Aug 10 2020

gousemoodhin added a comment to D81904: [clang] Do not crash for unsupported fixed point to floating point conversion.

I don't have commit access. Please use these details to commit.
My Github username: gousemoodhin
My GitHub email id: nadafgouse5@gmail.com

Aug 10 2020, 10:30 AM · Restricted Project
gousemoodhin added a comment to D81904: [clang] Do not crash for unsupported fixed point to floating point conversion.

I don't think "Handle fixed point conversion" is a descriptive enough title.

I am going to resolve FIXME in followup patches.

I assume by this you mean to move forward with adding floating-fixed conversions? I have an unsubmitted patch for APFixedPoint which implements the semantics of the conversions, but I'm currently waiting on D85312, D85314, and more recently I found D54749 which is probably a prerequisite for the IR codegen.

Yes,
I will add a function for fixed point to floating point conversion, (Example: handleFixedPointToFloatConversion()), similar to handleIntToFloatConversion() (SemaExpr.cpp)

Alright. There's a lot more that needs to be done to get the conversions to work, though. I would recommend having a look at some of the earlier patches, like D56900. The approach for codegen will probably be different, though. There's also the patches I mentioned earlier for moving all of the codegen+APFixedPoint code to LLVM, so things may move around in the future.

I can upload my partial APFixedPoint patch as a reference of the semantics of the conversions.

Aug 10 2020, 10:27 AM · Restricted Project
gousemoodhin retitled D81904: [clang] Do not crash for unsupported fixed point to floating point conversion from [clang] Handle fixed point conversion to [clang] Do not crash for unsupported fixed point to floating point conversion.
Aug 10 2020, 10:14 AM · Restricted Project
gousemoodhin added a comment to D81904: [clang] Do not crash for unsupported fixed point to floating point conversion.

I don't think "Handle fixed point conversion" is a descriptive enough title.

I am going to resolve FIXME in followup patches.

I assume by this you mean to move forward with adding floating-fixed conversions? I have an unsubmitted patch for APFixedPoint which implements the semantics of the conversions, but I'm currently waiting on D85312, D85314, and more recently I found D54749 which is probably a prerequisite for the IR codegen.

Aug 10 2020, 10:10 AM · Restricted Project
gousemoodhin added a comment to D81904: [clang] Do not crash for unsupported fixed point to floating point conversion.
Aug 10 2020, 9:03 AM · Restricted Project
gousemoodhin updated the summary of D81904: [clang] Do not crash for unsupported fixed point to floating point conversion.
Aug 10 2020, 8:59 AM · Restricted Project

Aug 9 2020

gousemoodhin updated the diff for D81904: [clang] Do not crash for unsupported fixed point to floating point conversion.
Aug 9 2020, 1:26 PM · Restricted Project
gousemoodhin updated the summary of D81904: [clang] Do not crash for unsupported fixed point to floating point conversion.
Aug 9 2020, 1:26 PM · Restricted Project
gousemoodhin updated the summary of D81904: [clang] Do not crash for unsupported fixed point to floating point conversion.
Aug 9 2020, 1:25 PM · Restricted Project
gousemoodhin updated the summary of D81904: [clang] Do not crash for unsupported fixed point to floating point conversion.
Aug 9 2020, 1:24 PM · Restricted Project
gousemoodhin added inline comments to D81904: [clang] Do not crash for unsupported fixed point to floating point conversion.
Aug 9 2020, 12:11 PM · Restricted Project
gousemoodhin updated the diff for D81904: [clang] Do not crash for unsupported fixed point to floating point conversion.
Aug 9 2020, 12:10 PM · Restricted Project

Aug 7 2020

gousemoodhin added a comment to D85568: [clang] Fix typo in comment.

Ok, thanks!

Aug 7 2020, 7:23 PM · Restricted Project
gousemoodhin added inline comments to D85568: [clang] Fix typo in comment.
Aug 7 2020, 7:08 PM · Restricted Project
gousemoodhin added inline comments to D85568: [clang] Fix typo in comment.
Aug 7 2020, 5:04 PM · Restricted Project
gousemoodhin requested review of D85568: [clang] Fix typo in comment.
Aug 7 2020, 4:21 PM · Restricted Project
gousemoodhin added inline comments to D81904: [clang] Do not crash for unsupported fixed point to floating point conversion.
Aug 7 2020, 9:15 AM · Restricted Project

Aug 6 2020

gousemoodhin added a comment to D81904: [clang] Do not crash for unsupported fixed point to floating point conversion.

You need a test case for this, Frontend/fixed_point_errors.c is probably a good place for it.

Aug 6 2020, 10:02 AM · Restricted Project
gousemoodhin updated the diff for D81904: [clang] Do not crash for unsupported fixed point to floating point conversion.
Aug 6 2020, 9:59 AM · Restricted Project

Aug 2 2020

gousemoodhin updated the summary of D81904: [clang] Do not crash for unsupported fixed point to floating point conversion.
Aug 2 2020, 9:45 PM · Restricted Project
gousemoodhin added inline comments to D81904: [clang] Do not crash for unsupported fixed point to floating point conversion.
Aug 2 2020, 9:44 PM · Restricted Project
gousemoodhin updated the diff for D81904: [clang] Do not crash for unsupported fixed point to floating point conversion.
Aug 2 2020, 9:38 PM · Restricted Project
gousemoodhin updated the diff for D83929: [clang]: Remove assertion which checks explicit declaration.
Aug 2 2020, 2:15 PM · Restricted Project

Jul 31 2020

gousemoodhin added a comment to D83929: [clang]: Remove assertion which checks explicit declaration.

We already check that explicit is only used in the proper scopes in ActOnFunctionDeclarator (and the proper scopes aren't just class scopes, due to deduction guides). In fact, the assert appears to have nothing to do with whether the expression appears at function scope; that's a red herring caused by unary && (address of label) doing different things at that scope. An analogous case crashes at class scope too:

void *p;
struct X { explicit(p) X(); };

It looks like this is just a bogus assertion; when ActOnExplicitBoolSpecifier produces an invalid ExplicitSpecifier and the parser stores it on the DeclSpec, the assertion that's triggering is in effect asserting that the ExplicitSpecifier is not invalid, which seems wrong, because it certainly can be invalid. We'll need to check that later users of the ExplicitSpecifier can cope with it being invalid, but subject to that, removing the assertion seems like the right change to me.

Jul 31 2020, 10:11 AM · Restricted Project

Jul 22 2020

gousemoodhin added a reviewer for D83929: [clang]: Remove assertion which checks explicit declaration: Restricted Project.
Jul 22 2020, 12:46 PM · Restricted Project
gousemoodhin updated the diff for D83929: [clang]: Remove assertion which checks explicit declaration.
Jul 22 2020, 12:14 PM · Restricted Project

Jul 15 2020

gousemoodhin created D83929: [clang]: Remove assertion which checks explicit declaration.
Jul 15 2020, 9:57 PM · Restricted Project

Jul 5 2020

gousemoodhin updated the diff for D81904: [clang] Do not crash for unsupported fixed point to floating point conversion.
Jul 5 2020, 12:47 PM · Restricted Project

Jul 1 2020

gousemoodhin added a comment to D82266: [clang] Handle block scope when using lambda inside if initializer.

Yes, I agree with David.
In current scenario, we are avoiding compiler crash.

Jul 1 2020, 2:04 PM

Jun 26 2020

gousemoodhin updated the diff for D82266: [clang] Handle block scope when using lambda inside if initializer.

Add new test case

Jun 26 2020, 3:39 PM

Jun 24 2020

gousemoodhin retitled D82266: [clang] Handle block scope when using lambda inside if initializer from clang: Handle block scope to [clang] Handle block scope when using lambda inside if initializer.
Jun 24 2020, 6:29 PM
gousemoodhin updated the diff for D82266: [clang] Handle block scope when using lambda inside if initializer.
Jun 24 2020, 6:29 PM

Jun 22 2020

gousemoodhin added a comment to D82266: [clang] Handle block scope when using lambda inside if initializer.

Hi! You need at least:

  1. Tests.
  2. A better description of the problem and why this is the right fix.
  3. A more descriptive title prefixed with [clang].
Jun 22 2020, 9:29 PM

Jun 20 2020

gousemoodhin created D82266: [clang] Handle block scope when using lambda inside if initializer.
Jun 20 2020, 2:18 PM

Jun 15 2020

gousemoodhin created D81904: [clang] Do not crash for unsupported fixed point to floating point conversion.
Jun 15 2020, 8:23 PM · Restricted Project