Page MenuHomePhabricator

[mlir][Types] Remove the subclass data from Type
ClosedPublic

Authored by rriddle on Aug 5 2020, 12:41 PM.

Details

Summary

Subclass data is useful when a certain amount of memory is allocated, but not all of it is used. In the case of Type, that hasn't been the case for a while and the subclass is just taking up a full unsigned. Removing this frees up ~8 bytes for almost every type instance.

Depends On D82597

Diff Detail

Event Timeline

rriddle created this revision.Aug 5 2020, 12:41 PM
rriddle requested review of this revision.Aug 5 2020, 12:41 PM
mravishankar accepted this revision.Aug 5 2020, 2:01 PM

Nice! Thanks for the cleanup!

This revision is now accepted and ready to land.Aug 5 2020, 2:01 PM
mehdi_amini accepted this revision.Aug 5 2020, 8:41 PM

Wow that was pretty bad actually, do I miss something or there was zero upside to the subclass data before?

Wow that was pretty bad actually, do I miss something or there was zero upside to the subclass data before?

A long long time ago there was an upside, but for at least the past 10 months its just been a waste of space.

Harbormaster completed remote builds in B67526: Diff 284023.
This revision was landed with ongoing or failed builds.Aug 7 2020, 1:44 PM
This revision was automatically updated to reflect the committed changes.