Page MenuHomePhabricator

[mlir] Remove locking for dialect/operation registration.
ClosedPublic

Authored by rriddle on Thu, Jun 25, 1:35 PM.

Details

Summary

Moving forward dialects should only be registered in a thread safe context. This matches the existing usage we have today, but it allows for removing quite a bit of expensive locking from the context.

This led to ~.5 a second compile time improvement when running one conversion pass on a very large .mlir file(hundreds of thousands of operations).

Depends On D81883

Diff Detail

Event Timeline

rriddle created this revision.Thu, Jun 25, 1:35 PM
Herald added a project: Restricted Project. · View Herald TranscriptThu, Jun 25, 1:35 PM
jpienaar accepted this revision.Sun, Jun 28, 7:52 AM
This revision is now accepted and ready to land.Sun, Jun 28, 7:52 AM
This revision was automatically updated to reflect the committed changes.