Page MenuHomePhabricator

[mlir] Add a utility class, ThreadLocalCache, for storing non static thread local objects.
Needs ReviewPublic

Authored by rriddle on Thu, Jun 25, 1:36 PM.

Details

Summary

This class allows for defining thread local objects that have a set non-static lifetime. This internals of the cache use a static thread_local map between the various different non-static objects and the desired value type. When a non-static object destructs, it simply nulls out the entry in the static map. This will leave an entry in the map, but erase any of the data for the associated value. The current use cases for this are in the MLIRContext, meaning that the number of items in the static map is ~1-2 which aren't particularly costly enough to warrant the complexity of pruning. If a use case arises that requires pruning of the map, the functionality can be added.

This is especially useful in the context of MLIR for implementing thread-local caching of context level objects that would otherwise have very high lock contention. This revision adds a thread local cache in the MLIRContext for attributes, identifiers, and types to reduce some of the locking burden. This led to a speedup of several hundred miliseconds when compiling a conversion pass on a very large mlir module(>300K operations).

Depends On D82596

Diff Detail

Event Timeline

rriddle created this revision.Thu, Jun 25, 1:36 PM
Herald added a project: Restricted Project. · View Herald TranscriptThu, Jun 25, 1:36 PM