Depends on D91861.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
This is close, just a few nits. Also, since this has the first uses of IsNegative, it'd be great to have a couple of tests for one of the flags it's used on.
clang/lib/Frontend/CompilerInvocation.cpp | ||
---|---|---|
135 | Nit: clang/Basic/LLVM.h pulls Optional in namespace clang so you don't need the llvm:: qualifier. | |
136–137 | Please drop parameter names for TableIndex and Diags. |
Nit: clang/Basic/LLVM.h pulls Optional in namespace clang so you don't need the llvm:: qualifier.