[MLIR][Shape] Fold `shape.size_eq`

[frgossen]

Summary

Fold shape.size_eq.

Depends On D82628

[frgossen]

Remove CHECK-DAGs

[silvas]

LGTM modulo splitting into two separate ops.

mlir/lib/Dialect/Shape/IR/Shape.cpp

390

This will be much cleaner with two separate ops.

[rriddle]

mlir/include/mlir/IR/Builders.h

112

I would rather use bool here. This method also isn't strictly necessary given that it does exactly the same thing as getBoolAttr.

mlir/lib/Dialect/Shape/IR/Shape.cpp

393

This looks much longer than just doing:

BoolAttr::get(eq, getContext());

[frgossen]

Address comments

[frgossen]

Rebase

[rriddle]

mlir/test/Dialect/Shape/canonicalize.mlir

476

Can you simplify this to just checking something like:

// CHECK: %[[RESULT:.*]] = shape.size_eq
// CHECK: return %[[RESULT]]

?

[frgossen]

Address comment