MLIR][Shape] Add function signature conversion to `scf` to `std` lowering.
Needs ReviewPublic
Actions

Authored by frgossen on Thu, Jun 25, 1:57 AM.

Details

Reviewers

rriddle
pifon2a

Summary

The pass lowers fully to scf (and std where unavoidable).
It includes patterns from the shape to std lowering pass for testing
purposes.
This change prepares for the lowering of shape.shape_eq to scf.

Depends On D82528

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

frgossen created this revision.Thu, Jun 25, 1:57 AM

Herald added a reviewer: rriddle. · View Herald TranscriptThu, Jun 25, 1:57 AM

Herald added a project: Restricted Project. · View Herald Transcript

Herald added subscribers: msifontes, jurahul, Kayjukh and 15 others. · View Herald Transcript

frgossen added a child revision: D82530: [MLIR][Shape] Lower `shape.shape_eq` to `scf`.Thu, Jun 25, 1:58 AM

Harbormaster failed remote builds in B61675: Diff 273258!Thu, Jun 25, 1:58 AM

frgossen added a reviewer: pifon2a.Thu, Jun 25, 1:59 AM

Remove CHECK-DAGs

Harbormaster failed remote builds in B61751: Diff 273388!Thu, Jun 25, 9:08 AM

rriddle added inline comments.Thu, Jun 25, 1:20 PM

mlir/lib/IR/Builders.cpp
169 ↗	(On Diff #273388)	This method doesn't look like it is used in this revision.

Rebase

Harbormaster failed remote builds in B61899: Diff 273657!Fri, Jun 26, 4:50 AM

frgossen retitled this revision from [MLIR][Shape] Add function signature conversion to `scf` to `std` lowering. to MLIR][Shape] Add function signature conversion to `scf` to `std` lowering..Mon, Jun 29, 7:01 AM

frgossen edited the summary of this revision. (Show Details)

Revision Contents
Changeset List

			Path	Packages
M			mlir/include/mlir/Dialect/SCF/SCFOps.td (6 lines)
M			mlir/lib/Conversion/ShapeToSCF/CMakeLists.txt (1 line)
M			mlir/lib/Conversion/ShapeToSCF/ShapeToSCF.cpp (75 lines)
M			mlir/test/Conversion/ShapeToSCF/shape-to-scf.mlir (28 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	273258	16576f7		Thu, Jun 25, 1:57 AM	★	★
Diff 2	273388	a35acf4	Remove `CHECK-DAG`s	Thu, Jun 25, 8:46 AM	★	★
Diff 3	273657	79c4a15	Rebase	Fri, Jun 26, 4:06 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
ef4a994d2778	34f2fce5c99c	79c4a15010dc	Frederik Gossen	MLIR][Shape] Add function signature conversion to `scf` to `std` lowering. (Show More…)	Fri, Jun 26, 4:05 AM

Status	Author	Revision
Accepted	frgossen	D82534 [MLIR][Shape] Lower `shape.size_eq` to the standard dialect
Needs Review	frgossen	D82533 [MLIR][Shape] Fold `shape.shape_eq`
Accepted	frgossen	D82531 [MLIR][Shape] Fold `shape.size_eq`
Needs Review	frgossen	D82628 [MLIR][Shape] Add `shape.size_eq` to the shape dialect
Accepted	frgossen	D82530 [MLIR][Shape] Lower `shape.shape_eq` to `scf`
Needs Review	frgossen	D82529 MLIR][Shape] Add function signature conversion to `scf` to `std` lowering.
Needs Review	frgossen	D82528 [MLIR][Shape] Add `shape.shape_eq` operation