MLIR][Shape] Add function signature conversion to `shape` to `scf` lowering.
AbandonedPublic
Actions

Authored by frgossen on Jun 25 2020, 1:57 AM.

Details

Reviewers

rriddle
pifon2a

Summary

The pass lowers fully to scf (and std where unavoidable).
It includes patterns from the shape to std lowering pass for testing
purposes.
This change prepares for the lowering of shape.shape_eq to scf.

Depends On D82528

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

frgossen created this revision.Jun 25 2020, 1:57 AM

Herald added a reviewer: rriddle. · View Herald TranscriptJun 25 2020, 1:57 AM

Herald added a project: Restricted Project. · View Herald Transcript

Herald added subscribers: msifontes, jurahul, Kayjukh and 15 others. · View Herald Transcript

frgossen added a child revision: D82530: [MLIR][Shape] Lower `shape.shape_eq` to `scf`.Jun 25 2020, 1:58 AM

Harbormaster failed remote builds in B61675: Diff 273258!Jun 25 2020, 1:58 AM

frgossen added a reviewer: pifon2a.Jun 25 2020, 1:59 AM

Remove CHECK-DAGs

Harbormaster failed remote builds in B61751: Diff 273388!Jun 25 2020, 9:08 AM

rriddle added inline comments.Jun 25 2020, 1:20 PM

mlir/lib/IR/Builders.cpp
169 ↗	(On Diff #273388)	This method doesn't look like it is used in this revision.

Rebase

Harbormaster failed remote builds in B61899: Diff 273657!Jun 26 2020, 4:50 AM

frgossen retitled this revision from [MLIR][Shape] Add function signature conversion to `scf` to `std` lowering. to MLIR][Shape] Add function signature conversion to `scf` to `std` lowering..Jun 29 2020, 7:01 AM

frgossen edited the summary of this revision. (Show Details)

frgossen retitled this revision from MLIR][Shape] Add function signature conversion to `scf` to `std` lowering. to MLIR][Shape] Add function signature conversion to `shape` to `scf` lowering..Jul 13 2020, 2:34 AM

No longer relevant for the new lowering strategy