- User Since
- Jan 3 2020, 4:17 AM (129 w, 5 d)
Wed, Jun 1
May 23 2022
May 20 2022
May 12 2022
Sorry to delay on this for so long. I am proposing, instead, a TensorToLinalgPass here: https://reviews.llvm.org/D125384
May 11 2022
May 9 2022
May 4 2022
May 2 2022
Hello, why were parseOptionalAssignmentListWithTypesand parseAssignmentListWithTypes removed? This seems to be a common pattern in MLIR where functionality is provided but untested and unused inside of core and then freely removed while breaking users. If this is the intended progression of the API, a deprecation would be appreciated, so people can raise concerns that used functionality is being deleted. If this being freely removed because users of the code outside of the LLVM repository don't impact this decision, it really indicates that MLIR core needs to start providing some form of a stable API that people can rely on rather than the current (small) chaos caused by many changes.
Apr 4 2022
Mar 30 2022
Mar 8 2022
Feb 18 2022
Landing now instead as it is low risk, and I mainly wanted to confirm with River.
I'll leave this until Monday to submit in case the comment in code that insert is soft deprecated is out of date.
Feb 17 2022
Update test cases
Feb 10 2022
Clang documentation for ASAN, as I feel like everyone has different flows for using it: https://clang.llvm.org/docs/AddressSanitizer.html
I am reverting this change as it has a stack-use-after-scope error. I suspect this is due to the call to expandAffineMap returning a SmallVector which is then referenced with the ValueRange indices inside of the if block and then used outside.
Feb 8 2022
Hi, I added a fix forward for this change, as a rollback was hard due to another change, but it would be ideal to confirm that it is okay, as I'm not sure exactly what you were going for: https://github.com/llvm/llvm-project/commit/64b918852c09db6461d4c4c97df288c7b7fee865
Dec 15 2021
Nov 24 2021
Store empty attributes instead of nullptrs.
Nov 23 2021
Nov 22 2021
Nov 2 2021
Hi Jamie, this code has test failures: https://reviews.llvm.org/B131761
Oct 1 2021
Sep 6 2021
Sep 3 2021
Drive by comment
Sep 2 2021
Aug 25 2021
Move the unsupported logic to the caller.
I've been somewhat convinced that this could lead to subtle bugs in the future, so we should leave it to the callers to handle this issue each time they want to build this op during dialect conversion, so I'm going to abandon this.
Move assertions to NamedAttrList::push_back
Aug 24 2021
Move the assertion logic to NamedAttrList.
Aug 23 2021
Aug 18 2021
Aug 17 2021
Aug 13 2021
Friendly ping on this
Aug 10 2021
Aug 9 2021
Jul 28 2021
I apologize for not providing one at the beginning. Following is the IR and an LLC command that resulted in SelectionDAGISel failing: https://reviews.llvm.org/P8269
Jul 27 2021
An important piece of information: this seems to happen only with assertions disabled (-DLLVM_ENABLE_ASSERTIONS=OFF)
Hello, unless I'm mistaken, this is breaking CodeGen/AArch64/arm64-ldxr-stxr.ll. Can you confirm if that's correct and rollback this commit until it's fixed?
Jul 12 2021
Jun 14 2021
Rebase, add tests, and extract reshape logic into separate methods.
Jun 13 2021
Jun 7 2021
Create a single method to support both Tensor and MemRef operands.
Jun 2 2021
Update a comment
Jun 1 2021
May 31 2021
May 30 2021
May 25 2021
Remove hoisting of allocas in non-loop cases.
May 21 2021
May 18 2021
May 11 2021
Respond to comments.
May 10 2021
May 7 2021
Change this patch to just a rename and expanded documentation.
May 6 2021
Apr 30 2021
I agree though that "Dependency" is a bad name. I'm just struggling to find a name to encode this concept of BufferViewFlowAnalysis.
Apr 29 2021
Describing what the code is intended to do (https://github.com/tensorflow/tensorflow/blob/master/tensorflow/compiler/xla/tests/reverse_test.cc#L146).
; ModuleID = '__compute_module' source_filename = "__compute_module" target datalayout = "e-m:e-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128" target triple = "x86_64-grtev4-linux-gnu"
Apr 28 2021
I'm reverting this due to test failures and emailing you a more in depth reproducer for the failures. It seems like you expected the possibility of failures, so I hope this is okay.
lebedev.ri's concerns seem to have been valid, so I'll be rolling this back. A test case in XLA that reverses data across certain dimensions in a multidimensional change fails with this patch. A sequence of loads and stores is converted into a single memcpy even though the ordering should be different across loads and stores.
Apr 23 2021
Apr 21 2021
A few places you checked that *.isa<ShapeType>() == *.isa<ShapeType>(). Out of curiosity, why not just compare the types?
Arc diff doesn't update the description, so FYI in case you didn't, update to mention the additional features you added.
Apr 20 2021
Update cmake file and remove friendliness between Analyses
I forwarded the DataLayout through several layers of functions. I started at the last point that the call sequence has the originating LinalgOp and passed it through as an additional argument rather than inside of any of the LinalgPromotionOption data structures. Please let me know what you think.
Forward DataLayout object to buffer allocation.
Apr 19 2021
It may not exist, it just sounds like a useful thing to have so I thought somebody could have added it. Feel free to have a local version or suggest one at Vector level. There's already VectorUnrollPattern that could be helpful.
Add test case to convert vectors to scalars.
Apr 16 2021
Apr 14 2021
Convert to StandardOpsDialect instead of LLVMDialect.
Rebase onto parent commit