- User Since
- Jan 3 2020, 4:17 AM (168 w, 2 d)
Wed, Mar 15
Pass container instead of begin/end to sort
Feb 23 2023
Dec 12 2022
NFC: cleanup some ugliness
I often add a simple dump command inside of a pass at the beginning or end when I'm quickly trying to gather some data and don't want to dump everything. I considered making a tiny rfc regarding this to see if others prefer another way, but want to at least first run it by a couple of folks. I'm sure there's several ways to do the same thing, but this would be my preferred way of debugging a pipeline not presented in a test using opt and before my morning coffee.
Dec 9 2022
Nov 24 2022
I'm leaving a few high level comments first. I think this abortOnFailedAssert=false case should be handled by a separate test pass instead.
Nov 21 2022
Nov 14 2022
It looks like you will also need to run clang-format on this. I use git clang-format --style=LLVM HEAD to format my patches before landing (then you can use arc diff to upload the final patch this time and I can submit it on your behalf).
Nov 10 2022
Oct 31 2022
Oct 26 2022
Are you still going to wait until early November, or are you going to commit it this week?
Oct 24 2022
Oct 21 2022
Oct 20 2022
Oct 4 2022
Sep 29 2022
Sep 13 2022
Sep 5 2022
Awesome! You use copyBeforeWrite and skipAnalysis. I think it would be better to use the same name consistently, like the other options/flags, unless skip-analysis is expected to grow to modifying multiple option values(?)
Sep 1 2022
Aug 31 2022
Drive by warning. If this patch is depending on a non-landed commit, this comment might be wrong. It looks like one python binding test case will fail with this patch:
Aug 29 2022
Unfortunately, it looks like the version of clang on the pre-merge bazel build bot is too old, or similar, so I am abandoning this attempted workaround.
Move fuse-ld to ci
Move flag from generic_clang to ci until pre-merge is fixed
Remove overlooked line.
linkopt can't be overriden with empty strings, so workaround differently.
Fix flipped names
Aug 25 2022
Remove definition of method after only declaration was previously removed.
Aug 23 2022
Aug 22 2022
Aug 18 2022
Drive by nit... The important parts to me in regards to this change are:
- The change to the assembly format
- The change in types that break C++ code interacting with this class
Aug 10 2022
I'm resigning as reviewer as I just wanted to voice my concerns regarding populate methods creating global effects. I wish more tests used the canonicalizer just to ease the mess that some FileCheck tests are, and I think targeted canonicalizations can make sense.
Aug 8 2022
I did add the canonicalization patterns to a downstream and have observed that they do "help" a lot of real cases I was seeing get to a fully decomposed state.
Aug 5 2022
This creates a situation where unrelated linalg::generic ops can be canonicalized as a side effect. This has happened multiple times in linalg infrastructure and is always confusing to a user when the populated patterns are actually doing much more than they claim to do because of these global canonicalizations. I can understand the benefits of this when only applied to the newly created ops, but as is this creates confusion.
Aug 4 2022
Respond to style fixes and improve the unrealized_conversion_cast conditional.
Aug 2 2022
Aug 1 2022
I'm going to land this as I suspect there are no strong feelings over this change and there was a lack of failing tests to show people might rely on this, but if anyone has concerns, please feel free to revert and raise your concerns, as this commit was not in review for long. For any abstract concerns though, please keep in mind that the existing code failed in multiple situations, and only worked in limited code paths.
Jul 29 2022
Jun 1 2022
May 23 2022
May 20 2022
May 12 2022
Sorry to delay on this for so long. I am proposing, instead, a TensorToLinalgPass here: https://reviews.llvm.org/D125384
May 11 2022
May 9 2022
May 4 2022
May 2 2022
Hello, why were parseOptionalAssignmentListWithTypesand parseAssignmentListWithTypes removed? This seems to be a common pattern in MLIR where functionality is provided but untested and unused inside of core and then freely removed while breaking users. If this is the intended progression of the API, a deprecation would be appreciated, so people can raise concerns that used functionality is being deleted. If this being freely removed because users of the code outside of the LLVM repository don't impact this decision, it really indicates that MLIR core needs to start providing some form of a stable API that people can rely on rather than the current (small) chaos caused by many changes.
Apr 4 2022
Mar 30 2022
Mar 8 2022
Feb 18 2022
Landing now instead as it is low risk, and I mainly wanted to confirm with River.
I'll leave this until Monday to submit in case the comment in code that insert is soft deprecated is out of date.
Feb 17 2022
Update test cases
Feb 10 2022
Clang documentation for ASAN, as I feel like everyone has different flows for using it: https://clang.llvm.org/docs/AddressSanitizer.html
I am reverting this change as it has a stack-use-after-scope error. I suspect this is due to the call to expandAffineMap returning a SmallVector which is then referenced with the ValueRange indices inside of the if block and then used outside.
Feb 8 2022
Hi, I added a fix forward for this change, as a rollback was hard due to another change, but it would be ideal to confirm that it is okay, as I'm not sure exactly what you were going for: https://github.com/llvm/llvm-project/commit/64b918852c09db6461d4c4c97df288c7b7fee865
Dec 15 2021
Nov 24 2021
Store empty attributes instead of nullptrs.
Nov 23 2021
Nov 22 2021
Nov 2 2021
Hi Jamie, this code has test failures: https://reviews.llvm.org/B131761
Oct 1 2021
Sep 6 2021
Sep 3 2021
Drive by comment
Sep 2 2021
Aug 25 2021
Move the unsupported logic to the caller.
I've been somewhat convinced that this could lead to subtle bugs in the future, so we should leave it to the callers to handle this issue each time they want to build this op during dialect conversion, so I'm going to abandon this.
Move assertions to NamedAttrList::push_back
Aug 24 2021
Move the assertion logic to NamedAttrList.