Page MenuHomePhabricator

tpopp (Theodore Popp)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 3 2020, 4:17 AM (37 w, 1 d)

Recent Activity

Yesterday

tpopp abandoned D84635: [MLIR] Add lowering for shape.extend..
Fri, Sep 18, 7:07 AM · Restricted Project
tpopp abandoned D84632: [MLIR] Add shape.extend op..

I'm abandoning this revision for now

Fri, Sep 18, 7:07 AM · Restricted Project
tpopp updated the diff for D87894: [mlir] Shape.AssumingOp implements RegionBranchOpInterface..

Add note to explain purpose of method.

Fri, Sep 18, 5:06 AM · Restricted Project
tpopp added a comment to D87894: [mlir] Shape.AssumingOp implements RegionBranchOpInterface..

Ready for review now.

Fri, Sep 18, 5:06 AM · Restricted Project
tpopp updated the diff for D87894: [mlir] Shape.AssumingOp implements RegionBranchOpInterface..

Update test case to pass by using previously unused value.

Fri, Sep 18, 5:04 AM · Restricted Project
tpopp added a comment to D87894: [mlir] Shape.AssumingOp implements RegionBranchOpInterface..

Note that this is not complete and was uploaded at the current state to share a patch to reproduce a bug.

Fri, Sep 18, 2:18 AM · Restricted Project
tpopp requested review of D87894: [mlir] Shape.AssumingOp implements RegionBranchOpInterface..
Fri, Sep 18, 2:16 AM · Restricted Project

Tue, Sep 15

tpopp requested review of D87706: [mlir] Remove redundant shape.cstr_broadcastable canonicalization..
Tue, Sep 15, 9:31 AM · Restricted Project

Jul 29 2020

tpopp requested review of D84845: [MLIR][NFC] Move Shape::WitnessType Declaration..
Jul 29 2020, 7:04 AM · Restricted Project
tpopp requested review of D84832: [MLIR] Forward extent tensors through shape.broadcast..
Jul 29 2020, 4:04 AM · Restricted Project

Jul 27 2020

tpopp updated the diff for D84635: [MLIR] Add lowering for shape.extend..

Correct loop space of the second for loop to be a suffix rather than a prefix.

Jul 27 2020, 6:12 AM · Restricted Project
Herald added a project to D84635: [MLIR] Add lowering for shape.extend.: Restricted Project.
Jul 27 2020, 4:14 AM · Restricted Project
Herald added a project to D84632: [MLIR] Add shape.extend op.: Restricted Project.
Jul 27 2020, 3:48 AM · Restricted Project

Jul 21 2020

tpopp added inline comments to D83969: Create the Reduction Tree Pass.
Jul 21 2020, 11:43 AM · Restricted Project

Jul 17 2020

tpopp added inline comments to D83969: Create the Reduction Tree Pass.
Jul 17 2020, 9:38 AM · Restricted Project

Jul 15 2020

tpopp accepted D83854: [mlir][shape] Fold shape.broadcast with scalar operands.

LGTM otherwise

Jul 15 2020, 8:50 AM · Restricted Project
tpopp added inline comments to D83854: [mlir][shape] Fold shape.broadcast with scalar operands.
Jul 15 2020, 8:45 AM · Restricted Project

Jul 7 2020

tpopp added inline comments to D83194: [mlir] Add additional Canonicalization of shape.cstr_broadcastable..
Jul 7 2020, 4:57 AM · Restricted Project
tpopp updated the diff for D83194: [mlir] Add additional Canonicalization of shape.cstr_broadcastable..

Refactor code. No new behavior was added.

Jul 7 2020, 4:30 AM · Restricted Project

Jul 6 2020

tpopp accepted D83123: [MLIR][Shape] Lower `shape.any`.
Jul 6 2020, 2:46 AM · Restricted Project
Herald added a project to D83194: [mlir] Add additional Canonicalization of shape.cstr_broadcastable.: Restricted Project.
Jul 6 2020, 1:44 AM · Restricted Project

Jul 1 2020

tpopp resigned from D82676: [CGP] Prevent optimizePhiType from iterating forever.

Thank you for handling this case and the patience in waiting for the reproducer when I originally rolled this back. I'm resigning as a reviewer just to make it clear that I'm not qualified to review this change.

Jul 1 2020, 3:11 AM · Restricted Project

Jun 30 2020

tpopp added inline comments to D82803: Create the MLIR Reduce framework.
Jun 30 2020, 7:33 AM · Restricted Project

Jun 23 2020

tpopp added a comment to D81827: [CGP] Convert phi types.

I'm trying to get some help from more experienced coworkers in California side to see how I could help prove this. I also was off in the 2x slowdown. Compilation of one object file is taking slightly under 3x longer and then being stopped by a timeout in infrastructure that I haven't yet found a workaround for. I'm looking into some parts to see if maybe there's an infinite loop while waiting for insights from others.

Jun 23 2020, 6:21 AM · Restricted Project

Jun 22 2020

tpopp added a comment to D81827: [CGP] Convert phi types.

I reverted the follow up change that enabled this pass as it is causing 2x slowdowns on compilation of some large binaries at Google and assume that it will be affecting others also. It looked maybe related to ThinLTO, but I don't know if that's relevant or not.

Jun 22 2020, 4:16 AM · Restricted Project

Jun 18 2020

tpopp updated the diff for D81560: [mlir] Add a pass to remove all shape.cstr_ and assuming_ ops..

Add some tests for individual ops.

Jun 18 2020, 4:18 AM · Restricted Project
tpopp added a comment to D81560: [mlir] Add a pass to remove all shape.cstr_ and assuming_ ops..

I'm going to land this, as I handled Sean's comment, so there doesn't seem to be anything contentious left.

Jun 18 2020, 4:18 AM · Restricted Project

Jun 17 2020

tpopp added inline comments to D81560: [mlir] Add a pass to remove all shape.cstr_ and assuming_ ops..
Jun 17 2020, 8:03 AM · Restricted Project
tpopp updated the diff for D81560: [mlir] Add a pass to remove all shape.cstr_ and assuming_ ops..

Change constraint remove to replace cstr_ ops with passing witnesses.

Jun 17 2020, 8:03 AM · Restricted Project

Jun 15 2020

tpopp added a comment to D81560: [mlir] Add a pass to remove all shape.cstr_ and assuming_ ops..

I haven't finished handling Sean's comment, but wanted to share my thoughts and pieces so far.

Jun 15 2020, 10:23 AM · Restricted Project
tpopp updated the diff for D81560: [mlir] Add a pass to remove all shape.cstr_ and assuming_ ops..

Match MLIR style.

Jun 15 2020, 10:23 AM · Restricted Project

Jun 10 2020

tpopp created D81560: [mlir] Add a pass to remove all shape.cstr_ and assuming_ ops..
Jun 10 2020, 5:58 AM · Restricted Project

Jun 9 2020

tpopp added a comment to D81431: Added number of operands verification for shape.assuming_all operation..

I think you might have deleted your changes to ShapeOps.td, but that might also be me getting confused by this website.

Jun 9 2020, 12:30 AM · Restricted Project

Jun 6 2020

tpopp added a comment to D81283: [mlir] Fix a build error and a warning in mlir.

As more people are complaining, I'm going ahead and reverting the CLs that added and rely on this new file.

Jun 6 2020, 2:38 AM · Restricted Project
tpopp created D81328: [mlir] Restructure Shape dialect's CMakeLists..
Jun 6 2020, 1:34 AM · Restricted Project
tpopp added a comment to D81283: [mlir] Fix a build error and a warning in mlir.

First, sorry for the breakage.

Jun 6 2020, 1:34 AM · Restricted Project

Jun 5 2020

tpopp created D81245: [mlir] Move attr-dict to end of Shape dialect ops.
Jun 5 2020, 2:42 AM · Restricted Project

Jun 4 2020

tpopp added inline comments to D80305: [mlir] Add folding for shape.any.
Jun 4 2020, 8:12 AM · Restricted Project, Restricted Project
tpopp added inline comments to D80304: [mlir] Canonicalization of shape.cstr_broadcastable.
Jun 4 2020, 8:12 AM · Restricted Project, Restricted Project
tpopp updated the diff for D80303: [mlir] Canonicaliztion of shape.cstr_eq.

Replace with folding and handle non-const but equal inputs.

Jun 4 2020, 8:12 AM · Restricted Project, Restricted Project
tpopp updated the diff for D80302: [mlir] Canonicalization of shape.assuming.

Rename variables.

Jun 4 2020, 8:12 AM · Restricted Project, Restricted Project
tpopp updated the diff for D80305: [mlir] Add folding for shape.any.

Explain commutativity of any.

Jun 4 2020, 8:12 AM · Restricted Project, Restricted Project
tpopp updated the diff for D80304: [mlir] Canonicalization of shape.cstr_broadcastable.

Switch to folding and also handle repeated inputs.

Jun 4 2020, 8:12 AM · Restricted Project, Restricted Project
tpopp updated the diff for D80306: [mlir] Canonicalization of shape.assuming_all.

Instead of canonicalization, use folding.

Jun 4 2020, 8:12 AM · Restricted Project, Restricted Project
tpopp updated the diff for D80307: [mlir] Add a shape op that always returns a successful witness.

Instead of true_witness, have const_witness that can be true or false.

Jun 4 2020, 8:12 AM · Restricted Project, Restricted Project

May 29 2020

tpopp abandoned D80189: [mlir] Add canonicalization for Cstr and Assuming Shape Ops..
May 29 2020, 3:45 AM · Restricted Project

May 25 2020

tpopp added inline comments to D80394: Add `shape.get_extent`..
May 25 2020, 1:34 AM · Restricted Project
tpopp added a comment to D80394: Add `shape.get_extent`..

Just a note of a typo in your commit message "sahpe". I see you updated the diff with an updated commit message, so I'm guessing it's fixed, but arc doesn't propagate updated commit messages unfortunately.

May 25 2020, 1:02 AM · Restricted Project

May 20 2020

tpopp updated the diff for D80307: [mlir] Add a shape op that always returns a successful witness.

Remove named TODO.

May 20 2020, 9:48 AM · Restricted Project, Restricted Project
tpopp added a reviewer for D80302: [mlir] Canonicalization of shape.assuming: herhut.
May 20 2020, 9:16 AM · Restricted Project, Restricted Project
tpopp added a reviewer for D80303: [mlir] Canonicaliztion of shape.cstr_eq: herhut.
May 20 2020, 9:16 AM · Restricted Project, Restricted Project
tpopp added a reviewer for D80304: [mlir] Canonicalization of shape.cstr_broadcastable: herhut.
May 20 2020, 9:16 AM · Restricted Project, Restricted Project
tpopp added a reviewer for D80305: [mlir] Add folding for shape.any: herhut.
May 20 2020, 9:16 AM · Restricted Project, Restricted Project
tpopp added a reviewer for D80306: [mlir] Canonicalization of shape.assuming_all: herhut.
May 20 2020, 9:16 AM · Restricted Project, Restricted Project
tpopp added a comment to D80189: [mlir] Add canonicalization for Cstr and Assuming Shape Ops..

I split this commit up into smaller pieces.

May 20 2020, 9:16 AM · Restricted Project
tpopp added a reviewer for D80307: [mlir] Add a shape op that always returns a successful witness: herhut.
May 20 2020, 9:16 AM · Restricted Project, Restricted Project
tpopp created D80305: [mlir] Add folding for shape.any.
May 20 2020, 9:16 AM · Restricted Project, Restricted Project
tpopp created D80307: [mlir] Add a shape op that always returns a successful witness.
May 20 2020, 9:16 AM · Restricted Project, Restricted Project
tpopp created D80303: [mlir] Canonicaliztion of shape.cstr_eq.
May 20 2020, 9:16 AM · Restricted Project, Restricted Project
tpopp created D80304: [mlir] Canonicalization of shape.cstr_broadcastable.
May 20 2020, 9:16 AM · Restricted Project, Restricted Project
tpopp created D80302: [mlir] Canonicalization of shape.assuming.
May 20 2020, 9:16 AM · Restricted Project, Restricted Project
tpopp created D80306: [mlir] Canonicalization of shape.assuming_all.
May 20 2020, 9:16 AM · Restricted Project, Restricted Project
tpopp added a comment to D80180: [mlir] Add custom assembly formats to shape.witness ops..

@silvas I was going to wait because you hadn't accepted the commit, but because (1) I am not working the next 4 days and (2) have other commits using these operations, I'm going to submit this, but can follow up on any other feedback.

May 20 2020, 4:51 AM · Restricted Project
tpopp updated the diff for D80180: [mlir] Add custom assembly formats to shape.witness ops..

Match example code in documentation to the actual custom form.

May 20 2020, 3:12 AM · Restricted Project
tpopp updated the diff for D80180: [mlir] Add custom assembly formats to shape.witness ops..

Remove parantheses

May 20 2020, 2:07 AM · Restricted Project
tpopp added inline comments to D80179: [mlir] Mark witness related Shape dialect ops as NoSideEffect..
May 20 2020, 1:35 AM · Restricted Project

May 19 2020

tpopp created D80189: [mlir] Add canonicalization for Cstr and Assuming Shape Ops..
May 19 2020, 1:36 AM · Restricted Project
tpopp created D80187: [mlir] Custom printing/parsing for Shape::AssumingOp.
May 19 2020, 12:30 AM · Restricted Project

May 18 2020

tpopp created D80180: [mlir] Add custom assembly formats to shape.witness ops..
May 18 2020, 9:40 PM · Restricted Project
tpopp created D80179: [mlir] Mark witness related Shape dialect ops as NoSideEffect..
May 18 2020, 9:40 PM · Restricted Project

May 15 2020

tpopp added inline comments to D79717: [MLIR] Add shape.witness type and ops.
May 15 2020, 2:19 AM · Restricted Project
tpopp updated the diff for D79717: [MLIR] Add shape.witness type and ops.

Update op descriptions and test based on feedback.

May 15 2020, 2:19 AM · Restricted Project

May 12 2020

tpopp updated the diff for D79717: [MLIR] Add shape.witness type and ops.

Update descriptions of operations.

May 12 2020, 6:24 AM · Restricted Project

May 11 2020

tpopp added a comment to D79717: [MLIR] Add shape.witness type and ops.

Please don't review yet. This is a work in progress including the op definitions.

May 11 2020, 8:01 AM · Restricted Project
tpopp created D79717: [MLIR] Add shape.witness type and ops.
May 11 2020, 8:01 AM · Restricted Project

Apr 30 2020

tpopp updated the diff for D79088: [MLIR] Add isa<> support for Dialects..

Remove newline.

Apr 30 2020, 2:25 AM · Restricted Project

Apr 29 2020

tpopp created D79088: [MLIR] Add isa<> support for Dialects..
Apr 29 2020, 6:56 AM · Restricted Project

Apr 28 2020

tpopp added a comment to D78381: [libc++] Create a small DSL for defining Lit features and parameters.

I'm going to go ahead and ship this now so I can see whether it breaks anything.

This breaks Fedora 32 (x86_64) building with the system clang/lld (version 10.0):

[0+1] Running all regression tests
llvm-lit: /home/dave/s/lp/libcxxabi/test/lit.cfg:64: note: Using configuration variant: libcxxabi
llvm-lit: /home/dave/s/lp/libcxx/utils/libcxx/test/config.py:307: note: inferred use_system_cxx_lib as: None
llvm-lit: /home/dave/s/lp/libcxx/utils/libcxx/test/config.py:333: note: inferred use_clang_verify as: True
llvm-lit: /home/dave/s/lp/libcxx/utils/libcxx/test/config.py:342: note: enabling thread-safety annotations
llvm-lit: /home/dave/s/lp/libcxx/utils/libcxx/test/config.py:487: note: inferred language dialect as: c++2a
llvm-lit: /home/dave/s/lp/libcxx/utils/libcxx/test/target_info.py:84: warning: The locale fr_FR.UTF-8 is not supported by your platform. Some tests will be unsupported.
llvm-lit: /home/dave/s/lp/libcxx/utils/libcxx/test/target_info.py:84: warning: The locale ru_RU.UTF-8 is not supported by your platform. Some tests will be unsupported.
llvm-lit: /home/dave/s/lp/libcxx/utils/libcxx/test/target_info.py:84: warning: The locale zh_CN.UTF-8 is not supported by your platform. Some tests will be unsupported.
llvm-lit: /home/dave/s/lp/libcxx/utils/libcxx/test/target_info.py:84: warning: The locale fr_CA.ISO8859-1 is not supported by your platform. Some tests will be unsupported.
llvm-lit: /home/dave/s/lp/libcxx/utils/libcxx/test/target_info.py:84: warning: The locale cs_CZ.ISO8859-2 is not supported by your platform. Some tests will be unsupported.
llvm-lit: /home/dave/s/lp/libcxx/utils/libcxx/test/config.py:389: note: inferred long_tests as: True
llvm-lit: /home/dave/s/lp/libcxx/utils/libcxx/test/config.py:153: note: Using compiler: /usr/bin/clang++
llvm-lit: /home/dave/s/lp/libcxx/utils/libcxx/test/config.py:154: note: Using flags: ['-v']
llvm-lit: /home/dave/s/lp/libcxx/utils/libcxx/test/config.py:158: note: Using compile flags: ['-Werror=thread-safety', '-DLIBCXXABI_NO_TIMER', '-D_LIBCPP_ENABLE_CXX17_REMOVED_UNEXPECTED_FUNCTIONS', '-funwind-tables', '-std=c++2a', '-nostdinc++', '-I/home/dave/s/lp/libcxx/include', '-I/home/dave/s/lp/libcxxabi/include', '-DSTDC_FORMAT_MACROS', '-DSTDC_LIMIT_MACROS', '-DSTDC_CONSTANT_MACROS', '-I/home/dave/s/lp/libcxx/test/support', '-ftemplate-depth=270']
llvm-lit: /home/dave/s/lp/libcxx/utils/libcxx/test/config.py:161: note: Using warnings: ['-Wall', '-Wextra', '-D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER', '-Wuser-defined-warnings', '-Wshadow', '-Wno-unused-command-line-argument', '-Wno-attributes', '-Wno-pessimizing-move', '-Wno-c++11-extensions', '-Wno-user-defined-literals', '-Wno-noexcept-type', '-Wsign-compare', '-Wunused-variable', '-Wunused-parameter', '-Wunreachable-code', '-Wno-unused-local-typedef']
llvm-lit: /home/dave/s/lp/libcxx/utils/libcxx/test/config.py:162: note: Using link flags: ['-L/tmp/_update_lc/r/./lib64', '-Wl,-rpath,/tmp/_update_lc/r/./lib64', '-L/tmp/_update_lc/r/./lib64', '-Wl,-rpath,/tmp/_update_lc/r/./lib64', '-nodefaultlibs', '/tmp/_update_lc/r/./lib64/libc++.a', '/tmp/_update_lc/r/./lib64/libc++abi.a', '-lm', '-lgcc_s', '-lgcc', '-lpthread', '-lrt', '-lc', '-lgcc_s', '-lgcc']
llvm-lit: /home/dave/s/lp/libcxx/utils/libcxx/test/config.py:164: note: Using available_features: ['long_tests', 'fdelayed-template-parsing', 'libc++', 'c++2a', 'diagnose-if-support', 'has-fblocks', '-faligned-allocation', 'clang-10', 'clang', 'locale.en_US.UTF-8', 'linux', 'clang-10.0.0', '-fsized-deallocation', 'thread-safety', 'libcxxabi-has-system-unwinder', 'fcoroutines-ts', 'modules-support', 'clang-10.0']
llvm-lit: /home/dave/s/lp/libcxx/utils/libcxx/test/config.py:170: note: Adding environment variables: {}
llvm-lit: /home/dave/s/lp/libcxxabi/test/lit.cfg:77: note: Using the new libc++ testing format
llvm-lit: /home/dave/s/lp/libcxx/test/lit.cfg:49: note: Using configuration variant: libcxx
llvm-lit: /home/dave/s/lp/libcxx/utils/libcxx/test/config.py:307: note: inferred use_system_cxx_lib as: None
llvm-lit: /home/dave/s/lp/libcxx/utils/libcxx/test/config.py:333: note: inferred use_clang_verify as: True
llvm-lit: /home/dave/s/lp/libcxx/utils/libcxx/test/config.py:342: note: enabling thread-safety annotations
llvm-lit: /home/dave/s/lp/libcxx/utils/libcxx/test/config.py:487: note: inferred language dialect as: c++2a
llvm-lit: /home/dave/s/lp/libcxx/utils/libcxx/test/target_info.py:84: warning: The locale fr_FR.UTF-8 is not supported by your platform. Some tests will be unsupported.
llvm-lit: /home/dave/s/lp/libcxx/utils/libcxx/test/target_info.py:84: warning: The locale ru_RU.UTF-8 is not supported by your platform. Some tests will be unsupported.
llvm-lit: /home/dave/s/lp/libcxx/utils/libcxx/test/target_info.py:84: warning: The locale zh_CN.UTF-8 is not supported by your platform. Some tests will be unsupported.
llvm-lit: /home/dave/s/lp/libcxx/utils/libcxx/test/target_info.py:84: warning: The locale fr_CA.ISO8859-1 is not supported by your platform. Some tests will be unsupported.
llvm-lit: /home/dave/s/lp/libcxx/utils/libcxx/test/target_info.py:84: warning: The locale cs_CZ.ISO8859-2 is not supported by your platform. Some tests will be unsupported.
llvm-lit: /home/dave/s/lp/libcxx/utils/libcxx/test/config.py:389: note: inferred long_tests as: True
llvm-lit: /home/dave/s/lp/libcxx/utils/libcxx/test/config.py:153: note: Using compiler: /usr/bin/clang++
llvm-lit: /home/dave/s/lp/libcxx/utils/libcxx/test/config.py:154: note: Using flags: ['-v']
llvm-lit: /home/dave/s/lp/libcxx/utils/libcxx/test/config.py:158: note: Using compile flags: ['-Werror=thread-safety', '-std=c++2a', '-include', '/home/dave/s/lp/libcxx/test/support/nasty_macros.h', '-nostdinc++', '-I/home/dave/s/lp/libcxx/include', '-I/tmp/_update_lc/r/projects/libcxx/include/c++build', '-D
STDC_FORMAT_MACROS', '-DSTDC_LIMIT_MACROS', '-DSTDC_CONSTANT_MACROS', '-I/home/dave/s/lp/libcxx/test/support', '-ftemplate-depth=270']
llvm-lit: /home/dave/s/lp/libcxx/utils/libcxx/test/config.py:161: note: Using warnings: ['-Wall', '-Wextra', '-D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER', '-Wuser-defined-warnings', '-Wshadow', '-Wno-unused-command-line-argument', '-Wno-attributes', '-Wno-pessimizing-move', '-Wno-c++11-extensions', '-Wno-user-defined-literals', '-Wno-noexcept-type', '-Wsign-compare', '-Wunused-variable', '-Wunused-parameter', '-Wunreachable-code', '-Wno-unused-local-typedef']
llvm-lit: /home/dave/s/lp/libcxx/utils/libcxx/test/config.py:162: note: Using link flags: ['-L/tmp/_update_lc/r/./lib64', '-Wl,-rpath,/tmp/_update_lc/r/./lib64', '-nodefaultlibs', '-lc++experimental', '/tmp/_update_lc/r/./lib64/libc++.a', '-lc++abi', '-lm', '-lgcc_s', '-lgcc', '-lpthread', '-lrt', '-lc', '-lgcc_s', '-lgcc']
llvm-lit: /home/dave/s/lp/libcxx/utils/libcxx/test/config.py:164: note: Using available_features: ['modules-support', 'clang-10.0', 'fdelayed-template-parsing', 'diagnose-if-support', 'has-fblocks', 'clang-10', 'libatomic', '-faligned-allocation', 'clang', 'locale.en_US.UTF-8', 'c++experimental', 'long_tests', 'libc++', 'c++2a', 'linux', 'clang-10.0.0', 'thread-safety', 'fcoroutines-ts', '-fsized-deallocation']
llvm-lit: /home/dave/s/lp/libcxx/utils/libcxx/test/config.py:170: note: Adding environment variables: {}
llvm-lit: /home/dave/s/lp/libcxx/test/lit.cfg:62: note: Using the new libc++ testing format
llvm-lit: /tmp/_update_lc/r/bin/../../../../home/dave/s/lp/llvm/utils/lit/lit/TestingConfig.py:100: fatal: unable to parse config file '/home/dave/s/lp/libcxx/test/libcxx/selftest/dsl/lit.local.cfg', traceback: Traceback (most recent call last):

File "/tmp/_update_lc/r/bin/../../../../home/dave/s/lp/llvm/utils/lit/lit/TestingConfig.py", line 89, in load_from_path
  exec(compile(data, path, 'exec'), cfg_globals, None)
File "/home/dave/s/lp/libcxx/test/libcxx/selftest/dsl/lit.local.cfg", line 13, in <module>
  escaped = [(k.replace('%{', '%{escaped_'), base64.b64encode(v)) for (k, v) in config.substitutions]
File "/home/dave/s/lp/libcxx/test/libcxx/selftest/dsl/lit.local.cfg", line 13, in <listcomp>
  escaped = [(k.replace('%{', '%{escaped_'), base64.b64encode(v)) for (k, v) in config.substitutions]
File "/usr/lib64/python3.8/base64.py", line 58, in b64encode
  encoded = binascii.b2a_base64(s, newline=False)

TypeError: a bytes-like object is required, not 'str'

FAILED: CMakeFiles/check-all

Apr 28 2020, 4:47 AM · Restricted Project
tpopp updated the diff for D78930: [MLIR] Give AffineStoreOp and AffineLoadOp Memory SideEffects..

Reorder definition of ops and handle a rebase.

Apr 28 2020, 2:07 AM · Restricted Project

Apr 27 2020

tpopp created D78930: [MLIR] Give AffineStoreOp and AffineLoadOp Memory SideEffects..
Apr 27 2020, 8:01 AM · Restricted Project
tpopp created D78914: [MLIR][NFC] Organize the ordering in LLVM.h.
Apr 27 2020, 4:15 AM · Restricted Project
tpopp added a comment to D78802: [MLIR] Propagate input side effect information.

The failing tests seem to have just been failing at head. Failures now are just from the clang-tidy warning of a Twine being used.

Apr 27 2020, 2:38 AM · Restricted Project
tpopp added inline comments to D78802: [MLIR] Propagate input side effect information.
Apr 27 2020, 1:33 AM · Restricted Project
tpopp updated the diff for D78802: [MLIR] Propagate input side effect information.

std::move last use of string.

Apr 27 2020, 1:33 AM · Restricted Project

Apr 24 2020

tpopp updated the diff for D78802: [MLIR] Propagate input side effect information.

Update variable names to llvm style.

Apr 24 2020, 8:04 AM · Restricted Project
tpopp updated the diff for D78803: [MLIR] Remove document references to gpu.kernel_module and gpu.kernel..

Update comment on the kernel attribute of gpu.launch_func.

Apr 24 2020, 7:32 AM · Restricted Project
tpopp created D78803: [MLIR] Remove document references to gpu.kernel_module and gpu.kernel..
Apr 24 2020, 3:45 AM · Restricted Project
tpopp updated the diff for D78707: [MLIR] Add RecursiveSideEffects to Loops::ParallelOp..

Creating a new revision to confirm that build failures were unrelated to my change.

Apr 24 2020, 3:13 AM · Restricted Project
tpopp added a reviewer for D78802: [MLIR] Propagate input side effect information: rriddle.
Apr 24 2020, 3:13 AM · Restricted Project
Herald added a reviewer for D78802: [MLIR] Propagate input side effect information: herhut.
Apr 24 2020, 3:13 AM · Restricted Project

Apr 23 2020

tpopp accepted D78727: [mlir][StandardToSPIRV] Fix test cases where DCE removes all the code..

Thank you for the quick solution!

Apr 23 2020, 9:43 AM · Restricted Project
tpopp created D78707: [MLIR] Add RecursiveSideEffects to Loops::ParallelOp..
Apr 23 2020, 5:21 AM · Restricted Project

Apr 14 2020

tpopp updated the diff for D77723: [MLIR] Constant fold multiplies in deriveStaticUpperBound..

Replace some types with auto.

Apr 14 2020, 2:37 AM · Restricted Project

Apr 8 2020

tpopp created D77723: [MLIR] Constant fold multiplies in deriveStaticUpperBound..
Apr 8 2020, 5:55 AM · Restricted Project

Apr 1 2020

tpopp added a comment to D77128: [MLIR] Implement LoopLikeInterface for loop.parallel.

Uday, I landed this thinking you were doing more of a drive-by review, but I'll do a follow up commit if you have any more concerns.

Apr 1 2020, 8:14 AM · Restricted Project
tpopp added inline comments to D77052: [MLIR] Rename collapsePLoops -> collapseParallelLoops.
Apr 1 2020, 1:36 AM · Restricted Project

Mar 31 2020

tpopp updated the diff for D77128: [MLIR] Implement LoopLikeInterface for loop.parallel.

Update map# on test case to allow splitting of test cases.

Mar 31 2020, 5:31 AM · Restricted Project
tpopp updated the diff for D77060: [MLIR] Replace OpBuilder(Block) with atBlockBegin and atBlockEnd.

Follow naming convention for atBlockBegin and atBlockEnd.

Mar 31 2020, 4:23 AM · Restricted Project
tpopp retitled D77060: [MLIR] Replace OpBuilder(Block) with atBlockBegin and atBlockEnd from [MLIR] Replace OpBuilder(Block) withatBlockBegin and atBlockEnd to [MLIR] Replace OpBuilder(Block) with atBlockBegin and atBlockEnd.
Mar 31 2020, 4:23 AM · Restricted Project
tpopp retitled D77060: [MLIR] Replace OpBuilder(Block) with atBlockBegin and atBlockEnd from [MLIR] Replace OpBuilder(Block) with AtBlockBegin and AtBlockEnd to [MLIR] Replace OpBuilder(Block) withatBlockBegin and atBlockEnd.
Mar 31 2020, 4:23 AM · Restricted Project