Page MenuHomePhabricator

tpopp (Theodore Popp)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 3 2020, 4:17 AM (129 w, 5 d)

Recent Activity

Wed, Jun 1

tpopp accepted D126765: Fix bazel build after 59b273a166b9d1165015b5cf10c21641cc01d682..
Wed, Jun 1, 3:10 AM · Restricted Project, Restricted Project

May 23 2022

tpopp abandoned D123027: [mlir] Support tensor.pad bufferization.
May 23 2022, 7:12 AM · Restricted Project, Restricted Project
tpopp accepted D125636: [mlir][bufferize] Support fully dynamic layout maps in BufferResultsToOutParams.
May 23 2022, 3:43 AM · Restricted Project, Restricted Project

May 20 2022

tpopp accepted D125637: [mlir][bufferize][NFC] Update One-Shot Bufferize pass documentation.
May 20 2022, 3:19 AM · Restricted Project, Restricted Project

May 12 2022

tpopp added a comment to D123027: [mlir] Support tensor.pad bufferization.

Sorry to delay on this for so long. I am proposing, instead, a TensorToLinalgPass here: https://reviews.llvm.org/D125384

May 12 2022, 1:19 AM · Restricted Project, Restricted Project

May 11 2022

tpopp accepted D125376: [mlir][bufferize] Support alloc hoisting across function boundaries.
May 11 2022, 7:23 AM · Restricted Project, Restricted Project
tpopp accepted D125375: [mlir][bufferize][NFC] Move helper functions to BufferizationOptions.
May 11 2022, 6:55 AM · Restricted Project, Restricted Project
tpopp requested review of D125384: [mlir] Add TensorToLinalgPass.
May 11 2022, 6:40 AM · Restricted Project, Restricted Project

May 9 2022

tpopp accepted D125093: [mlir][math] Promote (b)f16 to f32 when lowering to libm calls.
May 9 2022, 1:19 AM · Restricted Project, Restricted Project

May 4 2022

tpopp added a comment to D124649: [AsmParser] Introduce a new "Argument" abstraction + supporting logic.

Hello, why were parseOptionalAssignmentListWithTypesand parseAssignmentListWithTypes removed?

This was simply dead code in the tree. I'm sorry I didn't realize other people were using it, I didn't mean to break anyone intentionally. There is a simple replacement with parseArgument and parse comma separated list, though we could add back if it would help with your internal build and integration for awhile.

-Chris

May 4 2022, 7:00 AM · Restricted Project, Restricted Project, Restricted Project

May 2 2022

tpopp added a comment to D124649: [AsmParser] Introduce a new "Argument" abstraction + supporting logic.

Hello, why were parseOptionalAssignmentListWithTypesand parseAssignmentListWithTypes removed? This seems to be a common pattern in MLIR where functionality is provided but untested and unused inside of core and then freely removed while breaking users. If this is the intended progression of the API, a deprecation would be appreciated, so people can raise concerns that used functionality is being deleted. If this being freely removed because users of the code outside of the LLVM repository don't impact this decision, it really indicates that MLIR core needs to start providing some form of a stable API that people can rely on rather than the current (small) chaos caused by many changes.

May 2 2022, 12:24 AM · Restricted Project, Restricted Project, Restricted Project

Apr 4 2022

tpopp requested review of D123027: [mlir] Support tensor.pad bufferization.
Apr 4 2022, 6:07 AM · Restricted Project, Restricted Project

Mar 30 2022

tpopp accepted D122649: [mlir][tensor] Fix bufferization of CollapseShapeOp / ExpandShapeOp.
Mar 30 2022, 1:26 AM · Restricted Project, Restricted Project

Mar 8 2022

tpopp added inline comments to D121189: [mlir][NFC] Update the Builtin dialect to use "Both" accessors.
Mar 8 2022, 11:28 PM · Restricted Project, Restricted Project, Restricted Project
tpopp added inline comments to D121189: [mlir][NFC] Update the Builtin dialect to use "Both" accessors.
Mar 8 2022, 6:49 AM · Restricted Project, Restricted Project, Restricted Project

Feb 18 2022

tpopp added a comment to D120021: Rename PatternRewriteSet::insert to add.

Landing now instead as it is low risk, and I mainly wanted to confirm with River.

Feb 18 2022, 3:19 AM · Restricted Project
tpopp added a comment to D120021: Rename PatternRewriteSet::insert to add.

I'll leave this until Monday to submit in case the comment in code that insert is soft deprecated is out of date.

Feb 18 2022, 12:21 AM · Restricted Project

Feb 17 2022

tpopp updated the diff for D120020: [mlir] Propagate NaNs in PolynomialApproximation.

Update test cases

Feb 17 2022, 1:42 AM · Restricted Project
tpopp requested review of D120021: Rename PatternRewriteSet::insert to add.
Feb 17 2022, 1:28 AM · Restricted Project
tpopp requested review of D120020: [mlir] Propagate NaNs in PolynomialApproximation.
Feb 17 2022, 1:23 AM · Restricted Project

Feb 10 2022

tpopp added a comment to D119402: [MLIR] Fix fold-memref-subview-ops for affine.load/store.

Clang documentation for ASAN, as I feel like everyone has different flows for using it: https://clang.llvm.org/docs/AddressSanitizer.html

Feb 10 2022, 1:51 AM · Restricted Project
tpopp added a comment to D119402: [MLIR] Fix fold-memref-subview-ops for affine.load/store.

I am reverting this change as it has a stack-use-after-scope error. I suspect this is due to the call to expandAffineMap returning a SmallVector which is then referenced with the ValueRange indices inside of the if block and then used outside.

Feb 10 2022, 1:48 AM · Restricted Project

Feb 8 2022

tpopp added a comment to D119065: [mlir][NFC] Remove deprecated/old build/fold/parser utilities from OpDefinition.

Hi, I added a fix forward for this change, as a rollback was hard due to another change, but it would be ideal to confirm that it is okay, as I'm not sure exactly what you were going for: https://github.com/llvm/llvm-project/commit/64b918852c09db6461d4c4c97df288c7b7fee865

Feb 8 2022, 2:22 AM · Restricted Project, Restricted Project

Dec 15 2021

tpopp requested review of D115789: [mlir] Use rewriter in linalg Detensorize.
Dec 15 2021, 2:09 AM · Restricted Project

Nov 24 2021

tpopp added a comment to D114358: Don't store nullptrs in mlir::FuncOp::getAllArgAttrs' result.

Was the patch updated?

Nov 24 2021, 1:55 AM · Restricted Project
tpopp updated the diff for D114358: Don't store nullptrs in mlir::FuncOp::getAllArgAttrs' result.

Store empty attributes instead of nullptrs.

Nov 24 2021, 1:53 AM · Restricted Project

Nov 23 2021

tpopp added inline comments to D114358: Don't store nullptrs in mlir::FuncOp::getAllArgAttrs' result.
Nov 23 2021, 12:02 AM · Restricted Project

Nov 22 2021

tpopp requested review of D114358: Don't store nullptrs in mlir::FuncOp::getAllArgAttrs' result.
Nov 22 2021, 3:57 AM · Restricted Project
tpopp added inline comments to D114065: [Bazel] Set the right default for LLVM_WINDOWS_PREFER_FORWARD_SLASH on Windows.
Nov 22 2021, 1:56 AM · Restricted Project
tpopp requested review of D114352: Rename MlirExecutionEngine lookup to lookupPacked.
Nov 22 2021, 1:53 AM · Restricted Project

Nov 2 2021

tpopp added a comment to D87202: Add new choices dot-cfg and dot-cfg-quiet to print-changed which creates a website of DOT files showing colourized changes as the IR is changed by passes in the new pass manager pipeline..

Hi @tpopp, can you please explain to me the nature of these failures? The code changed here is only active under options that are not being used in those tests so I expect that the errors are unrelated. I have not received any notifications from the build-bots of a problem so far. I am also unclear as to why there are build issues on those other platforms. Are you asking me to revert this?

Nov 2 2021, 10:28 AM · Restricted Project
tpopp added a comment to D87202: Add new choices dot-cfg and dot-cfg-quiet to print-changed which creates a website of DOT files showing colourized changes as the IR is changed by passes in the new pass manager pipeline..

Hi Jamie, this code has test failures: https://reviews.llvm.org/B131761

Nov 2 2021, 10:00 AM · Restricted Project

Oct 1 2021

tpopp accepted D110919: [mlir] Enable loop peeling for "reduction" dimensions of tiled_loop..
Oct 1 2021, 4:07 AM · Restricted Project

Sep 6 2021

tpopp accepted D109247: [mlir][linalg] Fix `FoldInitTensorWithDimOp` if dim(init_tensor) is static..
Sep 6 2021, 1:37 AM · Restricted Project

Sep 3 2021

tpopp accepted D109230: [mlir][linalg] Extend tiled_loop to SCF conversion to generate scf.parallel..
Sep 3 2021, 8:52 AM · Restricted Project
tpopp added a comment to D108270: [mlir][linalg] linalg.tiled_loop peeling.

Drive by comment

Sep 3 2021, 8:44 AM · Restricted Project
tpopp added inline comments to D109230: [mlir][linalg] Extend tiled_loop to SCF conversion to generate scf.parallel..
Sep 3 2021, 8:25 AM · Restricted Project

Sep 2 2021

tpopp accepted D109140: [mlir][linalg] Expose function to create op on buffers during bufferization..
Sep 2 2021, 2:01 AM · Restricted Project

Aug 25 2021

tpopp updated the diff for D108205: [mlir] Prevent assertion failure in DropUnitDims.

Move the unsupported logic to the caller.

Aug 25 2021, 8:49 AM · Restricted Project
tpopp added inline comments to D108205: [mlir] Prevent assertion failure in DropUnitDims.
Aug 25 2021, 8:49 AM · Restricted Project
tpopp abandoned D108561: [mlir] Handle null attributes on TiledLoopOp creation..

I've been somewhat convinced that this could lead to subtle bugs in the future, so we should leave it to the callers to handle this issue each time they want to build this op during dialect conversion, so I'm going to abandon this.

Aug 25 2021, 7:34 AM · Restricted Project
tpopp updated the diff for D108570: [mlir] Add assertions to prevent adding null attributes.

Move assertions to NamedAttrList::push_back

Aug 25 2021, 2:06 AM · Restricted Project

Aug 24 2021

tpopp updated the diff for D108570: [mlir] Add assertions to prevent adding null attributes.

Move the assertion logic to NamedAttrList.

Aug 24 2021, 6:31 AM · Restricted Project
tpopp added inline comments to D108570: [mlir] Add assertions to prevent adding null attributes.
Aug 24 2021, 6:30 AM · Restricted Project
tpopp added inline comments to D108561: [mlir] Handle null attributes on TiledLoopOp creation..
Aug 24 2021, 6:00 AM · Restricted Project

Aug 23 2021

tpopp requested review of D108570: [mlir] Add assertions to prevent adding null attributes.
Aug 23 2021, 11:26 AM · Restricted Project
tpopp requested review of D108561: [mlir] Handle null attributes on TiledLoopOp creation..
Aug 23 2021, 8:51 AM · Restricted Project
tpopp added a reviewer for D108205: [mlir] Prevent assertion failure in DropUnitDims: gysit.
Aug 23 2021, 8:11 AM · Restricted Project

Aug 18 2021

tpopp added inline comments to D108205: [mlir] Prevent assertion failure in DropUnitDims.
Aug 18 2021, 12:32 AM · Restricted Project

Aug 17 2021

tpopp requested review of D108205: [mlir] Prevent assertion failure in DropUnitDims.
Aug 17 2021, 6:33 AM · Restricted Project

Aug 13 2021

tpopp added a comment to D107818: [mlir] Set top-down traversal for LinalgElementwiseOpFusion.

Friendly ping on this

Aug 13 2021, 7:48 AM · Restricted Project
tpopp accepted D108017: [clang] Adjust BUILD.bazel file to also generate AttrDocTable..
Aug 13 2021, 12:20 AM · Restricted Project

Aug 10 2021

tpopp requested review of D107818: [mlir] Set top-down traversal for LinalgElementwiseOpFusion.
Aug 10 2021, 5:07 AM · Restricted Project

Aug 9 2021

tpopp requested review of D107754: [mlir] NFC Replace some code snippets with equivalent method calls.
Aug 9 2021, 4:21 AM · Restricted Project

Jul 28 2021

tpopp added a comment to D106762: [AArch64][GlobalISel] Enable some select combines after legalization.

Ok, should be fixed in a11d9a1f480f.

Jul 28 2021, 1:48 AM · Restricted Project
tpopp added a comment to rGd7bbb1230a94: Revert "[X86][AVX] Add getBROADCAST_LOAD helper function. NFCI.".

I apologize for not providing one at the beginning. Following is the IR and an LLC command that resulted in SelectionDAGISel failing: https://reviews.llvm.org/P8269

Jul 28 2021, 1:48 AM

Jul 27 2021

tpopp added a comment to D106762: [AArch64][GlobalISel] Enable some select combines after legalization.

An important piece of information: this seems to happen only with assertions disabled (-DLLVM_ENABLE_ASSERTIONS=OFF)

Jul 27 2021, 6:54 AM · Restricted Project
tpopp added a comment to D106762: [AArch64][GlobalISel] Enable some select combines after legalization.

Hello, unless I'm mistaken, this is breaking CodeGen/AArch64/arm64-ldxr-stxr.ll. Can you confirm if that's correct and rollback this commit until it's fixed?

Jul 27 2021, 6:25 AM · Restricted Project

Jul 12 2021

tpopp accepted D105813: MLIR] Fix documentation of the `ExecutionEngine` in the toy tutorial example.
Jul 12 2021, 7:22 AM · Restricted Project

Jun 14 2021

tpopp updated the diff for D103513: Support buffers in LinalgFoldUnitExtentDims.

Rebase, add tests, and extract reshape logic into separate methods.

Jun 14 2021, 2:58 AM · Restricted Project

Jun 13 2021

tpopp accepted D104103: [mlir] Remove traits that require vector type support from ops in Complex dialect..
Jun 13 2021, 9:58 PM · Restricted Project

Jun 7 2021

tpopp updated the diff for D103513: Support buffers in LinalgFoldUnitExtentDims.

Create a single method to support both Tensor and MemRef operands.

Jun 7 2021, 3:08 AM · Restricted Project
tpopp added a comment to D103513: Support buffers in LinalgFoldUnitExtentDims.

Have a comment above (clicked enter early there). Will review more, but if we are going down this path, do we just replicate all the tests here for tensors with memrefs as well?

Jun 7 2021, 3:05 AM · Restricted Project

Jun 2 2021

tpopp added a reviewer for D103513: Support buffers in LinalgFoldUnitExtentDims: mravishankar.
Jun 2 2021, 4:53 AM · Restricted Project
tpopp updated the diff for D103513: Support buffers in LinalgFoldUnitExtentDims.

Update a comment

Jun 2 2021, 4:53 AM · Restricted Project
tpopp requested review of D103513: Support buffers in LinalgFoldUnitExtentDims.
Jun 2 2021, 4:51 AM · Restricted Project

Jun 1 2021

tpopp requested review of D103447: [mlir] Use interfaces in MathToLibm.
Jun 1 2021, 4:04 AM · Restricted Project

May 31 2021

tpopp added a comment to D103388: [mlir][NFC] Remove illegal TanhOp in LLVMConversionTarget.

Do this let us also remove the build/link dependency on the math dialect from this conversion?

May 31 2021, 1:40 AM · Restricted Project

May 30 2021

tpopp requested review of D103388: [mlir][NFC] Remove illegal TanhOp in LLVMConversionTarget.
May 30 2021, 11:42 PM · Restricted Project

May 25 2021

tpopp updated the diff for D102681: [mlir] Support buffer hoisting on allocas.

Remove hoisting of allocas in non-loop cases.

May 25 2021, 5:19 AM · Restricted Project
tpopp requested review of D103076: [mlir] Fold memref.dim of OffsetSizeAndStrideOpInterface outputs.
May 25 2021, 2:38 AM · Restricted Project

May 21 2021

tpopp added inline comments to D102681: [mlir] Support buffer hoisting on allocas.
May 21 2021, 12:16 AM · Restricted Project

May 18 2021

tpopp requested review of D102681: [mlir] Support buffer hoisting on allocas.
May 18 2021, 3:12 AM · Restricted Project

May 11 2021

tpopp updated the diff for D102157: Support VectorTransfer splitting on writes also..

Respond to comments.

May 11 2021, 1:32 AM · Restricted Project

May 10 2021

tpopp requested review of D102157: Support VectorTransfer splitting on writes also..
May 10 2021, 2:12 AM · Restricted Project

May 7 2021

tpopp updated the diff for D100838: [mlir] Split BufferAliasAnalysis into 2 classes.

Change this patch to just a rename and expanded documentation.

May 7 2021, 7:10 AM · Restricted Project

May 6 2021

tpopp added a comment to D100838: [mlir] Split BufferAliasAnalysis into 2 classes.

I have to admit that my comment regarding all aliases of A was a bit misleading :-( At the time of writing, I accidentally had the "flow"-property (required by the BufferDeallocation phase) in mind. My comment was meant to address potentially "inconsistent" results of two "alias analyses" (of course, aliasing is a symmetric property!) :-)

Regarding the name: I really like BufferViewFlowAnalysis, as it expresses the property of data flow between different Value nodes.

This alias analysis should indeed not exist. It is broken in several different ways, and only works now because well.. luck mostly

This also sounds a bit misleading. At the time of implementing, we had to introduce a specialized and domain-specific version that collects all aliases depending on the "flow" of a given value. This analysis was never intended to serve as a universal global program analysis. However, I agree that it might be beneficial to replace this analysis implementation by the ones available right now.

May 6 2021, 6:48 AM · Restricted Project

Apr 30 2021

tpopp added a comment to D100838: [mlir] Split BufferAliasAnalysis into 2 classes.

I agree though that "Dependency" is a bad name. I'm just struggling to find a name to encode this concept of BufferViewFlowAnalysis.

Apr 30 2021, 1:22 AM · Restricted Project
tpopp added a comment to D100838: [mlir] Split BufferAliasAnalysis into 2 classes.

I am not convinced that DependencyAnalysis is the better name here. For dependencies, I think of read-after-write, etc.. This only computes the flow of buffers through control flow.

Apr 30 2021, 1:19 AM · Restricted Project

Apr 29 2021

tpopp added a comment to D97667: [loop-idiom] Hoist loop memcpys to loop preheader.

Describing what the code is intended to do (https://github.com/tensorflow/tensorflow/blob/master/tensorflow/compiler/xla/tests/reverse_test.cc#L146).

Apr 29 2021, 1:37 AM · Restricted Project
tpopp added a comment to D97667: [loop-idiom] Hoist loop memcpys to loop preheader.
; ModuleID = '__compute_module' 
source_filename = "__compute_module"                                                                                               
target datalayout = "e-m:e-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128"                                       
target triple = "x86_64-grtev4-linux-gnu"
Apr 29 2021, 1:23 AM · Restricted Project

Apr 28 2021

tpopp added a reviewer for D100838: [mlir] Split BufferAliasAnalysis into 2 classes: pifon2a.
Apr 28 2021, 1:59 PM · Restricted Project
tpopp accepted D101456: [MLIR][Shape] Fix `shape.broadcast` to standard lowering.
Apr 28 2021, 7:20 AM · Restricted Project
tpopp added a comment to D101385: tsan: refactor fork handling.

I'm reverting this due to test failures and emailing you a more in depth reproducer for the failures. It seems like you expected the possibility of failures, so I hope this is okay.

Apr 28 2021, 5:11 AM · Restricted Project
tpopp added a comment to D97667: [loop-idiom] Hoist loop memcpys to loop preheader.

lebedev.ri's concerns seem to have been valid, so I'll be rolling this back. A test case in XLA that reverses data across certain dimensions in a multidimensional change fails with this patch. A sequence of loads and stores is converted into a single memcpy even though the ordering should be different across loads and stores.

Apr 28 2021, 4:13 AM · Restricted Project

Apr 23 2021

tpopp added a comment to D100838: [mlir] Split BufferAliasAnalysis into 2 classes.

Friendly ping.

Apr 23 2021, 4:57 AM · Restricted Project
tpopp added a comment to D99939: [mlir] Support complex numbers in Linalg promotion.

Friendly ping.

Apr 23 2021, 4:57 AM · Restricted Project

Apr 21 2021

tpopp accepted D100634: [MLIR][Shape] Add canonicalizations for `shape.broadcast`.
Apr 21 2021, 6:51 AM · Restricted Project
tpopp added a comment to D100634: [MLIR][Shape] Add canonicalizations for `shape.broadcast`.

A few places you checked that *.isa<ShapeType>() == *.isa<ShapeType>(). Out of curiosity, why not just compare the types?

Apr 21 2021, 12:46 AM · Restricted Project
tpopp added a comment to D100634: [MLIR][Shape] Add canonicalizations for `shape.broadcast`.

Arc diff doesn't update the description, so FYI in case you didn't, update to mention the additional features you added.

Apr 21 2021, 12:23 AM · Restricted Project

Apr 20 2021

tpopp updated the diff for D100838: [mlir] Split BufferAliasAnalysis into 2 classes.

Update cmake file and remove friendliness between Analyses

Apr 20 2021, 11:54 PM · Restricted Project
tpopp requested review of D100838: [mlir] Split BufferAliasAnalysis into 2 classes.
Apr 20 2021, 3:52 AM · Restricted Project
tpopp added a comment to D99939: [mlir] Support complex numbers in Linalg promotion.

I forwarded the DataLayout through several layers of functions. I started at the last point that the call sequence has the originating LinalgOp and passed it through as an additional argument rather than inside of any of the LinalgPromotionOption data structures. Please let me know what you think.

Apr 20 2021, 3:27 AM · Restricted Project
tpopp updated the diff for D99939: [mlir] Support complex numbers in Linalg promotion.

Forward DataLayout object to buffer allocation.

Apr 20 2021, 3:26 AM · Restricted Project

Apr 19 2021

tpopp added a comment to D100367: [mlir] Add patterns to lower Math operations to LLVM based libm calls..

It may not exist, it just sounds like a useful thing to have so I thought somebody could have added it. Feel free to have a local version or suggest one at Vector level. There's already VectorUnrollPattern that could be helpful.

Apr 19 2021, 11:33 PM · Restricted Project
tpopp updated the diff for D100367: [mlir] Add patterns to lower Math operations to LLVM based libm calls..

Add test case to convert vectors to scalars.

Apr 19 2021, 11:32 PM · Restricted Project

Apr 16 2021

tpopp added inline comments to D100634: [MLIR][Shape] Add canonicalizations for `shape.broadcast`.
Apr 16 2021, 7:16 AM · Restricted Project

Apr 14 2021

tpopp updated the diff for D100367: [mlir] Add patterns to lower Math operations to LLVM based libm calls..

Convert to StandardOpsDialect instead of LLVMDialect.

Apr 14 2021, 6:53 AM · Restricted Project
tpopp added a comment to D100367: [mlir] Add patterns to lower Math operations to LLVM based libm calls..

On a second thought, does this even need to target LLVM dialect directly? I'd expect us to have vector insert/extract in the vector dialect (hopefully, there is also a facility to unpack vectors; I see a naive combination of vector-to-loops and loop-unroll, but there may be something more specific) and we can call functions at the std level. The std->llvm conversion will do the rest.

Apr 14 2021, 6:37 AM · Restricted Project
tpopp updated the diff for D99939: [mlir] Support complex numbers in Linalg promotion.

Rebase onto parent commit

Apr 14 2021, 1:44 AM · Restricted Project