Page MenuHomePhabricator

tpopp (Theodore Popp)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 3 2020, 4:17 AM (12 w, 4 d)

Recent Activity

Today

tpopp updated the diff for D77128: [MLIR] Implement LoopLikeInterface for loop.parallel.

Update map# on test case to allow splitting of test cases.

Tue, Mar 31, 5:31 AM · Restricted Project
tpopp updated the diff for D77060: [MLIR] Replace OpBuilder(Block) with atBlockBegin and atBlockEnd.

Follow naming convention for atBlockBegin and atBlockEnd.

Tue, Mar 31, 4:23 AM · Restricted Project
tpopp retitled D77060: [MLIR] Replace OpBuilder(Block) with atBlockBegin and atBlockEnd from [MLIR] Replace OpBuilder(Block) withatBlockBegin and atBlockEnd to [MLIR] Replace OpBuilder(Block) with atBlockBegin and atBlockEnd.
Tue, Mar 31, 4:23 AM · Restricted Project
tpopp retitled D77060: [MLIR] Replace OpBuilder(Block) with atBlockBegin and atBlockEnd from [MLIR] Replace OpBuilder(Block) with AtBlockBegin and AtBlockEnd to [MLIR] Replace OpBuilder(Block) withatBlockBegin and atBlockEnd.
Tue, Mar 31, 4:23 AM · Restricted Project
tpopp added inline comments to D77128: [MLIR] Implement LoopLikeInterface for loop.parallel.
Tue, Mar 31, 4:23 AM · Restricted Project
tpopp updated the diff for D77128: [MLIR] Implement LoopLikeInterface for loop.parallel.

Replace ->getOperation() with dereference and run split-input-file on test file.

Tue, Mar 31, 4:23 AM · Restricted Project
tpopp created D77128: [MLIR] Implement LoopLikeInterface for loop.parallel.
Tue, Mar 31, 2:47 AM · Restricted Project
tpopp retitled D77060: [MLIR] Replace OpBuilder(Block) with atBlockBegin and atBlockEnd from [MLIR] Make OpBuilder(Block) default to inserting at Block::begin(). to [MLIR] Replace OpBuilder(Block) with AtBlockBegin and AtBlockEnd.
Tue, Mar 31, 1:37 AM · Restricted Project
tpopp updated the diff for D77060: [MLIR] Replace OpBuilder(Block) with atBlockBegin and atBlockEnd.

Create AtBlockBegin and AtBlockEnd. Remove OpBuilder(Block).

Tue, Mar 31, 1:37 AM · Restricted Project

Yesterday

tpopp added a comment to D77060: [MLIR] Replace OpBuilder(Block) with atBlockBegin and atBlockEnd.

Could we rather have static constructors that make it explicit what the insertion point is?

Mon, Mar 30, 10:16 AM · Restricted Project
tpopp added inline comments to D77052: [MLIR] Rename collapsePLoops -> collapseParallelLoops.
Mon, Mar 30, 10:16 AM · Restricted Project
tpopp created D77060: [MLIR] Replace OpBuilder(Block) with atBlockBegin and atBlockEnd.
Mon, Mar 30, 8:03 AM · Restricted Project
tpopp created D77052: [MLIR] Rename collapsePLoops -> collapseParallelLoops.
Mon, Mar 30, 4:50 AM · Restricted Project

Fri, Mar 20

tpopp updated the diff for D76363: [MLIR] Add parallel loop coalescing..

Rename variable for clang tidy reasons.

Fri, Mar 20, 4:51 AM · Restricted Project
tpopp updated the diff for D76363: [MLIR] Add parallel loop coalescing..

Use correct variable to fix undefined variable error.

Fri, Mar 20, 2:40 AM · Restricted Project

Thu, Mar 19

tpopp updated the diff for D76363: [MLIR] Add parallel loop coalescing..

Change loop form inside of collapsePLoops.

Thu, Mar 19, 6:59 AM · Restricted Project
tpopp added inline comments to D76363: [MLIR] Add parallel loop coalescing..
Thu, Mar 19, 6:59 AM · Restricted Project
tpopp added inline comments to D76363: [MLIR] Add parallel loop coalescing..
Thu, Mar 19, 6:59 AM · Restricted Project
tpopp added inline comments to D76363: [MLIR] Add parallel loop coalescing..
Thu, Mar 19, 6:26 AM · Restricted Project
tpopp updated the diff for D76363: [MLIR] Add parallel loop coalescing..

Handle herhut's comments and fix broken collapsing
logic that used the wrong upper bound value.

Thu, Mar 19, 6:26 AM · Restricted Project
tpopp updated the diff for D76363: [MLIR] Add parallel loop coalescing..

Use OptionList instead of llvm:🆑:list

Thu, Mar 19, 3:11 AM · Restricted Project
tpopp updated the diff for D76363: [MLIR] Add parallel loop coalescing..

Handle formatting and naming feedback.

Thu, Mar 19, 2:39 AM · Restricted Project
tpopp updated the summary of D76363: [MLIR] Add parallel loop coalescing..
Thu, Mar 19, 2:07 AM · Restricted Project
tpopp added a comment to D76363: [MLIR] Add parallel loop coalescing..

Could you please add a summary to the commit message - even if it's a couple of lines?

+1, we document it here: https://mlir.llvm.org/getting_started/Contributing/#commit-messages

Thu, Mar 19, 2:07 AM · Restricted Project

Wed, Mar 18

tpopp updated the diff for D76363: [MLIR] Add parallel loop coalescing..

Save loops.getLoc in a variable and use variable everywhere instead.

Wed, Mar 18, 8:42 AM · Restricted Project
tpopp added a reviewer for D76363: [MLIR] Add parallel loop coalescing.: herhut.
Wed, Mar 18, 8:42 AM · Restricted Project
tpopp updated the diff for D76363: [MLIR] Add parallel loop coalescing..

Refactored some code to be more proper.

Wed, Mar 18, 8:42 AM · Restricted Project
tpopp created D76363: [MLIR] Add parallel loop coalescing..
Wed, Mar 18, 7:36 AM · Restricted Project

Jan 20 2020

tpopp added a comment to D72921: Create a gpu.module operation for the GPU Dialect..

Can you expand on the original reason for the revert? What has been fix in the patch?

Jan 20 2020, 2:16 AM · Restricted Project
tpopp updated the diff for D72921: Create a gpu.module operation for the GPU Dialect..

Run clang-format with LLVM style instead of google style.

Jan 20 2020, 2:07 AM · Restricted Project

Jan 17 2020

tpopp added a reverting change for rGac446302ca41: Revert "[mlir] Create a gpu.module operation for the GPU Dialect.": D72921: Create a gpu.module operation for the GPU Dialect..
Jan 17 2020, 6:49 AM
Herald added a reviewer for D72921: Create a gpu.module operation for the GPU Dialect.: antiagainst.
Jan 17 2020, 6:49 AM · Restricted Project

Jan 14 2020

tpopp updated the diff for D72336: [mlir] Create a gpu.module operation for the GPU Dialect..

Change which location information is used at one point.

Jan 14 2020, 1:23 AM · Restricted Project

Jan 13 2020

tpopp updated the diff for D72336: [mlir] Create a gpu.module operation for the GPU Dialect..

Remove GpuModuleOp::create.

Jan 13 2020, 2:34 AM · Restricted Project

Jan 9 2020

tpopp added inline comments to D72336: [mlir] Create a gpu.module operation for the GPU Dialect..
Jan 9 2020, 1:49 AM · Restricted Project
tpopp updated the diff for D72336: [mlir] Create a gpu.module operation for the GPU Dialect..

Rename GpuModule to GPUModule and improve description.

Jan 9 2020, 1:31 AM · Restricted Project

Jan 7 2020

tpopp created D72336: [mlir] Create a gpu.module operation for the GPU Dialect..
Jan 7 2020, 7:42 AM · Restricted Project