Page MenuHomePhabricator

[MLIR][Shape] Fold `shape.size_eq`
AcceptedPublic

Authored by frgossen on Thu, Jun 25, 2:02 AM.

Details

Summary

Fold shape.size_eq.

Depends On D82628

Diff Detail

Event Timeline

frgossen created this revision.Thu, Jun 25, 2:02 AM
Herald added a reviewer: jpienaar. · View Herald Transcript
Herald added a reviewer: silvas. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
frgossen updated this revision to Diff 273386.Thu, Jun 25, 8:31 AM

Remove CHECK-DAGs

silvas accepted this revision.Thu, Jun 25, 10:02 AM

LGTM modulo splitting into two separate ops.

mlir/lib/Dialect/Shape/IR/Shape.cpp
395

This will be much cleaner with two separate ops.

rriddle added inline comments.Thu, Jun 25, 12:30 PM
mlir/include/mlir/IR/Builders.h
112 ↗(On Diff #273386)

I would rather use bool here. This method also isn't strictly necessary given that it does exactly the same thing as getBoolAttr.

mlir/lib/Dialect/Shape/IR/Shape.cpp
398

This looks much longer than just doing:

BoolAttr::get(eq, getContext());

frgossen updated this revision to Diff 273616.Fri, Jun 26, 1:42 AM
frgossen marked 3 inline comments as done.

Address comments

frgossen retitled this revision from [MLIR][Shape] Fold `shape.eq` for sizes to [MLIR][Shape] Fold `shape.size_eq`.Fri, Jun 26, 1:44 AM
frgossen edited the summary of this revision. (Show Details)
jpienaar accepted this revision.Sun, Jun 28, 7:53 AM
This revision is now accepted and ready to land.Sun, Jun 28, 7:53 AM