Page MenuHomePhabricator
People frgossen

frgossen (Frederik Gossen)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 3 2020, 3:29 AM (7 w, 4 d)

Recent Activity
View All

Today

frgossen added inline comments to D80280: [MLIR] Add `index_to_size` and `size_to_index` to the shape dialect.
Tue, May 26, 2:39 AM · Restricted Project
frgossen updated the diff for D80281: [MLIR] Add `num_elements` to the shape dialect.

Remove redundant documentation

Tue, May 26, 2:39 AM · Restricted Project
frgossen updated the diff for D80278: [MLIR] Tidy up documentation for `Shape_JoinOp`, `Shape_ReduceOp`, and `Shape_ConstSizeOp`.

Rebase

Tue, May 26, 2:39 AM · Restricted Project
frgossen updated the diff for D80280: [MLIR] Add `index_to_size` and `size_to_index` to the shape dialect.

Remove redundant documentation

Tue, May 26, 2:39 AM · Restricted Project
frgossen updated the diff for D80277: [MLIR] Move `ConcatOp` to its lexicographic position.
Tue, May 26, 2:07 AM · Restricted Project
frgossen added inline comments to D80280: [MLIR] Add `index_to_size` and `size_to_index` to the shape dialect.
Tue, May 26, 2:07 AM · Restricted Project
frgossen added a comment to D80277: [MLIR] Move `ConcatOp` to its lexicographic position.

@silvas, can I land this?

Tue, May 26, 2:07 AM · Restricted Project
frgossen added a comment to D80278: [MLIR] Tidy up documentation for `Shape_JoinOp`, `Shape_ReduceOp`, and `Shape_ConstSizeOp`.

@silvas, can I land this?

Tue, May 26, 2:07 AM · Restricted Project
frgossen retitled D80275: [MLIR] Add missing decorative comment line from [MLIR] Cosmetic change to [MLIR] Add missing decorative comment line.
Tue, May 26, 1:35 AM · Restricted Project

Wed, May 20

frgossen added a reviewer for D80283: [MLIR] Fix operand type in `from_extent_tensor` in the shape dialect: mravishankar.
Wed, May 20, 4:18 AM · Restricted Project
frgossen added reviewers for D80283: [MLIR] Fix operand type in `from_extent_tensor` in the shape dialect: pifon2a, herhut.
Wed, May 20, 2:40 AM · Restricted Project
frgossen added reviewers for D80281: [MLIR] Add `num_elements` to the shape dialect: pifon2a, herhut.
Wed, May 20, 2:40 AM · Restricted Project
frgossen added reviewers for D80280: [MLIR] Add `index_to_size` and `size_to_index` to the shape dialect: pifon2a, herhut.
Wed, May 20, 2:40 AM · Restricted Project
frgossen created D80283: [MLIR] Fix operand type in `from_extent_tensor` in the shape dialect.
Wed, May 20, 2:40 AM · Restricted Project
frgossen added reviewers for D80278: [MLIR] Tidy up documentation for `Shape_JoinOp`, `Shape_ReduceOp`, and `Shape_ConstSizeOp`: pifon2a, herhut.
Wed, May 20, 2:40 AM · Restricted Project
frgossen added reviewers for D80275: [MLIR] Add missing decorative comment line: pifon2a, herhut.
Wed, May 20, 2:40 AM · Restricted Project
frgossen added reviewers for D80277: [MLIR] Move `ConcatOp` to its lexicographic position: pifon2a, herhut.
Wed, May 20, 2:40 AM · Restricted Project
frgossen added a comment to D80004: [MLIR] Add `from_index`, `to_index`, and `num_elements` to the shape dialect.

As suggested by @silvas , this revision is now split up into multiple ones:

Wed, May 20, 2:40 AM · Restricted Project
frgossen abandoned D80004: [MLIR] Add `from_index`, `to_index`, and `num_elements` to the shape dialect.
Wed, May 20, 2:40 AM · Restricted Project
frgossen added a child revision for D80281: [MLIR] Add `num_elements` to the shape dialect: D80283: [MLIR] Fix operand type in `from_extent_tensor` in the shape dialect.
Wed, May 20, 2:40 AM · Restricted Project
frgossen created D80281: [MLIR] Add `num_elements` to the shape dialect.
Wed, May 20, 2:39 AM · Restricted Project
frgossen added a child revision for D80280: [MLIR] Add `index_to_size` and `size_to_index` to the shape dialect: D80281: [MLIR] Add `num_elements` to the shape dialect.
Wed, May 20, 2:39 AM · Restricted Project
frgossen updated the diff for D80280: [MLIR] Add `index_to_size` and `size_to_index` to the shape dialect.

Simplify folding

Wed, May 20, 2:07 AM · Restricted Project
frgossen created D80280: [MLIR] Add `index_to_size` and `size_to_index` to the shape dialect.
Wed, May 20, 2:07 AM · Restricted Project
frgossen added a child revision for D80278: [MLIR] Tidy up documentation for `Shape_JoinOp`, `Shape_ReduceOp`, and `Shape_ConstSizeOp`: D80280: [MLIR] Add `index_to_size` and `size_to_index` to the shape dialect.
Wed, May 20, 2:07 AM · Restricted Project
frgossen created D80278: [MLIR] Tidy up documentation for `Shape_JoinOp`, `Shape_ReduceOp`, and `Shape_ConstSizeOp`.
Wed, May 20, 1:35 AM · Restricted Project
frgossen added a child revision for D80277: [MLIR] Move `ConcatOp` to its lexicographic position: D80278: [MLIR] Tidy up documentation for `Shape_JoinOp`, `Shape_ReduceOp`, and `Shape_ConstSizeOp`.
Wed, May 20, 1:34 AM · Restricted Project
frgossen created D80277: [MLIR] Move `ConcatOp` to its lexicographic position.
Wed, May 20, 1:02 AM · Restricted Project
frgossen added a child revision for D80275: [MLIR] Add missing decorative comment line: D80277: [MLIR] Move `ConcatOp` to its lexicographic position.
Wed, May 20, 1:02 AM · Restricted Project
frgossen retitled D80275: [MLIR] Add missing decorative comment line from [MLIR] Cosmetic changes to [MLIR] Cosmetic change.
Wed, May 20, 1:02 AM · Restricted Project
frgossen added a reviewer for D80275: [MLIR] Add missing decorative comment line: silvas.
Wed, May 20, 1:02 AM · Restricted Project
frgossen created D80275: [MLIR] Add missing decorative comment line.
Wed, May 20, 1:02 AM · Restricted Project

Tue, May 19

frgossen committed rG5afd86b0de72: [MLIR] Add helper functions for common integer types (authored by frgossen).
[MLIR] Add helper functions for common integer types
Tue, May 19, 4:51 AM
frgossen closed D80111: [MLIR] Add helper functions for common integer types.
Tue, May 19, 4:50 AM · Restricted Project
frgossen added inline comments to D80004: [MLIR] Add `from_index`, `to_index`, and `num_elements` to the shape dialect.
Tue, May 19, 3:45 AM · Restricted Project
frgossen updated the diff for D80004: [MLIR] Add `from_index`, `to_index`, and `num_elements` to the shape dialect.

Rename and constant folding

Tue, May 19, 3:45 AM · Restricted Project
frgossen added a comment to D80111: [MLIR] Add helper functions for common integer types.

Can I land this? @rriddle appears to be inactive since May 7th.

Tue, May 19, 3:45 AM · Restricted Project

Mon, May 18

frgossen added inline comments to D80004: [MLIR] Add `from_index`, `to_index`, and `num_elements` to the shape dialect.
Mon, May 18, 4:15 AM · Restricted Project
frgossen added a reviewer for D80111: [MLIR] Add helper functions for common integer types: silvas.
Mon, May 18, 2:05 AM · Restricted Project
frgossen added a reviewer for D80111: [MLIR] Add helper functions for common integer types: pifon2a.
Mon, May 18, 2:05 AM · Restricted Project
frgossen created D80111: [MLIR] Add helper functions for common integer types.
Mon, May 18, 2:05 AM · Restricted Project

Fri, May 15

frgossen added reviewers for D80004: [MLIR] Add `from_index`, `to_index`, and `num_elements` to the shape dialect: herhut, pifon2a.
Fri, May 15, 7:00 AM · Restricted Project
Herald added a reviewer for D80004: [MLIR] Add `from_index`, `to_index`, and `num_elements` to the shape dialect: jpienaar.
Fri, May 15, 7:00 AM · Restricted Project

Fri, May 8

frgossen committed rG5d5f61fc894b: [MLIR] Add complex addition and substraction to the standard dialect (authored by frgossen).
[MLIR] Add complex addition and substraction to the standard dialect
Fri, May 8, 3:11 AM
frgossen closed D79479: [MLIR] Add complex addition and substraction to the standard dialect.
Fri, May 8, 3:11 AM · Restricted Project
frgossen added a comment to D79479: [MLIR] Add complex addition and substraction to the standard dialect.

Thanks

Fri, May 8, 3:11 AM · Restricted Project
frgossen updated the diff for D79479: [MLIR] Add complex addition and substraction to the standard dialect.

Extract operands in helper function.

Fri, May 8, 3:11 AM · Restricted Project

Wed, May 6

frgossen created D79479: [MLIR] Add complex addition and substraction to the standard dialect.
Wed, May 6, 4:48 AM · Restricted Project

Mon, May 4

frgossen committed rG031265ad8a2e: [MLIR] Add complex numbers to standard dialect (authored by frgossen).
[MLIR] Add complex numbers to standard dialect
Mon, May 4, 7:27 AM
frgossen closed D79159: [MLIR] Add complex numbers to standard dialect.
Mon, May 4, 7:27 AM · Restricted Project
frgossen updated the diff for D79159: [MLIR] Add complex numbers to standard dialect.

Apply clang tidy suggestions

Mon, May 4, 5:50 AM · Restricted Project
frgossen updated the diff for D79159: [MLIR] Add complex numbers to standard dialect.

Nits

Mon, May 4, 4:46 AM · Restricted Project
frgossen added a comment to D79159: [MLIR] Add complex numbers to standard dialect.

Address nits.

Mon, May 4, 4:46 AM · Restricted Project
frgossen added inline comments to D79159: [MLIR] Add complex numbers to standard dialect.
Mon, May 4, 3:10 AM · Restricted Project
frgossen updated the diff for D79159: [MLIR] Add complex numbers to standard dialect.

Simplified assembly format, introduced ComplexStructBuilder.

Mon, May 4, 3:10 AM · Restricted Project

Thu, Apr 30

frgossen added a comment to D79159: [MLIR] Add complex numbers to standard dialect.

Thanks for the many helpful comments.
There is one comment for which I'd like clarification.

Thu, Apr 30, 4:31 AM · Restricted Project
frgossen added inline comments to D79159: [MLIR] Add complex numbers to standard dialect.
Thu, Apr 30, 4:11 AM · Restricted Project
frgossen updated the diff for D79159: [MLIR] Add complex numbers to standard dialect.

Document operands, small changes.

Thu, Apr 30, 3:57 AM · Restricted Project
frgossen added reviewers for D79159: [MLIR] Add complex numbers to standard dialect: pifon2a, herhut.
Thu, Apr 30, 2:06 AM · Restricted Project
frgossen created D79159: [MLIR] Add complex numbers to standard dialect.
Thu, Apr 30, 2:06 AM · Restricted Project

Apr 24 2020

frgossen accepted D78803: [MLIR] Remove document references to gpu.kernel_module and gpu.kernel..
Apr 24 2020, 8:04 AM · Restricted Project
frgossen requested changes to D78803: [MLIR] Remove document references to gpu.kernel_module and gpu.kernel..

Thank you.

Apr 24 2020, 4:49 AM · Restricted Project
frgossen committed rG7e4b139a04d7: [MLIR] Ensure `gpu.func` must be inside a `gpu.module`. (authored by frgossen).
[MLIR] Ensure `gpu.func` must be inside a `gpu.module`.
Apr 24 2020, 12:30 AM
frgossen closed D78541: [MLIR] Ensure `gpu.func` must be inside a `gpu.module`..
Apr 24 2020, 12:29 AM · Restricted Project

Apr 23 2020

frgossen added a comment to D78541: [MLIR] Ensure `gpu.func` must be inside a `gpu.module`..

@mravishankar, can I land this?

Apr 23 2020, 5:21 AM · Restricted Project

Apr 22 2020

frgossen committed rG0372db05bb15: [MLIR] Use nested symbol to identify kernel in `LaunchFuncOp`. (authored by frgossen).
[MLIR] Use nested symbol to identify kernel in `LaunchFuncOp`.
Apr 22 2020, 1:03 AM
frgossen committed rG648fc9508334: [MLIR] Use `kernel` as a short hand for `gpu.kernel` attribute. (authored by frgossen).
[MLIR] Use `kernel` as a short hand for `gpu.kernel` attribute.
Apr 22 2020, 1:03 AM
frgossen closed D78551: [MLIR] Use nested symbol to identify kernel in `LaunchFuncOp`..
Apr 22 2020, 1:03 AM · Restricted Project
frgossen closed D78542: [MLIR] Use `kernel` as a short hand for `gpu.kernel` attribute..
Apr 22 2020, 1:03 AM · Restricted Project
frgossen committed rG28138027460d: [MLIR] Fix test case for kernel attribute. (authored by frgossen).
[MLIR] Fix test case for kernel attribute.
Apr 22 2020, 12:31 AM
frgossen closed D78540: [MLIR] Fix test case for kernel attribute..
Apr 22 2020, 12:30 AM · Restricted Project

Apr 21 2020

Herald added a reviewer for D78551: [MLIR] Use nested symbol to identify kernel in `LaunchFuncOp`.: antiagainst.
Apr 21 2020, 3:44 AM · Restricted Project
frgossen added inline comments to D78541: [MLIR] Ensure `gpu.func` must be inside a `gpu.module`..
Apr 21 2020, 3:12 AM · Restricted Project
frgossen updated the diff for D78541: [MLIR] Ensure `gpu.func` must be inside a `gpu.module`..

Simplify test case.

Apr 21 2020, 3:12 AM · Restricted Project
frgossen updated the summary of D78542: [MLIR] Use `kernel` as a short hand for `gpu.kernel` attribute..
Apr 21 2020, 2:39 AM · Restricted Project
frgossen created D78542: [MLIR] Use `kernel` as a short hand for `gpu.kernel` attribute..
Apr 21 2020, 12:30 AM · Restricted Project
frgossen created D78540: [MLIR] Fix test case for kernel attribute..
Apr 21 2020, 12:30 AM · Restricted Project
frgossen created D78541: [MLIR] Ensure `gpu.func` must be inside a `gpu.module`..
Apr 21 2020, 12:30 AM · Restricted Project

Apr 3 2020

frgossen added a reviewer for D77397: Fix typos in toy tutorial: herhut.
Apr 3 2020, 8:02 AM · Restricted Project
frgossen updated the diff for D77382: [MLIR] Fix shape inference in toy tutorial.

Fix typo

Apr 3 2020, 7:30 AM · Restricted Project
frgossen created D77397: Fix typos in toy tutorial.
Apr 3 2020, 7:29 AM · Restricted Project
frgossen retitled D77382: [MLIR] Fix shape inference in toy tutorial from Fix shape inference in toy tutorial to [MLIR] Fix shape inference in toy tutorial.
Apr 3 2020, 6:57 AM · Restricted Project
frgossen abandoned D77381: Fix shape inference in toy tutorial.
Apr 3 2020, 6:24 AM · Restricted Project
frgossen abandoned D77380: Format code.
Apr 3 2020, 6:24 AM · Restricted Project
frgossen created D77382: [MLIR] Fix shape inference in toy tutorial.
Apr 3 2020, 5:20 AM · Restricted Project
frgossen updated the diff for D77381: Fix shape inference in toy tutorial.

Honestly, learning how to use arc diff.

Apr 3 2020, 5:20 AM · Restricted Project
frgossen updated the diff for D77381: Fix shape inference in toy tutorial.

Fix formatting

Apr 3 2020, 5:20 AM · Restricted Project
frgossen created D77381: Fix shape inference in toy tutorial.
Apr 3 2020, 5:20 AM · Restricted Project
frgossen created D77380: Format code.
Apr 3 2020, 4:15 AM · Restricted Project