Page MenuHomePhabricator
People frgossen

frgossen (Frederik Gossen)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 3 2020, 3:29 AM (34 w, 5 d)

Recent Activity
View All

Fri, Nov 27

frgossen committed rG6484567f1488: [MLIR][SCF] Find all innermost loops for parallel loop tiling (authored by frgossen).
[MLIR][SCF] Find all innermost loops for parallel loop tiling
Fri, Nov 27, 1:41 AM
frgossen closed D92188: [MLIR][SCF] Find all innermost loops for parallel loop tiling.
Fri, Nov 27, 1:41 AM · Restricted Project
frgossen retitled D92188: [MLIR][SCF] Find all innermost loops for parallel loop tiling from [MLIR][SCF] Find all innermost loops for prarallel loop tiling to [MLIR][SCF] Find all innermost loops for parallel loop tiling.
Fri, Nov 27, 1:08 AM · Restricted Project
frgossen updated the diff for D92188: [MLIR][SCF] Find all innermost loops for parallel loop tiling.

Address comments

Fri, Nov 27, 1:06 AM · Restricted Project

Thu, Nov 26

frgossen requested review of D92188: [MLIR][SCF] Find all innermost loops for parallel loop tiling.
Thu, Nov 26, 9:09 AM · Restricted Project
frgossen accepted D92032: [mlir][bufferize] Add argument materialization for bufferization.

Thanks!

Thu, Nov 26, 4:35 AM · Restricted Project
frgossen accepted D92032: [mlir][bufferize] Add argument materialization for bufferization.

Sorry, I saw this only now.
Thank you!

Thu, Nov 26, 2:08 AM · Restricted Project

Tue, Nov 24

frgossen abandoned D82534: [MLIR][Shape] Lower `shape.size_eq` to the standard dialect.
Tue, Nov 24, 5:08 AM · Restricted Project
frgossen abandoned D82531: [MLIR][Shape] Fold `shape.size_eq`.
Tue, Nov 24, 5:08 AM · Restricted Project
frgossen abandoned D82628: [MLIR][Shape] Add `shape.size_eq` to the shape dialect.
Tue, Nov 24, 5:08 AM · Restricted Project

Mon, Nov 23

frgossen accepted D91070: [mlir] Add print functions for i64, index..
Mon, Nov 23, 7:18 AM · Restricted Project

Fri, Nov 20

frgossen accepted D91856: [mlir][std] Fold comparisons when the operands are equal.

Thanks!

Fri, Nov 20, 2:54 AM · Restricted Project
frgossen accepted D91855: [mlir][std] Fold load(tensor_to_memref) into extract_element.

Thanks!

Fri, Nov 20, 2:50 AM · Restricted Project
frgossen accepted D91854: [mlir][std] Canonicalize a dim(memref_reshape) into a load from the shape operand.

Thanks!

Fri, Nov 20, 2:50 AM · Restricted Project

Fri, Nov 13

frgossen added a comment to D85634: [MLIR][Standard] Fix cast materialization for incompatible types.

I believe this is still relevant as the FIXME is still present. The mlir-cuda-runner tests still fail.
@rriddle

Fri, Nov 13, 6:23 AM · Restricted Project

Thu, Nov 5

frgossen abandoned D90856: [MLIR] Fix missing namespaces in `mlir/unittests/TableGen/OpBuildGen.cpp`.

https://reviews.llvm.org/D90858

Thu, Nov 5, 9:16 AM · Restricted Project
frgossen requested review of D90856: [MLIR] Fix missing namespaces in `mlir/unittests/TableGen/OpBuildGen.cpp`.
Thu, Nov 5, 8:27 AM · Restricted Project

Wed, Nov 4

frgossen committed rG1664462d70cc: [MLIR] Support walks over regions and blocks (authored by frgossen).
[MLIR] Support walks over regions and blocks
Wed, Nov 4, 4:50 AM
frgossen closed D90753: [MLIR] Support walks over regions and blocks.
Wed, Nov 4, 4:50 AM · Restricted Project
frgossen updated the summary of D90753: [MLIR] Support walks over regions and blocks.
Wed, Nov 4, 4:48 AM · Restricted Project
frgossen added reviewers for D90753: [MLIR] Support walks over regions and blocks: stella.stamenova, bkramer.
Wed, Nov 4, 3:03 AM · Restricted Project
frgossen requested review of D90753: [MLIR] Support walks over regions and blocks.
Wed, Nov 4, 3:02 AM · Restricted Project

Tue, Nov 3

frgossen added a comment to D90379: [MLIR] Support walks over regions and blocks.

Yes, I reverted it yesterday as it caused problems with the integrate. I will re-land this when I figure out how to install an old GCC version.

Tue, Nov 3, 1:19 AM · Restricted Project

Nov 2 2020

frgossen added a reverting change for rGdbae3d50f114: [MLIR] Support walks over regions and blocks: rG327bf5c2d910: Revert "[MLIR] Support walks over regions and blocks".
Nov 2 2020, 8:22 AM
frgossen committed rG327bf5c2d910: Revert "[MLIR] Support walks over regions and blocks" (authored by frgossen).
Revert "[MLIR] Support walks over regions and blocks"
Nov 2 2020, 8:22 AM
frgossen added a reverting change for rG56299b1e58bf: [MLIR] Use `llvm::is_one_of` in walk templates: rG6b74a5aab11f: Revert "[MLIR] Use `llvm::is_one_of` in walk templates".
Nov 2 2020, 8:22 AM
frgossen added a reverting change for D90379: [MLIR] Support walks over regions and blocks: rG327bf5c2d910: Revert "[MLIR] Support walks over regions and blocks".
Nov 2 2020, 8:22 AM · Restricted Project
frgossen committed rG6b74a5aab11f: Revert "[MLIR] Use `llvm::is_one_of` in walk templates" (authored by frgossen).
Revert "[MLIR] Use `llvm::is_one_of` in walk templates"
Nov 2 2020, 8:22 AM
frgossen added a reverting change for D90449: [MLIR] Use `llvm::is_one_of` in walk templates: rG6b74a5aab11f: Revert "[MLIR] Use `llvm::is_one_of` in walk templates".
Nov 2 2020, 8:22 AM · Restricted Project
frgossen added a comment to D90379: [MLIR] Support walks over regions and blocks.

Unfortunately, I could not reproduce this failure,
I tried with gcc/g++ (Debian 10.2.0-9) 10.2.0.

Nov 2 2020, 2:09 AM · Restricted Project
frgossen accepted D90405: [mlir] Add shape.is_broadcastable..
Nov 2 2020, 1:32 AM · Restricted Project

Oct 30 2020

frgossen committed rG56299b1e58bf: [MLIR] Use `llvm::is_one_of` in walk templates (authored by frgossen).
[MLIR] Use `llvm::is_one_of` in walk templates
Oct 30 2020, 7:43 AM
frgossen closed D90449: [MLIR] Use `llvm::is_one_of` in walk templates.
Oct 30 2020, 7:43 AM · Restricted Project
frgossen added inline comments to D90379: [MLIR] Support walks over regions and blocks.
Oct 30 2020, 3:19 AM · Restricted Project
frgossen requested review of D90449: [MLIR] Use `llvm::is_one_of` in walk templates.
Oct 30 2020, 3:19 AM · Restricted Project

Oct 29 2020

frgossen accepted D90407: [mlir] Add lowering for IsBroadcastable to Std dialect..

Looks good!

Oct 29 2020, 10:04 AM · Restricted Project
frgossen accepted D90377: [mlir] Convert `memref_reshape` to LLVM..
Oct 29 2020, 8:59 AM · Restricted Project
frgossen committed rGdbae3d50f114: [MLIR] Support walks over regions and blocks (authored by frgossen).
[MLIR] Support walks over regions and blocks
Oct 29 2020, 7:35 AM
frgossen closed D90379: [MLIR] Support walks over regions and blocks.
Oct 29 2020, 7:34 AM · Restricted Project
frgossen added inline comments to D90379: [MLIR] Support walks over regions and blocks.
Oct 29 2020, 6:48 AM · Restricted Project
frgossen updated the diff for D90379: [MLIR] Support walks over regions and blocks.

Address comment

Oct 29 2020, 6:48 AM · Restricted Project
frgossen updated the diff for D90379: [MLIR] Support walks over regions and blocks.

Fix clang-tidy

Oct 29 2020, 6:18 AM · Restricted Project
frgossen requested review of D90379: [MLIR] Support walks over regions and blocks.
Oct 29 2020, 3:40 AM · Restricted Project
frgossen accepted D90375: [mlir] Reorder shape assuming bufferization..
Oct 29 2020, 3:06 AM · Restricted Project

Oct 28 2020

frgossen abandoned D90229: [MLIR] Define an order on `Value`s.

Thanks! Will do that

Oct 28 2020, 2:47 AM · Restricted Project

Oct 27 2020

frgossen accepted D90204: [mlir] Add bufferization for std.select op..
Oct 27 2020, 6:07 AM · Restricted Project
frgossen requested review of D90229: [MLIR] Define an order on `Value`s.
Oct 27 2020, 6:04 AM · Restricted Project

Oct 26 2020

frgossen accepted D90033: [mlir] Convert MemRefReinterpretCastOp to LLVM..
Oct 26 2020, 5:26 AM · Restricted Project
frgossen added a comment to D89902: [MLIR] Extract buffer alias analysis for reuse.
In D89902#2350128, @jpienaar wrote:

Is this change related to build breakage? (https://buildkite.com/mlir/mlir-core/builds/8813)

Oct 26 2020, 2:55 AM · Restricted Project

Oct 23 2020

frgossen committed rG8039b3f96680: [MLIR] Fix bad merge with buffer alias analysis. (authored by frgossen).
[MLIR] Fix bad merge with buffer alias analysis.
Oct 23 2020, 7:12 AM
frgossen committed rG6d83e3b44335: [MLIR] Extract buffer alias analysis for reuse (authored by frgossen).
[MLIR] Extract buffer alias analysis for reuse
Oct 23 2020, 6:24 AM
frgossen closed D89902: [MLIR] Extract buffer alias analysis for reuse.
Oct 23 2020, 6:24 AM · Restricted Project
frgossen updated the diff for D89902: [MLIR] Extract buffer alias analysis for reuse.

Rebase

Oct 23 2020, 6:20 AM · Restricted Project

Oct 21 2020

frgossen updated the diff for D89902: [MLIR] Extract buffer alias analysis for reuse.

Address comment

Oct 21 2020, 12:33 PM · Restricted Project
frgossen updated the diff for D89902: [MLIR] Extract buffer alias analysis for reuse.

Address comments

Oct 21 2020, 11:59 AM · Restricted Project
frgossen requested review of D89902: [MLIR] Extract buffer alias analysis for reuse.
Oct 21 2020, 11:19 AM · Restricted Project

Oct 19 2020

frgossen accepted D89594: [mlir] Add some more std bufferize patterns..
Oct 19 2020, 5:37 AM · Restricted Project

Sep 30 2020

frgossen committed rGcdda7822d6ce: [MLIR][Standard] Add `atan2` to standard dialect (authored by frgossen).
[MLIR][Standard] Add `atan2` to standard dialect
Sep 30 2020, 1:39 AM
frgossen closed D88168: [MLIR][Standard] Add `atan2` to standard dialect.
Sep 30 2020, 1:39 AM · Restricted Project

Sep 29 2020

frgossen updated the diff for D88168: [MLIR][Standard] Add `atan2` to standard dialect.

Address comments

Sep 29 2020, 3:27 AM · Restricted Project
frgossen added a reviewer for D88168: [MLIR][Standard] Add `atan2` to standard dialect: pifon2a.
Sep 29 2020, 12:38 AM · Restricted Project

Sep 28 2020

frgossen updated the diff for D88168: [MLIR][Standard] Add `atan2` to standard dialect.

Address comments

Sep 28 2020, 5:51 AM · Restricted Project
frgossen accepted D88258: [mlir][shape] Make conversion passes more consistent..

Thanks

Sep 28 2020, 5:29 AM · Restricted Project

Sep 24 2020

frgossen added a reviewer for D88168: [MLIR][Standard] Add `atan2` to standard dialect: ftynse.
Sep 24 2020, 5:02 AM · Restricted Project

Sep 23 2020

frgossen added a comment to D88168: [MLIR][Standard] Add `atan2` to standard dialect.

See https://llvm.discourse.group/t/standard-add-atan2-to-the-standard-dialect/1837

Sep 23 2020, 10:20 AM · Restricted Project
frgossen requested review of D88168: [MLIR][Standard] Add `atan2` to standard dialect.
Sep 23 2020, 10:19 AM · Restricted Project
frgossen added a comment to D88091: [MLIR][Standard] Add `atan` to standard dialect.

https://llvm.discourse.group/t/standard-add-atan2-to-the-standard-dialect/1837

Sep 23 2020, 6:27 AM · Restricted Project
frgossen added a comment to D88091: [MLIR][Standard] Add `atan` to standard dialect.

We do not intend to add a standard lowering for atan as there would be many possible approximations.
Like @bondhugula said, it helps us with the lowering from lmhlo to std where we can subsequently apply our approximation.
Sorry for the missing discussion on Discourse. Should I still post it?

Sep 23 2020, 2:16 AM · Restricted Project

Sep 22 2020

frgossen committed rGe952bb709ff7: [MLIR][Standard] Add `atan` to standard dialect (authored by frgossen).
[MLIR][Standard] Add `atan` to standard dialect
Sep 22 2020, 6:17 AM
frgossen closed D88091: [MLIR][Standard] Add `atan` to standard dialect.
Sep 22 2020, 6:17 AM · Restricted Project
frgossen updated the diff for D88091: [MLIR][Standard] Add `atan` to standard dialect.

Fix documentation

Sep 22 2020, 6:15 AM · Restricted Project
frgossen requested review of D88091: [MLIR][Standard] Add `atan` to standard dialect.
Sep 22 2020, 5:54 AM · Restricted Project
frgossen committed rG0841f7172b74: [MLIR][Linalg] Fix assertion in dependency analysis (authored by frgossen).
[MLIR][Linalg] Fix assertion in dependency analysis
Sep 22 2020, 3:22 AM
frgossen closed D88080: [MLIR][Linalg] Fix assertion in dependency analysis.
Sep 22 2020, 3:21 AM · Restricted Project
frgossen added reviewers for D88080: [MLIR][Linalg] Fix assertion in dependency analysis: pifon2a, herhut.
Sep 22 2020, 3:04 AM · Restricted Project
frgossen requested review of D88080: [MLIR][Linalg] Fix assertion in dependency analysis.
Sep 22 2020, 3:04 AM · Restricted Project

Sep 18 2020

frgossen accepted D87875: [mlir][shape] Extend shape.cstr_require with a message..

Thanks

Sep 18 2020, 1:09 AM · Restricted Project

Sep 16 2020

frgossen accepted D87706: [mlir] Remove redundant shape.cstr_broadcastable canonicalization..
Sep 16 2020, 7:25 AM · Restricted Project
frgossen added inline comments to D87696: [mlir][Standard] Canonicalize chains of tensor_cast operations.
Sep 16 2020, 2:32 AM · Restricted Project

Sep 15 2020

frgossen accepted D87696: [mlir][Standard] Canonicalize chains of tensor_cast operations.
Sep 15 2020, 8:35 AM · Restricted Project
frgossen added inline comments to D87696: [mlir][Standard] Canonicalize chains of tensor_cast operations.
Sep 15 2020, 8:35 AM · Restricted Project

Sep 14 2020

frgossen accepted D87525: [mlir][Standard] Add canonicalizer for dynamic_tensor_from_elements.
Sep 14 2020, 2:22 AM · Restricted Project
frgossen added a comment to D87525: [mlir][Standard] Add canonicalizer for dynamic_tensor_from_elements.

Thanks!

Sep 14 2020, 1:45 AM · Restricted Project

Sep 11 2020

frgossen added a comment to D87492: [mlir] Fix some edge cases around 0-element TensorFromElementsOp.

Thanks!

Sep 11 2020, 6:29 AM · Restricted Project

Sep 10 2020

frgossen committed rG018f6936dbce: [MLIR][Standard] Simplify `tensor_from_elements` (authored by frgossen).
[MLIR][Standard] Simplify `tensor_from_elements`
Sep 10 2020, 7:43 AM
frgossen closed D87366: [MLIR][Standard] Simplify `tensor_from_elements`.
Sep 10 2020, 7:43 AM · Restricted Project
frgossen added inline comments to D87366: [MLIR][Standard] Simplify `tensor_from_elements`.
Sep 10 2020, 7:42 AM · Restricted Project
frgossen updated the diff for D87366: [MLIR][Standard] Simplify `tensor_from_elements`.

Address nit

Sep 10 2020, 7:41 AM · Restricted Project

Sep 9 2020

frgossen added inline comments to D86287: [MLIR][Standard] Update `tensor_from_elements` assembly format.
Sep 9 2020, 4:42 AM · Restricted Project
frgossen requested review of D87366: [MLIR][Standard] Simplify `tensor_from_elements`.
Sep 9 2020, 4:40 AM · Restricted Project
frgossen committed rG5106a8b8f8d0: [MLIR][Shape] Lower `shape_of` to `dynamic_tensor_from_elements` (authored by frgossen).
[MLIR][Shape] Lower `shape_of` to `dynamic_tensor_from_elements`
Sep 9 2020, 12:56 AM
frgossen closed D86935: [MLIR][Shape] Lower `shape_of` to `dynamic_tensor_from_elements`.
Sep 9 2020, 12:55 AM · Restricted Project
frgossen committed rG133322d2e308: [MLIR][Standard] Update `tensor_from_elements` assembly format (authored by frgossen).
[MLIR][Standard] Update `tensor_from_elements` assembly format
Sep 9 2020, 12:46 AM
frgossen closed D86287: [MLIR][Standard] Update `tensor_from_elements` assembly format.
Sep 9 2020, 12:46 AM · Restricted Project
frgossen committed rG6a494e117cd9: [MLIR] Add debug support for ignored patterns (authored by frgossen).
[MLIR] Add debug support for ignored patterns
Sep 9 2020, 12:19 AM
frgossen closed D87290: MLIR] Add debug support for ignored patterns.
Sep 9 2020, 12:18 AM · Restricted Project
frgossen updated the diff for D87290: MLIR] Add debug support for ignored patterns.

Address comment

Sep 9 2020, 12:17 AM · Restricted Project

Sep 8 2020

frgossen added a reviewer for D87290: MLIR] Add debug support for ignored patterns: herhut.
Sep 8 2020, 8:21 AM · Restricted Project
frgossen requested review of D87290: MLIR] Add debug support for ignored patterns.
Sep 8 2020, 8:20 AM · Restricted Project
frgossen added inline comments to D86287: [MLIR][Standard] Update `tensor_from_elements` assembly format.
Sep 8 2020, 5:29 AM · Restricted Project