Page MenuHomePhabricator

frgossen (Frederik Gossen)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 3 2020, 3:29 AM (156 w, 1 d)

Recent Activity

Tue, Mar 21

frgossen updated the diff for D146456: [MLIR] Address post-commit comments on function deduplication.

Address comments

Tue, Mar 21, 7:51 AM · Restricted Project, Restricted Project

Mon, Mar 20

frgossen added inline comments to D146456: [MLIR] Address post-commit comments on function deduplication.
Mon, Mar 20, 10:45 PM · Restricted Project, Restricted Project
frgossen updated the diff for D146456: [MLIR] Address post-commit comments on function deduplication.

Addrwss comments

Mon, Mar 20, 10:45 PM · Restricted Project, Restricted Project
frgossen added reviewers for D146456: [MLIR] Address post-commit comments on function deduplication: rriddle, mehdi_amini.
Mon, Mar 20, 2:09 PM · Restricted Project, Restricted Project
frgossen added a comment to D144738: [MLIR] Add pass to deduplicate functions.

Thanks for the comments. I addressed them in https://reviews.llvm.org/D146456.

Mon, Mar 20, 2:08 PM · Restricted Project, Restricted Project
frgossen requested review of D146456: [MLIR] Address post-commit comments on function deduplication.
Mon, Mar 20, 2:08 PM · Restricted Project, Restricted Project

Fri, Mar 17

frgossen committed rGf0594b6fd49f: [MLIR] Add label to print-ir pass (authored by frgossen).
[MLIR] Add label to print-ir pass
Fri, Mar 17, 11:58 AM · Restricted Project, Restricted Project
frgossen closed D145523: [MLIR] Add label to print-ir pass.
Fri, Mar 17, 11:58 AM · Restricted Project, Restricted Project

Mon, Mar 13

frgossen retitled D145523: [MLIR] Add label to print-ir pass from BEGIN_PUBLIC [MLIR] Add label to print-ir pass END_PUBLIC to [MLIR] Add label to print-ir pass.
Mon, Mar 13, 9:51 AM · Restricted Project, Restricted Project

Tue, Mar 7

frgossen added a reviewer for D145523: [MLIR] Add label to print-ir pass: pifon2a.
Tue, Mar 7, 11:44 AM · Restricted Project, Restricted Project
frgossen requested review of D145523: [MLIR] Add label to print-ir pass.
Tue, Mar 7, 11:44 AM · Restricted Project, Restricted Project

Fri, Mar 3

frgossen added a comment to D145217: [mlir][llvm] Drop the access group and alias strings (NFC)..

Could you share a reference use of these interfaces? I'm not very familiar with this myself, just remember that it broke our tests last time.

Fri, Mar 3, 6:30 AM · Restricted Project, Restricted Project

Mar 1 2023

frgossen committed rGbdb955b307c5: [MLIR] Add `print-ir` pass for debugging purposes (authored by frgossen).
[MLIR] Add `print-ir` pass for debugging purposes
Mar 1 2023, 11:42 AM · Restricted Project, Restricted Project
frgossen closed D144918: [MLIR] Add `print-ir` pass for debugging purposes.
Mar 1 2023, 11:42 AM · Restricted Project, Restricted Project
frgossen updated the diff for D144918: [MLIR] Add `print-ir` pass for debugging purposes.

.

Mar 1 2023, 11:34 AM · Restricted Project, Restricted Project
frgossen updated the diff for D144918: [MLIR] Add `print-ir` pass for debugging purposes.

.

Mar 1 2023, 11:31 AM · Restricted Project, Restricted Project
frgossen updated the diff for D144918: [MLIR] Add `print-ir` pass for debugging purposes.

Address comments

Mar 1 2023, 11:28 AM · Restricted Project, Restricted Project
frgossen added a comment to D144918: [MLIR] Add `print-ir` pass for debugging purposes.

mlir-print-ir-after=pass-name is easy enough to use from the opt tools. However, I could not find an easy way to set that programmatically (or pass the flag through the tests)

Mar 1 2023, 10:30 AM · Restricted Project, Restricted Project

Feb 28 2023

frgossen updated the diff for D144919: [MLIR] Remove redundant scf.if builder.

Rebase

Feb 28 2023, 10:44 AM · Restricted Project, Restricted Project, Restricted Project
frgossen updated the diff for D144919: [MLIR] Remove redundant scf.if builder.

Fix formatting

Feb 28 2023, 10:42 AM · Restricted Project, Restricted Project, Restricted Project
frgossen updated the diff for D144918: [MLIR] Add `print-ir` pass for debugging purposes.

Rebase

Feb 28 2023, 10:38 AM · Restricted Project, Restricted Project
frgossen updated the diff for D144919: [MLIR] Remove redundant scf.if builder.

Fix flang

Feb 28 2023, 9:28 AM · Restricted Project, Restricted Project, Restricted Project
frgossen updated the diff for D144919: [MLIR] Remove redundant scf.if builder.

Rebase

Feb 28 2023, 8:03 AM · Restricted Project, Restricted Project, Restricted Project
frgossen updated the diff for D144918: [MLIR] Add `print-ir` pass for debugging purposes.

Rebase

Feb 28 2023, 7:01 AM · Restricted Project, Restricted Project
frgossen updated the diff for D144918: [MLIR] Add `print-ir` pass for debugging purposes.

Fix Cmake file

Feb 28 2023, 6:29 AM · Restricted Project, Restricted Project

Feb 27 2023

frgossen added a reviewer for D144919: [MLIR] Remove redundant scf.if builder: jpienaar.
Feb 27 2023, 2:39 PM · Restricted Project, Restricted Project, Restricted Project
frgossen requested review of D144919: [MLIR] Remove redundant scf.if builder.
Feb 27 2023, 2:38 PM · Restricted Project, Restricted Project, Restricted Project
frgossen added a reviewer for D144918: [MLIR] Add `print-ir` pass for debugging purposes: pifon2a.
Feb 27 2023, 2:28 PM · Restricted Project, Restricted Project
frgossen requested review of D144918: [MLIR] Add `print-ir` pass for debugging purposes.
Feb 27 2023, 2:27 PM · Restricted Project, Restricted Project
frgossen requested review of D144917: patch mlir D144868.
Feb 27 2023, 2:27 PM · Restricted Project, Restricted Project
frgossen committed rGe7b52c46bf31: [MLIR] Add primitive builders for scf.if (authored by frgossen).
[MLIR] Add primitive builders for scf.if
Feb 27 2023, 10:54 AM · Restricted Project, Restricted Project
frgossen closed D144886: [MLIR] Add primitive builders for scf.if.
Feb 27 2023, 10:54 AM · Restricted Project, Restricted Project
frgossen added a comment to D144886: [MLIR] Add primitive builders for scf.if.

Thanks! Default values are possible but then it collides with the other builder

Feb 27 2023, 10:53 AM · Restricted Project, Restricted Project
frgossen retitled D144886: [MLIR] Add primitive builders for scf.if from BEGIN_PUBLIC [MLIR] Add primitive builders for scf.if END_PUBLIC to [MLIR] Add primitive builders for scf.if.
Feb 27 2023, 10:52 AM · Restricted Project, Restricted Project
frgossen added a reviewer for D144886: [MLIR] Add primitive builders for scf.if: jpienaar.
Feb 27 2023, 8:50 AM · Restricted Project, Restricted Project
frgossen requested review of D144886: [MLIR] Add primitive builders for scf.if.
Feb 27 2023, 8:49 AM · Restricted Project, Restricted Project
frgossen committed rGb12bcf3fb7fa: [MLIR] Add pass to deduplicate functions (authored by frgossen).
[MLIR] Add pass to deduplicate functions
Feb 27 2023, 8:00 AM · Restricted Project, Restricted Project
frgossen closed D144738: [MLIR] Add pass to deduplicate functions.
Feb 27 2023, 8:00 AM · Restricted Project, Restricted Project
frgossen updated the diff for D144738: [MLIR] Add pass to deduplicate functions.

Address comments

Feb 27 2023, 7:59 AM · Restricted Project, Restricted Project
frgossen added a comment to D144738: [MLIR] Add pass to deduplicate functions.

Thanks!

Feb 27 2023, 7:57 AM · Restricted Project, Restricted Project
frgossen committed rG31fc47e3ab8b: [MLIR] Expose region equivalence check through OperationEquivalence (authored by frgossen).
[MLIR] Expose region equivalence check through OperationEquivalence
Feb 27 2023, 7:50 AM · Restricted Project, Restricted Project
frgossen closed D144735: [MLIR] Expose region equivalence check through OperationEquivalence.
Feb 27 2023, 7:50 AM · Restricted Project, Restricted Project

Feb 24 2023

frgossen added a reviewer for D144738: [MLIR] Add pass to deduplicate functions: pifon2a.
Feb 24 2023, 8:18 AM · Restricted Project, Restricted Project
frgossen requested review of D144738: [MLIR] Add pass to deduplicate functions.
Feb 24 2023, 8:17 AM · Restricted Project, Restricted Project
frgossen added a reviewer for D144735: [MLIR] Expose region equivalence check through OperationEquivalence: pifon2a.
Feb 24 2023, 8:02 AM · Restricted Project, Restricted Project
frgossen requested review of D144735: [MLIR] Expose region equivalence check through OperationEquivalence.
Feb 24 2023, 8:02 AM · Restricted Project, Restricted Project

Feb 10 2023

frgossen committed rG3de0bc4c3d02: [MLIR] Reintroduce shared attribute names in the LLVM dialect (authored by frgossen).
[MLIR] Reintroduce shared attribute names in the LLVM dialect
Feb 10 2023, 1:20 PM · Restricted Project, Restricted Project
frgossen closed D143774: [MLIR] Reintroduce shared attribute names in the LLVM dialect.
Feb 10 2023, 1:20 PM · Restricted Project, Restricted Project
frgossen added inline comments to D143774: [MLIR] Reintroduce shared attribute names in the LLVM dialect.
Feb 10 2023, 1:12 PM · Restricted Project, Restricted Project
frgossen updated the diff for D143774: [MLIR] Reintroduce shared attribute names in the LLVM dialect.

Address comment

Feb 10 2023, 1:12 PM · Restricted Project, Restricted Project
frgossen added inline comments to D143654: [mlir][llvm] Store memory op metadata using op attributes..
Feb 10 2023, 12:26 PM · Restricted Project, Restricted Project, Restricted Project
frgossen added a reviewer for D143774: [MLIR] Reintroduce shared attribute names in the LLVM dialect: gysit.
Feb 10 2023, 12:26 PM · Restricted Project, Restricted Project
frgossen requested review of D143774: [MLIR] Reintroduce shared attribute names in the LLVM dialect.
Feb 10 2023, 12:25 PM · Restricted Project, Restricted Project
frgossen added inline comments to D143654: [mlir][llvm] Store memory op metadata using op attributes..
Feb 10 2023, 12:16 PM · Restricted Project, Restricted Project, Restricted Project

Feb 9 2023

frgossen added inline comments to D143514: [mlir][sparse] Port the remaining integration tests to use SVE.
Feb 9 2023, 11:33 AM · Restricted Project, Restricted Project
frgossen added inline comments to D143514: [mlir][sparse] Port the remaining integration tests to use SVE.
Feb 9 2023, 11:29 AM · Restricted Project, Restricted Project

Jan 20 2023

frgossen committed rG1125c5c0b2cf: [MLIR] Remove scf.if builder with explicit result types and callbacks (authored by frgossen).
[MLIR] Remove scf.if builder with explicit result types and callbacks
Jan 20 2023, 7:52 AM · Restricted Project, Restricted Project
frgossen closed D142056: [MLIR] Remove scf.if builder with explicit result types and callbacks.
Jan 20 2023, 7:52 AM · Restricted Project, Restricted Project
frgossen committed rG029f1a4efd25: [MLIR] Address post-submit comments on scf.if's InferTypeOpInterface (authored by frgossen).
[MLIR] Address post-submit comments on scf.if's InferTypeOpInterface
Jan 20 2023, 7:38 AM · Restricted Project, Restricted Project
frgossen closed D142155: [MLIR] Address post-submit comments on scf.if's InferTypeOpInterface.
Jan 20 2023, 7:38 AM · Restricted Project, Restricted Project
frgossen added reviewers for D142155: [MLIR] Address post-submit comments on scf.if's InferTypeOpInterface: pifon2a, jpienaar.
Jan 20 2023, 6:11 AM · Restricted Project, Restricted Project

Jan 19 2023

frgossen added a comment to D142049: [MLIR] Add InferTypeOpInterface to scf.if op.

Thanks!

Jan 19 2023, 1:01 PM · Restricted Project, Restricted Project
frgossen updated the diff for D142155: [MLIR] Address post-submit comments on scf.if's InferTypeOpInterface.

.

Jan 19 2023, 1:01 PM · Restricted Project, Restricted Project
frgossen requested review of D142155: [MLIR] Address post-submit comments on scf.if's InferTypeOpInterface.
Jan 19 2023, 12:57 PM · Restricted Project, Restricted Project
frgossen added a reverting change for rG399b8ee7edf1: [MLIR] Update bazel build file after 455305624884cf9237143e2ba0635fcc5ba5206: rG9ef7ae507387: Revert "[MLIR] Update bazel build file after….
Jan 19 2023, 12:06 PM · Restricted Project
frgossen committed rG9ef7ae507387: Revert "[MLIR] Update bazel build file after… (authored by frgossen).
Revert "[MLIR] Update bazel build file after…
Jan 19 2023, 12:05 PM · Restricted Project
frgossen committed rG399b8ee7edf1: [MLIR] Update bazel build file after 455305624884cf9237143e2ba0635fcc5ba5206 (authored by frgossen).
[MLIR] Update bazel build file after 455305624884cf9237143e2ba0635fcc5ba5206
Jan 19 2023, 11:26 AM · Restricted Project
frgossen committed rG7f66e1833f62: [MLIR] Add InferTypeOpInterface to scf.if op (authored by frgossen).
[MLIR] Add InferTypeOpInterface to scf.if op
Jan 19 2023, 10:20 AM · Restricted Project, Restricted Project
frgossen closed D142049: [MLIR] Add InferTypeOpInterface to scf.if op.
Jan 19 2023, 10:20 AM · Restricted Project, Restricted Project
frgossen updated the diff for D142049: [MLIR] Add InferTypeOpInterface to scf.if op.

Address comments

Jan 19 2023, 10:18 AM · Restricted Project, Restricted Project

Jan 18 2023

frgossen added a reviewer for D142056: [MLIR] Remove scf.if builder with explicit result types and callbacks: jpienaar.
Jan 18 2023, 1:54 PM · Restricted Project, Restricted Project
frgossen requested review of D142056: [MLIR] Remove scf.if builder with explicit result types and callbacks.
Jan 18 2023, 1:53 PM · Restricted Project, Restricted Project
frgossen abandoned D141703: [MLIR] Add `OpFoldResult` builder to tensor.dim op.
Jan 18 2023, 11:35 AM · Restricted Project, Restricted Project
frgossen added a reviewer for D142049: [MLIR] Add InferTypeOpInterface to scf.if op: pifon2a.
Jan 18 2023, 11:22 AM · Restricted Project, Restricted Project
frgossen added a reviewer for D142049: [MLIR] Add InferTypeOpInterface to scf.if op: jpienaar.
Jan 18 2023, 11:19 AM · Restricted Project, Restricted Project
frgossen retitled D142049: [MLIR] Add InferTypeOpInterface to scf.if op from BEGIN_PUBLIC [MLIR] Add InferTypeOpInterface to scf.if op END_PUBLIC to [MLIR] Add InferTypeOpInterface to scf.if op.
Jan 18 2023, 11:19 AM · Restricted Project, Restricted Project
frgossen requested review of D142049: [MLIR] Add InferTypeOpInterface to scf.if op.
Jan 18 2023, 11:18 AM · Restricted Project, Restricted Project

Jan 17 2023

frgossen committed rGd2f136920b92: [MLIR] Add return type inference to scf.if builder (authored by frgossen).
[MLIR] Add return type inference to scf.if builder
Jan 17 2023, 11:10 AM · Restricted Project, Restricted Project
frgossen closed D141928: [MLIR] Add return type inference to scf.if builder.
Jan 17 2023, 11:10 AM · Restricted Project, Restricted Project
frgossen updated the diff for D141928: [MLIR] Add return type inference to scf.if builder.

Add TODO

Jan 17 2023, 11:07 AM · Restricted Project, Restricted Project
frgossen added a comment to D141804: [mlir][linalg] Omit printing result types for named ops..

In strong favour of this.
All IR should be readable, especially linalg, which is not the easiest dialect.

Jan 17 2023, 8:43 AM · Restricted Project, Restricted Project
frgossen added a comment to D141928: [MLIR] Add return type inference to scf.if builder.

Could you perhaps expand on that exception or point to where this is assumed? Are these where during a pass an invalid state is created or is this across passes?

Jan 17 2023, 8:28 AM · Restricted Project, Restricted Project
frgossen added a comment to D141928: [MLIR] Add return type inference to scf.if builder.

We cannot generally infer the return type as there are use cases relying on the old behaviour.
In particular, cases which expect an empty yield op to be generated just to replace it afterwards.

Jan 17 2023, 6:15 AM · Restricted Project, Restricted Project
frgossen requested review of D141928: [MLIR] Add return type inference to scf.if builder.
Jan 17 2023, 6:11 AM · Restricted Project, Restricted Project
frgossen abandoned D85634: [MLIR][Standard] Fix cast materialization for incompatible types.
Jan 17 2023, 6:10 AM · Restricted Project, Restricted Project
frgossen abandoned D110459: [MLIR] Improve calling convention for unranked memory descriptor results..
Jan 17 2023, 6:09 AM · Restricted Project, Restricted Project
frgossen abandoned D128353: [MLIR] Add LLVM_NODISCARD to MLIR builders for types and attributes..
Jan 17 2023, 6:09 AM · Restricted Project, Restricted Project
frgossen added a comment to D141703: [MLIR] Add `OpFoldResult` builder to tensor.dim op.

Don't feel strong about this though, so we can discard this also.

Jan 17 2023, 6:01 AM · Restricted Project, Restricted Project
frgossen added a comment to D141703: [MLIR] Add `OpFoldResult` builder to tensor.dim op.

Right, getValueOrCreateConstantIndexOp works.
As there is a builder for int64_t, which creates a constant one for OpFoldResult would be the natural completion, no?

Jan 17 2023, 6:01 AM · Restricted Project, Restricted Project

Jan 13 2023

frgossen requested review of D141703: [MLIR] Add `OpFoldResult` builder to tensor.dim op.
Jan 13 2023, 9:48 AM · Restricted Project, Restricted Project

Jan 3 2023

frgossen added a comment to D140013: [mlir][tosa] Fix out-of-boundaries iteration for tosa-to-linalg.

This failed our internal tests. I think the issue is *not* with your revision but a test case would be nice here!
Could you add a test for the reshape op explicitly?

Jan 3 2023, 3:23 PM · Restricted Project, Restricted Project

Sep 20 2022

frgossen committed rG6e50d6641944: [MLIR] Update bazel build files after 242d558658cd5a480b02883e2982d7246342e0d0 (authored by frgossen).
[MLIR] Update bazel build files after 242d558658cd5a480b02883e2982d7246342e0d0
Sep 20 2022, 12:20 PM · Restricted Project
frgossen closed D134301: [MLIR] Update bazel build files after 242d558658cd5a480b02883e2982d7246342e0d0.
Sep 20 2022, 12:20 PM · Restricted Project, Restricted Project
frgossen added a reviewer for D134301: [MLIR] Update bazel build files after 242d558658cd5a480b02883e2982d7246342e0d0: cmtice.
Sep 20 2022, 12:14 PM · Restricted Project, Restricted Project
frgossen requested review of D134301: [MLIR] Update bazel build files after 242d558658cd5a480b02883e2982d7246342e0d0.
Sep 20 2022, 12:11 PM · Restricted Project, Restricted Project

Sep 14 2022

frgossen accepted D133793: [MLIR] Add getI2Type/getI4Type/getI16type to `OpBuilder`.
Sep 14 2022, 8:32 AM · Restricted Project, Restricted Project

Sep 2 2022

frgossen added a comment to D133076: [mlir][arith] Change the syntax of `arith.cmpi/f`.

I am not conviced that this is an improvement but this is highly subjective ofc.

Sep 2 2022, 2:15 AM · Restricted Project, Restricted Project, Restricted Project

Aug 17 2022

frgossen committed rG894e8a5446dc: [MLIR] Add dealloc alias check to bufferization (authored by kushanam).
[MLIR] Add dealloc alias check to bufferization
Aug 17 2022, 4:12 PM · Restricted Project, Restricted Project
frgossen closed D131797: add dealloc alias check to bufferization.
Aug 17 2022, 4:12 PM · Restricted Project, Restricted Project
frgossen added a comment to D131797: add dealloc alias check to bufferization.

The Ci is running but I do not see any changed. This is strange.

Aug 17 2022, 2:52 PM · Restricted Project, Restricted Project