Page MenuHomePhabricator

frgossen (Frederik Gossen)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 3 2020, 3:29 AM (117 w, 4 d)

Recent Activity

Fri, Jun 24

frgossen added a reviewer for D128353: [MLIR] Add LLVM_NODISCARD to MLIR builders for types and attributes.: jpienaar.
Fri, Jun 24, 8:36 AM · Restricted Project, Restricted Project

Thu, Jun 23

frgossen committed rG02d29afd16d7: [MLIR] Add `decomposeMixedStridesOrOffsets` and `decomposeMixedSizes` (authored by frgossen).
[MLIR] Add `decomposeMixedStridesOrOffsets` and `decomposeMixedSizes`
Thu, Jun 23, 4:09 PM · Restricted Project, Restricted Project
frgossen closed D128376: [MLIR] Add `decomposeMixedStridesOrOffsets` and `decomposeMixedSizes`.
Thu, Jun 23, 4:09 PM · Restricted Project, Restricted Project

Wed, Jun 22

frgossen added a reviewer for D128376: [MLIR] Add `decomposeMixedStridesOrOffsets` and `decomposeMixedSizes`: pifon2a.
Wed, Jun 22, 1:37 PM · Restricted Project, Restricted Project
frgossen requested review of D128376: [MLIR] Add `decomposeMixedStridesOrOffsets` and `decomposeMixedSizes`.
Wed, Jun 22, 1:37 PM · Restricted Project, Restricted Project
frgossen retitled D128353: [MLIR] Add LLVM_NODISCARD to MLIR builders for types and attributes. from Add LLVM_NODISCARD to MLIR builders for types and attributes. to [MLIR] Add LLVM_NODISCARD to MLIR builders for types and attributes..
Wed, Jun 22, 1:30 PM · Restricted Project, Restricted Project
frgossen added a comment to D128353: [MLIR] Add LLVM_NODISCARD to MLIR builders for types and attributes..

Added rationale

Wed, Jun 22, 1:28 PM · Restricted Project, Restricted Project
frgossen updated the summary of D128353: [MLIR] Add LLVM_NODISCARD to MLIR builders for types and attributes..
Wed, Jun 22, 1:28 PM · Restricted Project, Restricted Project
frgossen added a reviewer for D128353: [MLIR] Add LLVM_NODISCARD to MLIR builders for types and attributes.: pifon2a.
Wed, Jun 22, 12:07 PM · Restricted Project, Restricted Project
frgossen requested review of D128353: [MLIR] Add LLVM_NODISCARD to MLIR builders for types and attributes..
Wed, Jun 22, 9:01 AM · Restricted Project, Restricted Project

Fri, Jun 17

frgossen added a reviewer for D128078: [mlir][nvgpu] Fix Bazel BUILD file: christopherbate.
Fri, Jun 17, 11:37 AM · Restricted Project, Restricted Project
frgossen committed rGe694b2234430: [mlir][nvgpu] Fix Bazel BUILD file (authored by frgossen).
[mlir][nvgpu] Fix Bazel BUILD file
Fri, Jun 17, 11:36 AM · Restricted Project
frgossen closed D128078: [mlir][nvgpu] Fix Bazel BUILD file.
Fri, Jun 17, 11:35 AM · Restricted Project, Restricted Project
frgossen added a reviewer for D128078: [mlir][nvgpu] Fix Bazel BUILD file: aartbik.
Fri, Jun 17, 11:34 AM · Restricted Project, Restricted Project
frgossen requested review of D128078: [mlir][nvgpu] Fix Bazel BUILD file.
Fri, Jun 17, 11:33 AM · Restricted Project, Restricted Project

Thu, Jun 16

frgossen added a comment to rG3cd5696a3309: Revert "Reland "Reland "[X86][RFC] Enable `_Float16` type support on X86….

Hi Phoebe,
I could reproduce the exact same failure through llc but I am not exactly sure what flags to pass for it to optimize the IR in the same way as the XLA JIT does.
Below, you find the optimized IR that was dumped out of the JIT. When running this through llc, I get the failure that is also included below.

Thu, Jun 16, 8:21 AM · Restricted Project, Restricted Project, Restricted Project
frgossen added a comment to rG3cd5696a3309: Revert "Reland "Reland "[X86][RFC] Enable `_Float16` type support on X86….

Will try putting a command together. This failed in a JIT compiler and I do know that it does not fail reliably, possibly only on certain CPUs.

Thu, Jun 16, 6:41 AM · Restricted Project, Restricted Project, Restricted Project

Wed, Jun 15

frgossen added a reverting change for rGe1c5afa47d37: Reland "Reland "[X86][RFC] Enable `_Float16` type support on X86 following the…: rG3cd5696a3309: Revert "Reland "Reland "[X86][RFC] Enable `_Float16` type support on X86….
Wed, Jun 15, 3:07 PM · Restricted Project, Restricted Project, Restricted Project
frgossen committed rG3cd5696a3309: Revert "Reland "Reland "[X86][RFC] Enable `_Float16` type support on X86… (authored by frgossen).
Revert "Reland "Reland "[X86][RFC] Enable `_Float16` type support on X86…
Wed, Jun 15, 3:07 PM · Restricted Project, Restricted Project, Restricted Project

Tue, Jun 14

frgossen added a reverting change for rG9dea11728340: [mlir] Add a generic data-flow analysis framework: rGa6fa12ab3b47: Revert "[mlir] Add a generic data-flow analysis framework".
Tue, Jun 14, 2:15 PM · Restricted Project, Restricted Project
frgossen committed rGa6fa12ab3b47: Revert "[mlir] Add a generic data-flow analysis framework" (authored by frgossen).
Revert "[mlir] Add a generic data-flow analysis framework"
Tue, Jun 14, 2:15 PM · Restricted Project, Restricted Project
frgossen added a reverting change for D126751: [mlir] Add a generic data-flow analysis framework: rGa6fa12ab3b47: Revert "[mlir] Add a generic data-flow analysis framework".
Tue, Jun 14, 2:14 PM · Restricted Project, Restricted Project

Mon, Jun 13

frgossen committed rGff6ce9e8fc7c: Add `createDynamicDimValues` to tensor dialect utils (authored by frgossen).
Add `createDynamicDimValues` to tensor dialect utils
Mon, Jun 13, 5:27 AM · Restricted Project, Restricted Project
frgossen closed D127533: Add createDynamicDimOps to tensor dialect utils.
Mon, Jun 13, 5:27 AM · Restricted Project, Restricted Project
frgossen added a comment to D127533: Add createDynamicDimOps to tensor dialect utils.

Thanks

Mon, Jun 13, 5:25 AM · Restricted Project, Restricted Project
frgossen updated the diff for D127533: Add createDynamicDimOps to tensor dialect utils.

Address comments

Mon, Jun 13, 5:25 AM · Restricted Project, Restricted Project

Fri, Jun 10

frgossen added reviewers for D127533: Add createDynamicDimOps to tensor dialect utils: pifon2a, akuegel.
Fri, Jun 10, 1:26 PM · Restricted Project, Restricted Project
frgossen requested review of D127533: Add createDynamicDimOps to tensor dialect utils.
Fri, Jun 10, 1:25 PM · Restricted Project, Restricted Project

May 18 2022

frgossen committed rG6d36cfed3b5d: [MLIR] Make `parseDimensionListRanked` configurable wrt parsing a trailing `x` (authored by frgossen).
[MLIR] Make `parseDimensionListRanked` configurable wrt parsing a trailing `x`
May 18 2022, 2:43 AM · Restricted Project, Restricted Project
frgossen closed D125797: [MLIR] Make `parseDimensionListRanked` configurable wrt parsing a trailing `x`.
May 18 2022, 2:43 AM · Restricted Project, Restricted Project
frgossen added a comment to D125797: [MLIR] Make `parseDimensionListRanked` configurable wrt parsing a trailing `x`.

Thanks!

May 18 2022, 2:30 AM · Restricted Project, Restricted Project
frgossen updated the diff for D125797: [MLIR] Make `parseDimensionListRanked` configurable wrt parsing a trailing `x`.

Address comments

May 18 2022, 2:15 AM · Restricted Project, Restricted Project

May 17 2022

frgossen updated the summary of D125797: [MLIR] Make `parseDimensionListRanked` configurable wrt parsing a trailing `x`.
May 17 2022, 8:29 AM · Restricted Project, Restricted Project
frgossen requested review of D125797: [MLIR] Make `parseDimensionListRanked` configurable wrt parsing a trailing `x`.
May 17 2022, 8:28 AM · Restricted Project, Restricted Project

May 3 2022

frgossen accepted D124773: [mlir] Add sin & cos ops to complex dialect.

Awesome, thanks!!

May 3 2022, 10:18 AM · Restricted Project, Restricted Project
frgossen added inline comments to D124773: [mlir] Add sin & cos ops to complex dialect.
May 3 2022, 9:18 AM · Restricted Project, Restricted Project
frgossen added inline comments to D124773: [mlir] Add sin & cos ops to complex dialect.
May 3 2022, 8:05 AM · Restricted Project, Restricted Project
frgossen added a comment to D124773: [mlir] Add sin & cos ops to complex dialect.

Awesome! Thank you!

May 3 2022, 8:02 AM · Restricted Project, Restricted Project

Apr 26 2022

frgossen added a comment to D123641: Fix iteration counting in greedy pattern application.

Hi Mike,

Apr 26 2022, 9:24 AM · Restricted Project, Restricted Project

Apr 25 2022

frgossen committed rG8fbf9acc8c67: Add missing comparison operators to SmallVector (authored by frgossen).
Add missing comparison operators to SmallVector
Apr 25 2022, 3:18 PM · Restricted Project, Restricted Project
frgossen closed D124407: Add missing comparison operators to SmallVector.
Apr 25 2022, 3:18 PM · Restricted Project, Restricted Project
frgossen updated the diff for D124407: Add missing comparison operators to SmallVector.

Add tests

Apr 25 2022, 2:45 PM · Restricted Project, Restricted Project
frgossen added a reviewer for D124407: Add missing comparison operators to SmallVector: bkramer.
Apr 25 2022, 10:47 AM · Restricted Project, Restricted Project
frgossen requested review of D124407: Add missing comparison operators to SmallVector.
Apr 25 2022, 10:47 AM · Restricted Project, Restricted Project

Apr 21 2022

frgossen committed rG673e9828be2c: [MLIR] Fix iteration counting in greedy pattern application (authored by frgossen).
[MLIR] Fix iteration counting in greedy pattern application
Apr 21 2022, 12:18 PM · Restricted Project, Restricted Project
frgossen closed D123641: Fix iteration counting in greedy pattern application.
Apr 21 2022, 12:17 PM · Restricted Project, Restricted Project

Apr 13 2022

frgossen added inline comments to D123641: Fix iteration counting in greedy pattern application.
Apr 13 2022, 7:25 AM · Restricted Project, Restricted Project

Apr 12 2022

frgossen added a reviewer for D123641: Fix iteration counting in greedy pattern application: pifon2a.
Apr 12 2022, 4:03 PM · Restricted Project, Restricted Project
frgossen requested review of D123641: Fix iteration counting in greedy pattern application.
Apr 12 2022, 4:02 PM · Restricted Project, Restricted Project

Mar 29 2022

frgossen added a comment to D120905: [demangler] Add operator precedence.

It's wrapping the function args. I think it's just the space that confused me. Here's the example for completeness.

Mar 29 2022, 10:49 AM · Restricted Project, Restricted Project, Restricted Project
frgossen added a comment to D120905: [demangler] Add operator precedence.

I see parenthesis around simple types like int. Not sure if this is intended.

Mar 29 2022, 10:25 AM · Restricted Project, Restricted Project, Restricted Project

Mar 28 2022

frgossen abandoned D122621: Add missing case `HLSL` to `ParseLangArgs` in `TypeSystemClang.cpp`.
Mar 28 2022, 4:38 PM · Restricted Project, Restricted Project
frgossen requested review of D122621: Add missing case `HLSL` to `ParseLangArgs` in `TypeSystemClang.cpp`.
Mar 28 2022, 4:36 PM · Restricted Project, Restricted Project
frgossen added inline comments to D120905: [demangler] Add operator precedence.
Mar 28 2022, 1:31 PM · Restricted Project, Restricted Project, Restricted Project

Mar 10 2022

frgossen abandoned D121389: [MLIR] Allow empty vector type attributes.

Thanks!
After reading the documentation, I think I was just using the wrong thing.

Mar 10 2022, 10:56 AM · Restricted Project, Restricted Project
frgossen requested review of D121389: [MLIR] Allow empty vector type attributes.
Mar 10 2022, 9:49 AM · Restricted Project, Restricted Project

Feb 6 2022

frgossen accepted D119043: [mlir] Add canonicalizer to remove redundant shape.cstr_broadcastable ops.

That's a nice way of doing this. Thanks for adding this.

Feb 6 2022, 2:23 PM · Restricted Project

Feb 4 2022

frgossen accepted D119025: [mlir] Add canonicalizer to merge shape.assuming_all ops.

Thanks for adding this.

Feb 4 2022, 12:32 PM · Restricted Project

Jan 27 2022

frgossen committed rG2c7b0685e179: Fix tensor.extract for complex elements (authored by frgossen).
Fix tensor.extract for complex elements
Jan 27 2022, 7:33 PM

Nov 16 2021

frgossen committed rG3f3d4e8a15a7: Fix unused variable warning in LoadStoreOpt.cpp with (void) (authored by frgossen).
Fix unused variable warning in LoadStoreOpt.cpp with (void)
Nov 16 2021, 3:05 AM
frgossen committed rG2bceb7c8dae2: Revert "Fix unused variable in llvm/lib/CodeGen/GlobalISel/LoadStoreOpt.cpp" (authored by frgossen).
Revert "Fix unused variable in llvm/lib/CodeGen/GlobalISel/LoadStoreOpt.cpp"
Nov 16 2021, 3:01 AM
frgossen added a reverting change for rG40a609aebe4a: Fix unused variable in llvm/lib/CodeGen/GlobalISel/LoadStoreOpt.cpp: rG2bceb7c8dae2: Revert "Fix unused variable in llvm/lib/CodeGen/GlobalISel/LoadStoreOpt.cpp".
Nov 16 2021, 3:01 AM
frgossen added a reverting change for rGa062e2a8ca27: Fix unused variable warning.: rGecfe7a340440: Revert "Fix unused variable warning.".
Nov 16 2021, 3:00 AM
frgossen committed rGecfe7a340440: Revert "Fix unused variable warning." (authored by frgossen).
Revert "Fix unused variable warning."
Nov 16 2021, 3:00 AM
frgossen added a reverting change for rG5b84ae7c4808: Fix another unused variable error.: rG9a6817b7edb4: Revert "Fix another unused variable error.".
Nov 16 2021, 2:59 AM
frgossen committed rG9a6817b7edb4: Revert "Fix another unused variable error." (authored by frgossen).
Revert "Fix another unused variable error."
Nov 16 2021, 2:59 AM
frgossen committed rG40a609aebe4a: Fix unused variable in llvm/lib/CodeGen/GlobalISel/LoadStoreOpt.cpp (authored by frgossen).
Fix unused variable in llvm/lib/CodeGen/GlobalISel/LoadStoreOpt.cpp
Nov 16 2021, 2:06 AM

Oct 12 2021

frgossen accepted D111651: [mlir][Shape] Add a pattern to turn extract from shape_of into tensor.dim.

Thanks!

Oct 12 2021, 9:44 AM · Restricted Project
frgossen added a comment to D110459: [MLIR] Improve calling convention for unranked memory descriptor results..

Friendly ping

Oct 12 2021, 5:10 AM · Restricted Project

Oct 7 2021

frgossen accepted D111139: [mlir] Don't allow dynamic extent tensor types for ConstShapeOp..

Sg.

Oct 7 2021, 1:38 AM · Restricted Project

Oct 6 2021

frgossen updated the diff for D110459: [MLIR] Improve calling convention for unranked memory descriptor results..

Add documentation

Oct 6 2021, 6:07 AM · Restricted Project

Oct 5 2021

frgossen added inline comments to D110459: [MLIR] Improve calling convention for unranked memory descriptor results..
Oct 5 2021, 3:40 PM · Restricted Project
frgossen added a comment to D111139: [mlir] Don't allow dynamic extent tensor types for ConstShapeOp..

I agree, dynamically shaped constants seem counter-intuitive. They may be needed for folding ops w/o changing their result type though.

Oct 5 2021, 6:11 AM · Restricted Project
frgossen committed rG519663bebaf1: [MLIR] Add an option to disable `maxIterations` in greedy pattern rewrites (authored by frgossen).
[MLIR] Add an option to disable `maxIterations` in greedy pattern rewrites
Oct 5 2021, 2:49 AM
frgossen closed D111058: [MLIR] Add an option to disable `maxIterations` in greedy pattern rewrites.
Oct 5 2021, 2:49 AM · Restricted Project
frgossen updated the diff for D110459: [MLIR] Improve calling convention for unranked memory descriptor results..

Address comments

Oct 5 2021, 2:40 AM · Restricted Project

Oct 4 2021

frgossen added a reviewer for D111058: [MLIR] Add an option to disable `maxIterations` in greedy pattern rewrites: jpienaar.
Oct 4 2021, 10:23 AM · Restricted Project
frgossen updated the summary of D110459: [MLIR] Improve calling convention for unranked memory descriptor results..
Oct 4 2021, 10:13 AM · Restricted Project
frgossen added a comment to D110459: [MLIR] Improve calling convention for unranked memory descriptor results..

Thanks for the useful comments :) I see how the description did not make this clear, which is updated now.

Oct 4 2021, 10:11 AM · Restricted Project
frgossen updated the diff for D110459: [MLIR] Improve calling convention for unranked memory descriptor results..

Address comments

Oct 4 2021, 10:11 AM · Restricted Project
frgossen added a reviewer for D111058: [MLIR] Add an option to disable `maxIterations` in greedy pattern rewrites: lattner.
Oct 4 2021, 7:44 AM · Restricted Project
frgossen requested review of D111058: [MLIR] Add an option to disable `maxIterations` in greedy pattern rewrites.
Oct 4 2021, 7:42 AM · Restricted Project

Sep 24 2021

frgossen added a reviewer for D110459: [MLIR] Improve calling convention for unranked memory descriptor results.: herhut.
Sep 24 2021, 4:50 PM · Restricted Project
frgossen requested review of D110459: [MLIR] Improve calling convention for unranked memory descriptor results..
Sep 24 2021, 4:50 PM · Restricted Project

Aug 25 2021

frgossen accepted D108561: [mlir] Handle null attributes on TiledLoopOp creation..
Aug 25 2021, 12:56 AM · Restricted Project

Aug 24 2021

frgossen added inline comments to D108561: [mlir] Handle null attributes on TiledLoopOp creation..
Aug 24 2021, 3:16 AM · Restricted Project

Aug 19 2021

frgossen committed rGc20cb5547ddd: Avoid unused variable when NDEBUG (authored by frgossen).
Avoid unused variable when NDEBUG
Aug 19 2021, 4:00 AM

Aug 3 2021

frgossen committed rGf0008a4cf435: [MLIR] Add `getI8Type` to `OpBuilder` (authored by frgossen).
[MLIR] Add `getI8Type` to `OpBuilder`
Aug 3 2021, 2:43 AM
frgossen closed D107332: [MLIR] Add `getI8Type` to `OpBuilder`.
Aug 3 2021, 2:43 AM · Restricted Project
frgossen requested review of D107332: [MLIR] Add `getI8Type` to `OpBuilder`.
Aug 3 2021, 2:34 AM · Restricted Project

Jul 13 2021

frgossen committed rG9c90725eaee5: [MLIR] Fix documentation of the `ExecutionEngine` in the toy tutorial example (authored by frgossen).
[MLIR] Fix documentation of the `ExecutionEngine` in the toy tutorial example
Jul 13 2021, 4:24 AM
frgossen closed D105813: MLIR] Fix documentation of the `ExecutionEngine` in the toy tutorial example.
Jul 13 2021, 4:24 AM · Restricted Project

Jul 12 2021

frgossen added reviewers for D105813: MLIR] Fix documentation of the `ExecutionEngine` in the toy tutorial example: tpopp, pifon2a.
Jul 12 2021, 6:39 AM · Restricted Project
frgossen requested review of D105813: MLIR] Fix documentation of the `ExecutionEngine` in the toy tutorial example.
Jul 12 2021, 6:38 AM · Restricted Project
frgossen committed rGed1f149b54c2: [MLIR][StandardToLLVM] Move `copyUnrankedDescriptors` to pattern (authored by frgossen).
[MLIR][StandardToLLVM] Move `copyUnrankedDescriptors` to pattern
Jul 12 2021, 6:35 AM
frgossen closed D105810: [MLIR][StandardToLLVM] Move `copyUnrankedDescriptors` to pattern.
Jul 12 2021, 6:35 AM · Restricted Project
frgossen added a comment to D105810: [MLIR][StandardToLLVM] Move `copyUnrankedDescriptors` to pattern.

Thanks!

Jul 12 2021, 6:15 AM · Restricted Project
frgossen updated the diff for D105810: [MLIR][StandardToLLVM] Move `copyUnrankedDescriptors` to pattern.

Address comment

Jul 12 2021, 6:14 AM · Restricted Project
frgossen added reviewers for D105810: [MLIR][StandardToLLVM] Move `copyUnrankedDescriptors` to pattern: pifon2a, tpopp.
Jul 12 2021, 5:15 AM · Restricted Project
frgossen requested review of D105810: [MLIR][StandardToLLVM] Move `copyUnrankedDescriptors` to pattern.
Jul 12 2021, 5:14 AM · Restricted Project