User Details
- User Since
- Apr 3 2020, 3:29 AM (156 w, 1 d)
Tue, Mar 21
Address comments
Mon, Mar 20
Addrwss comments
Thanks for the comments. I addressed them in https://reviews.llvm.org/D146456.
Fri, Mar 17
Mon, Mar 13
Tue, Mar 7
Fri, Mar 3
Could you share a reference use of these interfaces? I'm not very familiar with this myself, just remember that it broke our tests last time.
Mar 1 2023
.
.
Address comments
mlir-print-ir-after=pass-name is easy enough to use from the opt tools. However, I could not find an easy way to set that programmatically (or pass the flag through the tests)
Feb 28 2023
Rebase
Fix formatting
Rebase
Fix flang
Rebase
Rebase
Fix Cmake file
Feb 27 2023
Thanks! Default values are possible but then it collides with the other builder
Address comments
Thanks!
Feb 24 2023
Feb 10 2023
Address comment
Feb 9 2023
Jan 20 2023
Jan 19 2023
Thanks!
.
Address comments
Jan 18 2023
Jan 17 2023
Add TODO
In strong favour of this.
All IR should be readable, especially linalg, which is not the easiest dialect.
We cannot generally infer the return type as there are use cases relying on the old behaviour.
In particular, cases which expect an empty yield op to be generated just to replace it afterwards.
Don't feel strong about this though, so we can discard this also.
Right, getValueOrCreateConstantIndexOp works.
As there is a builder for int64_t, which creates a constant one for OpFoldResult would be the natural completion, no?
Jan 13 2023
Jan 3 2023
This failed our internal tests. I think the issue is *not* with your revision but a test case would be nice here!
Could you add a test for the reshape op explicitly?
Sep 20 2022
Sep 14 2022
Sep 2 2022
I am not conviced that this is an improvement but this is highly subjective ofc.
Aug 17 2022
The Ci is running but I do not see any changed. This is strange.