Page MenuHomePhabricator

[MLIR][Shape] Lower `shape.size_eq` to the standard dialect
AcceptedPublic

Authored by frgossen on Jun 25 2020, 2:06 AM.

Details

Reviewers
pifon2a
Summary

Lower shape.size_eq to the standard dialect's cmpi operation.

Depends On D82628

Diff Detail

Event Timeline

frgossen created this revision.Jun 25 2020, 2:06 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 25 2020, 2:06 AM
pifon2a requested changes to this revision.Jun 25 2020, 3:49 AM
pifon2a added inline comments.
mlir/lib/Conversion/ShapeToStandard/ShapeToStandard.cpp
105

shouldn't this check be a part of verify()?

mlir/test/Conversion/ShapeToStandard/shape-to-standard.mlir
124

just CHECK or CHECK-NEXT?

This revision now requires changes to proceed.Jun 25 2020, 3:49 AM
pifon2a accepted this revision.Jun 25 2020, 3:50 AM
pifon2a added inline comments.
mlir/lib/Conversion/ShapeToStandard/ShapeToStandard.cpp
105

oh, i saw another PR

This revision is now accepted and ready to land.Jun 25 2020, 3:50 AM
pifon2a added inline comments.Jun 25 2020, 3:51 AM
mlir/lib/Conversion/ShapeToStandard/ShapeToStandard.cpp
105

in general, i would prefer having here

if (!operandTy.isa<SizeType>())
      return failure();

and

if (!operandTy.isa<ShapeType>())
      return failure();

in the SCF counter-part.

frgossen updated this revision to Diff 273306.Jun 25 2020, 4:44 AM
frgossen marked 4 inline comments as done.

Address comments

frgossen retitled this revision from [MLIR][Shape] Lower `shape.eq` to the standard dialect to [MLIR][Shape] Lower `shape.size_eq` to the standard dialect.Jun 26 2020, 1:47 AM
frgossen edited the summary of this revision. (Show Details)