Page MenuHomePhabricator
Differential D82533

[MLIR][Shape] Fold `shape.shape_eq`
ClosedPublic
Actions

Authored by frgossen on Jun 25 2020, 2:02 AM.

Details

Reviewers
silvas
tpopp
jpienaar
Commits
rGf9595857b9f8: [MLIR][Shape] Fold `shape.shape_eq`
Summary

Fold shape.shape_eq.

Depends On D82528

Diff Detail

Event Timeline

frgossen created this revision.Jun 25 2020, 2:02 AM
Herald added a reviewer: silvas. · View Herald TranscriptJun 25 2020, 2:02 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: msifontes, jurahul, Kayjukh and 14 others. · View Herald Transcript
frgossen added a reviewer: tpopp.Jun 25 2020, 2:03 AM
Harbormaster failed remote builds in B61679: Diff 273263!Jun 25 2020, 2:30 AM
frgossen updated this revision to Diff 273382.Jun 25 2020, 8:27 AM

Remove CHECK-DAGs

Harbormaster failed remote builds in B61747: Diff 273382!Jun 25 2020, 9:07 AM
silvas accepted this revision.Jun 25 2020, 10:09 AM

LGTM, modulo splitting into two ops and a nit.

mlir/lib/Dialect/Shape/IR/Shape.cpp
501

can you use std::equal or check in STLExtras.h if we have a range version? That should make this more compact.

(actually, adding range_equal to STLExtras.h would be cool, then after splitting into two ops this could be just llvm::range_equal(lhs.cast<DenseIntElementsAttr>(), rhs.cast<DenseIntElementsAttr>()))

This revision is now accepted and ready to land.Jun 25 2020, 10:09 AM
frgossen updated this revision to Diff 273656.Jun 26 2020, 4:02 AM
frgossen marked 2 inline comments as done.

Simplify folding

Herald added a reviewer: jpienaar. · View Herald TranscriptJun 26 2020, 4:02 AM
This revision now requires review to proceed.Jun 26 2020, 4:02 AM
frgossen added inline comments.Jun 26 2020, 4:02 AM
mlir/lib/Dialect/Shape/IR/Shape.cpp
501

Turns out there is actually == defined on these.
Thanks!

Harbormaster failed remote builds in B61898: Diff 273656!Jun 26 2020, 4:20 AM
frgossen retitled this revision from [MLIR][Shape] Fold `shape.eq` for shapes. to [MLIR][Shape] Fold `shape.shape_eq`.Jun 29 2020, 6:58 AM
frgossen edited the summary of this revision. (Show Details)
frgossen added a parent revision: D82528: [MLIR][Shape] Add `shape.shape_eq` operation.
frgossen updated this revision to Diff 274110.Jun 29 2020, 7:12 AM

Rebase

Harbormaster failed remote builds in B62150: Diff 274110!Jun 29 2020, 7:33 AM
frgossen updated this revision to Diff 277349.Jul 13 2020, 2:23 AM

Rebase

Harbormaster failed remote builds in B63922: Diff 277349!Jul 13 2020, 2:24 AM
silvas accepted this revision.Jul 13 2020, 10:04 AM
jpienaar accepted this revision.Sun, Jul 19, 3:08 PM
This revision is now accepted and ready to land.Sun, Jul 19, 3:08 PM
frgossen updated this revision to Diff 279191.Mon, Jul 20, 5:24 AM

Rebase

Harbormaster failed remote builds in B64894: Diff 279191!Mon, Jul 20, 5:25 AM
Closed by commit rGf9595857b9f8: [MLIR][Shape] Fold `shape.shape_eq` (authored by frgossen). · Explain WhyMon, Jul 20, 5:26 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
mlir/
include/
mlir/
Dialect/
Shape/
IR/
1 line
lib/
Dialect/
Shape/
IR/
14 lines
test/
Dialect/
Shape/
53 lines

Diff 279193

View Options

mlir/include/mlir/Dialect/Shape/IR/ShapeOps.td

Loading...
View Options

mlir/lib/Dialect/Shape/IR/Shape.cpp

Loading...
View Options

mlir/test/Dialect/Shape/canonicalize.mlir

Loading...