Fold shape.shape_eq.
Depends On D82528
Paths
| Differential D82533
[MLIR][Shape] Fold `shape.shape_eq` ClosedPublic Authored by frgossen on Jun 25 2020, 2:02 AM.
Details
Summary Fold shape.shape_eq. Depends On D82528
Diff Detail
Event TimelineComment Actions LGTM, modulo splitting into two ops and a nit.
This revision is now accepted and ready to land.Jun 25 2020, 10:09 AM This revision now requires review to proceed.Jun 26 2020, 4:02 AM
frgossen retitled this revision from [MLIR][Shape] Fold `shape.eq` for shapes. to [MLIR][Shape] Fold `shape.shape_eq`.Jun 29 2020, 6:58 AM This revision is now accepted and ready to land.Jul 19 2020, 3:08 PM Closed by commit rGf9595857b9f8: [MLIR][Shape] Fold `shape.shape_eq` (authored by frgossen). · Explain WhyJul 20 2020, 5:26 AM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 279193 mlir/include/mlir/Dialect/Shape/IR/ShapeOps.td
mlir/lib/Dialect/Shape/IR/Shape.cpp
mlir/test/Dialect/Shape/canonicalize.mlir
|
can you use std::equal or check in STLExtras.h if we have a range version? That should make this more compact.
(actually, adding range_equal to STLExtras.h would be cool, then after splitting into two ops this could be just llvm::range_equal(lhs.cast<DenseIntElementsAttr>(), rhs.cast<DenseIntElementsAttr>()))