Page MenuHomePhabricator

[MLIR] Modify HasParent trait to allow one of several op's as a parent
ClosedPublic

Authored by jurahul on Jun 15 2020, 2:08 PM.

Details

Summary
  • Modify HasParent trait to allow one of several op's as a parent -
  • Expose this trait in the ODS framework using the ParentOneOf<> trait.

Diff Detail

Unit TestsFailed

TimeTest
130 mslinux > MLIR.Target::Unknown Unit Message ("")
Script: -- : 'RUN: at line 1'; /mnt/disks/ssd0/agent/premerge-debian-5d5d95fcbb-cs8pv-1/llvm-project/premerge-checks/build/bin/mlir-translate -mlir-to-llvmir /mnt/disks/ssd0/agent/premerge-debian-5d5d95fcbb-cs8pv-1/llvm-project/premerge-checks/mlir/test/Target/llvmir-intrinsics.mlir | /mnt/disks/ssd0/agent/premerge-debian-5d5d95fcbb-cs8pv-1/llvm-project/premerge-checks/build/bin/FileCheck /mnt/disks/ssd0/agent/premerge-debian-5d5d95fcbb-cs8pv-1/llvm-project/premerge-checks/mlir/test/Target/llvmir-intrinsics.mlir
180 mswindows > MLIR.Target::Unknown Unit Message ("")
Script: -- : 'RUN: at line 1'; c:\ws\buildkite-windows-3\llvm-project\premerge-checks\build\bin\mlir-translate.exe -mlir-to-llvmir C:\ws\buildkite-windows-3\llvm-project\premerge-checks\mlir\test\Target\llvmir-intrinsics.mlir | c:\ws\buildkite-windows-3\llvm-project\premerge-checks\build\bin\filecheck.exe C:\ws\buildkite-windows-3\llvm-project\premerge-checks\mlir\test\Target\llvmir-intrinsics.mlir

Event Timeline

jurahul created this revision.Jun 15 2020, 2:08 PM
Herald added a project: Restricted Project. · View Herald Transcript
jurahul retitled this revision from - Modify HasParent trait to allow one of several op's as a parent - Expose this trait in the ODS framework using the ParentOneOf<> trait. to [MLIR] Modify HasParent trait to allow one of several op's as a parent.Jun 15 2020, 2:09 PM
jurahul edited the summary of this revision. (Show Details)
jurahul removed reviewers: rriddle, antiagainst.
rriddle accepted this revision.Jun 15 2020, 2:11 PM
rriddle added inline comments.
mlir/include/mlir/IR/OpDefinition.h
1162

Does << llvm::makeArrayRef(...) not work?

This revision is now accepted and ready to land.Jun 15 2020, 2:11 PM
jurahul updated this revision to Diff 270876.Jun 15 2020, 2:55 PM

Address review comments

jurahul marked 2 inline comments as done.Jun 15 2020, 2:57 PM
jurahul added inline comments.
mlir/include/mlir/IR/OpDefinition.h
1162

Looks like it does. I have adopted that now.

jurahul marked an inline comment as done.Jun 15 2020, 4:53 PM

The 2 test failures look unrelated to this change. As such, I'd appreciate if someone can help land this change.

This revision was automatically updated to reflect the committed changes.