Page MenuHomePhabricator

[MLIR] Modify HasParent trait to allow one of several op's as a parent
ClosedPublic

Authored by jurahul on Mon, Jun 15, 2:08 PM.

Details

Summary
  • Modify HasParent trait to allow one of several op's as a parent -
  • Expose this trait in the ODS framework using the ParentOneOf<> trait.

Diff Detail

Event Timeline

jurahul created this revision.Mon, Jun 15, 2:08 PM
Herald added a project: Restricted Project. · View Herald Transcript
jurahul retitled this revision from - Modify HasParent trait to allow one of several op's as a parent - Expose this trait in the ODS framework using the ParentOneOf<> trait. to [MLIR] Modify HasParent trait to allow one of several op's as a parent.Mon, Jun 15, 2:09 PM
jurahul edited the summary of this revision. (Show Details)
jurahul removed reviewers: rriddle, antiagainst.
rriddle accepted this revision.Mon, Jun 15, 2:11 PM
rriddle added inline comments.
mlir/include/mlir/IR/OpDefinition.h
1162

Does << llvm::makeArrayRef(...) not work?

This revision is now accepted and ready to land.Mon, Jun 15, 2:11 PM
jurahul updated this revision to Diff 270876.Mon, Jun 15, 2:55 PM

Address review comments

jurahul marked 2 inline comments as done.Mon, Jun 15, 2:57 PM
jurahul added inline comments.
mlir/include/mlir/IR/OpDefinition.h
1162

Looks like it does. I have adopted that now.

jurahul marked an inline comment as done.Mon, Jun 15, 4:53 PM

The 2 test failures look unrelated to this change. As such, I'd appreciate if someone can help land this change.

This revision was automatically updated to reflect the committed changes.