This is an archive of the discontinued LLVM Phabricator instance.

Differential D80614

[docs] Release notes for DIModule metadata
ClosedPublic

Authored by SouraVX on May 27 2020, 1:42 AM.

Details

Reviewers
aprantl
jini.susan.george
alok
jhenderson
Commits
rGc1d5b831b1cb: [docs] Release notes for DIModule metadata
Summary

Updated the release notes for the changes in the DIModule metadata.

Diff Detail

Event Timeline

SouraVX created this revision.May 27 2020, 1:42 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 27 2020, 1:42 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
SouraVX mentioned this in D79484: [DebugInfo] Fortran module DebugInfo support in LLVM.May 27 2020, 1:48 AM
jhenderson added inline comments.May 27 2020, 2:21 AM
llvm/docs/ReleaseNotes.rst
73

I'm not familiar with much of this metadata stuff (I focus mostly on tools), so ignore if "lineno" is a special term with a specific meaning, but otherwise, I'd prefer "line number" instead of "lineno".

SouraVX updated this revision to Diff 266461.May 27 2020, 2:43 AM
SouraVX added a reviewer: jhenderson.

Addressed @jhenderson comments. Thanks for this.

SouraVX marked 2 inline comments as done.May 27 2020, 2:44 AM
SouraVX added inline comments.
llvm/docs/ReleaseNotes.rst
73

It's the same. Thanks for the suggestion, line number is much more readable from Release Notes point of view.

aprantl accepted this revision.May 27 2020, 10:50 AM
This revision is now accepted and ready to land.May 27 2020, 10:50 AM
Closed by commit rGc1d5b831b1cb: [docs] Release notes for DIModule metadata (authored by SouraVX). · Explain WhyMay 27 2020, 10:20 PM
This revision was automatically updated to reflect the committed changes.
SouraVX marked an inline comment as done.

Revision Contents

PathSize
llvm/
docs/
4 lines

Diff 266461

llvm/docs/ReleaseNotes.rst

Show First 20 Lines • Show All 64 Lines • ▼ Show 20 Lines* The callsite attribute `vector-function-abi-variant
``VFDatabase`` class. ``VFDatabase`` class.
* `dereferenceable` attributes and metadata on pointers no longer imply * `dereferenceable` attributes and metadata on pointers no longer imply
anything about the alignment of the pointer in question. Previously, some anything about the alignment of the pointer in question. Previously, some
optimizations would make assumptions based on the type of the pointer. This optimizations would make assumptions based on the type of the pointer. This
behavior was undocumented. To preserve optimizations, frontends may need to behavior was undocumented. To preserve optimizations, frontends may need to
be updated to generate appropriate `align` attributes and metadata. be updated to generate appropriate `align` attributes and metadata.
* The DIModule metadata is extended to contain file and line number
jhendersonUnsubmitted
Done
ReplyInline Actions

I'm not familiar with much of this metadata stuff (I focus mostly on tools), so ignore if "lineno" is a special term with a specific meaning, but otherwise, I'd prefer "line number" instead of "lineno".

jhenderson: I'm not familiar with much of this metadata stuff (I focus mostly on tools), so ignore if…
SouraVXAuthorUnsubmitted
Done
ReplyInline Actions

It's the same. Thanks for the suggestion, line number is much more readable from Release Notes point of view.

SouraVX: It's the same. Thanks for the suggestion, `line number` is much more readable from `Release…
information. This information is used to represent Fortran modules debug
info at IR level.
Changes to building LLVM Changes to building LLVM
------------------------ ------------------------
Changes to the ARM Backend Changes to the ARM Backend
-------------------------- --------------------------
During this release ... During this release ...
▲ Show 20 Lines • Show All 114 Lines • Show Last 20 Lines