- User Since
- Oct 13 2019, 9:52 PM (49 w, 4 d)
Wed, Sep 16
Thanks @aprantl for reviewing this. Any idea how to backport it to LLVM 11
Sat, Sep 12
Incorporated comment from @aprantl .
Fri, Sep 11
Updated to incorporate comment from @aprantl .
Updated to incorporate @aprantl 's comment.
Thu, Sep 10
Wed, Sep 9
Aug 12 2020
@jmorse do you have any more comment on this ?
@jmorse Do you have any more comment on this ?
Aug 3 2020
Incorporated comments from @jmorse .
Thanks for your reviewing this.
Jul 20 2020
Jul 18 2020
Jul 15 2020
Incorporated comments from @aprantl .
Jul 10 2020
May 28 2020
May 27 2020
Incorporated comments from @aprantl and re-based.
May 23 2020
Updated the patch for comments from @aprantl .
May 22 2020
Re-based and incorporated comments from @jmorse .
May 19 2020
Removed -mtriple from tests.
This commit fixed clang testcases to change expected output for DISubstring which should include lowerBound=0, which is what is passed to constructor.
Below file is truncated in patch. while the test passes in my workarea. I am not sure how to include a binary file in patch.
May 15 2020
May 13 2020
Re-based and addressed comments from @aprantl
Addressed comments from @aprantl and re-based.
May 11 2020
Thanks for the explanation and pointers.
Incorporated comments form @aprantl. In addition to that also updated dependencies function in file DwarfCompileUnit.cpp.
Thanks for your attention and comments.
Can you please add a check to Verifier.cpp that checks that only arrays get a data location?
I shall update the patch with this.
Can you please add a round-trip test to test/Assembler/ (see dicompositetype-members.ll for an example)?
I have added the round trip test named llvm/test/Bitcode/dataLocation.ll, should I move this to Assembler directory?
Can you please extend the metadata unit test llvm/unittests/IR/MetadataTest.cpp to exercise the changes in LLVMContextImpl.h?
I shall update the patch to incorporate this.
Should this be added to DIBuilder?
As of now, flang front-end doesnt utilize these routines, we can defer it or update it now itself provided f18 is now part of LLVM and later we may need.
Can you add some form of documentation that explains what the new field is used for? Perhaps in the doxygen of DIBuilder, and/or in SourceLevelDebugging.rst or LangRef.rst?
May 7 2020
Incorporated comments from @vsk
May 6 2020
May 5 2020
Updated for comments from @djtodoro .
update for comments from djtodoro
May 4 2020
May 3 2020
May 2 2020
May 1 2020
Updated to address comments from @probinson
Apr 30 2020
Mar 1 2020
Updated for the comments from @vsk . Deleted definition and usage of function LdStHasDebugValue.
Feb 25 2020
Feb 23 2020
This is updated to re-base and addressing common concern about performance and suggestion form @vsk to use RemoveRedundantDbgInstrs.
Feb 11 2020
Updated to incorporate review comments from Adrian (@aprantl) .
This version is updated to incorporate comments from David (@dstenb ).
Feb 10 2020
Hi David (@dstenb), I have incorporated all your comments. I have also added you as reviewer. Kindly give your feedback.
Feb 6 2020
Updated to incorporate comments from @dstenb
Feb 5 2020
Jan 9 2020
Re-based and cleanup.
Re-based and some cleanup.
Jan 6 2020
Updated to re-base and include a test case as suggested by @aprantl.
Jan 3 2020
This is re-based and updated to apply LLVM_arg0 to existing DWARF operator and to upgrade for older styled DWARF expressions. This is done as suggested by @aprantl .
Jan 2 2020
Re-based and updated.
Rebased and updated.