This is an archive of the discontinued LLVM Phabricator instance.

[ELF] Use namespace qualifiers (lld:: or elf::) instead of `namespace lld { namespace elf {`
ClosedPublic

Authored by MaskRay on May 14 2020, 10:44 PM.

Details

Summary

Similar to D74882. This reverts much code from commit
bd8cfe65f5fee4ad573adc2172359c9552e8cdc0 (D68323) and fixes some
problems before D68323.

Sorry for the churn but D68323 was a mistake. Namespace qualifiers avoid
bugs where the definition does not match the declaration from the
header. See
https://llvm.org/docs/CodingStandards.html#use-namespace-qualifiers-to-implement-previously-declared-functions (D74515)

Diff Detail

Event Timeline

MaskRay created this revision.May 14 2020, 10:44 PM

No objections from me, this does seem to be more consistent with the Coding Standards.

I am fine with it too.

MaskRay updated this revision to Diff 264258.May 15 2020, 8:47 AM

Fix all files

MaskRay retitled this revision from [ELF] Use namespace qualifiers to [ELF] Use namespace qualifiers (lld:: or elf::) instead of `namespace lld { namespace elf {`.May 15 2020, 8:50 AM
MaskRay edited the summary of this revision. (Show Details)
This revision was not accepted when it landed; it landed in state Needs Review.May 15 2020, 9:13 AM
This revision was automatically updated to reflect the committed changes.