Page MenuHomePhabricator

[lldb] Move ClangModulesDeclVendor ownership to ClangPersistentVariables
AbandonedPublic

Authored by teemperor on May 11 2020, 3:59 PM.

Details

Summary

This is another step in moving plugin dependencies out of non-plugins.
Target doesn't need to know about this, and ClangPersistentVariables is
available in all situations where you want to access
ClangModulesDeclVendor.

Diff Detail

Event Timeline

xiaobai created this revision.May 11 2020, 3:59 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 11 2020, 3:59 PM
Herald added subscribers: yaxunl, mgorny. · View Herald Transcript
shafik added a subscriber: shafik.May 27 2020, 2:11 PM
shafik added inline comments.
lldb/source/Plugins/ExpressionParser/Clang/ClangASTSource.cpp
854

Can we just write a helper method to these two steps in ClangASTSource and then ClangExpressionDeclMap will just get it as well.

teemperor commandeered this revision.May 19 2021, 2:09 PM
teemperor edited reviewers, added: xiaobai; removed: teemperor.

Replaced by D102811 and Alex has apparently a new account, so closing this.

teemperor abandoned this revision.May 19 2021, 2:09 PM

Replaced by D102811 and Alex has apparently a new account, so closing this.

Yes, thank you for doing that. Forgot about this one. :)