Page MenuHomePhabricator

xiaobai (Alex Langford)
uwu

Projects

User does not belong to any projects.

User Details

User Since
Mar 21 2017, 11:50 AM (130 w, 8 h)

Recent Activity

Fri, Sep 13

xiaobai added a comment to D67569: [lldb-vscode] correctly handle multiple sourceMap entries.

Looks fine to me. Any objections @clayborg?

Fri, Sep 13, 2:03 PM

Thu, Sep 12

xiaobai committed rG5b2b38e053b4: [Target] Move InferiorCall to Process (authored by xiaobai).
[Target] Move InferiorCall to Process
Thu, Sep 12, 5:05 PM
xiaobai committed rL371796: [Target] Move InferiorCall to Process.
[Target] Move InferiorCall to Process
Thu, Sep 12, 5:01 PM
xiaobai closed D67472: [Target] Move InferiorCall to Process.
Thu, Sep 12, 5:01 PM · Restricted Project, Restricted Project
xiaobai updated the diff for D67472: [Target] Move InferiorCall to Process.

Rename function in question to CallVoidArgVoidPtrReturn

Thu, Sep 12, 3:56 PM · Restricted Project, Restricted Project
xiaobai updated the summary of D67472: [Target] Move InferiorCall to Process.
Thu, Sep 12, 3:34 PM · Restricted Project, Restricted Project
xiaobai updated the diff for D67472: [Target] Move InferiorCall to Process.

Rename InferiorCall to CallNoArgNoReturnFunc
make CallNoArgReturnFunc public

Thu, Sep 12, 3:34 PM · Restricted Project, Restricted Project

Wed, Sep 11

xiaobai created D67472: [Target] Move InferiorCall to Process.
Wed, Sep 11, 3:38 PM · Restricted Project, Restricted Project
xiaobai committed rG1b385a180250: [Plugins/Process] Remove direct use of ClangASTContext from InferiorCallPOSIX (authored by xiaobai).
[Plugins/Process] Remove direct use of ClangASTContext from InferiorCallPOSIX
Wed, Sep 11, 1:40 PM
xiaobai committed rL371654: [Plugins/Process] Remove direct use of ClangASTContext from InferiorCallPOSIX.
[Plugins/Process] Remove direct use of ClangASTContext from InferiorCallPOSIX
Wed, Sep 11, 1:35 PM
xiaobai closed D67427: [Plugins/Process] Remove direct use of ClangASTContext from InferiorCallPOSIX.
Wed, Sep 11, 1:35 PM · Restricted Project, Restricted Project

Tue, Sep 10

xiaobai created D67427: [Plugins/Process] Remove direct use of ClangASTContext from InferiorCallPOSIX.
Tue, Sep 10, 5:54 PM · Restricted Project, Restricted Project

Mon, Sep 9

xiaobai committed rG1dbee8f0437f: [Expression] Remove unused header from LLVMUserExpression (authored by xiaobai).
[Expression] Remove unused header from LLVMUserExpression
Mon, Sep 9, 5:05 PM
xiaobai committed rL371472: [Expression] Remove unused header from LLVMUserExpression.
[Expression] Remove unused header from LLVMUserExpression
Mon, Sep 9, 5:04 PM
xiaobai committed rG9e86561878dc: [Symbol] Give ClangASTContext a PersistentExpressionState instead of a… (authored by xiaobai).
[Symbol] Give ClangASTContext a PersistentExpressionState instead of a…
Mon, Sep 9, 4:11 PM
xiaobai committed rL371470: [Symbol] Give ClangASTContext a PersistentExpressionState instead of a….
[Symbol] Give ClangASTContext a PersistentExpressionState instead of a…
Mon, Sep 9, 4:11 PM

Fri, Sep 6

xiaobai committed rGb482db6dfeda: [Core] Remove use of ClangASTContext in DumpDataExtractor (authored by xiaobai).
[Core] Remove use of ClangASTContext in DumpDataExtractor
Fri, Sep 6, 2:06 PM
xiaobai committed rL371258: [Core] Remove use of ClangASTContext in DumpDataExtractor.
[Core] Remove use of ClangASTContext in DumpDataExtractor
Fri, Sep 6, 2:04 PM
xiaobai closed D67239: [Core] Remove use of ClangASTContext in DumpDataExtractor.
Fri, Sep 6, 2:04 PM · Restricted Project, Restricted Project
xiaobai updated the diff for D67239: [Core] Remove use of ClangASTContext in DumpDataExtractor.

Refactored slightly to be a bit safer

Fri, Sep 6, 11:05 AM · Restricted Project, Restricted Project

Thu, Sep 5

xiaobai added a comment to D67239: [Core] Remove use of ClangASTContext in DumpDataExtractor.

Hmm, good question. If you call GetAPInt with a byte_size of 0, it should assert when trying to read 0 bytes with the DataExtractor. In the worst case, it gives you a broken APInt. I think guarded the call to GetAPInt to protect against this, but I think that it would also be a good idea to make GetAPInt return llvm::None in that case.

Thu, Sep 5, 3:35 PM · Restricted Project, Restricted Project
xiaobai created D67239: [Core] Remove use of ClangASTContext in DumpDataExtractor.
Thu, Sep 5, 2:34 PM · Restricted Project, Restricted Project

Wed, Aug 28

xiaobai committed rG3e45e3ba959f: [Core] Use GetAPInt instead of constructing APInts in place (authored by xiaobai).
[Core] Use GetAPInt instead of constructing APInts in place
Wed, Aug 28, 1:16 PM
xiaobai committed rL370255: [Core] Use GetAPInt instead of constructing APInts in place.
[Core] Use GetAPInt instead of constructing APInts in place
Wed, Aug 28, 1:16 PM
xiaobai accepted D66858: POSIX DYLD: add workaround for android L loader.

LGTM, small typo tho

Wed, Aug 28, 10:27 AM · Restricted Project

Tue, Aug 27

xiaobai accepted D66811: [dotest] Remove results port.

LGTM

Tue, Aug 27, 11:12 AM · Restricted Project, Restricted Project
xiaobai removed an edge from rL370075: [JITLink] Add timers and -show-times option to llvm-jitlink.: D66811: [dotest] Remove results port.
Tue, Aug 27, 11:12 AM
xiaobai removed 1 commit(s) for D66811: [dotest] Remove results port: rL370075: [JITLink] Add timers and -show-times option to llvm-jitlink..
Tue, Aug 27, 11:12 AM · Restricted Project, Restricted Project

Mon, Aug 26

xiaobai committed rL369970: [Core] GetAPInt should return an Optional.
[Core] GetAPInt should return an Optional
Mon, Aug 26, 2:15 PM
xiaobai committed rG5e777e1ed288: [Core] GetAPInt should return an Optional (authored by xiaobai).
[Core] GetAPInt should return an Optional
Mon, Aug 26, 2:14 PM
xiaobai added inline comments to D66249: [JIT][Breakpoint] Add "BreakpointInjectedSite" and FCB Trampoline.
Mon, Aug 26, 12:52 PM · Restricted Project

Thu, Aug 22

xiaobai committed rGcb68bd726db4: [Symbol] Decouple clang from DeclVendor (authored by xiaobai).
[Symbol] Decouple clang from DeclVendor
Thu, Aug 22, 11:11 PM
xiaobai committed rL369735: [Symbol] Decouple clang from DeclVendor.
[Symbol] Decouple clang from DeclVendor
Thu, Aug 22, 11:10 PM
xiaobai closed D66628: [Symbol] Decouple clang from DeclVendor.
Thu, Aug 22, 11:10 PM · Restricted Project, Restricted Project
xiaobai created D66628: [Symbol] Decouple clang from DeclVendor.
Thu, Aug 22, 6:07 PM · Restricted Project, Restricted Project

Tue, Aug 20

xiaobai committed rG7719495e2cae: [Symbol] Remove unused clang headers from Type (authored by xiaobai).
[Symbol] Remove unused clang headers from Type
Tue, Aug 20, 9:57 PM
xiaobai committed rL369494: [Symbol] Remove unused clang headers from Type.
[Symbol] Remove unused clang headers from Type
Tue, Aug 20, 9:56 PM
xiaobai added a comment to D66102: [Symbol] Decouple clang from CompilerType.

I wouldn't mind adding something to reduce boilerplate, but I'm not sure it would actually look too different. A wrapper function or subclass constructor would need to take a ClangASTContext and a clang::QualType so we could avoid calls to getAsOpaquePtr() everywhere but that's about it I think?

Tue, Aug 20, 4:02 PM · Restricted Project, Restricted Project
xiaobai committed rGb2232a1af321: [Symbol] Move VerifyDecl to ClangASTContext (authored by xiaobai).
[Symbol] Move VerifyDecl to ClangASTContext
Tue, Aug 20, 3:08 PM
xiaobai committed rL369456: [Symbol] Move VerifyDecl to ClangASTContext.
[Symbol] Move VerifyDecl to ClangASTContext
Tue, Aug 20, 3:08 PM
xiaobai committed rGcb40f89c6e22: [Symbol][NFC] Remove references to clang in TypeMap (authored by xiaobai).
[Symbol][NFC] Remove references to clang in TypeMap
Tue, Aug 20, 1:46 PM
xiaobai committed rL369436: [Symbol][NFC] Remove references to clang in TypeMap.
[Symbol][NFC] Remove references to clang in TypeMap
Tue, Aug 20, 1:46 PM
xiaobai committed rG1271521ed887: [ClangExpressionParser] Add ClangDeclVendor (authored by xiaobai).
[ClangExpressionParser] Add ClangDeclVendor
Tue, Aug 20, 11:53 AM
xiaobai committed rL369424: [ClangExpressionParser] Add ClangDeclVendor.
[ClangExpressionParser] Add ClangDeclVendor
Tue, Aug 20, 11:46 AM
xiaobai closed D66451: [ClangExpressionParser] Add ClangDeclVendor.
Tue, Aug 20, 11:46 AM · Restricted Project, Restricted Project

Mon, Aug 19

xiaobai added inline comments to D66451: [ClangExpressionParser] Add ClangDeclVendor.
Mon, Aug 19, 4:42 PM · Restricted Project, Restricted Project
xiaobai created D66451: [ClangExpressionParser] Add ClangDeclVendor.
Mon, Aug 19, 4:09 PM · Restricted Project, Restricted Project
xiaobai accepted D66448: Include "windows" Instead of "Windows".

Case-sensitive filesystems lol

Mon, Aug 19, 3:39 PM · Restricted Project
xiaobai committed rG3b4ce731fbcc: [lldb-vscode] add `launchCommands` to handle launch specific commands (authored by xiaobai).
[lldb-vscode] add `launchCommands` to handle launch specific commands
Mon, Aug 19, 1:18 PM
xiaobai committed rL369296: [lldb-vscode] add `launchCommands` to handle launch specific commands.
[lldb-vscode] add `launchCommands` to handle launch specific commands
Mon, Aug 19, 1:17 PM
xiaobai closed D65363: [lldb-vscode] add `launchCommands` to handle launch specific commands.
Mon, Aug 19, 1:17 PM · Restricted Project, Restricted Project

Aug 14 2019

xiaobai committed rG0630bbc7fe03: [NFCI] Always initialize BugReport const fields (authored by xiaobai).
[NFCI] Always initialize BugReport const fields
Aug 14 2019, 6:00 PM
xiaobai committed rL368950: [NFCI] Always initialize BugReport const fields.
[NFCI] Always initialize BugReport const fields
Aug 14 2019, 5:58 PM
xiaobai closed D66265: [NFCI] Always initialize BugReport const fields.
Aug 14 2019, 5:58 PM · Restricted Project, Restricted Project
xiaobai created D66265: [NFCI] Always initialize BugReport const fields.
Aug 14 2019, 5:30 PM · Restricted Project, Restricted Project
xiaobai added a comment to D66174: [Utility] Reimplement RegularExpression on top of llvm::Regex.

I like the idea of using something from llvm instead of rolling our own. The code changes look relatively simple and straightforward, so that's good.

Aug 14 2019, 10:37 AM · Restricted Project, Restricted Project

Aug 13 2019

xiaobai committed rG21872bc9bf37: [analyzer] Don't delete TaintConfig copy constructor (authored by xiaobai).
[analyzer] Don't delete TaintConfig copy constructor
Aug 13 2019, 6:10 PM
xiaobai committed rL368779: [analyzer] Don't delete TaintConfig copy constructor.
[analyzer] Don't delete TaintConfig copy constructor
Aug 13 2019, 6:08 PM
xiaobai closed D66192: [analyzer] Don't delete TaintConfig copy constructor.
Aug 13 2019, 6:08 PM · Restricted Project, Restricted Project
xiaobai created D66192: [analyzer] Don't delete TaintConfig copy constructor.
Aug 13 2019, 5:58 PM · Restricted Project, Restricted Project
xiaobai committed rGb809187a6b42: [NFCI] Explicitly provide user-defined constructor for SectionRef (authored by xiaobai).
[NFCI] Explicitly provide user-defined constructor for SectionRef
Aug 13 2019, 3:18 PM
xiaobai committed rL368758: [NFCI] Explicitly provide user-defined constructor for SectionRef.
[NFCI] Explicitly provide user-defined constructor for SectionRef
Aug 13 2019, 3:18 PM
xiaobai committed rGbddab07d4a21: [Symbol] Decouple clang from CompilerType (authored by xiaobai).
[Symbol] Decouple clang from CompilerType
Aug 13 2019, 12:42 PM
xiaobai committed rL368741: [Symbol] Decouple clang from CompilerType.
[Symbol] Decouple clang from CompilerType
Aug 13 2019, 12:42 PM
xiaobai closed D66102: [Symbol] Decouple clang from CompilerType.
Aug 13 2019, 12:41 PM · Restricted Project, Restricted Project
xiaobai added inline comments to D59555: [analyzer] Add yaml parser to GenericTaintChecker.
Aug 13 2019, 10:34 AM · Restricted Project, Restricted Project

Aug 12 2019

xiaobai committed rGf4446f177505: [Symbol] Remove redundant include (authored by xiaobai).
[Symbol] Remove redundant include
Aug 12 2019, 5:27 PM
xiaobai committed rL368638: [Symbol] Remove redundant include.
[Symbol] Remove redundant include
Aug 12 2019, 5:25 PM
xiaobai created D66102: [Symbol] Decouple clang from CompilerType.
Aug 12 2019, 11:55 AM · Restricted Project, Restricted Project
xiaobai added a reviewer for D66102: [Symbol] Decouple clang from CompilerType: labath.
Aug 12 2019, 11:55 AM · Restricted Project, Restricted Project
xiaobai accepted D66093: [Symbol] GetTypeBitAlign() should return None in case of failure..

I appreciate you adding more error handling. Thank you!

Aug 12 2019, 11:11 AM · Restricted Project, Restricted Project

Aug 7 2019

xiaobai committed rG4cd04547f52e: [Symbol] Remove commented out code from CompileUnit (authored by xiaobai).
[Symbol] Remove commented out code from CompileUnit
Aug 7 2019, 1:52 PM
xiaobai committed rL368205: [Symbol] Remove commented out code from CompileUnit.
[Symbol] Remove commented out code from CompileUnit
Aug 7 2019, 1:50 PM

Aug 6 2019

xiaobai committed rG5fdf10bae878: [SymbolFile] Remove commented out method (authored by xiaobai).
[SymbolFile] Remove commented out method
Aug 6 2019, 12:47 PM
xiaobai committed rL368075: [SymbolFile] Remove commented out method.
[SymbolFile] Remove commented out method
Aug 6 2019, 12:46 PM

Aug 5 2019

xiaobai accepted D65782: [CompilerType] Simplify the interface a bit more...
Aug 5 2019, 4:35 PM · Restricted Project, Restricted Project
xiaobai accepted D65781: [CompilerType] Remove an unused function..
Aug 5 2019, 4:16 PM · Restricted Project, Restricted Project

Jul 31 2019

xiaobai added a reviewer for D65548: Make JITDylib ignore Exported flag: lhames.
Jul 31 2019, 4:43 PM · Restricted Project
xiaobai committed rG70402bfc46e0: [API] Remove use of ClangASTContext from SBTarget (authored by xiaobai).
[API] Remove use of ClangASTContext from SBTarget
Jul 31 2019, 1:49 PM
xiaobai committed rL367480: [API] Remove use of ClangASTContext from SBTarget.
[API] Remove use of ClangASTContext from SBTarget
Jul 31 2019, 1:47 PM
xiaobai closed D64964: [API] Remove use of ClangASTContext from SBTarget.
Jul 31 2019, 1:47 PM · Restricted Project

Jul 30 2019

xiaobai updated the diff for D64964: [API] Remove use of ClangASTContext from SBTarget.

Removed argument to GetScratchTypeSystems from SBTarget

Jul 30 2019, 5:54 PM · Restricted Project
xiaobai updated the diff for D64964: [API] Remove use of ClangASTContext from SBTarget.

Update GetScatchTypeSystems to account for changes to TypeSystem usage

Jul 30 2019, 5:50 PM · Restricted Project
xiaobai committed rGc1210c7e96fe: [SymbolFilePDB] Fix windows bots after rL367360 (authored by xiaobai).
[SymbolFilePDB] Fix windows bots after rL367360
Jul 30 2019, 4:48 PM
xiaobai committed rL367368: [SymbolFilePDB] Fix windows bots after rL367360.
[SymbolFilePDB] Fix windows bots after rL367360
Jul 30 2019, 4:47 PM
xiaobai committed rG0e252e38ef84: [Symbol] Use llvm::Expected when getting TypeSystems (authored by xiaobai).
[Symbol] Use llvm::Expected when getting TypeSystems
Jul 30 2019, 3:13 PM
xiaobai committed rL367360: [Symbol] Use llvm::Expected when getting TypeSystems.
[Symbol] Use llvm::Expected when getting TypeSystems
Jul 30 2019, 3:12 PM
xiaobai closed D65122: [Symbol] Use llvm::Expected when getting TypeSystems.
Jul 30 2019, 3:11 PM · Restricted Project
xiaobai committed rG072317311473: [SymbolFile] SymbolFileDWARF::ParseLineTable should lock its module (authored by xiaobai).
[SymbolFile] SymbolFileDWARF::ParseLineTable should lock its module
Jul 30 2019, 2:23 PM
xiaobai committed rL367358: [SymbolFile] SymbolFileDWARF::ParseLineTable should lock its module.
[SymbolFile] SymbolFileDWARF::ParseLineTable should lock its module
Jul 30 2019, 2:23 PM
xiaobai accepted D65450: Add llvm-style RTTI to ObjectFile hierarchy.

LGTM

Jul 30 2019, 10:50 AM · Restricted Project

Jul 29 2019

xiaobai added a comment to D62213: [ABI] Implement Windows ABI for x86_64.

I think this change has introduced a dependence on x64.

I tried building with the 32b Visual Studio compiler and there are a number of undefined registers in registercontextwindows_x64.cpp.
This is because the version of _CONTEXT included by winnt.h is for x32 and not x64.

i.e., llvm-project\lldb\source\plugins\process\windows\common\x64\registercontextwindows_x64.cpp(297): error C2039: 'Rax': is not a member of '_CONTEXT'

Jul 29 2019, 5:53 PM · Restricted Project, Restricted Project
xiaobai added inline comments to D65122: [Symbol] Use llvm::Expected when getting TypeSystems.
Jul 29 2019, 2:44 PM · Restricted Project
xiaobai updated the diff for D65122: [Symbol] Use llvm::Expected when getting TypeSystems.

Small logic change in SBModule

Jul 29 2019, 2:44 PM · Restricted Project
xiaobai added a comment to D65122: [Symbol] Use llvm::Expected when getting TypeSystems.

I have one remark about the consumeError+LLDB_LOG pattern. As for whether this is better than status quo or not, I still don't have an opinion on that. :)

Jul 29 2019, 12:10 PM · Restricted Project
xiaobai updated the diff for D65122: [Symbol] Use llvm::Expected when getting TypeSystems.

Fix incorrect error logging pattern

Jul 29 2019, 12:07 PM · Restricted Project

Jul 26 2019

xiaobai updated the diff for D65122: [Symbol] Use llvm::Expected when getting TypeSystems.

Address comments:

  • Use Expected<TypeSystem&>
  • Did some formatting
  • Made error checking more explicit
Jul 26 2019, 5:53 PM · Restricted Project
xiaobai added a comment to D65122: [Symbol] Use llvm::Expected when getting TypeSystems.

I'm going to update this diff with what I changed to give y'all a better idea of what has been changed. I shoulda done that to begin with... :P

Jul 26 2019, 11:17 AM · Restricted Project

Jul 25 2019

xiaobai added a comment to D65122: [Symbol] Use llvm::Expected when getting TypeSystems.

After going through this and modifying this patch, I can't help but wonder if llvm::Optional<TypeSystem &> would be more appropriate. There are plenty of instances where it's not a hard error if you can't get a TypeSystem and the appropriate action is probably just to log and move on. I am conflicted because I like how Expected forces you to be more rigorous with error handling but I can't help but feel it is the wrong abstraction. Thoughts?

Jul 25 2019, 7:52 PM · Restricted Project
xiaobai accepted D65185: Let tablegen generate property definitions.

I think this is fine. Using .def files would be okay too, but I like the sanity checks that Jonas introduced in the LLDBPropertyDefEmitter

Jul 25 2019, 12:32 PM · Restricted Project, Restricted Project