Page MenuHomePhabricator

bulbazord (Alex Langford)
:3

Projects

User does not belong to any projects.

User Details

User Since
Dec 1 2020, 2:41 PM (28 w, 4 d)

Recent Activity

Thu, Jun 17

bulbazord added a comment to D104067: [lldb] Decouple ObjCLanguage from Symtab.

ping!

Thu, Jun 17, 11:04 AM · Restricted Project

Sat, Jun 12

bulbazord updated the diff for D104067: [lldb] Decouple ObjCLanguage from Symtab.

Addressing comments

Sat, Jun 12, 7:58 PM · Restricted Project

Thu, Jun 10

bulbazord added a comment to D104067: [lldb] Decouple ObjCLanguage from Symtab.

Note that this is working towards solving the same problem as D103210 but it does so in a different way. Instead of repurposing the old diff, I made a new one so it is a little easier to compare/contrast. Hopefully it's not too confusing.

Thu, Jun 10, 3:00 PM · Restricted Project
bulbazord requested review of D104067: [lldb] Decouple ObjCLanguage from Symtab.
Thu, Jun 10, 2:59 PM · Restricted Project

Tue, Jun 8

bulbazord committed rG64576a1be887: [lldb][NFC] Refactor name to index maps in Symtab (authored by bulbazord).
[lldb][NFC] Refactor name to index maps in Symtab
Tue, Jun 8, 12:38 PM
bulbazord closed D103652: [lldb][NFC] Refactor name to index maps in Symtab.
Tue, Jun 8, 12:38 PM · Restricted Project
bulbazord updated the diff for D103652: [lldb][NFC] Refactor name to index maps in Symtab.

Rename function :)

Tue, Jun 8, 12:23 PM · Restricted Project

Mon, Jun 7

bulbazord updated the diff for D103652: [lldb][NFC] Refactor name to index maps in Symtab.

Remove unused line of code that I forgot to remove previously

Mon, Jun 7, 1:35 PM · Restricted Project
bulbazord updated the diff for D103652: [lldb][NFC] Refactor name to index maps in Symtab.

Address feedback

Mon, Jun 7, 1:33 PM · Restricted Project

Thu, Jun 3

bulbazord added a comment to D103210: [lldb] Introduce Language::MethodNameInfo.

We have a method called Language::GetMethodNameVariants, that could be extended/modified to be more suitable. Unless you had something else in mind? Maybe something more specific to Symtab mapping like Language::GetFunctionNameSearchVariants.

That actually seems like a great idea! Module::LookupInfo also seems quite close to the data structure we would need to return, so we could in theory return a list of that from the function instead.

Awesome, I'll work on that next :)

This makes sense to me, I'll also make this change in this patch :)

Feel free to also put it up as a NFC patch. It seems in general like a good cleanup from what I can see, so that should be a quick review :)

Just uploaded: D103652

Thu, Jun 3, 3:12 PM · Restricted Project
bulbazord requested review of D103652: [lldb][NFC] Refactor name to index maps in Symtab.
Thu, Jun 3, 3:11 PM · Restricted Project

Thu, May 27

bulbazord added a comment to D103210: [lldb] Introduce Language::MethodNameInfo.

+1 to not add any language-specific terms to the Language API.

Looking over the code, it seems what the code is doing its:

  • Going over the symbol names.
  • Creating a search index from the symbol names that is optionally grouped via the FunctionNameType cases (and there is a 'eFunctionNameTypeSelector' which isn't that nice but that's why we try to do selector-specific stuff).

So what about having an API that for a given symbol name gives us all the alternative names we should put into this search index (and optionally a FunctionNameType so we can put it into the right group)? I guess C++ could also benefit from the same API as it would just return the right basenames then?

We have a method called Language::GetMethodNameVariants, that could be extended/modified to be more suitable. Unless you had something else in mind? Maybe something more specific to Symtab mapping like Language::GetFunctionNameSearchVariants.

If we make the different m_*to_index maps in Symtab into something two nested maps with the form FunctionNameType -> name -> index, then that would also remove quite a bit of copy-pasted code in Symtab.cpp

This makes sense to me, I'll also make this change in this patch :)

Thu, May 27, 11:04 AM · Restricted Project

Wed, May 26

bulbazord added a comment to D103210: [lldb] Introduce Language::MethodNameInfo.

Let me know how you feel about this abstraction/idea. I think we'll need something like this at some point to remove most of the remaining dependencies (e.g. in Module.cpp) so I'd like to get something good going here.

Wed, May 26, 3:03 PM · Restricted Project
bulbazord requested review of D103210: [lldb] Introduce Language::MethodNameInfo.
Wed, May 26, 3:02 PM · Restricted Project
bulbazord accepted D103158: [lldb][NFC] Use Language plugins in Mangled::GuessLanguage.

This is about what I thought needed to be done as well. Thanks for taking care of this!

Wed, May 26, 10:33 AM · Restricted Project

Tue, May 25

bulbazord added a comment to D103095: [lldb][NFC] Don't depend on Clang libraries from selected core libraries.

Arg, nevermind, I built in the wrong directory... I thought we're already there, but there are a few dependencies still left.

Tue, May 25, 2:15 PM · Restricted Project

May 20 2021

bulbazord updated the diff for D102811: [lldb] Move ClangModulesDeclVendor ownership to ClangPersistentVariables from Target.

Add helper in ClangASTSource

May 20 2021, 1:27 PM · Restricted Project

May 19 2021

bulbazord added a comment to D79752: [lldb] Move ClangModulesDeclVendor ownership to ClangPersistentVariables.

Replaced by D102811 and Alex has apparently a new account, so closing this.

May 19 2021, 2:10 PM · Restricted Project
bulbazord requested review of D102811: [lldb] Move ClangModulesDeclVendor ownership to ClangPersistentVariables from Target.
May 19 2021, 2:04 PM · Restricted Project

Dec 1 2020

bulbazord updated bulbazord.
Dec 1 2020, 2:45 PM