[ELF] --warn-backrefs: don't warn if -u/--export-dynamic-symbol
ClosedPublic
Actions

Authored by MaskRay on Apr 6 2020, 9:37 PM.

Details

Reviewers

grimar
psmith
ruiu
• espindola

Commits

rGa27a7b98cd19: [ELF] --warn-backrefs: don't warn if -u/--export-dynamic-symbol

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

MaskRay created this revision.Apr 6 2020, 9:37 PM

Herald added a reviewer: • espindola. · View Herald TranscriptApr 6 2020, 9:37 PM

Herald added a project: Restricted Project. · View Herald Transcript

Herald added subscribers: llvm-commits, arichardson, emaste. · View Herald Transcript

MaskRay added a parent revision: D77522: [ELF] --warn-backrefs: don't warn for linking sandwich problems.Apr 6 2020, 9:38 PM

Harbormaster failed remote builds in B52108: Diff 255584!Apr 6 2020, 10:53 PM

grimar added inline comments.Apr 7 2020, 4:23 AM

lld/test/ELF/warn-backrefs.s
70	You forgot `--warn-backrefs`.

Add missing --warn-backrefs

Harbormaster completed remote builds in B52186: Diff 255738.Apr 7 2020, 1:04 PM

LGTM

This revision is now accepted and ready to land.Apr 8 2020, 1:32 AM

Closed by commit rGa27a7b98cd19: [ELF] --warn-backrefs: don't warn if -u/--export-dynamic-symbol (authored by MaskRay). · Explain WhyApr 8 2020, 9:46 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

lld/

ELF/

Driver.cpp

4 lines

test/

ELF/

warn-backrefs.s

6 lines

Diff 256049

View Options

lld/ELF/Driver.cpp