Page MenuHomePhabricator

[hip] Remove `hip_pinned_shadow`.
ClosedPublic

Authored by hliao on Apr 6 2020, 1:09 PM.

Details

Summary
  • Use device_builtin_surface and device_builtin_texture for surface/texture reference support. So far, both the host and device use the same reference type, which could be revised later when interface/implementation is stablized.

Diff Detail

Event Timeline

hliao created this revision.Apr 6 2020, 1:09 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 6 2020, 1:10 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
yaxunl added a comment.Apr 6 2020, 5:17 PM

Is the runtime and HIP directed test change in place?

hliao added a comment.Apr 6 2020, 6:53 PM

Is the runtime and HIP directed test change in place?

yeah, I verified several tests using texture references.

yaxunl accepted this revision.Apr 6 2020, 8:23 PM

LGTM. Thanks!

This revision is now accepted and ready to land.Apr 6 2020, 8:23 PM
This revision was automatically updated to reflect the committed changes.