This is an archive of the discontinued LLVM Phabricator instance.

Remove asserting getters from base Type
ClosedPublic

Authored by ctetreau on Apr 1 2020, 5:07 PM.

Details

Summary

Remove asserting vector getters from Type in preparation for the
VectorType refactor. The existence of these functions complicates the
refactor while adding little value.

Diff Detail

Event Timeline

ctetreau created this revision.Apr 1 2020, 5:07 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 1 2020, 5:07 PM
efriedma added inline comments.Apr 9 2020, 8:56 PM
llvm/lib/IR/Type.cpp
156 ↗(On Diff #256399)

It probably makes sense to make this an inline function in DerivedTypes.h

ctetreau updated this revision to Diff 256574.Apr 10 2020, 8:01 AM

address code review issues

This revision is now accepted and ready to land.Apr 10 2020, 11:14 AM
ctetreau updated this revision to Diff 258392.Apr 17 2020, 12:11 PM

catch stragglers

Herald added a project: Restricted Project. · View Herald TranscriptApr 17 2020, 12:11 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
ctetreau updated this revision to Diff 258393.Apr 17 2020, 12:13 PM

fix permissions

ctetreau updated this revision to Diff 258411.Apr 17 2020, 1:28 PM

catch straggler

This revision was automatically updated to reflect the committed changes.