This is an archive of the discontinued LLVM Phabricator instance.

Clean up usages of asserting vector getters in Type

Authored by ctetreau on Apr 1 2020, 4:41 PM.



Remove usages of asserting vector getters in Type in preparation for the
VectorType refactor. The existence of these functions complicates the
refactor while adding little value.

Diff Detail

Event Timeline

ctetreau created this revision.Apr 1 2020, 4:41 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 1 2020, 4:41 PM
ctetreau updated this revision to Diff 254580.Apr 2 2020, 11:50 AM

Mention that this is NFC

sdesmalen accepted this revision.Apr 6 2020, 8:41 AM

LGTM with nit addressed.


nit: Given that Src is always of VectorType, maybe just create a new variable

auto *SrcTy = cast<VectorType>(Src->getType())

that would remove the need for the cast here and below..

This revision is now accepted and ready to land.Apr 6 2020, 8:41 AM
ctetreau updated this revision to Diff 255399.Apr 6 2020, 10:25 AM
ctetreau marked an inline comment as done.

address code review issues

This revision was automatically updated to reflect the committed changes.