Details

Reviewers

rriddle
efriedma
sdesmalen

Commits

rG92dde8a65791: Clean up usages of asserting vector getters in Type

Summary

Remove usages of asserting vector getters in Type in preparation for the
VectorType refactor. The existence of these functions complicates the
refactor while adding little value.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

ctetreau created this revision.Apr 1 2020, 4:31 PM

Herald added a project: Restricted Project. · View Herald TranscriptApr 1 2020, 4:31 PM

Herald added subscribers: llvm-commits, grosul1, Joonsoo and 12 others. · View Herald Transcript

Harbormaster completed remote builds in B51375: Diff 254342.Apr 1 2020, 5:59 PM

Mention that this is NFC

Harbormaster completed remote builds in B51509: Diff 254574.Apr 2 2020, 12:28 PM

ctetreau added reviewers: rriddle, efriedma, sdesmalen.Apr 2 2020, 2:52 PM

sdesmalen added inline comments.Apr 6 2020, 8:45 AM

mlir/lib/Conversion/StandardToLLVM/StandardToLLVM.cpp
1807–1810	is the cast to `unsigned` needed?

ctetreau marked an inline comment as done.Apr 6 2020, 10:09 AM

ctetreau added inline comments.

mlir/lib/Conversion/StandardToLLVM/StandardToLLVM.cpp
1807–1810	VectorType::getNumElements() returns uint64_t, where Type::getVectorNumElements() returned unsigned. At least in visual studio, this results in an error due to a narrowing conversion. I have no idea why this is, I can't imagine that we'd need 64 bits to express the number of vector lanes.

Update commit message to mention MLIR

Harbormaster failed remote builds in B51981: Diff 255392!Apr 6 2020, 11:25 AM

efriedma added inline comments.Apr 6 2020, 11:27 AM

mlir/lib/Conversion/StandardToLLVM/StandardToLLVM.cpp
1807–1810	Actually, I'm pretty sure it's actually "SequentalType::getNumElements()" returns a uint64_t. We could consider changing that once I land the patch to kill SequentialType.