Page MenuHomePhabricator

GlobalISel: Reimplement fewerElementsVectorBasic
ClosedPublic

Authored by arsenm on Feb 4 2020, 7:24 AM.

Details

Summary

Pad with undef to a wider size, and unmerge. Also avoid introducing
instructions for the fully undef components.

Diff Detail

Event Timeline

arsenm created this revision.Feb 4 2020, 7:24 AM
paquette added inline comments.Feb 4 2020, 10:40 AM
llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp
2613

Message for the assert would be useful here

2627–2630

Comment explaining what the loop produces would be helpful.

arsenm updated this revision to Diff 242379.Feb 4 2020, 11:02 AM

More comments

arsenm updated this revision to Diff 242770.Feb 5 2020, 3:36 PM

Rebase tests

aemerson accepted this revision.Feb 24 2020, 3:42 PM

Looks reasonable.

llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp
2621

typo paddedd

This revision is now accepted and ready to land.Feb 24 2020, 3:42 PM