Page MenuHomePhabricator

Petar.Avramovic (Petar Avramovic)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 21 2018, 6:39 AM (228 w, 20 h)

Recent Activity

Yesterday

Petar.Avramovic requested review of D129194: [AArch64][GlobalISel] Fix call lowering for <3 x i32> vector arguments.
Wed, Jul 6, 5:51 AM · Restricted Project, Restricted Project

Tue, Jul 5

Petar.Avramovic added a comment to D129084: [AMDGPU] gfx11 Fix disassembler for VOP3 dpp8.

op_sel value is not being propagated from src_modifiers to the op_sel operand

I was convinced that op_sel value is not important for instruction printing. Non dpp version does not even have op_sel operand and still gets printed correctly, helper prints op_sel[a,b,c] from src_modifiers.
I missed to test assembler, missing part is setting op_sel bit in src_modifiers, done via cvtVOP3P.
I will double check both.

Tue, Jul 5, 1:18 PM · Restricted Project, Restricted Project
Petar.Avramovic updated the diff for D129084: [AMDGPU] gfx11 Fix disassembler for VOP3 dpp8.
Tue, Jul 5, 1:13 PM · Restricted Project, Restricted Project
Petar.Avramovic added inline comments to D129075: [AMDGPU] gfx11 allow dlc for MUBUF atomics.
Tue, Jul 5, 8:34 AM · Restricted Project, Restricted Project

Mon, Jul 4

Petar.Avramovic requested review of D129084: [AMDGPU] gfx11 Fix disassembler for VOP3 dpp8.
Mon, Jul 4, 7:49 AM · Restricted Project, Restricted Project
Petar.Avramovic added inline comments to D129075: [AMDGPU] gfx11 allow dlc for MUBUF atomics.
Mon, Jul 4, 6:15 AM · Restricted Project, Restricted Project
Petar.Avramovic requested review of D129075: [AMDGPU] gfx11 allow dlc for MUBUF atomics.
Mon, Jul 4, 5:50 AM · Restricted Project, Restricted Project

May 13 2022

Petar.Avramovic added a comment to D125516: [GlobalISel] Handle constant splat in funnel shift combine.

Name changes look good to me. Wait a little if @paquette or @aemerson have comments.

May 13 2022, 6:42 AM · Restricted Project, Restricted Project

May 11 2022

Petar.Avramovic accepted D125319: [AMDGPU] gfx11 BUF Instructions.
May 11 2022, 3:15 AM · Restricted Project, Restricted Project

May 10 2022

Petar.Avramovic accepted D125261: [AMDGPU] gfx11 subtarget features & early tests.
May 10 2022, 7:09 AM · Restricted Project, Restricted Project
Petar.Avramovic added a comment to D125261: [AMDGPU] gfx11 subtarget features & early tests.

Can you also add comment that test changes for some memory instructions are caused by subtarget feature that allows offset folding (to be precise not having feature that forbids offset folding). Maybe separate these tests to another patch.

May 10 2022, 5:52 AM · Restricted Project, Restricted Project
Petar.Avramovic added a comment to D125261: [AMDGPU] gfx11 subtarget features & early tests.

LGTM also, I am just double checking tests, might add a few more comments soon.

May 10 2022, 5:12 AM · Restricted Project, Restricted Project

Apr 21 2022

Petar.Avramovic committed rGe06290e53f28: AMDGPU/GlobalISel: Fix isVCC for uniform s1 with reg class on wave32 (authored by Petar.Avramovic).
AMDGPU/GlobalISel: Fix isVCC for uniform s1 with reg class on wave32
Apr 21 2022, 7:13 AM · Restricted Project, Restricted Project
Petar.Avramovic committed rG4e0dacb2cf32: AMDGPU/GlobalISel: Precommit test for D124163 (authored by Petar.Avramovic).
AMDGPU/GlobalISel: Precommit test for D124163
Apr 21 2022, 7:13 AM · Restricted Project, Restricted Project
Petar.Avramovic closed D124163: AMDGPU/GlobalISel: Fix isVCC for uniform s1 with reg class on wave32.
Apr 21 2022, 7:12 AM · Restricted Project, Restricted Project
Petar.Avramovic requested review of D124163: AMDGPU/GlobalISel: Fix isVCC for uniform s1 with reg class on wave32.
Apr 21 2022, 5:45 AM · Restricted Project, Restricted Project

Feb 22 2022

Petar.Avramovic added inline comments to D117328: GlobalISel: Add bitcast to tryFoldUnmergeCast.
Feb 22 2022, 2:54 AM · Restricted Project

Jan 19 2022

Petar.Avramovic accepted D117607: GlobalISel: Fix assert on unmerge to different element of casted vector.
Jan 19 2022, 3:21 AM · Restricted Project
Petar.Avramovic added inline comments to D109242: GlobalISel: Artifact combine build-vector and unmerges into concat-vector.
Jan 19 2022, 3:19 AM · Restricted Project
Petar.Avramovic requested review of D117655: Precommit for build vector patches.
Jan 19 2022, 3:16 AM · Restricted Project
Petar.Avramovic updated the diff for D109242: GlobalISel: Artifact combine build-vector and unmerges into concat-vector.

There should be no reason to look through copies here, switch to getVRegDef.

Jan 19 2022, 3:14 AM · Restricted Project

Jan 17 2022

Petar.Avramovic added a comment to D109243: AMDGPU/GlobalISel: Add build_vector_trunc post-legalizer combine.

I don't think this is the best place to perform this combine since there are some regressions in regbank-combiner.
Also I expect that it will be covered by D116441 during inst-selection.

Jan 17 2022, 3:54 AM · Restricted Project
Petar.Avramovic added inline comments to D109240: GlobalISel: Artifact combine merge-like opcode and unmerge into copy.
Jan 17 2022, 3:47 AM · Restricted Project

Jan 14 2022

Petar.Avramovic requested review of D117328: GlobalISel: Add bitcast to tryFoldUnmergeCast.
Jan 14 2022, 8:31 AM · Restricted Project
Petar.Avramovic updated the diff for D109242: GlobalISel: Artifact combine build-vector and unmerges into concat-vector.
Jan 14 2022, 8:29 AM · Restricted Project
Petar.Avramovic updated the diff for D109241: GlobalISel: Artifact combine build-vectors and unmerge into unmerge.
Jan 14 2022, 8:28 AM · Restricted Project
Petar.Avramovic updated the diff for D109240: GlobalISel: Artifact combine merge-like opcode and unmerge into copy.
Jan 14 2022, 8:27 AM · Restricted Project

Jan 13 2022

Petar.Avramovic committed rG1919d2c93165: AMDGPU/GlobalISel: Regenerate fceil test (NFC) (authored by Petar.Avramovic).
AMDGPU/GlobalISel: Regenerate fceil test (NFC)
Jan 13 2022, 5:32 AM
Petar.Avramovic committed rG235886e174d8: AMDGPU/GlobalISel: Fix custom legalizatation for fceil (authored by Petar.Avramovic).
AMDGPU/GlobalISel: Fix custom legalizatation for fceil
Jan 13 2022, 5:32 AM

Jan 12 2022

Petar.Avramovic committed rGc8c5dc766b25: GlobalIsel: Fix fma combine when one of the operands comes from unmerge (authored by Petar.Avramovic).
GlobalIsel: Fix fma combine when one of the operands comes from unmerge
Jan 12 2022, 8:48 AM
Petar.Avramovic committed rG9f38a681cf25: GlobalIsel: Precommit fma combine tests with one operand from unmerge (authored by Petar.Avramovic).
GlobalIsel: Precommit fma combine tests with one operand from unmerge
Jan 12 2022, 8:48 AM
Petar.Avramovic closed D117032: GlobalIsel: Fix fma combine when one of the uses comes from unmerge.
Jan 12 2022, 8:48 AM · Restricted Project
Petar.Avramovic updated the diff for D117032: GlobalIsel: Fix fma combine when one of the uses comes from unmerge.

Previous version already had llvm-ir test with fma pattern covered in matchCombineFAddFMulToFMadOrFMA.
Cover remaining potential errors when MRI.getVRegDef(Reg)->getOperand(0).getReg() is used. Adding targeted mir tests for all these cases.
I don't have llvm-ir tests for these since they seem to combine before legalizer, unmerges that causes bad combine are generated in legalizer.

Jan 12 2022, 7:17 AM · Restricted Project

Jan 11 2022

Petar.Avramovic added a comment to D117032: GlobalIsel: Fix fma combine when one of the uses comes from unmerge.

TODO: do the same for remaining fma combines.

Jan 11 2022, 9:05 AM · Restricted Project
Petar.Avramovic requested review of D117032: GlobalIsel: Fix fma combine when one of the uses comes from unmerge.
Jan 11 2022, 9:02 AM · Restricted Project

Jan 10 2022

Petar.Avramovic accepted D116942: GlobalISel: Fix legalization error where CSE leaves behind dead defs.

The G_UNMERGE_VALUES of the G_SEXT of the G_BUILD_VECTOR would introduce a G_SEXT for each of the scalars.

Is there a reason why we don't have simpler pattern where conversion opcode of merge like opcode is not used by G_UNMERGE_VALUES (in this case only G_SEXT of the G_BUILD_VECTOR -> G_BUILD_VECTOR of G_SEXT for each of the scalars).

Jan 10 2022, 8:34 AM · Restricted Project
Petar.Avramovic committed rGd9d2516aafb9: AMDGPU/GlobalISel: Rework legalization for extract/insert vector elt (authored by Petar.Avramovic).
AMDGPU/GlobalISel: Rework legalization for extract/insert vector elt
Jan 10 2022, 4:25 AM
Petar.Avramovic closed D116115: AMDGPU/GlobalISel: Rework legalization for extract/insert vector elt.
Jan 10 2022, 4:25 AM · Restricted Project

Dec 30 2021

Petar.Avramovic updated the diff for D109969: AMDGPU/GlobalISel: Add isel patterns for min3 and max3.

Use ThreeOpFrag for integer min3 and max3.
Floating point min3 and max3 use regular pattern since Tablegen does not support complex pattern (VOP3Mods) inside PatFrag which would count sgpr operands. There should not be many cases where this would make a big difference since sgpr float operands come as function arguments or uniform loads, there are no uniform versions of floating point instructions.
There should be no constant bus restriction errors (sdag also takes care of cst_bus_restrictions when it prints mir from selected DAG)

  • integer min/max3 ThreeOpFrag handles cst_bus_restrictions
  • float min/max3
    • sdag deals with cst_bus_restrictions when it prints mir from selected DAG
    • globalisel all float min/max3 operands are set to vgpr by regbankselect

Improve test coverage and add precommit for new tests.

Dec 30 2021, 8:18 AM · Restricted Project

Dec 27 2021

Petar.Avramovic added inline comments to D114198: [GlobalISel] Rework more/fewer elements for vectors.
Dec 27 2021, 3:17 AM · Restricted Project
Petar.Avramovic committed rG508e39afe012: GlobalISel: remove redundant line added in D114198. NFC (authored by Petar.Avramovic).
GlobalISel: remove redundant line added in D114198. NFC
Dec 27 2021, 3:16 AM

Dec 23 2021

Petar.Avramovic committed rGfd3cde600ba6: AMDGPU/GlobalISel: Fix attempt to select non-legal instr in mir test (authored by Petar.Avramovic).
AMDGPU/GlobalISel: Fix attempt to select non-legal instr in mir test
Dec 23 2021, 7:15 AM
Petar.Avramovic committed rG29f88b93fdbe: [GlobalISel] Rework more/fewer elements for vectors (authored by Petar.Avramovic).
[GlobalISel] Rework more/fewer elements for vectors
Dec 23 2021, 5:30 AM
Petar.Avramovic committed rGd2863088ab89: GlobalISel: Regen vector mir tests, add tests for vector arg lowering (authored by Petar.Avramovic).
GlobalISel: Regen vector mir tests, add tests for vector arg lowering
Dec 23 2021, 5:30 AM
Petar.Avramovic closed D114198: [GlobalISel] Rework more/fewer elements for vectors.
Dec 23 2021, 5:30 AM · Restricted Project

Dec 21 2021

Petar.Avramovic updated the diff for D114198: [GlobalISel] Rework more/fewer elements for vectors.

Address comments, fix more spelling mistakes.

Dec 21 2021, 3:36 PM · Restricted Project
Petar.Avramovic requested review of D116115: AMDGPU/GlobalISel: Rework legalization for extract/insert vector elt.
Dec 21 2021, 8:49 AM · Restricted Project
Petar.Avramovic updated the diff for D114198: [GlobalISel] Rework more/fewer elements for vectors.

Cleanup.

Dec 21 2021, 8:33 AM · Restricted Project
Petar.Avramovic added inline comments to D114198: [GlobalISel] Rework more/fewer elements for vectors.
Dec 21 2021, 8:30 AM · Restricted Project
Petar.Avramovic updated the diff for D114198: [GlobalISel] Rework more/fewer elements for vectors.

Rebase and address comments.

Dec 21 2021, 8:20 AM · Restricted Project

Dec 16 2021

Petar.Avramovic added inline comments to D115881: [AMDGPU] Select no-return ds_* atomic ops in tblgen..
Dec 16 2021, 8:07 AM · Restricted Project

Dec 15 2021

Petar.Avramovic updated the diff for D114198: [GlobalISel] Rework more/fewer elements for vectors.

Rebase and ping.

Dec 15 2021, 6:50 AM · Restricted Project
Petar.Avramovic updated the diff for D109969: AMDGPU/GlobalISel: Add isel patterns for min3 and max3.

Rebase and ping.

Dec 15 2021, 6:49 AM · Restricted Project
Petar.Avramovic updated the diff for D114200: [D114198] precommit regen mir tests part 1.

Rebase.

Dec 15 2021, 6:48 AM · Restricted Project

Dec 3 2021

Petar.Avramovic updated the diff for D114198: [GlobalISel] Rework more/fewer elements for vectors.

Rebase and ping.

Dec 3 2021, 4:50 AM · Restricted Project
Petar.Avramovic committed rG0b34ffe4a61e: AMDGPU/GlobalISel: Add clamp combine (authored by Petar.Avramovic).
AMDGPU/GlobalISel: Add clamp combine
Dec 3 2021, 4:03 AM
Petar.Avramovic committed rGec54867d750b: AMDGPU/GlobalISel: Add floating point med3 combine (authored by Petar.Avramovic).
AMDGPU/GlobalISel: Add floating point med3 combine
Dec 3 2021, 4:03 AM
Petar.Avramovic committed rGab01f4d26400: AMDGPU/GlobalISel: Do not fcanonicalize const splat padded with undef (authored by Petar.Avramovic).
AMDGPU/GlobalISel: Do not fcanonicalize const splat padded with undef
Dec 3 2021, 4:03 AM
Petar.Avramovic closed D90052: AMDGPU/GlobalISel: Add clamp combine.
Dec 3 2021, 4:02 AM · Restricted Project
Petar.Avramovic closed D90051: AMDGPU/GlobalISel: Add floating point med3 combine.
Dec 3 2021, 4:02 AM · Restricted Project
Petar.Avramovic closed D104408: AMDGPU/GlobalISel: Do not fcanonicalize const splat padded with undef.
Dec 3 2021, 4:02 AM · Restricted Project

Dec 2 2021

Petar.Avramovic added inline comments to D90051: AMDGPU/GlobalISel: Add floating point med3 combine.
Dec 2 2021, 8:52 AM · Restricted Project
Petar.Avramovic updated the diff for D90051: AMDGPU/GlobalISel: Add floating point med3 combine.

Cache SIInstrInfo in the helper.

Dec 2 2021, 8:51 AM · Restricted Project

Dec 1 2021

Petar.Avramovic updated the diff for D90051: AMDGPU/GlobalISel: Add floating point med3 combine.

Rebase and ping.

Dec 1 2021, 1:57 PM · Restricted Project
Petar.Avramovic committed rG641906da8de2: AMDGPU/GlobalISel: Fix constant bus restriction errors for med3 (authored by Petar.Avramovic).
AMDGPU/GlobalISel: Fix constant bus restriction errors for med3
Dec 1 2021, 12:37 PM
Petar.Avramovic closed D114700: AMDGPU/GlobalISel: Fix constant bus restriction errors for med3.
Dec 1 2021, 12:37 PM · Restricted Project

Nov 30 2021

Petar.Avramovic updated the diff for D114700: AMDGPU/GlobalISel: Fix constant bus restriction errors for med3.

Use same prefix for gfx9 and gfx10 in mir test.

Nov 30 2021, 6:04 AM · Restricted Project
Petar.Avramovic updated the diff for D114700: AMDGPU/GlobalISel: Fix constant bus restriction errors for med3.

Make all operands vgpr for med3. Find already existing copies to vgpr for constants.

Nov 30 2021, 3:44 AM · Restricted Project

Nov 29 2021

Petar.Avramovic requested review of D114700: AMDGPU/GlobalISel: Fix constant bus restriction errors for med3.
Nov 29 2021, 5:23 AM · Restricted Project

Nov 18 2021

Petar.Avramovic requested review of D114200: [D114198] precommit regen mir tests part 1.
Nov 18 2021, 3:41 PM · Restricted Project
Petar.Avramovic requested review of D114199: [D114198] precommit regen mir tests part 2.
Nov 18 2021, 3:40 PM · Restricted Project
Petar.Avramovic requested review of D114198: [GlobalISel] Rework more/fewer elements for vectors.
Nov 18 2021, 3:26 PM · Restricted Project

Oct 5 2021

Petar.Avramovic accepted D111129: [AMDGPU][GlobalISel] Fix legalization of G_UMULH.
Oct 5 2021, 2:48 AM · Restricted Project
Petar.Avramovic added a comment to D110926: [GlobalISel] Support vectors in LegalizerHelper::narrowScalarMul.

Afaik %3:_(<2 x s32>), %4:_(<2 x s32>) = G_UNMERGE_VALUES %0:_(<2 x s64>) is not yet defined to work like that and should probably be forbidden to make such instruction in builder. Only allow scalar split and vector split to elements or sub-vectors.
Desired unmerge works if done step by step:

%5:_(s64), %6:_(s64) = G_UNMERGE_VALUES %0:_(<2 x s64>)
%7:_(s32), %8:_(s32) = G_UNMERGE_VALUES %5:_(s64)
%9:_(s32), %10:_(s32) = G_UNMERGE_VALUES %6:_(s64)
%3:_(<2 x s32>) = G_BUILD_VECTOR %5:_(s64), %7:_(s32)
%4:_(<2 x s32>) = G_BUILD_VECTOR %6:_(s64), %8:_(s32)

Similar for merge: merge s64 elements first then build <2 x s64> vector.
But <2 x s32> instructions will be scalarized, bit shift packing into <2 x s16> is most probably slower.
Why not go with scalarize at the start?

Oct 5 2021, 2:28 AM · Restricted Project

Sep 21 2021

Petar.Avramovic committed rGf3366983f0aa: AMDGPU/GlobalISel: Restore run line erased in D109154 by mistake (authored by Petar.Avramovic).
AMDGPU/GlobalISel: Restore run line erased in D109154 by mistake
Sep 21 2021, 8:04 AM
Petar.Avramovic added a comment to D107650: GlobalISel[RFC]: Avoid use of G_INSERT and G_EXTRACT in Legalizer .

Haven't finished grokking this yet, some comments so far.

Do you have some test cases you are interested in? High level summary would be that by doing unmerge to each element before changing number of elements in a vector we are able to reference each element using vreg. This should be enough since we don't deal with anything smaller. This fixes main problem I see in combines "referencing an element in subvector" required by "merge subvector with subvector(or single element) of another subvector".

Sep 21 2021, 8:02 AM · Restricted Project
Petar.Avramovic committed rG8bc71856681c: GlobalISel/Utils: Refactor constant splat match functions (authored by Petar.Avramovic).
GlobalISel/Utils: Refactor constant splat match functions
Sep 21 2021, 3:10 AM
Petar.Avramovic closed D104410: GlobalISel/Utils: Refactor constant splat match functions.
Sep 21 2021, 3:10 AM · Restricted Project
Petar.Avramovic added inline comments to D109154: [GlobalISel] Improve elimination of dead instructions in legalizer.
Sep 21 2021, 2:46 AM · Restricted Project

Sep 20 2021

Petar.Avramovic updated the diff for D104410: GlobalISel/Utils: Refactor constant splat match functions.

Addressed review comments.

Sep 20 2021, 8:48 AM · Restricted Project
Petar.Avramovic updated the diff for D109969: AMDGPU/GlobalISel: Add isel patterns for min3 and max3.

Remove min3 and max3 combine from sdag path, use isel patterns. I am not sure about this for sdag, generated code looks worse. I could move this to the post-regbankcombiner for global-isel.
Notable test changes:

  • ieee = true : quieting(fcanonicalize) of operands that go in min3/max3. This is because min/max legalization happens, originally combine would make min3/max3 before legalizing.
  • uniform ctlz/cttz lowering : isel selects uniform min/max thus no min3/max3. SI Fix SGPR copies turns this into v_min/v_max and it looks like a regression.
Sep 20 2021, 7:48 AM · Restricted Project
Petar.Avramovic added a comment to D109154: [GlobalISel] Improve elimination of dead instructions in legalizer.

Thanks for the review and compile time performance testing.

Sep 20 2021, 4:03 AM · Restricted Project
Petar.Avramovic committed rGe4c46ddd91eb: [GlobalISel] Improve elimination of dead instructions in legalizer (authored by Petar.Avramovic).
[GlobalISel] Improve elimination of dead instructions in legalizer
Sep 20 2021, 4:02 AM
Petar.Avramovic closed D109154: [GlobalISel] Improve elimination of dead instructions in legalizer.
Sep 20 2021, 4:02 AM · Restricted Project
Petar.Avramovic added a comment to D109969: AMDGPU/GlobalISel: Add isel patterns for min3 and max3.

Dag does this in dag-combiner. For GlobalISel combine would be in regbankcombiner (we need banks to not combine for uniform min and max) which runs just before isel. And since it is simple to match I did this in tablegen.
I will check if this works for sdag without regressions.

Sep 20 2021, 3:07 AM · Restricted Project
Petar.Avramovic retitled D109969: AMDGPU/GlobalISel: Add isel patterns for min3 and max3 from AMDGPU/GlobalISel: Add min3 and max3 combines to AMDGPU/GlobalISel: Add isel patterns for min3 and max3.
Sep 20 2021, 2:59 AM · Restricted Project

Sep 17 2021

Petar.Avramovic added a comment to D90051: AMDGPU/GlobalISel: Add floating point med3 combine.

Ping.

Sep 17 2021, 8:57 AM · Restricted Project
Petar.Avramovic updated the diff for D104410: GlobalISel/Utils: Refactor constant splat match functions.

Remove comment about constant splat with NaN value. Seems unnecessary to mention it since we match all constants.

Sep 17 2021, 8:56 AM · Restricted Project
Petar.Avramovic requested review of D109969: AMDGPU/GlobalISel: Add isel patterns for min3 and max3.
Sep 17 2021, 8:26 AM · Restricted Project
Petar.Avramovic added inline comments to D104410: GlobalISel/Utils: Refactor constant splat match functions.
Sep 17 2021, 3:45 AM · Restricted Project
Petar.Avramovic added a comment to D104410: GlobalISel/Utils: Refactor constant splat match functions.

Ping.

Sep 17 2021, 3:03 AM · Restricted Project
Petar.Avramovic committed rGd477a7c2e704: GlobalISel/Utils: Refactor integer/float constant match functions (authored by Petar.Avramovic).
GlobalISel/Utils: Refactor integer/float constant match functions
Sep 17 2021, 2:38 AM
Petar.Avramovic closed D104409: GlobalISel/Utils: Refactor integer/float constant match functions.
Sep 17 2021, 2:38 AM · Restricted Project

Sep 16 2021

Petar.Avramovic updated the summary of D107650: GlobalISel[RFC]: Avoid use of G_INSERT and G_EXTRACT in Legalizer .
Sep 16 2021, 5:59 AM · Restricted Project
Petar.Avramovic added a comment to D109858: [GlobalISel][AMDGPU] Add dead code elimination clean up after legalization..

Most common case where we end up with dead instrs in output is unmerge with dead deaf
legalize unmerge using lower(unmerge is in inst list):
Legalizing: %36:_(s16), %37:_(s16) = G_UNMERGE_VALUES %17:_(<2 x s16>)
%37 is dead here, lower creates instrs and artifacts but we are now going through instrlist
.. .. New MI: %49:_(s32) = G_BITCAST %17:_(<2 x s16>)
.. .. New MI: %36:_(s16) = G_TRUNC %49:_(s32)
.. .. New MI: %50:_(s32) = G_LSHR %49:_, %47:_(s32)
.. .. New MI: %37:_(s16) = G_TRUNC %50:_(s32)

Sep 16 2021, 4:20 AM · Restricted Project

Sep 15 2021

Petar.Avramovic added a comment to D107650: GlobalISel[RFC]: Avoid use of G_INSERT and G_EXTRACT in Legalizer .

Ping. Also see build_vector combines starting with D109240.

Sep 15 2021, 8:28 AM · Restricted Project
Petar.Avramovic updated the diff for D104409: GlobalISel/Utils: Refactor integer/float constant match functions.

Rebase and ping.
Brief summary:
Add support for g_fconstant matching and option to return APFloat.
Rename getConstantVRegValWithLookThrough into get{I|F|Any}ConstantVRegValWithLookThrough. Remove HandleFConstant argument, use function with appropriate name instead.
Add matchers for Reg and APInt/Float: g_constant m_GCst(&ValueAndVReg) and g_fconstant m_GFCst(&FPValueAndVReg)

Sep 15 2021, 8:21 AM · Restricted Project

Sep 14 2021

Petar.Avramovic added inline comments to D109750: [GlobalISel][Legalizer] Don't use eraseFromParentAndMarkDBGValuesForRemoval() for some artifacts..
Sep 14 2021, 7:55 AM · Restricted Project

Sep 10 2021

Petar.Avramovic updated the diff for D109243: AMDGPU/GlobalISel: Add build_vector_trunc post-legalizer combine.

Move to amdgpu post-legalizer combine.

Sep 10 2021, 6:16 AM · Restricted Project

Sep 8 2021

Petar.Avramovic added inline comments to D109241: GlobalISel: Artifact combine build-vectors and unmerge into unmerge.
Sep 8 2021, 4:16 AM · Restricted Project