volkan (Volkan Keles)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 30 2015, 12:54 PM (133 w, 1 d)

Recent Activity

Today

volkan committed rL322800: Fix the failure caused by r322773.
Fix the failure caused by r322773
Wed, Jan 17, 5:12 PM
volkan committed rL322773: Add a TargetOption to enable/disable GlobalISel.
Add a TargetOption to enable/disable GlobalISel
Wed, Jan 17, 2:38 PM
volkan closed D42137: Add a TargetOption to enable/disable GlobalISel.
Wed, Jan 17, 2:38 PM

Yesterday

volkan created D42137: Add a TargetOption to enable/disable GlobalISel.
Tue, Jan 16, 3:08 PM
volkan committed rL322582: [GlobalISel][TableGen] Add support for SDNodeXForm.
[GlobalISel][TableGen] Add support for SDNodeXForm
Tue, Jan 16, 10:45 AM
volkan closed D42012: [GlobalISel][TableGen] Add support for SDNodeXForm.
Tue, Jan 16, 10:45 AM
volkan updated the diff for D42012: [GlobalISel][TableGen] Add support for SDNodeXForm.

Updated based on Daniel's comments.

Tue, Jan 16, 9:46 AM

Fri, Jan 12

volkan updated the diff for D42012: [GlobalISel][TableGen] Add support for SDNodeXForm.

Added the pattern to the test file.

Fri, Jan 12, 5:10 PM
volkan added inline comments to D42012: [GlobalISel][TableGen] Add support for SDNodeXForm.
Fri, Jan 12, 5:04 PM
volkan added inline comments to D42012: [GlobalISel][TableGen] Add support for SDNodeXForm.
Fri, Jan 12, 4:28 PM
volkan updated the diff for D42012: [GlobalISel][TableGen] Add support for SDNodeXForm.

Replaced auto with the actual type to make the code easy to read.

Fri, Jan 12, 4:21 PM
volkan created D42012: [GlobalISel][TableGen] Add support for SDNodeXForm.
Fri, Jan 12, 2:39 PM

Wed, Jan 10

volkan added a comment to D41876: Add a utility to reduce GlobalISel tests.

Could this be extended to reduce any isel related bug?

Yes, it can be extended to reduce the other ISel problems by adding a regex and the specific arguments for llc.

I'm guessing the answer is no since you'd have to update the regex as well, but would it make sense to allow llc arguments to be passed through from the command line or something like that?

Wed, Jan 10, 1:22 PM

Tue, Jan 9

volkan updated the diff for D41876: Add a utility to reduce GlobalISel tests.

Added a comment about how the script works.

Tue, Jan 9, 3:14 PM
volkan added a comment to D41876: Add a utility to reduce GlobalISel tests.

Out of interest: Could you explain what this is doing exactly (as the comment at the beginning of the script isn't too specific about what is happening here)? At a first glance it seems to inject a custom command into bugpoint and checks the output for that "LLVM ERROR:" regex? Or is there something else?

Tue, Jan 9, 3:07 PM
volkan added a comment to D41876: Add a utility to reduce GlobalISel tests.

Hi Volkan,

Disclaimer: I have looked at the patch at all.

Could this be extended to reduce any isel related bug?

Cheers,
-Quentin

Tue, Jan 9, 3:07 PM
volkan created D41876: Add a utility to reduce GlobalISel tests.
Tue, Jan 9, 11:51 AM

Fri, Dec 29

volkan created D41638: [llvm-extract] Support extracting basic blocks.
Fri, Dec 29, 3:59 PM

Dec 1 2017

volkan committed rL319524: GlobalISel: Enable the legalization of G_MERGE_VALUES and G_UNMERGE_VALUES.
GlobalISel: Enable the legalization of G_MERGE_VALUES and G_UNMERGE_VALUES
Dec 1 2017, 12:19 AM
volkan closed D39823: GlobalISel: Enable the legalization of G_MERGE_VALUES and G_UNMERGE_VALUES.
Dec 1 2017, 12:19 AM

Nov 29 2017

volkan added inline comments to D39823: GlobalISel: Enable the legalization of G_MERGE_VALUES and G_UNMERGE_VALUES.
Nov 29 2017, 10:49 PM
volkan updated the diff for D39823: GlobalISel: Enable the legalization of G_MERGE_VALUES and G_UNMERGE_VALUES.

Updated based on Daniel's comments.

Nov 29 2017, 10:39 PM

Nov 27 2017

volkan added a comment to D39823: GlobalISel: Enable the legalization of G_MERGE_VALUES and G_UNMERGE_VALUES.

Ping.

Nov 27 2017, 10:02 PM

Nov 15 2017

volkan added a comment to D38200: [GISel]: Process new insts to legalize in the order they were created.

I think this is no longer required, rL318210 fixed this problem.

Nov 15 2017, 3:52 PM

Nov 14 2017

volkan added inline comments to D39823: GlobalISel: Enable the legalization of G_MERGE_VALUES and G_UNMERGE_VALUES.
Nov 14 2017, 4:08 PM
volkan updated the diff for D39823: GlobalISel: Enable the legalization of G_MERGE_VALUES and G_UNMERGE_VALUES.
  • Handled missing cases for AArch64.
  • Rebased.
Nov 14 2017, 4:08 PM
volkan accepted D39267: [GISel]: Change Legalization from top down to bottom up + DCE.

Hi Aditya,

Nov 14 2017, 1:14 PM

Nov 10 2017

volkan updated the diff for D39823: GlobalISel: Enable the legalization of G_MERGE_VALUES and G_UNMERGE_VALUES.

Removed the special case for G_MERGE_VALUES.

Nov 10 2017, 1:09 PM
volkan added inline comments to D39823: GlobalISel: Enable the legalization of G_MERGE_VALUES and G_UNMERGE_VALUES.
Nov 10 2017, 12:58 PM

Nov 9 2017

volkan updated the diff for D39823: GlobalISel: Enable the legalization of G_MERGE_VALUES and G_UNMERGE_VALUES.

Updated based on Kristof's comments.

Nov 9 2017, 4:08 PM
volkan added inline comments to D39823: GlobalISel: Enable the legalization of G_MERGE_VALUES and G_UNMERGE_VALUES.
Nov 9 2017, 3:23 PM

Nov 8 2017

volkan created D39823: GlobalISel: Enable the legalization of G_MERGE_VALUES and G_UNMERGE_VALUES.
Nov 8 2017, 4:26 PM

Aug 30 2017

volkan accepted D36880: [GSel]: Add a cleanup combiner to cleanup legalization artifacts.

Thank you Aditya, LGTM!

Aug 30 2017, 9:57 AM
volkan added inline comments to D36880: [GSel]: Add a cleanup combiner to cleanup legalization artifacts.
Aug 30 2017, 5:16 AM

Aug 29 2017

volkan added a comment to D36880: [GSel]: Add a cleanup combiner to cleanup legalization artifacts.

Thank you Aditya. I added a few more inline comments.

Aug 29 2017, 10:42 AM

Aug 25 2017

volkan added inline comments to D36880: [GSel]: Add a cleanup combiner to cleanup legalization artifacts.
Aug 25 2017, 3:23 AM

Jul 27 2017

volkan added a comment to D35737: [GSel]: Support Widening G_ICMP's destination operand..

LGTM except:

  • Missing test case
  • The title needs be updated
Jul 27 2017, 4:34 AM
volkan added a reviewer for D35737: [GSel]: Support Widening G_ICMP's destination operand.: volkan.
Jul 27 2017, 4:33 AM

Jul 26 2017

volkan added a comment to D35737: [GSel]: Support Widening G_ICMP's destination operand..

Could you add a test case or an explanation if it's not possible to add a test case?

Jul 26 2017, 3:50 AM

Jun 5 2017

volkan committed rL304743: [GlobalISel] IRTranslator: Add MachineMemOperand to target memory intrinsics.
[GlobalISel] IRTranslator: Add MachineMemOperand to target memory intrinsics
Jun 5 2017, 3:17 PM
volkan closed D33724: [GlobalISel] IRTranslator: Add MachineMemOperand to target memory intrinsics by committing rL304743: [GlobalISel] IRTranslator: Add MachineMemOperand to target memory intrinsics.
Jun 5 2017, 3:17 PM
volkan closed D33724: [GlobalISel] IRTranslator: Add MachineMemOperand to target memory intrinsics.
Jun 5 2017, 3:17 PM

May 31 2017

volkan created D33724: [GlobalISel] IRTranslator: Add MachineMemOperand to target memory intrinsics.
May 31 2017, 7:39 AM

May 19 2017

volkan committed rL303412: [GlobalISel] IRTranslator: Translate ConstantStruct.
[GlobalISel] IRTranslator: Translate ConstantStruct
May 19 2017, 3:00 AM
volkan closed D33317: [GlobalISel] IRTranslator: Translate ConstantStruct.
May 19 2017, 3:00 AM
volkan updated the diff for D33317: [GlobalISel] IRTranslator: Translate ConstantStruct.
  • Use SmallVector instead of std::vector.
May 19 2017, 2:58 AM

May 18 2017

volkan created D33317: [GlobalISel] IRTranslator: Translate ConstantStruct.
May 18 2017, 6:00 AM
volkan abandoned D33315: [GlobalISel] IRTranslator: Translate ConstantStruct.

This patch didn’t get sent to the mailing list because I forgot to add llvm-commits in the first place. I’m going to close and re-create this revision.

May 18 2017, 5:57 AM
volkan updated subscribers of D33315: [GlobalISel] IRTranslator: Translate ConstantStruct.
May 18 2017, 5:23 AM
volkan created D33315: [GlobalISel] IRTranslator: Translate ConstantStruct.
May 18 2017, 5:23 AM

Apr 11 2017

volkan committed rL299929: [GlobalISel] LegalizerInfo: Enable legalization of non-power-of-2 types.
[GlobalISel] LegalizerInfo: Enable legalization of non-power-of-2 types
Apr 11 2017, 3:22 AM
volkan closed D31711: [GlobalISel] LegalizerInfo: Enable legalization of non-power-of-2 types.
Apr 11 2017, 3:22 AM
volkan updated the diff for D31711: [GlobalISel] LegalizerInfo: Enable legalization of non-power-of-2 types.
  • Updated the comment.
Apr 11 2017, 3:21 AM
volkan added inline comments to D31711: [GlobalISel] LegalizerInfo: Enable legalization of non-power-of-2 types.
Apr 11 2017, 12:04 AM

Apr 7 2017

volkan requested review of D31711: [GlobalISel] LegalizerInfo: Enable legalization of non-power-of-2 types.
Apr 7 2017, 11:11 AM
volkan updated the diff for D31711: [GlobalISel] LegalizerInfo: Enable legalization of non-power-of-2 types.
  • Updated the patch per my previous comment.
  • Added a vector fallback test.
Apr 7 2017, 10:55 AM
volkan added inline comments to D31711: [GlobalISel] LegalizerInfo: Enable legalization of non-power-of-2 types.
Apr 7 2017, 7:14 AM

Apr 5 2017

volkan updated the diff for D31711: [GlobalISel] LegalizerInfo: Enable legalization of non-power-of-2 types.

Added a test.

Apr 5 2017, 9:02 AM
volkan retitled D31711: [GlobalISel] LegalizerInfo: Enable legalization of non-power-of-2 types from [GlobalISel] LegalizerInfo: Check if the vector element type is power of 2 to [GlobalISel] LegalizerInfo: Enable legalization of vector types with non-power-of-2 number of elements.
Apr 5 2017, 8:57 AM
volkan added inline comments to D31711: [GlobalISel] LegalizerInfo: Enable legalization of non-power-of-2 types.
Apr 5 2017, 8:56 AM
volkan created D31711: [GlobalISel] LegalizerInfo: Enable legalization of non-power-of-2 types.
Apr 5 2017, 8:00 AM

Mar 21 2017

volkan committed rL298367: [GlobalISel] Fix shufflevector tests.
[GlobalISel] Fix shufflevector tests
Mar 21 2017, 6:25 AM
volkan committed rL298358: [GlobalISel] Move isTriviallyDead to Utils. NFC..
[GlobalISel] Move isTriviallyDead to Utils. NFC.
Mar 21 2017, 3:59 AM
volkan committed rL298347: [GlobalISel] Translate shufflevector.
[GlobalISel] Translate shufflevector
Mar 21 2017, 1:56 AM
volkan closed D30962: [GlobalISel] Translate shufflevector.
Mar 21 2017, 1:56 AM
volkan added a comment to D30962: [GlobalISel] Translate shufflevector.
In D30962#704916, @ab wrote:

We don't need to do this now, but should we encode the mask in the G_SHUFFLE_VECTOR itself? Either as multiple Imm MOs, or a single new 'VectorMask' operand of some sort?

I think we should probably stick with a single operand to represent the mask since some targets can use vector registers to specify the shuffle mask (e.g. VSHF.df on Mips), but I do agree that a single operand containing a whole constant mask would be nicer to match than the current G_MERGE_VALUES of G_CONSTANTS since there's lots of ways of writing the same constant right now. For example:

Mar 21 2017, 12:52 AM

Mar 17 2017

volkan updated the diff for D30962: [GlobalISel] Translate shufflevector.

Added more tests.

Mar 17 2017, 1:32 PM

Mar 14 2017

volkan created D30962: [GlobalISel] Translate shufflevector.
Mar 14 2017, 5:17 PM
volkan committed rL297792: [GlobalISel] IRTranslator: Return the scalar for <1 x Ty> constant vectors.
[GlobalISel] IRTranslator: Return the scalar for <1 x Ty> constant vectors
Mar 14 2017, 4:57 PM
volkan closed D30948: [GlobalISel] IRTranslator: Return the scalar for <1 x Ty> constant vectors.
Mar 14 2017, 4:57 PM
volkan created D30948: [GlobalISel] IRTranslator: Return the scalar for <1 x Ty> constant vectors.
Mar 14 2017, 10:59 AM

Mar 13 2017

volkan committed rL297670: GlobalISel: Translate ConstantDataVector.
GlobalISel: Translate ConstantDataVector
Mar 13 2017, 2:48 PM
volkan closed D30216: GlobalISel: Translate ConstantDataVector.
Mar 13 2017, 2:48 PM
volkan added inline comments to D30216: GlobalISel: Translate ConstantDataVector.
Mar 13 2017, 2:44 PM
volkan committed rL297663: [GlobalISel] Update PRE_ISEL_GENERIC_OPCODE_END marker.
[GlobalISel] Update PRE_ISEL_GENERIC_OPCODE_END marker
Mar 13 2017, 1:44 PM
volkan updated the diff for D30216: GlobalISel: Translate ConstantDataVector.

Added a non-power-of-2 test.

Mar 13 2017, 10:24 AM

Mar 10 2017

volkan committed rL297512: [GlobalISel] LegalizerHelper: Lower (G_FSUB X, Y) to (G_FADD X, (G_FNEG Y)).
[GlobalISel] LegalizerHelper: Lower (G_FSUB X, Y) to (G_FADD X, (G_FNEG Y))
Mar 10 2017, 1:37 PM
volkan closed D30786: [GlobalISel] LegalizerHelper: Lower (G_FSUB X, Y) to (G_FADD X, (G_FNEG Y)).
Mar 10 2017, 1:37 PM
volkan committed rL297509: GlobalISel: Translate ConstantAggregateZero vectors.
GlobalISel: Translate ConstantAggregateZero vectors
Mar 10 2017, 1:35 PM
volkan closed D30259: GlobalISel: Translate ConstantAggregateZero vectors.
Mar 10 2017, 1:35 PM
volkan updated the diff for D30259: GlobalISel: Translate ConstantAggregateZero vectors.
  • Added a non-power-of-2 test.
  • Removed GlobalISelAbortEnabled check.
Mar 10 2017, 12:00 PM
volkan committed rL297495: [GlobalISel] Translate insertelement and extractelement.
[GlobalISel] Translate insertelement and extractelement
Mar 10 2017, 11:20 AM
volkan closed D30761: [GlobalISel] Translate insertelement and extractelement.
Mar 10 2017, 11:20 AM
volkan updated the diff for D30786: [GlobalISel] LegalizerHelper: Lower (G_FSUB X, Y) to (G_FADD X, (G_FNEG Y)).

Check if G_FNEG is marked as Lower to avoid ending up with an infinite loop.

Mar 10 2017, 10:59 AM
volkan committed rL297491: [GlobalISel] Make LegalizerInfo accessible in LegalizerHelper.
[GlobalISel] Make LegalizerInfo accessible in LegalizerHelper
Mar 10 2017, 10:47 AM
volkan closed D30838: [GlobalISel] Make LegalizerInfo accessible in LegalizerHelper.
Mar 10 2017, 10:46 AM
volkan created D30838: [GlobalISel] Make LegalizerInfo accessible in LegalizerHelper.
Mar 10 2017, 10:40 AM
volkan added inline comments to D30786: [GlobalISel] LegalizerHelper: Lower (G_FSUB X, Y) to (G_FADD X, (G_FNEG Y)).
Mar 10 2017, 9:45 AM

Mar 9 2017

volkan created D30786: [GlobalISel] LegalizerHelper: Lower (G_FSUB X, Y) to (G_FADD X, (G_FNEG Y)).
Mar 9 2017, 11:34 AM

Mar 8 2017

volkan created D30761: [GlobalISel] Translate insertelement and extractelement.
Mar 8 2017, 3:15 PM
volkan updated the diff for D30259: GlobalISel: Translate ConstantAggregateZero vectors.

Use G_MERGE_VALUES to represent vectors.

Mar 8 2017, 11:02 AM
volkan committed rL297301: [GlobalISel] Add default action for G_FNEG.
[GlobalISel] Add default action for G_FNEG
Mar 8 2017, 10:21 AM
volkan closed D30721: [GlobalISel] Add default action for G_FNEG.
Mar 8 2017, 10:21 AM

Mar 7 2017

volkan updated the diff for D30216: GlobalISel: Translate ConstantDataVector.

Use G_MERGE_VALUES to represent vectors.

Mar 7 2017, 4:24 PM
volkan added inline comments to D30216: GlobalISel: Translate ConstantDataVector.
Mar 7 2017, 3:42 PM
volkan added inline comments to D30721: [GlobalISel] Add default action for G_FNEG.
Mar 7 2017, 3:22 PM
volkan created D30721: [GlobalISel] Add default action for G_FNEG.
Mar 7 2017, 2:49 PM
volkan committed rL297171: [GlobalISel] Translate floating-point negation.
[GlobalISel] Translate floating-point negation
Mar 7 2017, 10:15 AM
volkan closed D30671: [GlobalISel] Translate floating-point negation.
Mar 7 2017, 10:15 AM
volkan added inline comments to D30671: [GlobalISel] Translate floating-point negation.
Mar 7 2017, 1:26 AM