volkan (Volkan Keles)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 30 2015, 12:54 PM (155 w, 5 d)

Recent Activity

Fri, Jun 22

volkan accepted D48469: [GISel]: Add opcode to translate addrspacecast.

LGTM.

Fri, Jun 22, 12:42 PM

Mar 12 2018

volkan committed rL327340: BlockExtractor: Don’t delete functions directly.
BlockExtractor: Don’t delete functions directly
Mar 12 2018, 3:31 PM

Mar 8 2018

volkan accepted D44128: [GISel]: Add helpers for easy building G_FCONSTANT along with matchers.

LGTM. Thank you Aditya.

Mar 8 2018, 2:45 PM
volkan added inline comments to D44128: [GISel]: Add helpers for easy building G_FCONSTANT along with matchers.
Mar 8 2018, 12:05 PM

Mar 5 2018

volkan committed rL326749: GlobalISel: IRTranslate llvm.fabs.* intrinsic.
GlobalISel: IRTranslate llvm.fabs.* intrinsic
Mar 5 2018, 2:34 PM
volkan closed D43864: GlobalISel: IRTranslate llvm.fabs.* intrinsic.
Mar 5 2018, 2:34 PM
volkan updated the diff for D43864: GlobalISel: IRTranslate llvm.fabs.* intrinsic.

Added pattern matcher support for G_FABS.

Mar 5 2018, 11:55 AM

Mar 2 2018

volkan added a comment to D43864: GlobalISel: IRTranslate llvm.fabs.* intrinsic.

This looks mostly fine. Could you also add pattern matchers for fabs when you get the greenlight from others?

Mar 2 2018, 5:14 AM

Feb 28 2018

volkan created D43864: GlobalISel: IRTranslate llvm.fabs.* intrinsic.
Feb 28 2018, 3:35 AM

Feb 14 2018

volkan committed rL325162: GlobalISel: Add templated functions and pattern matcher support for some more….
GlobalISel: Add templated functions and pattern matcher support for some more…
Feb 14 2018, 12:00 PM
volkan closed D43309: GlobalISel: Add templated functions and pattern matcher support for some more opcodes.
Feb 14 2018, 12:00 PM
volkan updated the diff for D43309: GlobalISel: Add templated functions and pattern matcher support for some more opcodes.

Added a check for the input operand of the bitcast instruction.

Feb 14 2018, 11:48 AM
volkan created D43309: GlobalISel: Add templated functions and pattern matcher support for some more opcodes.
Feb 14 2018, 11:36 AM

Feb 12 2018

volkan committed rL324971: GlobalISel: IRTranslate llvm.fmuladd.* intrinsic.
GlobalISel: IRTranslate llvm.fmuladd.* intrinsic
Feb 12 2018, 4:50 PM
volkan closed D43090: GlobalISel: IRTranslate llvm.fmuladd.* intrinsic.
Feb 12 2018, 4:49 PM
volkan updated the diff for D43090: GlobalISel: IRTranslate llvm.fmuladd.* intrinsic.

Added a TODO about moving a part of the translation to the combiner.

Feb 12 2018, 4:48 PM
volkan added inline comments to D43090: GlobalISel: IRTranslate llvm.fmuladd.* intrinsic.
Feb 12 2018, 9:40 AM

Feb 9 2018

volkan added inline comments to D43090: GlobalISel: IRTranslate llvm.fmuladd.* intrinsic.
Feb 9 2018, 12:51 PM

Feb 8 2018

volkan created D43090: GlobalISel: IRTranslate llvm.fmuladd.* intrinsic.
Feb 8 2018, 1:50 PM

Feb 6 2018

volkan committed rL324442: GlobalISel: Always check operand types when executing match table.
GlobalISel: Always check operand types when executing match table
Feb 6 2018, 6:47 PM
volkan closed D42984: GlobalISel: Always check operand types when executing match table.
Feb 6 2018, 6:47 PM
volkan created D42984: GlobalISel: Always check operand types when executing match table.
Feb 6 2018, 2:11 PM

Jan 24 2018

volkan committed rL323391: [GlobalISel][TableGen] Fix the statistics for emitted patters.
[GlobalISel][TableGen] Fix the statistics for emitted patters
Jan 24 2018, 4:20 PM

Jan 23 2018

volkan committed rL323274: Add missing include to fix the failure caused by r323266.
Add missing include to fix the failure caused by r323266
Jan 23 2018, 2:57 PM
volkan committed rL323271: BlockExtractor: Remove unused variable. NFC..
BlockExtractor: Remove unused variable. NFC.
Jan 23 2018, 2:27 PM
volkan committed rL323266: [llvm-extract] Support extracting basic blocks.
[llvm-extract] Support extracting basic blocks
Jan 23 2018, 1:53 PM
volkan closed D41638: [llvm-extract] Support extracting basic blocks.
Jan 23 2018, 1:53 PM
volkan added inline comments to D41638: [llvm-extract] Support extracting basic blocks.
Jan 23 2018, 12:26 PM
volkan committed rL323248: Add a utility to reduce GlobalISel tests.
Add a utility to reduce GlobalISel tests
Jan 23 2018, 11:49 AM
volkan closed D41876: Add a utility to reduce GlobalISel tests.
Jan 23 2018, 11:49 AM
volkan updated the diff for D41638: [llvm-extract] Support extracting basic blocks.

Updated based on the feedback.

Jan 23 2018, 11:36 AM
volkan added inline comments to D41638: [llvm-extract] Support extracting basic blocks.
Jan 23 2018, 11:35 AM

Jan 17 2018

volkan committed rL322800: Fix the failure caused by r322773.
Fix the failure caused by r322773
Jan 17 2018, 5:12 PM
volkan committed rL322773: Add a TargetOption to enable/disable GlobalISel.
Add a TargetOption to enable/disable GlobalISel
Jan 17 2018, 2:38 PM
volkan closed D42137: Add a TargetOption to enable/disable GlobalISel.
Jan 17 2018, 2:38 PM

Jan 16 2018

volkan created D42137: Add a TargetOption to enable/disable GlobalISel.
Jan 16 2018, 3:08 PM
volkan committed rL322582: [GlobalISel][TableGen] Add support for SDNodeXForm.
[GlobalISel][TableGen] Add support for SDNodeXForm
Jan 16 2018, 10:45 AM
volkan closed D42012: [GlobalISel][TableGen] Add support for SDNodeXForm.
Jan 16 2018, 10:45 AM
volkan updated the diff for D42012: [GlobalISel][TableGen] Add support for SDNodeXForm.

Updated based on Daniel's comments.

Jan 16 2018, 9:46 AM

Jan 12 2018

volkan updated the diff for D42012: [GlobalISel][TableGen] Add support for SDNodeXForm.

Added the pattern to the test file.

Jan 12 2018, 5:10 PM
volkan added inline comments to D42012: [GlobalISel][TableGen] Add support for SDNodeXForm.
Jan 12 2018, 5:04 PM
volkan added inline comments to D42012: [GlobalISel][TableGen] Add support for SDNodeXForm.
Jan 12 2018, 4:28 PM
volkan updated the diff for D42012: [GlobalISel][TableGen] Add support for SDNodeXForm.

Replaced auto with the actual type to make the code easy to read.

Jan 12 2018, 4:21 PM
volkan created D42012: [GlobalISel][TableGen] Add support for SDNodeXForm.
Jan 12 2018, 2:39 PM

Jan 10 2018

volkan added a comment to D41876: Add a utility to reduce GlobalISel tests.

Could this be extended to reduce any isel related bug?

Yes, it can be extended to reduce the other ISel problems by adding a regex and the specific arguments for llc.

I'm guessing the answer is no since you'd have to update the regex as well, but would it make sense to allow llc arguments to be passed through from the command line or something like that?

Jan 10 2018, 1:22 PM

Jan 9 2018

volkan updated the diff for D41876: Add a utility to reduce GlobalISel tests.

Added a comment about how the script works.

Jan 9 2018, 3:14 PM
volkan added a comment to D41876: Add a utility to reduce GlobalISel tests.

Out of interest: Could you explain what this is doing exactly (as the comment at the beginning of the script isn't too specific about what is happening here)? At a first glance it seems to inject a custom command into bugpoint and checks the output for that "LLVM ERROR:" regex? Or is there something else?

Jan 9 2018, 3:07 PM
volkan added a comment to D41876: Add a utility to reduce GlobalISel tests.

Hi Volkan,

Disclaimer: I have looked at the patch at all.

Could this be extended to reduce any isel related bug?

Cheers,
-Quentin

Jan 9 2018, 3:07 PM
volkan created D41876: Add a utility to reduce GlobalISel tests.
Jan 9 2018, 11:51 AM

Dec 29 2017

volkan created D41638: [llvm-extract] Support extracting basic blocks.
Dec 29 2017, 3:59 PM

Dec 1 2017

volkan committed rL319524: GlobalISel: Enable the legalization of G_MERGE_VALUES and G_UNMERGE_VALUES.
GlobalISel: Enable the legalization of G_MERGE_VALUES and G_UNMERGE_VALUES
Dec 1 2017, 12:19 AM
volkan closed D39823: GlobalISel: Enable the legalization of G_MERGE_VALUES and G_UNMERGE_VALUES.
Dec 1 2017, 12:19 AM

Nov 29 2017

volkan added inline comments to D39823: GlobalISel: Enable the legalization of G_MERGE_VALUES and G_UNMERGE_VALUES.
Nov 29 2017, 10:49 PM
volkan updated the diff for D39823: GlobalISel: Enable the legalization of G_MERGE_VALUES and G_UNMERGE_VALUES.

Updated based on Daniel's comments.

Nov 29 2017, 10:39 PM

Nov 27 2017

volkan added a comment to D39823: GlobalISel: Enable the legalization of G_MERGE_VALUES and G_UNMERGE_VALUES.

Ping.

Nov 27 2017, 10:02 PM

Nov 15 2017

volkan added a comment to D38200: [GISel]: Process new insts to legalize in the order they were created.

I think this is no longer required, rL318210 fixed this problem.

Nov 15 2017, 3:52 PM

Nov 14 2017

volkan added inline comments to D39823: GlobalISel: Enable the legalization of G_MERGE_VALUES and G_UNMERGE_VALUES.
Nov 14 2017, 4:08 PM
volkan updated the diff for D39823: GlobalISel: Enable the legalization of G_MERGE_VALUES and G_UNMERGE_VALUES.
  • Handled missing cases for AArch64.
  • Rebased.
Nov 14 2017, 4:08 PM
volkan accepted D39267: [GISel]: Change Legalization from top down to bottom up + DCE.

Hi Aditya,

Nov 14 2017, 1:14 PM

Nov 10 2017

volkan updated the diff for D39823: GlobalISel: Enable the legalization of G_MERGE_VALUES and G_UNMERGE_VALUES.

Removed the special case for G_MERGE_VALUES.

Nov 10 2017, 1:09 PM
volkan added inline comments to D39823: GlobalISel: Enable the legalization of G_MERGE_VALUES and G_UNMERGE_VALUES.
Nov 10 2017, 12:58 PM

Nov 9 2017

volkan updated the diff for D39823: GlobalISel: Enable the legalization of G_MERGE_VALUES and G_UNMERGE_VALUES.

Updated based on Kristof's comments.

Nov 9 2017, 4:08 PM
volkan added inline comments to D39823: GlobalISel: Enable the legalization of G_MERGE_VALUES and G_UNMERGE_VALUES.
Nov 9 2017, 3:23 PM

Nov 8 2017

volkan created D39823: GlobalISel: Enable the legalization of G_MERGE_VALUES and G_UNMERGE_VALUES.
Nov 8 2017, 4:26 PM

Aug 30 2017

volkan accepted D36880: [GSel]: Add a cleanup combiner to cleanup legalization artifacts.

Thank you Aditya, LGTM!

Aug 30 2017, 9:57 AM
volkan added inline comments to D36880: [GSel]: Add a cleanup combiner to cleanup legalization artifacts.
Aug 30 2017, 5:16 AM

Aug 29 2017

volkan added a comment to D36880: [GSel]: Add a cleanup combiner to cleanup legalization artifacts.

Thank you Aditya. I added a few more inline comments.

Aug 29 2017, 10:42 AM

Aug 25 2017

volkan added inline comments to D36880: [GSel]: Add a cleanup combiner to cleanup legalization artifacts.
Aug 25 2017, 3:23 AM

Jul 27 2017

volkan added a comment to D35737: [GSel]: Support Widening G_ICMP's destination operand..

LGTM except:

  • Missing test case
  • The title needs be updated
Jul 27 2017, 4:34 AM
volkan added a reviewer for D35737: [GSel]: Support Widening G_ICMP's destination operand.: volkan.
Jul 27 2017, 4:33 AM

Jul 26 2017

volkan added a comment to D35737: [GSel]: Support Widening G_ICMP's destination operand..

Could you add a test case or an explanation if it's not possible to add a test case?

Jul 26 2017, 3:50 AM

Jun 5 2017

volkan committed rL304743: [GlobalISel] IRTranslator: Add MachineMemOperand to target memory intrinsics.
[GlobalISel] IRTranslator: Add MachineMemOperand to target memory intrinsics
Jun 5 2017, 3:17 PM
volkan closed D33724: [GlobalISel] IRTranslator: Add MachineMemOperand to target memory intrinsics by committing rL304743: [GlobalISel] IRTranslator: Add MachineMemOperand to target memory intrinsics.
Jun 5 2017, 3:17 PM
volkan closed D33724: [GlobalISel] IRTranslator: Add MachineMemOperand to target memory intrinsics.
Jun 5 2017, 3:17 PM

May 31 2017

volkan created D33724: [GlobalISel] IRTranslator: Add MachineMemOperand to target memory intrinsics.
May 31 2017, 7:39 AM

May 19 2017

volkan committed rL303412: [GlobalISel] IRTranslator: Translate ConstantStruct.
[GlobalISel] IRTranslator: Translate ConstantStruct
May 19 2017, 3:00 AM
volkan closed D33317: [GlobalISel] IRTranslator: Translate ConstantStruct.
May 19 2017, 3:00 AM
volkan updated the diff for D33317: [GlobalISel] IRTranslator: Translate ConstantStruct.
  • Use SmallVector instead of std::vector.
May 19 2017, 2:58 AM

May 18 2017

volkan created D33317: [GlobalISel] IRTranslator: Translate ConstantStruct.
May 18 2017, 6:00 AM
volkan abandoned D33315: [GlobalISel] IRTranslator: Translate ConstantStruct.

This patch didn’t get sent to the mailing list because I forgot to add llvm-commits in the first place. I’m going to close and re-create this revision.

May 18 2017, 5:57 AM
volkan updated subscribers of D33315: [GlobalISel] IRTranslator: Translate ConstantStruct.
May 18 2017, 5:23 AM
volkan created D33315: [GlobalISel] IRTranslator: Translate ConstantStruct.
May 18 2017, 5:23 AM

Apr 11 2017

volkan committed rL299929: [GlobalISel] LegalizerInfo: Enable legalization of non-power-of-2 types.
[GlobalISel] LegalizerInfo: Enable legalization of non-power-of-2 types
Apr 11 2017, 3:22 AM
volkan closed D31711: [GlobalISel] LegalizerInfo: Enable legalization of non-power-of-2 types.
Apr 11 2017, 3:22 AM
volkan updated the diff for D31711: [GlobalISel] LegalizerInfo: Enable legalization of non-power-of-2 types.
  • Updated the comment.
Apr 11 2017, 3:21 AM
volkan added inline comments to D31711: [GlobalISel] LegalizerInfo: Enable legalization of non-power-of-2 types.
Apr 11 2017, 12:04 AM

Apr 7 2017

volkan requested review of D31711: [GlobalISel] LegalizerInfo: Enable legalization of non-power-of-2 types.
Apr 7 2017, 11:11 AM
volkan updated the diff for D31711: [GlobalISel] LegalizerInfo: Enable legalization of non-power-of-2 types.
  • Updated the patch per my previous comment.
  • Added a vector fallback test.
Apr 7 2017, 10:55 AM
volkan added inline comments to D31711: [GlobalISel] LegalizerInfo: Enable legalization of non-power-of-2 types.
Apr 7 2017, 7:14 AM

Apr 5 2017

volkan updated the diff for D31711: [GlobalISel] LegalizerInfo: Enable legalization of non-power-of-2 types.

Added a test.

Apr 5 2017, 9:02 AM
volkan retitled D31711: [GlobalISel] LegalizerInfo: Enable legalization of non-power-of-2 types from [GlobalISel] LegalizerInfo: Check if the vector element type is power of 2 to [GlobalISel] LegalizerInfo: Enable legalization of vector types with non-power-of-2 number of elements.
Apr 5 2017, 8:57 AM
volkan added inline comments to D31711: [GlobalISel] LegalizerInfo: Enable legalization of non-power-of-2 types.
Apr 5 2017, 8:56 AM
volkan created D31711: [GlobalISel] LegalizerInfo: Enable legalization of non-power-of-2 types.
Apr 5 2017, 8:00 AM

Mar 21 2017

volkan committed rL298367: [GlobalISel] Fix shufflevector tests.
[GlobalISel] Fix shufflevector tests
Mar 21 2017, 6:25 AM
volkan committed rL298358: [GlobalISel] Move isTriviallyDead to Utils. NFC..
[GlobalISel] Move isTriviallyDead to Utils. NFC.
Mar 21 2017, 3:59 AM
volkan committed rL298347: [GlobalISel] Translate shufflevector.
[GlobalISel] Translate shufflevector
Mar 21 2017, 1:56 AM
volkan closed D30962: [GlobalISel] Translate shufflevector.
Mar 21 2017, 1:56 AM
volkan added a comment to D30962: [GlobalISel] Translate shufflevector.
In D30962#704916, @ab wrote:

We don't need to do this now, but should we encode the mask in the G_SHUFFLE_VECTOR itself? Either as multiple Imm MOs, or a single new 'VectorMask' operand of some sort?

I think we should probably stick with a single operand to represent the mask since some targets can use vector registers to specify the shuffle mask (e.g. VSHF.df on Mips), but I do agree that a single operand containing a whole constant mask would be nicer to match than the current G_MERGE_VALUES of G_CONSTANTS since there's lots of ways of writing the same constant right now. For example:

Mar 21 2017, 12:52 AM

Mar 17 2017

volkan updated the diff for D30962: [GlobalISel] Translate shufflevector.

Added more tests.

Mar 17 2017, 1:32 PM

Mar 14 2017

volkan created D30962: [GlobalISel] Translate shufflevector.
Mar 14 2017, 5:17 PM