Page MenuHomePhabricator

volkan (Volkan Keles)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 30 2015, 12:54 PM (181 w, 13 h)

Recent Activity

Fri, Dec 14

volkan committed rL349200: [GlobalISel] LegalizerHelper: Implement fewerElementsVector for G_LOAD/G_STORE.
[GlobalISel] LegalizerHelper: Implement fewerElementsVector for G_LOAD/G_STORE
Fri, Dec 14, 2:14 PM
volkan closed D53728: [GlobalISel] LegalizerHelper: Implement fewerElementsVector for G_LOAD/G_STORE.
Fri, Dec 14, 2:14 PM
volkan updated the diff for D53728: [GlobalISel] LegalizerHelper: Implement fewerElementsVector for G_LOAD/G_STORE.
  • Replaced buildMerge with buildBuildVector/buildConcatVectors.
  • Updated the test to avoid generating G_CONCAT_VECTORS as it's not legal for v4s32/v2s64.
Fri, Dec 14, 2:05 PM

Mon, Dec 10

volkan added inline comments to D55294: [GISel]: Refactor MachineIRBuilder to allow passing additional parameters to build Instrs.
Mon, Dec 10, 12:48 PM
volkan accepted D53629: [GlobalISel] Restrict G_MERGE_VALUES capability and replace with new opcodes.

Thanks Amara, LGTM.

Mon, Dec 10, 9:48 AM

Wed, Dec 5

volkan accepted D54980: [NFC][GISel]: Provide an standard interface to observe changes across GISel passes.

LGTM.

Wed, Dec 5, 11:31 AM

Thu, Nov 29

volkan added inline comments to D53629: [GlobalISel] Restrict G_MERGE_VALUES capability and replace with new opcodes.
Thu, Nov 29, 3:02 PM
volkan committed rL347893: [GlobalISel] LegalizationArtifactCombiner: Combine aext([asz]ext x) -> [asz]ext….
[GlobalISel] LegalizationArtifactCombiner: Combine aext([asz]ext x) -> [asz]ext…
Thu, Nov 29, 10:22 AM
volkan closed D54174: [GlobalISel] LegalizationArtifactCombiner: Combine aext([asz]ext x) -> [asz]ext x.
Thu, Nov 29, 10:22 AM

Tue, Nov 27

volkan added a comment to D53629: [GlobalISel] Restrict G_MERGE_VALUES capability and replace with new opcodes.

Hi Volkan,

We are unable to legalize the test below because of the missing combine.

This sentence jumped at me. Are you saying we have mandatory combines at this point for legalization to work?
Although that wouldn't surprise me, I would like we have a clear list of what they are (if that's not already the case.)

Cheers,
-Quentin

Tue, Nov 27, 9:47 AM

Mon, Nov 26

volkan added inline comments to D53629: [GlobalISel] Restrict G_MERGE_VALUES capability and replace with new opcodes.
Mon, Nov 26, 2:53 PM
volkan added a comment to D54174: [GlobalISel] LegalizationArtifactCombiner: Combine aext([asz]ext x) -> [asz]ext x.

So these extends are created by the legalizer, correct? If so, it seems ok to me as that's what these artifact combines were intended for.

Mon, Nov 26, 9:00 AM
volkan added a reviewer for D54518: [GlobalISel] Fix insertion of stack-protector epilogue: aemerson.
Mon, Nov 26, 8:58 AM

Nov 13 2018

volkan added a comment to D54174: [GlobalISel] LegalizationArtifactCombiner: Combine aext([asz]ext x) -> [asz]ext x.

What's the reason for not putting this in a post-legalize combiner? It seems to me that we'll have to implement this in the Legalizer and the Combiner

Nov 13 2018, 2:29 AM

Nov 7 2018

volkan added a comment to D53629: [GlobalISel] Restrict G_MERGE_VALUES capability and replace with new opcodes.

Hi Amara,

Nov 7 2018, 10:44 AM

Nov 6 2018

volkan added inline comments to D53629: [GlobalISel] Restrict G_MERGE_VALUES capability and replace with new opcodes.
Nov 6 2018, 3:59 PM
volkan created D54174: [GlobalISel] LegalizationArtifactCombiner: Combine aext([asz]ext x) -> [asz]ext x.
Nov 6 2018, 11:55 AM
volkan committed rL346253: [AArch64][GlobalISel] Simplify and autogenerate the legalizer tests.
[AArch64][GlobalISel] Simplify and autogenerate the legalizer tests
Nov 6 2018, 11:01 AM
volkan committed rL346251: Reland r346166: [GlobalISel] Refactor the artifact combiner a bit by using….
Reland r346166: [GlobalISel] Refactor the artifact combiner a bit by using…
Nov 6 2018, 10:35 AM

Nov 5 2018

volkan committed rL346175: Revert "[GlobalISel] Refactor the artifact combiner a bit by using….
Revert "[GlobalISel] Refactor the artifact combiner a bit by using…
Nov 5 2018, 2:27 PM
volkan committed rL346166: [GlobalISel] Refactor the artifact combiner a bit by using MIPatternMatch.
[GlobalISel] Refactor the artifact combiner a bit by using MIPatternMatch
Nov 5 2018, 12:53 PM
volkan closed D54116: [GlobalISel] Refactor the artifact combiner a bit by using MIPatternMatch.
Nov 5 2018, 12:53 PM
volkan added a comment to D54116: [GlobalISel] Refactor the artifact combiner a bit by using MIPatternMatch.

Thanks. With this patch, are there any more users of getOpcodeDef? If not, we should probably remove that helper.

Nov 5 2018, 11:52 AM
volkan added inline comments to D54116: [GlobalISel] Refactor the artifact combiner a bit by using MIPatternMatch.
Nov 5 2018, 11:46 AM
volkan updated the diff for D54116: [GlobalISel] Refactor the artifact combiner a bit by using MIPatternMatch.

Added the missing legality check.

Nov 5 2018, 11:45 AM
volkan created D54116: [GlobalISel] Refactor the artifact combiner a bit by using MIPatternMatch.
Nov 5 2018, 11:36 AM

Nov 2 2018

volkan added a comment to D53594: [GlobalISel] Introduce G_BUILD_VECTOR and G_CONCAT_VECTOR opcodes.

Thanks @aditya_nandakumar for the context.

I understand where you're coming from.

What I meant is that I would rather have one opcode of build_vector and one for build_vector with trunc. The rationale is that it makes it clear what you want to achieve and it makes for a stronger type verifier.

+1 for having explicit opcodes for truncation.

Nov 2 2018, 11:00 AM

Nov 1 2018

volkan added a reviewer for D53728: [GlobalISel] LegalizerHelper: Implement fewerElementsVector for G_LOAD/G_STORE: aditya_nandakumar.
Nov 1 2018, 1:59 PM
volkan updated the diff for D53728: [GlobalISel] LegalizerHelper: Implement fewerElementsVector for G_LOAD/G_STORE.

Rebased.

Nov 1 2018, 12:48 PM
volkan committed rL345875: [GlobalISel] Fix a bug in LegalizeRuleSet::clampMaxNumElements.
[GlobalISel] Fix a bug in LegalizeRuleSet::clampMaxNumElements
Nov 1 2018, 12:06 PM
volkan closed D53734: [GlobalISel] Fix a bug in LegalizeRuleSet::clampMaxNumElements.
Nov 1 2018, 12:05 PM
volkan added inline comments to D53734: [GlobalISel] Fix a bug in LegalizeRuleSet::clampMaxNumElements.
Nov 1 2018, 10:45 AM

Oct 31 2018

volkan committed rL345751: [InstCombine] Combine nested min/max intrinsics with constants.
[InstCombine] Combine nested min/max intrinsics with constants
Oct 31 2018, 10:53 AM
volkan closed D53774: [InstCombine] Combine nested min/max intrinsics with constants.
Oct 31 2018, 10:53 AM
volkan added a comment to D53774: [InstCombine] Combine nested min/max intrinsics with constants.

Is it worth adjusting/adding some tests with NaN constants?

Oct 31 2018, 10:03 AM

Oct 30 2018

volkan added inline comments to D53774: [InstCombine] Combine nested min/max intrinsics with constants.
Oct 30 2018, 11:27 AM
volkan added a comment to D53774: [InstCombine] Combine nested min/max intrinsics with constants.

Side note: do you know if the reassociate pass handles these? I imagine we're going to miss the optimization in instcombine if the constants are separated in a longer chain of min/max ops.

Oct 30 2018, 11:17 AM
volkan updated the diff for D53774: [InstCombine] Combine nested min/max intrinsics with constants.
  • Updated the tests.
  • Added missing copyIRFlags call.
Oct 30 2018, 11:16 AM
volkan committed rL345616: [InstCombine] Add preliminary tests for nested min/max combines. NFC.
[InstCombine] Add preliminary tests for nested min/max combines. NFC
Oct 30 2018, 10:53 AM
volkan closed D53875: [InstCombine] Add preliminary tests for nested min/max combines. NFC.
Oct 30 2018, 10:53 AM
volkan created D53875: [InstCombine] Add preliminary tests for nested min/max combines. NFC.
Oct 30 2018, 10:40 AM

Oct 26 2018

volkan created D53774: [InstCombine] Combine nested min/max intrinsics with constants.
Oct 26 2018, 12:07 PM

Oct 25 2018

volkan created D53734: [GlobalISel] Fix a bug in LegalizeRuleSet::clampMaxNumElements.
Oct 25 2018, 2:55 PM
volkan created D53728: [GlobalISel] LegalizerHelper: Implement fewerElementsVector for G_LOAD/G_STORE.
Oct 25 2018, 1:43 PM
volkan committed rL345307: [AArch64][GlobalISel] Simplify a legalizer test. NFC..
[AArch64][GlobalISel] Simplify a legalizer test. NFC.
Oct 25 2018, 1:04 PM
volkan committed rL345292: [GlobalISel] LegalizerHelper: Fix the incorrect alignment when splitting….
[GlobalISel] LegalizerHelper: Fix the incorrect alignment when splitting…
Oct 25 2018, 10:54 AM
volkan closed D53664: [GlobalISel] LegalizerHelper: Fix the incorrect alignment when splitting loads/stores in narrowScalar.
Oct 25 2018, 10:54 AM
volkan committed rL345288: [GISel] LegalizerInfo: Rename MemDesc::Size to SizeInBits to make the value….
[GISel] LegalizerInfo: Rename MemDesc::Size to SizeInBits to make the value…
Oct 25 2018, 10:39 AM
volkan committed rL345282: [AArch64][GlobalISel] Fix the LegalityPredicate for lowerIf for G_LOAD/G_STORE.
[AArch64][GlobalISel] Fix the LegalityPredicate for lowerIf for G_LOAD/G_STORE
Oct 25 2018, 10:25 AM
volkan closed D53679: [AArch64][GlobalISel] Fix the LegalityPredicate for lowerIf for G_LOAD/G_STORE.
Oct 25 2018, 10:25 AM
volkan added a comment to D53679: [AArch64][GlobalISel] Fix the LegalityPredicate for lowerIf for G_LOAD/G_STORE.

LGTM with the test nit

Would you be willing to rename that Size member to SizeInBits to make the value clearer?

Oct 25 2018, 10:21 AM
volkan updated the diff for D53679: [AArch64][GlobalISel] Fix the LegalityPredicate for lowerIf for G_LOAD/G_STORE.

Updated the test to include the full instruction.

Oct 25 2018, 10:21 AM

Oct 24 2018

volkan created D53679: [AArch64][GlobalISel] Fix the LegalityPredicate for lowerIf for G_LOAD/G_STORE.
Oct 24 2018, 3:41 PM
volkan updated the diff for D53664: [GlobalISel] LegalizerHelper: Fix the incorrect alignment when splitting loads/stores in narrowScalar.
  • Simplified the test.
  • Replaced GreatestCommonDivisor64 with MinAlign to make sure the new alignment is power of 2.
Oct 24 2018, 1:27 PM
volkan created D53664: [GlobalISel] LegalizerHelper: Fix the incorrect alignment when splitting loads/stores in narrowScalar.
Oct 24 2018, 12:07 PM
volkan accepted D53592: [GlobalISel] Use the target preferred type for G_EXTRACT_VECTOR_ELT index.

LGTM, thanks Amara.

Oct 24 2018, 11:01 AM
volkan added a comment to D53594: [GlobalISel] Introduce G_BUILD_VECTOR and G_CONCAT_VECTOR opcodes.

Are two different opcodes for this really needed? Why not a single opcode with uniformly typed operands, either scalar or vector, which concatenates the operands as an appropriately sized vector? I know there's precedent for the separation elsewhere in LLVM, but it has always seemed redundant to me personally. The code for handling the BUILD vs. CONCAT cases tends to be very similar.

Oct 24 2018, 10:52 AM

Oct 10 2018

volkan committed rL344163: [GlobalISel] Fix the artifact combiner to fold G_IMPLICIT_DEF properly.
[GlobalISel] Fix the artifact combiner to fold G_IMPLICIT_DEF properly
Oct 10 2018, 11:03 AM
volkan closed D52996: [GlobalISel] Fix the artifact combiner to fold G_IMPLICIT_DEF properly.
Oct 10 2018, 11:03 AM

Oct 8 2018

volkan created D52996: [GlobalISel] Fix the artifact combiner to fold G_IMPLICIT_DEF properly.
Oct 8 2018, 12:46 PM

Aug 29 2018

volkan added a comment to D51362: [GlobalISel][IRTranslator] Canonicalize G_ICMP to have constant operands last.

I had a similar discussion with Quentin a while ago and it seemed there are two solutions:

  • Add a pass to canonicalize MIR
  • Extend MIRBuilder to canonicalize instructions
Aug 29 2018, 3:40 PM

Aug 28 2018

volkan accepted D51384: [GISel]: Add Legalization support for widening UADDO/USUBO Opcodes.

LGTM

Aug 28 2018, 3:01 PM

Jul 25 2018

volkan accepted D49428: [LSV] Look through selects for consecutive addresses.

LGTM

Jul 25 2018, 2:26 PM
volkan added a comment to D49428: [LSV] Look through selects for consecutive addresses.

Hi Roman,

Jul 25 2018, 1:17 PM

Jun 22 2018

volkan accepted D48469: [GISel]: Add opcode to translate addrspacecast.

LGTM.

Jun 22 2018, 12:42 PM

Mar 12 2018

volkan committed rL327340: BlockExtractor: Don’t delete functions directly.
BlockExtractor: Don’t delete functions directly
Mar 12 2018, 3:31 PM

Mar 8 2018

volkan accepted D44128: [GISel]: Add helpers for easy building G_FCONSTANT along with matchers.

LGTM. Thank you Aditya.

Mar 8 2018, 2:45 PM
volkan added inline comments to D44128: [GISel]: Add helpers for easy building G_FCONSTANT along with matchers.
Mar 8 2018, 12:05 PM

Mar 5 2018

volkan committed rL326749: GlobalISel: IRTranslate llvm.fabs.* intrinsic.
GlobalISel: IRTranslate llvm.fabs.* intrinsic
Mar 5 2018, 2:34 PM
volkan closed D43864: GlobalISel: IRTranslate llvm.fabs.* intrinsic.
Mar 5 2018, 2:34 PM
volkan updated the diff for D43864: GlobalISel: IRTranslate llvm.fabs.* intrinsic.

Added pattern matcher support for G_FABS.

Mar 5 2018, 11:55 AM

Mar 2 2018

volkan added a comment to D43864: GlobalISel: IRTranslate llvm.fabs.* intrinsic.

This looks mostly fine. Could you also add pattern matchers for fabs when you get the greenlight from others?

Mar 2 2018, 5:14 AM

Feb 28 2018

volkan created D43864: GlobalISel: IRTranslate llvm.fabs.* intrinsic.
Feb 28 2018, 3:35 AM

Feb 14 2018

volkan committed rL325162: GlobalISel: Add templated functions and pattern matcher support for some more….
GlobalISel: Add templated functions and pattern matcher support for some more…
Feb 14 2018, 12:00 PM
volkan closed D43309: GlobalISel: Add templated functions and pattern matcher support for some more opcodes.
Feb 14 2018, 12:00 PM
volkan updated the diff for D43309: GlobalISel: Add templated functions and pattern matcher support for some more opcodes.

Added a check for the input operand of the bitcast instruction.

Feb 14 2018, 11:48 AM
volkan created D43309: GlobalISel: Add templated functions and pattern matcher support for some more opcodes.
Feb 14 2018, 11:36 AM

Feb 12 2018

volkan committed rL324971: GlobalISel: IRTranslate llvm.fmuladd.* intrinsic.
GlobalISel: IRTranslate llvm.fmuladd.* intrinsic
Feb 12 2018, 4:50 PM
volkan closed D43090: GlobalISel: IRTranslate llvm.fmuladd.* intrinsic.
Feb 12 2018, 4:49 PM
volkan updated the diff for D43090: GlobalISel: IRTranslate llvm.fmuladd.* intrinsic.

Added a TODO about moving a part of the translation to the combiner.

Feb 12 2018, 4:48 PM
volkan added inline comments to D43090: GlobalISel: IRTranslate llvm.fmuladd.* intrinsic.
Feb 12 2018, 9:40 AM

Feb 9 2018

volkan added inline comments to D43090: GlobalISel: IRTranslate llvm.fmuladd.* intrinsic.
Feb 9 2018, 12:51 PM

Feb 8 2018

volkan created D43090: GlobalISel: IRTranslate llvm.fmuladd.* intrinsic.
Feb 8 2018, 1:50 PM

Feb 6 2018

volkan committed rL324442: GlobalISel: Always check operand types when executing match table.
GlobalISel: Always check operand types when executing match table
Feb 6 2018, 6:47 PM
volkan closed D42984: GlobalISel: Always check operand types when executing match table.
Feb 6 2018, 6:47 PM
volkan created D42984: GlobalISel: Always check operand types when executing match table.
Feb 6 2018, 2:11 PM

Jan 24 2018

volkan committed rL323391: [GlobalISel][TableGen] Fix the statistics for emitted patters.
[GlobalISel][TableGen] Fix the statistics for emitted patters
Jan 24 2018, 4:20 PM

Jan 23 2018

volkan committed rL323274: Add missing include to fix the failure caused by r323266.
Add missing include to fix the failure caused by r323266
Jan 23 2018, 2:57 PM
volkan committed rL323271: BlockExtractor: Remove unused variable. NFC..
BlockExtractor: Remove unused variable. NFC.
Jan 23 2018, 2:27 PM
volkan committed rL323266: [llvm-extract] Support extracting basic blocks.
[llvm-extract] Support extracting basic blocks
Jan 23 2018, 1:53 PM
volkan closed D41638: [llvm-extract] Support extracting basic blocks.
Jan 23 2018, 1:53 PM
volkan added inline comments to D41638: [llvm-extract] Support extracting basic blocks.
Jan 23 2018, 12:26 PM
volkan committed rL323248: Add a utility to reduce GlobalISel tests.
Add a utility to reduce GlobalISel tests
Jan 23 2018, 11:49 AM
volkan closed D41876: Add a utility to reduce GlobalISel tests.
Jan 23 2018, 11:49 AM
volkan updated the diff for D41638: [llvm-extract] Support extracting basic blocks.

Updated based on the feedback.

Jan 23 2018, 11:36 AM
volkan added inline comments to D41638: [llvm-extract] Support extracting basic blocks.
Jan 23 2018, 11:35 AM

Jan 17 2018

volkan committed rL322800: Fix the failure caused by r322773.
Fix the failure caused by r322773
Jan 17 2018, 5:12 PM
volkan committed rL322773: Add a TargetOption to enable/disable GlobalISel.
Add a TargetOption to enable/disable GlobalISel
Jan 17 2018, 2:38 PM
volkan closed D42137: Add a TargetOption to enable/disable GlobalISel.
Jan 17 2018, 2:38 PM

Jan 16 2018

volkan created D42137: Add a TargetOption to enable/disable GlobalISel.
Jan 16 2018, 3:08 PM