This is an archive of the discontinued LLVM Phabricator instance.

Differential D73653

[MLIR] Fixes for shared library dependencies.
ClosedPublic

Authored by stephenneuendorffer on Jan 29 2020, 11:37 AM.

Details

Reviewers
mravishankar
antiagainst
nicolasvasilache
vchuravy
inouehrs
mehdi_amini
jdoerfert
Commits
rGd7cbef2714c9: [MLIR] Fixes for shared library dependencies.
Summary

This patch is a step towards enabling BUILD_SHARED_LIBS=on, which
builds most libraries as DLLs instead of statically linked libraries.
The main effect of this is that incremental build times are greatly
reduced, since usually only one library need be relinked in response
to isolated code changes.

The bulk of this patch is fixing incorrect usage of cmake, where library
dependencies are listed under add_dependencies rather than under
target_link_libraries or under the LINK_LIBS tag. Correct usage should be
like this:

add_dependencies(MLIRfoo MLIRfooIncGen)
target_link_libraries(MLIRfoo MLIRlib1 MLIRlib2)

A separate issue is that in cmake, dependencies between static libraries
are automatically included in dependencies. In the above example, if MLIBlib1
depends on MLIRlib2, then it is sufficient to have only MLIRlib1 in the
target_link_libraries. When compiling with shared libraries, it is necessary
to have both MLIRlib1 and MLIRlib2 specified if MLIRfoo uses symbols from both.

Diff Detail

Event Timeline

stephenneuendorffer created this revision.Jan 29 2020, 11:37 AM
Herald added a reviewer: mravishankar. · View Herald TranscriptJan 29 2020, 11:37 AM
Herald added a reviewer: antiagainst. · View Herald Transcript
Herald added a reviewer: nicolasvasilache. · View Herald Transcript
Herald added a reviewer: nicolasvasilache. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: llvm-commits, liufengdb, aartbik and 13 others. · View Herald Transcript
stephenneuendorffer added a child revision: D73654: [MLIR] break cyclic dependency between VectorOps and Analysis.Jan 29 2020, 11:37 AM
stephenneuendorffer added reviewers: vchuravy, inouehrs.Jan 29 2020, 11:43 AM
merge_guards_bot added a subscriber: merge_guards_bot.Jan 29 2020, 11:59 AM

Unit tests: unknown.

clang-tidy: pass.

clang-format: pass.

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt

Pre-merge checks is in beta. Report issue. Please join beta or enable it for your project.

Harbormaster failed remote builds in B45279: Diff 241239!Jan 29 2020, 12:07 PM
mehdi_amini added a comment.Jan 29 2020, 9:49 PM

A separate issue is that in cmake, dependencies between static libraries
are automatically included in dependencies. In the above example, if MLIBlib1
depends on MLIRlib2, then it is sufficient to have only MLIRlib1 in the
target_link_libraries. When compiling with shared libraries, it is necessary
to have both MLIRlib1 and MLIRlib2 specified.

I believe this is only an issue if the target is directly using symbols from MLIRlib2 though.
If it only needs symbols from MLIRLib1 then this shouldn't be an issue right?

mehdi_amini accepted this revision.Jan 29 2020, 9:53 PM
mehdi_amini added inline comments.
mlir/lib/Dialect/FxpMathOps/CMakeLists.txt
9

It seems we've been using target_link_libraries elsewhere but they are the same, can we align on one form for consistency?

This revision is now accepted and ready to land.Jan 29 2020, 9:53 PM
nicolasvasilache accepted this revision.Feb 1 2020, 10:14 AM

Thank you Stephen!

Herald added a subscriber: Joonsoo. · View Herald TranscriptFeb 1 2020, 10:14 AM
stephenneuendorffer added a comment.Feb 3 2020, 4:46 PM
In D73653#1848667, @mehdi_amini wrote:

A separate issue is that in cmake, dependencies between static libraries
are automatically included in dependencies. In the above example, if MLIBlib1
depends on MLIRlib2, then it is sufficient to have only MLIRlib1 in the
target_link_libraries. When compiling with shared libraries, it is necessary
to have both MLIRlib1 and MLIRlib2 specified.

I believe this is only an issue if the target is directly using symbols from MLIRlib2 though.
If it only needs symbols from MLIRLib1 then this shouldn't be an issue right?

Yes, I agree. I've edited the comment to be clearer in this regard.

stephenneuendorffer updated this revision to Diff 242260.Feb 3 2020, 10:13 PM
stephenneuendorffer edited the summary of this revision. (Show Details)
Herald added a reviewer: jdoerfert. · View Herald TranscriptFeb 3 2020, 10:13 PM
merge_guards_bot added a comment.Feb 3 2020, 10:18 PM

Unit tests: unknown.

clang-tidy: pass.

clang-format: pass.

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt

Pre-merge checks is in beta. Report issue. Please join beta or enable it for your project.

Harbormaster failed remote builds in B45659: Diff 242260!Feb 3 2020, 10:19 PM
stephenneuendorffer marked an inline comment as done.Feb 3 2020, 10:31 PM
stephenneuendorffer added inline comments.
mlir/lib/Dialect/FxpMathOps/CMakeLists.txt
9

I fixed these to use target_link_libraries instead of LINK_LIBS

merge_guards_bot added a comment.Feb 3 2020, 10:52 PM

Unit tests: unknown.

clang-tidy: pass.

clang-format: pass.

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt

Pre-merge checks is in beta. Report issue. Please join beta or enable it for your project.

Closed by commit rGd7cbef2714c9: [MLIR] Fixes for shared library dependencies. (authored by stephenneuendorffer). · Explain WhyFeb 4 2020, 8:58 AM
This revision was automatically updated to reflect the committed changes.
kparzysz added a subscriber: kparzysz.Feb 5 2020, 6:03 AM

This commit causes errors when linking mlir-opt (I'm not using shared libraries):

[...]
/w/bld/org/lib/libMLIRGPUtoCUDATransforms.a(ConvertKernelFuncToCubin.cpp.o): In function `(anonymous namespace)::GpuKernelToCubinPass::runOnOperation()':
ConvertKernelFuncToCubin.cpp:(.text._ZN12_GLOBAL__N_120GpuKernelToCubinPass14runOnOperationEv+0x44): undefined reference to `LLVMInitializeNVPTXTarget'
ConvertKernelFuncToCubin.cpp:(.text._ZN12_GLOBAL__N_120GpuKernelToCubinPass14runOnOperationEv+0x49): undefined reference to `LLVMInitializeNVPTXTargetInfo'
ConvertKernelFuncToCubin.cpp:(.text._ZN12_GLOBAL__N_120GpuKernelToCubinPass14runOnOperationEv+0x4e): undefined reference to `LLVMInitializeNVPTXTargetMC'
ConvertKernelFuncToCubin.cpp:(.text._ZN12_GLOBAL__N_120GpuKernelToCubinPass14runOnOperationEv+0x53): undefined reference to `LLVMInitializeNVPTXAsmPrinter'
ConvertKernelFuncToCubin.cpp:(.text._ZN12_GLOBAL__N_120GpuKernelToCubinPass14runOnOperationEv+0x60): undefined reference to `mlir::translateModuleToNVVMIR(mlir::Operation*)'
ConvertKernelFuncToCubin.cpp:(.text._ZN12_GLOBAL__N_120GpuKernelToCubinPass14runOnOperationEv+0x2d0): undefined reference to `llvm::MCTargetOptions::MCTargetOptions()'
clang-9: error: linker command failed with exit code 1 (use -v to see invocation)
tools/mlir/tools/mlir-opt/CMakeFiles/mlir-opt.dir/build.make:114: recipe for target 'bin/mlir-opt' failed
make[2]: *** [bin/mlir-opt] Error 1
make[2]: Target 'tools/mlir/tools/mlir-opt/CMakeFiles/mlir-opt.dir/build' not remade because of errors.
[...]
herhut added a comment.Feb 5 2020, 6:57 AM

https://reviews.llvm.org/D74041 should fix the link errors.

stephenneuendorffer mentioned this in D72585: [MLIR] Fixes for BUILD_SHARED_LIBS=on.Feb 5 2020, 11:32 AM

Revision Contents

PathSize
mlir/
cmake/
modules/
1 line
lib/
Analysis/
3 lines
Conversion/
AffineToStandard/
3 lines
GPUToNVVM/
2 lines
GPUToROCDL/
1 line
LinalgToLLVM/
6 lines
LinalgToSPIRV/
1 line
LoopsToGPU/
1 line
VectorToLLVM/
2 lines
VectorToLoops/
1 line
Dialect/
FxpMathOps/
8 lines
GPU/
2 lines
LLVMIR/
2 lines
Linalg/
IR/
1 line
LoopOps/
2 lines
OpenMP/
1 line
QuantOps/
8 lines
SPIRV/
Serialization/
3 lines
VectorOps/
2 lines
EDSC/
24 lines
ExecutionEngine/
8 lines
Quantizer/
21 lines
Support/
3 lines
test/
Dialect/
SPIRV/
2 lines
lib/
IR/
2 lines
TestDialect/
6 lines
Transforms/
5 lines
tools/
mlir-opt/
18 lines

Diff 242260

mlir/cmake/modules/AddMLIR.cmake

function(mlir_tablegen ofn) function(mlir_tablegen ofn)
tablegen(MLIR ${ARGV} "-I${MLIR_MAIN_SRC_DIR}" "-I${MLIR_INCLUDE_DIR}") tablegen(MLIR ${ARGV} "-I${MLIR_MAIN_SRC_DIR}" "-I${MLIR_INCLUDE_DIR}")
set(TABLEGEN_OUTPUT ${TABLEGEN_OUTPUT} ${CMAKE_CURRENT_BINARY_DIR}/${ofn} set(TABLEGEN_OUTPUT ${TABLEGEN_OUTPUT} ${CMAKE_CURRENT_BINARY_DIR}/${ofn}
PARENT_SCOPE) PARENT_SCOPE)
endfunction() endfunction()
# TODO: This is to handle the current static registration, but should be # TODO: This is to handle the current static registration, but should be
# factored out a bit. # factored out a bit.
function(whole_archive_link target) function(whole_archive_link target)
add_dependencies(${target} ${ARGN})
if("${CMAKE_SYSTEM_NAME}" STREQUAL "Darwin") if("${CMAKE_SYSTEM_NAME}" STREQUAL "Darwin")
set(link_flags "-L${CMAKE_BINARY_DIR}/lib ") set(link_flags "-L${CMAKE_BINARY_DIR}/lib ")
FOREACH(LIB ${ARGN}) FOREACH(LIB ${ARGN})
string(CONCAT link_flags ${link_flags} "-Wl,-force_load ${CMAKE_BINARY_DIR}/lib/lib${LIB}.a ") string(CONCAT link_flags ${link_flags} "-Wl,-force_load ${CMAKE_BINARY_DIR}/lib/lib${LIB}.a ")
ENDFOREACH(LIB) ENDFOREACH(LIB)
elseif(MSVC) elseif(MSVC)
FOREACH(LIB ${ARGN}) FOREACH(LIB ${ARGN})
string(CONCAT link_flags ${link_flags} "/WHOLEARCHIVE:${CMAKE_BINARY_DIR}/${CMAKE_CFG_INTDIR}/lib/${LIB}.lib ") string(CONCAT link_flags ${link_flags} "/WHOLEARCHIVE:${CMAKE_BINARY_DIR}/${CMAKE_CFG_INTDIR}/lib/${LIB}.lib ")
Show All 10 Lines

mlir/lib/Analysis/CMakeLists.txt

Show All 17 Linesadd_llvm_library(MLIRAnalysis STATIC
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
${MLIR_MAIN_INCLUDE_DIR}/mlir/Analysis ${MLIR_MAIN_INCLUDE_DIR}/mlir/Analysis
) )
add_dependencies(MLIRAnalysis add_dependencies(MLIRAnalysis
MLIRAffineOps MLIRAffineOps
MLIRCallOpInterfacesIncGen MLIRCallOpInterfacesIncGen
MLIRTypeInferOpInterfaceIncGen MLIRTypeInferOpInterfaceIncGen
MLIRLoopOps MLIRLoopOps
MLIRVectorOps
) )
target_link_libraries(MLIRAnalysis MLIRAffineOps MLIRLoopOps MLIRVectorOps) target_link_libraries(MLIRAnalysis MLIRAffineOps MLIRLoopOps)

mlir/lib/Conversion/AffineToStandard/CMakeLists.txt

Show All 11 Linesadd_dependencies(
MLIRIR MLIRIR
LLVMCore LLVMCore
LLVMSupport LLVMSupport
) )
target_link_libraries( target_link_libraries(
MLIRAffineToStandard MLIRAffineToStandard
MLIRAffineOps MLIRAffineOps
MLIRLoopOps
MLIRPass
MLIRStandardOps MLIRStandardOps
MLIRTransforms
MLIRIR MLIRIR
LLVMCore LLVMCore
LLVMSupport LLVMSupport
) )

mlir/lib/Conversion/GPUToNVVM/CMakeLists.txt

Show All 9 Linesadd_dependencies(MLIRGPUtoNVVMTransforms
MLIRGPUToNVVMIncGen) MLIRGPUToNVVMIncGen)
target_link_libraries(MLIRGPUtoNVVMTransforms target_link_libraries(MLIRGPUtoNVVMTransforms
LLVMSupport LLVMSupport
MLIRGPU MLIRGPU
MLIRLLVMIR MLIRLLVMIR
MLIRNVVMIR MLIRNVVMIR
MLIRPass MLIRPass
MLIRStandardToLLVM
MLIRTransformUtils
) )

mlir/lib/Conversion/GPUToROCDL/CMakeLists.txt

add_llvm_library(MLIRGPUtoROCDLTransforms add_llvm_library(MLIRGPUtoROCDLTransforms
LowerGpuOpsToROCDLOps.cpp LowerGpuOpsToROCDLOps.cpp
) )
target_link_libraries(MLIRGPUtoROCDLTransforms target_link_libraries(MLIRGPUtoROCDLTransforms
LLVMSupport LLVMSupport
MLIRGPU MLIRGPU
MLIRLLVMIR MLIRLLVMIR
MLIRROCDLIR MLIRROCDLIR
MLIRPass MLIRPass
MLIRStandardToLLVM
) )

mlir/lib/Conversion/LinalgToLLVM/CMakeLists.txt

add_llvm_library(MLIRLinalgToLLVM add_llvm_library(MLIRLinalgToLLVM
LinalgToLLVM.cpp LinalgToLLVM.cpp
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
${MLIR_MAIN_INCLUDE_DIR}/mlir/Conversion/LinalgToLLVM ${MLIR_MAIN_INCLUDE_DIR}/mlir/Conversion/LinalgToLLVM
) )
set(LIBS set(LIBS
MLIRAffineToStandard
MLIREDSC
MLIRIR
MLIRLinalgOps MLIRLinalgOps
MLIRLLVMIR MLIRLLVMIR
MLIRLoopToStandard
MLIRStandardToLLVM
MLIRVectorToLLVM
MLIRTransforms MLIRTransforms
LLVMCore LLVMCore
LLVMSupport LLVMSupport
) )
add_dependencies(MLIRLinalgToLLVM ${LIBS}) add_dependencies(MLIRLinalgToLLVM ${LIBS})
target_link_libraries(MLIRLinalgToLLVM ${LIBS}) target_link_libraries(MLIRLinalgToLLVM ${LIBS})

mlir/lib/Conversion/LinalgToSPIRV/CMakeLists.txt

add_llvm_library(MLIRLinalgToSPIRVTransforms add_llvm_library(MLIRLinalgToSPIRVTransforms
LinalgToSPIRV.cpp LinalgToSPIRV.cpp
LinalgToSPIRVPass.cpp LinalgToSPIRVPass.cpp
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
${MLIR_MAIN_INCLUDE_DIR}/mlir/Dialect/SPIRV ${MLIR_MAIN_INCLUDE_DIR}/mlir/Dialect/SPIRV
${MLIR_MAIN_INCLUDE_DIR}/mlir/IR ${MLIR_MAIN_INCLUDE_DIR}/mlir/IR
) )
target_link_libraries(MLIRLinalgToSPIRVTransforms target_link_libraries(MLIRLinalgToSPIRVTransforms
MLIRIR MLIRIR
MLIRLinalgOps MLIRLinalgOps
MLIRLinalgUtils
MLIRPass MLIRPass
MLIRSPIRV MLIRSPIRV
MLIRSupport MLIRSupport
) )

mlir/lib/Conversion/LoopsToGPU/CMakeLists.txt

set(LIBS set(LIBS
MLIRAffineOps MLIRAffineOps
MLIRAffineToStandard
MLIRGPU MLIRGPU
MLIRIR MLIRIR
MLIRLinalgOps MLIRLinalgOps
MLIRPass MLIRPass
MLIRStandardOps MLIRStandardOps
MLIRSupport MLIRSupport
MLIRTransforms MLIRTransforms
LLVMSupport LLVMSupport
Show All 11 Lines

mlir/lib/Conversion/VectorToLLVM/CMakeLists.txt

add_llvm_library(MLIRVectorToLLVM add_llvm_library(MLIRVectorToLLVM
ConvertVectorToLLVM.cpp ConvertVectorToLLVM.cpp
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
${MLIR_MAIN_INCLUDE_DIR}/mlir/Conversion/VectorToLLVM ${MLIR_MAIN_INCLUDE_DIR}/mlir/Conversion/VectorToLLVM
) )
set(LIBS set(LIBS
MLIRLLVMIR MLIRLLVMIR
MLIRStandardToLLVM
MLIRVectorOps
MLIRTransforms MLIRTransforms
LLVMCore LLVMCore
LLVMSupport LLVMSupport
) )
add_dependencies(MLIRVectorToLLVM ${LIBS}) add_dependencies(MLIRVectorToLLVM ${LIBS})
target_link_libraries(MLIRVectorToLLVM ${LIBS}) target_link_libraries(MLIRVectorToLLVM ${LIBS})

mlir/lib/Conversion/VectorToLoops/CMakeLists.txt

add_llvm_library(MLIRVectorToLoops add_llvm_library(MLIRVectorToLoops
ConvertVectorToLoops.cpp ConvertVectorToLoops.cpp
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
${MLIR_MAIN_INCLUDE_DIR}/mlir/Conversion/VectorToLoops ${MLIR_MAIN_INCLUDE_DIR}/mlir/Conversion/VectorToLoops
) )
set(LIBS set(LIBS
MLIREDSC
MLIRLLVMIR MLIRLLVMIR
MLIRTransforms MLIRTransforms
LLVMCore LLVMCore
LLVMSupport LLVMSupport
) )
add_dependencies(MLIRVectorToLoops ${LIBS}) add_dependencies(MLIRVectorToLoops ${LIBS})
target_link_libraries(MLIRVectorToLoops ${LIBS}) target_link_libraries(MLIRVectorToLoops ${LIBS})

mlir/lib/Dialect/FxpMathOps/CMakeLists.txt

add_llvm_library(MLIRFxpMathOps add_llvm_library(MLIRFxpMathOps
IR/FxpMathOps.cpp IR/FxpMathOps.cpp
IR/DialectRegistration.cpp IR/DialectRegistration.cpp
Transforms/LowerUniformRealMath.cpp Transforms/LowerUniformRealMath.cpp
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
${MLIR_MAIN_INCLUDE_DIR}/mlir/Dialect/FxpMathOps ${MLIR_MAIN_INCLUDE_DIR}/mlir/Dialect/FxpMathOps
) )
mehdi_aminiUnsubmitted
Not Done
ReplyInline Actions

It seems we've been using target_link_libraries elsewhere but they are the same, can we align on one form for consistency?

mehdi_amini: It seems we've been using `target_link_libraries` elsewhere but they are the same, can we align…
stephenneuendorfferAuthorUnsubmitted
Done
ReplyInline Actions

I fixed these to use target_link_libraries instead of LINK_LIBS

stephenneuendorffer: I fixed these to use target_link_libraries instead of LINK_LIBS
target_link_libraries(MLIRFxpMathOps
MLIRQuantOps
MLIRIR
MLIRPass
MLIRSupport
MLIRStandardOps
)
add_dependencies(MLIRFxpMathOps add_dependencies(MLIRFxpMathOps
MLIRFxpMathOpsIncGen MLIRFxpMathOpsIncGen
MLIRQuantOps MLIRQuantOps
MLIRIR MLIRIR
MLIRPass MLIRPass
MLIRSupport MLIRSupport
MLIRStandardOps) MLIRStandardOps)

mlir/lib/Dialect/GPU/CMakeLists.txt

Show All 16 Linesadd_dependencies(MLIRGPU
MLIRSupport MLIRSupport
MLIRTransformUtils MLIRTransformUtils
LLVMSupport) LLVMSupport)
target_link_libraries(MLIRGPU target_link_libraries(MLIRGPU
MLIREDSC MLIREDSC
MLIRIR MLIRIR
MLIRLLVMIR MLIRLLVMIR
MLIRLoopOps MLIRLoopOps
MLIRPass
MLIRStandardOps
MLIRSupport MLIRSupport
MLIRTransformUtils MLIRTransformUtils
LLVMSupport) LLVMSupport)

mlir/lib/Dialect/LLVMIR/CMakeLists.txt

add_llvm_library(MLIRLLVMIR add_llvm_library(MLIRLLVMIR
IR/LLVMDialect.cpp IR/LLVMDialect.cpp
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
${MLIR_MAIN_INCLUDE_DIR}/mlir/Dialect/LLVMIR ${MLIR_MAIN_INCLUDE_DIR}/mlir/Dialect/LLVMIR
) )
add_dependencies(MLIRLLVMIR MLIRLLVMOpsIncGen MLIRLLVMConversionsIncGen LLVMAsmParser LLVMCore LLVMSupport) add_dependencies(MLIRLLVMIR MLIRLLVMOpsIncGen MLIRLLVMConversionsIncGen LLVMAsmParser LLVMCore LLVMSupport)
target_link_libraries(MLIRLLVMIR LLVMAsmParser LLVMCore LLVMSupport MLIRIR) target_link_libraries(MLIRLLVMIR LLVMAsmParser LLVMCore LLVMSupport MLIRIR)
add_llvm_library(MLIRNVVMIR add_llvm_library(MLIRNVVMIR
IR/NVVMDialect.cpp IR/NVVMDialect.cpp
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
${MLIR_MAIN_INCLUDE_DIR}/mlir/Dialect/LLVMIR ${MLIR_MAIN_INCLUDE_DIR}/mlir/Dialect/LLVMIR
) )
add_dependencies(MLIRNVVMIR MLIRNVVMOpsIncGen MLIRNVVMConversionsIncGen LLVMAsmParser LLVMCore LLVMSupport) add_dependencies(MLIRNVVMIR MLIRNVVMOpsIncGen MLIRNVVMConversionsIncGen LLVMAsmParser LLVMCore LLVMSupport)
target_link_libraries(MLIRNVVMIR LLVMAsmParser LLVMCore LLVMSupport MLIRIR) target_link_libraries(MLIRNVVMIR LLVMAsmParser MLIRIR MLIRLLVMIR LLVMSupport LLVMCore)
add_llvm_library(MLIRROCDLIR add_llvm_library(MLIRROCDLIR
IR/ROCDLDialect.cpp IR/ROCDLDialect.cpp
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
${MLIR_MAIN_INCLUDE_DIR}/mlir/Dialect/LLVMIR ${MLIR_MAIN_INCLUDE_DIR}/mlir/Dialect/LLVMIR
) )
add_dependencies(MLIRROCDLIR MLIRROCDLOpsIncGen MLIRROCDLConversionsIncGen LLVMAsmParser LLVMCore LLVMSupport) add_dependencies(MLIRROCDLIR MLIRROCDLOpsIncGen MLIRROCDLConversionsIncGen LLVMAsmParser LLVMCore LLVMSupport)
target_link_libraries(MLIRROCDLIR LLVMAsmParser LLVMCore LLVMSupport MLIRIR) target_link_libraries(MLIRROCDLIR LLVMAsmParser LLVMCore LLVMSupport MLIRIR)

mlir/lib/Dialect/Linalg/IR/CMakeLists.txt

set(LIBS set(LIBS
MLIRIR MLIRIR
MLIRStandardOps
) )
add_llvm_library(MLIRLinalgOps add_llvm_library(MLIRLinalgOps
LinalgOps.cpp LinalgOps.cpp
LinalgTypes.cpp LinalgTypes.cpp
LinalgRegistration.cpp LinalgRegistration.cpp
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
Show All 12 Lines

mlir/lib/Dialect/LoopOps/CMakeLists.txt

file(GLOB globbed *.c *.cpp) file(GLOB globbed *.c *.cpp)
add_llvm_library(MLIRLoopOps add_llvm_library(MLIRLoopOps
${globbed} ${globbed}
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
${MLIR_MAIN_INCLUDE_DIR}/mlir/LoopOps ${MLIR_MAIN_INCLUDE_DIR}/mlir/LoopOps
) )
add_dependencies(MLIRLoopOps MLIRLoopLikeInterfaceIncGen MLIRLoopOpsIncGen MLIRStandardOps LLVMSupport) add_dependencies(MLIRLoopOps MLIRLoopLikeInterfaceIncGen MLIRLoopOpsIncGen MLIRStandardOps LLVMSupport)
target_link_libraries(MLIRLoopOps LLVMSupport) target_link_libraries(MLIRLoopOps MLIRStandardOps LLVMSupport MLIRIR)

mlir/lib/Dialect/OpenMP/CMakeLists.txt

add_llvm_library(MLIROpenMP add_llvm_library(MLIROpenMP
IR/OpenMPDialect.cpp IR/OpenMPDialect.cpp
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
${MLIR_MAIN_INCLUDE_DIR}/mlir/Dialect/OpenMP ${MLIR_MAIN_INCLUDE_DIR}/mlir/Dialect/OpenMP
) )
add_dependencies(MLIROpenMP MLIROpenMPOpsIncGen) add_dependencies(MLIROpenMP MLIROpenMPOpsIncGen)
target_link_libraries(MLIROpenMP MLIRIR)

mlir/lib/Dialect/QuantOps/CMakeLists.txt

Show All 13 Linesadd_llvm_library(MLIRQuantOps
${MLIR_MAIN_INCLUDE_DIR}/mlir/Dialect/QuantOps ${MLIR_MAIN_INCLUDE_DIR}/mlir/Dialect/QuantOps
) )
add_dependencies(MLIRQuantOps add_dependencies(MLIRQuantOps
MLIRIR MLIRIR
MLIRPass MLIRPass
MLIRQuantOpsIncGen MLIRQuantOpsIncGen
MLIRSupport MLIRSupport
MLIRStandardOps) MLIRStandardOps)
target_link_libraries(MLIRQuantOps
MLIRIR
MLIRPass
MLIRSupport
MLIRStandardOps
MLIRTransformUtils
)

mlir/lib/Dialect/SPIRV/Serialization/CMakeLists.txt

add_llvm_library(MLIRSPIRVSerialization add_llvm_library(MLIRSPIRVSerialization
Deserializer.cpp Deserializer.cpp
Serializer.cpp Serializer.cpp
SPIRVBinaryUtils.cpp SPIRVBinaryUtils.cpp
TranslateRegistration.cpp TranslateRegistration.cpp
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
${MLIR_MAIN_INCLUDE_DIR}/mlir/Dialect/SPIRV ${MLIR_MAIN_INCLUDE_DIR}/mlir/Dialect/SPIRV
) )
add_dependencies(MLIRSPIRVSerialization add_dependencies(MLIRSPIRVSerialization
MLIRSPIRVSerializationGen) MLIRSPIRVSerializationGen)
target_link_libraries(MLIRSPIRVSerialization target_link_libraries(MLIRSPIRVSerialization
MLIRIR MLIRIR
MLIRSPIRV MLIRSPIRV
MLIRSupport) MLIRSupport
MLIRTranslation)

mlir/lib/Dialect/VectorOps/CMakeLists.txt

add_llvm_library(MLIRVectorOps add_llvm_library(MLIRVectorOps
DialectRegistration.cpp DialectRegistration.cpp
VectorOps.cpp VectorOps.cpp
VectorTransforms.cpp VectorTransforms.cpp
VectorUtils.cpp VectorUtils.cpp
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
${MLIR_MAIN_INCLUDE_DIR}/mlir/Dialect/VectorOps ${MLIR_MAIN_INCLUDE_DIR}/mlir/Dialect/VectorOps
) )
add_dependencies(MLIRVectorOps MLIRVectorOpsIncGen) add_dependencies(MLIRVectorOps MLIRVectorOpsIncGen)
add_dependencies(MLIRVectorOps MLIRVectorTransformPatternsIncGen) add_dependencies(MLIRVectorOps MLIRVectorTransformPatternsIncGen)
target_link_libraries(MLIRVectorOps MLIRIR) target_link_libraries(MLIRVectorOps MLIRAnalysis MLIRIR MLIRStandardOps MLIRAffineOps MLIRLoopOps)

mlir/lib/EDSC/CMakeLists.txt

Show All 9 Linesadd_llvm_library(MLIREDSC
Helpers.cpp Helpers.cpp
Intrinsics.cpp Intrinsics.cpp
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
${MLIR_MAIN_INCLUDE_DIR}/mlir/EDSC ${MLIR_MAIN_INCLUDE_DIR}/mlir/EDSC
) )
target_link_libraries(MLIREDSC target_link_libraries(MLIREDSC
PUBLIC PUBLIC
MLIRAffineOps MLIRAffineOps
MLIRIR
MLIRLoopOps MLIRLoopOps
MLIRStandardOps MLIRStandardOps
MLIRSupport
MLIRTransformUtils MLIRTransformUtils
MLIRVectorOps MLIRVectorOps
) )
add_llvm_library(MLIREDSCInterface add_llvm_library(MLIREDSCInterface
CoreAPIs.cpp CoreAPIs.cpp
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
${MLIR_MAIN_INCLUDE_DIR}/mlir/EDSC ${MLIR_MAIN_INCLUDE_DIR}/mlir/EDSC
) )
add_dependencies(MLIREDSCInterface MLIRIR) add_dependencies(MLIREDSCInterface MLIRIR)
target_link_libraries(MLIREDSC target_link_libraries(MLIREDSCInterface
PUBLIC PUBLIC
MLIRIR MLIRIR
MLIRSupport MLIRSupport
MLIRParser MLIRParser
) )

mlir/lib/ExecutionEngine/CMakeLists.txt

llvm_map_components_to_libnames(outlibs "nativecodegen" "IPO") llvm_map_components_to_libnames(outlibs "nativecodegen" "IPO")
add_llvm_library(MLIRExecutionEngine add_llvm_library(MLIRExecutionEngine
ExecutionEngine.cpp ExecutionEngine.cpp
OptUtils.cpp OptUtils.cpp
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
${MLIR_MAIN_INCLUDE_DIR}/mlir/ExecutionEngine ${MLIR_MAIN_INCLUDE_DIR}/mlir/ExecutionEngine
) )
target_link_libraries(MLIRExecutionEngine target_link_libraries(MLIRExecutionEngine
MLIRLLVMIR MLIRLLVMIR
MLIRTargetLLVMIR MLIRTargetLLVMIR
LLVMBitReader LLVMBitReader
LLVMBitWriter LLVMBitWriter
LLVMExecutionEngine LLVMExecutionEngine
LLVMOrcJIT LLVMOrcJIT
LLVMJITLink
LLVMSupport LLVMSupport
LLVMAnalysis
LLVMAggressiveInstCombine
LLVMInstCombine
LLVMMC
LLVMScalarOpts
LLVMTarget
LLVMVectorize
LLVMTransformUtils LLVMTransformUtils
${outlibs}) ${outlibs})

mlir/lib/Quantizer/CMakeLists.txt

# Support. # Support.
add_llvm_library(MLIRQuantizerSupport add_llvm_library(MLIRQuantizerSupport
Support/Configuration.cpp Support/Configuration.cpp
Support/ConstraintAnalysisGraph.cpp Support/ConstraintAnalysisGraph.cpp
Support/Metadata.cpp Support/Metadata.cpp
Support/Statistics.cpp Support/Statistics.cpp
Support/TypeUtils.cpp Support/TypeUtils.cpp
Support/UniformConstraints.cpp Support/UniformConstraints.cpp
Support/UniformSolvers.cpp Support/UniformSolvers.cpp
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
) )
add_dependencies(MLIRQuantizerSupport add_dependencies(MLIRQuantizerSupport
MLIRIR MLIRIR
MLIRQuantOps MLIRQuantOps
MLIRSupport MLIRSupport
MLIRStandardOps) MLIRStandardOps)
target_link_libraries(MLIRQuantizerSupport
MLIRIR
MLIRQuantOps
MLIRSupport
MLIRStandardOps
LLVMSupport
)
# Configurations. # Configurations.
add_llvm_library(MLIRQuantizerFxpMathConfig add_llvm_library(MLIRQuantizerFxpMathConfig
Configurations/FxpMathConfig.cpp Configurations/FxpMathConfig.cpp
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
) )
add_dependencies(MLIRQuantizerFxpMathConfig add_dependencies(MLIRQuantizerFxpMathConfig
MLIRFxpMathOpsIncGen MLIRFxpMathOpsIncGen
MLIRQuantizerSupport) MLIRQuantizerSupport)
target_link_libraries(MLIRQuantizerFxpMathConfig
MLIRIR
MLIRFxpMathOps
MLIRQuantOps
MLIRQuantizerSupport
)
# Transforms. # Transforms.
add_llvm_library(MLIRQuantizerTransforms add_llvm_library(MLIRQuantizerTransforms
Transforms/AddDefaultStatsTestPass.cpp Transforms/AddDefaultStatsTestPass.cpp
Transforms/InferQuantizedTypesPass.cpp Transforms/InferQuantizedTypesPass.cpp
Transforms/RemoveInstrumentationPass.cpp Transforms/RemoveInstrumentationPass.cpp
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
) )
add_dependencies(MLIRQuantizerTransforms add_dependencies(MLIRQuantizerTransforms
MLIRQuantizerFxpMathConfig MLIRQuantizerFxpMathConfig
MLIRQuantizerSupport MLIRQuantizerSupport
MLIRPass) MLIRPass)
target_link_libraries(MLIRQuantizerTransforms target_link_libraries(MLIRQuantizerTransforms
MLIRIR
MLIRQuantizerFxpMathConfig MLIRQuantizerFxpMathConfig
MLIRQuantizerSupport MLIRQuantizerSupport
MLIRPass) MLIRQuantOps
MLIRPass
LLVMSupport
)

mlir/lib/Support/CMakeLists.txt

Show All 19 Lines
add_llvm_library(MLIROptMain add_llvm_library(MLIROptMain
MlirOptMain.cpp MlirOptMain.cpp
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
${MLIR_MAIN_INCLUDE_DIR}/mlir/Support ${MLIR_MAIN_INCLUDE_DIR}/mlir/Support
) )
target_link_libraries(MLIROptMain target_link_libraries(MLIROptMain
MLIRPass MLIRPass
MLIRParser
LLVMSupport LLVMSupport
MLIRSupport MLIRSupport
) )
add_llvm_library(MLIRTranslateClParser add_llvm_library(MLIRTranslateClParser
TranslateClParser.cpp TranslateClParser.cpp
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
${MLIR_MAIN_INCLUDE_DIR}/mlir/Support ${MLIR_MAIN_INCLUDE_DIR}/mlir/Support
) )
target_link_libraries(MLIRTranslateClParser LLVMSupport) target_link_libraries(MLIRTranslateClParser LLVMSupport MLIRIR MLIRTranslation MLIRParser)
add_llvm_library(MLIRJitRunner add_llvm_library(MLIRJitRunner
JitRunner.cpp JitRunner.cpp
) )
target_link_libraries(MLIRJitRunner PRIVATE target_link_libraries(MLIRJitRunner PRIVATE
MLIRExecutionEngine MLIRExecutionEngine
MLIRIR MLIRIR
MLIRParser MLIRParser
MLIRStandardOps MLIRStandardOps
MLIRTargetLLVMIR MLIRTargetLLVMIR
MLIRTransforms MLIRTransforms
MLIRStandardToLLVM MLIRStandardToLLVM
MLIRSupport MLIRSupport
LLVMCore LLVMCore
LLVMSupport LLVMSupport
) )

mlir/test/Dialect/SPIRV/CMakeLists.txt

add_llvm_library(MLIRSPIRVTestPasses add_llvm_library(MLIRSPIRVTestPasses
TestAvailability.cpp TestAvailability.cpp
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
${MLIR_MAIN_INCLUDE_DIR}/mlir/Dialect/SPIRV ${MLIR_MAIN_INCLUDE_DIR}/mlir/Dialect/SPIRV
${MLIR_MAIN_INCLUDE_DIR}/mlir/IR ${MLIR_MAIN_INCLUDE_DIR}/mlir/IR
) )
target_link_libraries(MLIRSPIRVTestPasses target_link_libraries(MLIRSPIRVTestPasses PRIVATE
MLIRIR MLIRIR
MLIRPass MLIRPass
MLIRSPIRV MLIRSPIRV
MLIRSupport MLIRSupport
) )

mlir/test/lib/IR/CMakeLists.txt

add_llvm_library(MLIRTestIR add_llvm_library(MLIRTestIR
TestFunc.cpp TestFunc.cpp
TestMatchers.cpp TestMatchers.cpp
TestSymbolUses.cpp TestSymbolUses.cpp
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
) )
include_directories(${CMAKE_CURRENT_SOURCE_DIR}/../TestDialect) include_directories(${CMAKE_CURRENT_SOURCE_DIR}/../TestDialect)
include_directories(${CMAKE_CURRENT_BINARY_DIR}/../TestDialect) include_directories(${CMAKE_CURRENT_BINARY_DIR}/../TestDialect)
add_dependencies(MLIRTestIR add_dependencies(MLIRTestIR
MLIRTestDialect MLIRTestDialect
) )
target_link_libraries(MLIRTestIR target_link_libraries(MLIRTestIR
MLIRPass MLIRPass
) )

mlir/test/lib/TestDialect/CMakeLists.txt

Show All 11 Lines
add_public_tablegen_target(MLIRTestOpsIncGen) add_public_tablegen_target(MLIRTestOpsIncGen)
add_llvm_library(MLIRTestDialect add_llvm_library(MLIRTestDialect
TestDialect.cpp TestDialect.cpp
TestPatterns.cpp TestPatterns.cpp
) )
add_dependencies(MLIRTestDialect add_dependencies(MLIRTestDialect
MLIRTestOpsIncGen MLIRTestOpsIncGen
MLIRIR
LLVMSupport
MLIRTypeInferOpInterfaceIncGen MLIRTypeInferOpInterfaceIncGen
) )
target_link_libraries(MLIRTestDialect target_link_libraries(MLIRTestDialect
MLIRDialect MLIRDialect
MLIRIR MLIRIR
MLIRLinalgTransforms
MLIRPass
MLIRTransforms
MLIRTransformUtils
LLVMSupport LLVMSupport
) )

mlir/test/lib/Transforms/CMakeLists.txt

Show All 11 Linesadd_llvm_library(MLIRTestTransforms
TestOpaqueLoc.cpp TestOpaqueLoc.cpp
TestMemRefStrideCalculation.cpp TestMemRefStrideCalculation.cpp
TestVectorToLoopsConversion.cpp TestVectorToLoopsConversion.cpp
TestVectorTransforms.cpp TestVectorTransforms.cpp
TestVectorizationUtils.cpp TestVectorizationUtils.cpp
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
${MLIR_MAIN_INCLUDE_DIR}/mlir/Transforms ${MLIR_MAIN_INCLUDE_DIR}/mlir/Transforms
) )
include_directories(${CMAKE_CURRENT_SOURCE_DIR}/../TestDialect) include_directories(${CMAKE_CURRENT_SOURCE_DIR}/../TestDialect)
include_directories(${CMAKE_CURRENT_BINARY_DIR}/../TestDialect) include_directories(${CMAKE_CURRENT_BINARY_DIR}/../TestDialect)
include_directories(${CMAKE_CURRENT_SOURCE_DIR}/../DeclarativeTransforms) include_directories(${CMAKE_CURRENT_SOURCE_DIR}/../DeclarativeTransforms)
include_directories(${CMAKE_CURRENT_BINARY_DIR}/../DeclarativeTransforms) include_directories(${CMAKE_CURRENT_BINARY_DIR}/../DeclarativeTransforms)
add_dependencies(MLIRTestTransforms MLIRStandardOpsIncGen) add_dependencies(MLIRTestTransforms MLIRStandardOpsIncGen)
add_dependencies(MLIRTestTransforms MLIRTestLinalgTransformPatternsIncGen) add_dependencies(MLIRTestTransforms MLIRTestLinalgTransformPatternsIncGen)
add_dependencies(MLIRTestTransforms MLIRTestVectorTransformPatternsIncGen) add_dependencies(MLIRTestTransforms MLIRTestVectorTransformPatternsIncGen)
target_link_libraries(MLIRTestTransforms target_link_libraries(MLIRTestTransforms
MLIRAffineOps MLIRAffineOps
MLIRAnalysis MLIRAnalysis
MLIREDSC MLIREDSC
MLIRGPU MLIRGPU
MLIRLinalgOps MLIRLinalgOps
MLIRLinalgTransforms MLIRLinalgTransforms
MLIRLoopOps MLIRLoopOps
MLIRGPU MLIRGPU
MLIRPass MLIRPass
MLIRTestDialect MLIRTestDialect
MLIRTransformUtils
MLIRVectorToLoops
MLIRVectorOps MLIRVectorOps
) )

mlir/tools/mlir-opt/CMakeLists.txt

set(LLVM_OPTIONAL_SOURCES set(LLVM_OPTIONAL_SOURCES
null.cpp null.cpp
) )
set(LIB_LIBS set(LIB_LIBS
MLIRAnalysis MLIRAnalysis
MLIRLLVMIR MLIRLLVMIR
MLIROptMain
MLIRParser MLIRParser
MLIRPass MLIRPass
MLIRTransforms MLIRTransforms
MLIRSupport MLIRSupport
) )
add_llvm_library(MLIRMlirOptLib add_llvm_library(MLIRMlirOptLib
mlir-opt.cpp mlir-opt.cpp
) )
target_link_libraries(MLIRMlirOptLib ${LIB_LIBS}) target_link_libraries(MLIRMlirOptLib
${LIB_LIBS}
)
set(LIBS set(LIBS
MLIRAnalysis MLIRAnalysis
MLIRAffineOps MLIRAffineOps
MLIRAffineToStandard MLIRAffineToStandard
MLIRDialect
MLIRLoopsToGPU MLIRLoopsToGPU
MLIRLinalgToLLVM MLIRLinalgToLLVM
MLIRLoopToStandard MLIRLoopToStandard
MLIREDSC MLIREDSC
MLIRFxpMathOps MLIRFxpMathOps
MLIRGPU MLIRGPU
MLIRGPUtoNVVMTransforms MLIRGPUtoNVVMTransforms
MLIRGPUtoROCDLTransforms MLIRGPUtoROCDLTransforms
MLIRGPUtoSPIRVTransforms MLIRGPUtoSPIRVTransforms
MLIRLinalgOps MLIRLinalgOps
MLIRLinalgAnalysis
MLIRLinalgEDSC
MLIRLinalgTransforms
MLIRLinalgUtils
MLIRLLVMIR MLIRLLVMIR
MLIRLoopOps MLIRLoopOps
MLIRNVVMIR MLIRNVVMIR
MLIROpenMP MLIROpenMP
MLIROptMain MLIROptMain
MLIRParser MLIRParser
MLIRPass MLIRPass
MLIRQuantizerFxpMathConfig
MLIRQuantizerSupport
MLIRQuantizerTransforms MLIRQuantizerTransforms
MLIRQuantOps MLIRQuantOps
MLIRROCDLIR MLIRROCDLIR
MLIRSPIRV MLIRSPIRV
MLIRLinalgToSPIRVTransforms MLIRLinalgToSPIRVTransforms
MLIRStandardToSPIRVTransforms MLIRStandardToSPIRVTransforms
MLIRSPIRVTestPasses MLIRSPIRVTestPasses
MLIRSPIRVTransforms MLIRSPIRVTransforms
MLIRStandardOps MLIRStandardOps
MLIRStandardToLLVM MLIRStandardToLLVM
MLIRTransforms MLIRTransforms
MLIRTransformUtils
MLIRTestDialect MLIRTestDialect
MLIRTestIR MLIRTestIR
MLIRTestPass MLIRTestPass
MLIRTestTransforms MLIRTestTransforms
MLIRSupport MLIRSupport
MLIRVectorOps MLIRVectorOps
MLIRVectorToLLVM MLIRVectorToLLVM
MLIRVectorToLoops MLIRVectorToLoops
) )
if(MLIR_CUDA_CONVERSIONS_ENABLED) if(MLIR_CUDA_CONVERSIONS_ENABLED)
list(APPEND LIBS list(APPEND LIBS
MLIRGPUtoCUDATransforms MLIRGPUtoCUDATransforms
) )
endif() endif()
add_llvm_tool(mlir-opt add_llvm_tool(mlir-opt
mlir-opt.cpp mlir-opt.cpp
) )
llvm_update_compile_flags(mlir-opt) llvm_update_compile_flags(mlir-opt)
# It is necessary to use whole_archive_link to ensure that all static
# initializers are called. However, whole_archive_link libraries cannot
# also be target_link_libraries
whole_archive_link(mlir-opt ${LIBS}) whole_archive_link(mlir-opt ${LIBS})
target_link_libraries(mlir-opt PRIVATE MLIRIR MLIRMlirOptLib ${LIBS} LLVMSupport) target_link_libraries(mlir-opt PRIVATE MLIRIR MLIROptMain LLVMSupport LLVMCore LLVMAsmParser)