Page MenuHomePhabricator

[MLIR][GPU] Fix build files for mlir-opt.
ClosedPublic

Authored by herhut on Feb 5 2020, 4:52 AM.

Details

Summary

The recent refactoring of build files broke building with the MIR CUDA
integration enabled. This fixes it by adding some additional
dependencies to mlir-opt.

Diff Detail

Event Timeline

herhut created this revision.Feb 5 2020, 4:52 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 5 2020, 4:52 AM

There is probably a prettier way to do this but this unblocks building.

Unit tests: unknown.

clang-tidy: unknown.

clang-format: unknown.

Build artifacts: console-log.txt

Pre-merge checks is in beta. Report issue. Please join beta or enable it for your project.

Thanks for this. I didn't realize I hadn't tested the GPU config.

mlir/tools/mlir-opt/CMakeLists.txt
21

Maybe WHOLE_ARCHIVE_LINK_LIBS?

This revision is now accepted and ready to land.Feb 5 2020, 9:06 AM
This revision was automatically updated to reflect the committed changes.
herhut marked an inline comment as done.Feb 5 2020, 9:20 AM

I am setting up a build bot that will build the tree with the cuda parts enabled so we can see this easier.

mlir/tools/mlir-opt/CMakeLists.txt
21

Seems this landed already. We use FULL_LINK_LIBS is other places, as well, but we can do a global rename in a follow up.

I am setting up a build bot that will build the tree with the cuda parts enabled so we can see this easier.

I updated our build kite bot accordingly already: https://buildkite.com/mlir/mlir-core

herhut added a comment.Feb 6 2020, 1:22 AM

I am setting up a build bot that will build the tree with the cuda parts enabled so we can see this easier.

I updated our build kite bot accordingly already: https://buildkite.com/mlir/mlir-core

Does it also run the CUDA tests that require a GPU (mlir-cuda-runner based ones)?

Does it also run the CUDA tests that require a GPU (mlir-cuda-runner based ones)?

No it isn't just a cloud VM, building and testing on a GPU machine would be quite a waste