Page MenuHomePhabricator

[PowerPC] Add exception constraint to FP arithmetic
Needs ReviewPublic

Authored by qiucf on Jun 27 2019, 8:26 PM.

Details

Reviewers
hfinkel
nemanjai
jsji
kbarton
uweigand
andrew.w.kaylor
kpn
wuzish
Group Reviewers
Restricted Project
Summary

D55506 introduced concept of strict-fp nodes into LLVM. This patch is to add strict-fp exception support to PowerPC backend, and only contains basic arithmetic operations (+, -, *, /). Patch for the rest of floating point operations will be in following patches.

Diff Detail

Event Timeline

wuzish created this revision.Jun 27 2019, 8:26 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 27 2019, 8:26 PM
wuzish updated this revision to Diff 207476.Jul 1 2019, 11:00 PM

update testcases.

wuzish added a reviewer: kpn.Jul 3 2019, 11:11 PM
jsji added a reviewer: Restricted Project.Aug 27 2019, 7:57 PM
qiucf commandeered this revision.Oct 11 2019, 7:26 PM
qiucf added a reviewer: wuzish.
qiucf updated this revision to Diff 236310.Jan 6 2020, 1:26 AM
qiucf retitled this revision from [PowerPC] Add constraint fp support about exception part for operation +-*/ to [PowerPC] Add exception constraint to FP arithmetic.
qiucf edited the summary of this revision. (Show Details)

Rebase and fix conflicts.

Unit tests: pass. 61258 tests passed, 0 failed and 736 were skipped.

clang-tidy: pass.

clang-format: pass.

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

qiucf updated this revision to Diff 238170.Jan 14 2020, 10:41 PM

Fix a test error

Unit tests: unknown.

clang-tidy: unknown.

clang-format: unknown.

Build artifacts: console-log.txt

qiucf updated this revision to Diff 244392.Thu, Feb 13, 4:53 AM
  • Rename and combine some cases together.
  • Add some more cases.

I don't know enough about PowerPC to review the check in the tests, but the basic constrained intrinsic handling looks correct.