[Signals] Create a plugin directory just for signals

[xiaobai]

Summary

I plan on setting up a plugin architecture for UnixSignals since I
don't think it makes sense for UnixSignals to know about all the
platform-specific signal classes. The first step is to organize the directories
in a way that makes this easier to do.

[xiaobai]

Fix up include in gtest

[labath]

Although this is technically correct and pretty consistent with our other "plugins", I can't help but feel that it's incredibly wasteful. Each of the XXXSignals.cpp files is less than a 100 lines long (with the licence header and all bolierplate) and it's unlikely to ever grow beyond that. And essentially, all these files do is define a single enum. The reason they are this long is because the UnixSignals class is already over-engineered (e.g. I don't see why LinuxSignals needs to be a separate class, or why it needs to repeat the descriptions/default stop values for each of the signals). Making this a plugin would just add another chunk of boilerplate on top of that.

I don't know about others, but I'd rather us move in a direction which reduces the amount of boilerplate instead of adding more of it. In my ideal world, each of these signal definitions would just be a bunch of (number, name) pairs. This doesn't have/need to be a class or a plugin; a single constexpr variable would suffice for that. Then we'd just cross-reference this mapping with another one which gives the default stop values and descriptions for each of the signals, and that's it.

I know I am repeating myself, but each time I say this, it's because I find another reason for it: I think we should start a new library which I would roughly define as "utilities for describing and manipulating various low-level aspects of processes, but which is agnostic of any actual process class". The idea would be that we can shove here all classes which are shared between lldb-server liblldb. UnixSignals would be one candidate for it. AuxVector, MemoryRegionInfo are others. Plugins/Process/Utility (where most of the signal classes live) would be a pretty good place for it already, were it not for the "Plugins" part (it would be weird for non-plugin code to depend on something called a "plugin"). However, maybe we could just create a new top-level library called "ProcessUtil" (or whatever name we come up with) and move the relevant stuff there.

Anyway, TL;DR: I think this should be handled differently. However, if others are fine with this approach, then feel free to ignore me.

[xiaobai]

In D63363#1545427, @labath wrote:

Although this is technically correct and pretty consistent with our other "plugins", I can't help but feel that it's incredibly wasteful. Each of the XXXSignals.cpp files is less than a 100 lines long (with the licence header and all bolierplate) and it's unlikely to ever grow beyond that. And essentially, all these files do is define a single enum. The reason they are this long is because the UnixSignals class is already over-engineered (e.g. I don't see why LinuxSignals needs to be a separate class, or why it needs to repeat the descriptions/default stop values for each of the signals). Making this a plugin would just add another chunk of boilerplate on top of that.

I don't know about others, but I'd rather us move in a direction which reduces the amount of boilerplate instead of adding more of it. In my ideal world, each of these signal definitions would just be a bunch of (number, name) pairs. This doesn't have/need to be a class or a plugin; a single constexpr variable would suffice for that. Then we'd just cross-reference this mapping with another one which gives the default stop values and descriptions for each of the signals, and that's it.

I know I am repeating myself, but each time I say this, it's because I find another reason for it: I think we should start a new library which I would roughly define as "utilities for describing and manipulating various low-level aspects of processes, but which is agnostic of any actual process class". The idea would be that we can shove here all classes which are shared between lldb-server liblldb. UnixSignals would be one candidate for it. AuxVector, MemoryRegionInfo are others. Plugins/Process/Utility (where most of the signal classes live) would be a pretty good place for it already, were it not for the "Plugins" part (it would be weird for non-plugin code to depend on something called a "plugin"). However, maybe we could just create a new top-level library called "ProcessUtil" (or whatever name we come up with) and move the relevant stuff there.

Anyway, TL;DR: I think this should be handled differently. However, if others are fine with this approach, then feel free to ignore me.

I really don't like my approach here either and agree that the Signals support is over-engineered as is. I also think it's quite unfortunate that UnixSignals inside of Target by default has the Darwin signals instead of them being broken out into a separate file like the rest of the platforms. I am okay with this approach in the short term, though.

I think that the "ProcessUtil" idea is a good one. I kind of feel like "Plugins/Process/Utility" is a dumping ground for loosely related classes for manipulating processes', but let's see what other people think about that.

[jfb]

Can you describe what the goal of your plugin architecture is? Maybe you need an RFC by email before moving stuff around.

I want to understand what you're going for because as they are today the signals mostly work, and aren't really tested (because injecting these conditions isn't trivial). Anything you change is likely to break some subtle invariant which will only repro when your change is deployed at scale.

[xiaobai]

In D63363#1546464, @jfb wrote:

Can you describe what the goal of your plugin architecture is? Maybe you need an RFC by email before moving stuff around.

I want to understand what you're going for because as they are today the signals mostly work, and aren't really tested (because injecting these conditions isn't trivial). Anything you change is likely to break some subtle invariant which will only repro when your change is deployed at scale.

My goal is to remove non-plugin libraries dependencies on plugins. Today, Target depends on the ProcessUtility plugin because of UnixSignals. If Signals were their own plugin that could be accessed through the PluginManager interface, that dependency would go away. As Pavel said, this feels somewhat over engineered and contrived, but it is the simplest path forward. I am willing to drop this patch and go for a different solution if there is a nicer solution agreed upon by the community, so an RFC sounds like a nice idea. :)

[jfb]

In D63363#1546490, @xiaobai wrote:

In D63363#1546464, @jfb wrote:

Can you describe what the goal of your plugin architecture is? Maybe you need an RFC by email before moving stuff around.

I want to understand what you're going for because as they are today the signals mostly work, and aren't really tested (because injecting these conditions isn't trivial). Anything you change is likely to break some subtle invariant which will only repro when your change is deployed at scale.

My goal is to remove non-plugin libraries dependencies on plugins. Today, Target depends on the ProcessUtility plugin because of UnixSignals. If Signals were their own plugin that could be accessed through the PluginManager interface, that dependency would go away. As Pavel said, this feels somewhat over engineered and contrived, but it is the simplest path forward. I am willing to drop this patch and go for a different solution if there is a nicer solution agreed upon by the community, so an RFC sounds like a nice idea. :)

Removing the dependency seems fine, but we have to be careful with how signals work: they're inherently global state, and you want to register / de-register them exactly where they're registered / de-registered right now to keep them working exactly the same. If you change this, we need to really think through why that's a good idea (it might be!).

[labath]

In D63363#1546504, @jfb wrote:

In D63363#1546490, @xiaobai wrote:

In D63363#1546464, @jfb wrote:

Can you describe what the goal of your plugin architecture is? Maybe you need an RFC by email before moving stuff around.

I want to understand what you're going for because as they are today the signals mostly work, and aren't really tested (because injecting these conditions isn't trivial). Anything you change is likely to break some subtle invariant which will only repro when your change is deployed at scale.

My goal is to remove non-plugin libraries dependencies on plugins. Today, Target depends on the ProcessUtility plugin because of UnixSignals. If Signals were their own plugin that could be accessed through the PluginManager interface, that dependency would go away. As Pavel said, this feels somewhat over engineered and contrived, but it is the simplest path forward. I am willing to drop this patch and go for a different solution if there is a nicer solution agreed upon by the community, so an RFC sounds like a nice idea. :)

Removing the dependency seems fine, but we have to be careful with how signals work: they're inherently global state, and you want to register / de-register them exactly where they're registered / de-registered right now to keep them working exactly the same. If you change this, we need to really think through why that's a good idea (it might be!).

I think there's some misunderstading here. This code has nothing to do with signal handlers. All these classes do is describe the set of possible signals on a given target (e.g. if remote-debugging a linux mips machine from a darwin x86 host, we need to know what number does linux use to represent SIGSEGV on mips, etc.)...

[jfb]

In D63363#1546837, @labath wrote:

In D63363#1546504, @jfb wrote:

In D63363#1546490, @xiaobai wrote:

In D63363#1546464, @jfb wrote:

Can you describe what the goal of your plugin architecture is? Maybe you need an RFC by email before moving stuff around.

I want to understand what you're going for because as they are today the signals mostly work, and aren't really tested (because injecting these conditions isn't trivial). Anything you change is likely to break some subtle invariant which will only repro when your change is deployed at scale.

My goal is to remove non-plugin libraries dependencies on plugins. Today, Target depends on the ProcessUtility plugin because of UnixSignals. If Signals were their own plugin that could be accessed through the PluginManager interface, that dependency would go away. As Pavel said, this feels somewhat over engineered and contrived, but it is the simplest path forward. I am willing to drop this patch and go for a different solution if there is a nicer solution agreed upon by the community, so an RFC sounds like a nice idea. :)

Removing the dependency seems fine, but we have to be careful with how signals work: they're inherently global state, and you want to register / de-register them exactly where they're registered / de-registered right now to keep them working exactly the same. If you change this, we need to really think through why that's a good idea (it might be!).

I think there's some misunderstading here. This code has nothing to do with signal handlers. All these classes do is describe the set of possible signals on a given target (e.g. if remote-debugging a linux mips machine from a darwin x86 host, we need to know what number does linux use to represent SIGSEGV on mips, etc.)...

OK, if that's the intended change, and scope doesn't widen further, it would be good to say so in the review. The description leads me to believe that all things signal-related are in scope, and this refactoring is step #1 in that goal.

[jingham]

In D63363#1545427, @labath wrote:

Although this is technically correct and pretty consistent with our other "plugins", I can't help but feel that it's incredibly wasteful. Each of the XXXSignals.cpp files is less than a 100 lines long (with the licence header and all bolierplate) and it's unlikely to ever grow beyond that. And essentially, all these files do is define a single enum. The reason they are this long is because the UnixSignals class is already over-engineered (e.g. I don't see why LinuxSignals needs to be a separate class, or why it needs to repeat the descriptions/default stop values for each of the signals). Making this a plugin would just add another chunk of boilerplate on top of that.

I don't know about others, but I'd rather us move in a direction which reduces the amount of boilerplate instead of adding more of it. In my ideal world, each of these signal definitions would just be a bunch of (number, name) pairs. This doesn't have/need to be a class or a plugin; a single constexpr variable would suffice for that. Then we'd just cross-reference this mapping with another one which gives the default stop values and descriptions for each of the signals, and that's it.

I know I am repeating myself, but each time I say this, it's because I find another reason for it: I think we should start a new library which I would roughly define as "utilities for describing and manipulating various low-level aspects of processes, but which is agnostic of any actual process class". The idea would be that we can shove here all classes which are shared between lldb-server liblldb. UnixSignals would be one candidate for it. AuxVector, MemoryRegionInfo are others. Plugins/Process/Utility (where most of the signal classes live) would be a pretty good place for it already, were it not for the "Plugins" part (it would be weird for non-plugin code to depend on something called a "plugin"). However, maybe we could just create a new top-level library called "ProcessUtil" (or whatever name we come up with) and move the relevant stuff there.

Anyway, TL;DR: I think this should be handled differently. However, if others are fine with this approach, then feel free to ignore me.

How would you bind a particular variant of UnixSignals to the process plugin that it goes along with in this scenario?

[labath]

In D63363#1549500, @jingham wrote:

In D63363#1545427, @labath wrote:

Although this is technically correct and pretty consistent with our other "plugins", I can't help but feel that it's incredibly wasteful. Each of the XXXSignals.cpp files is less than a 100 lines long (with the licence header and all bolierplate) and it's unlikely to ever grow beyond that. And essentially, all these files do is define a single enum. The reason they are this long is because the UnixSignals class is already over-engineered (e.g. I don't see why LinuxSignals needs to be a separate class, or why it needs to repeat the descriptions/default stop values for each of the signals). Making this a plugin would just add another chunk of boilerplate on top of that.

I don't know about others, but I'd rather us move in a direction which reduces the amount of boilerplate instead of adding more of it. In my ideal world, each of these signal definitions would just be a bunch of (number, name) pairs. This doesn't have/need to be a class or a plugin; a single constexpr variable would suffice for that. Then we'd just cross-reference this mapping with another one which gives the default stop values and descriptions for each of the signals, and that's it.

I know I am repeating myself, but each time I say this, it's because I find another reason for it: I think we should start a new library which I would roughly define as "utilities for describing and manipulating various low-level aspects of processes, but which is agnostic of any actual process class". The idea would be that we can shove here all classes which are shared between lldb-server liblldb. UnixSignals would be one candidate for it. AuxVector, MemoryRegionInfo are others. Plugins/Process/Utility (where most of the signal classes live) would be a pretty good place for it already, were it not for the "Plugins" part (it would be weird for non-plugin code to depend on something called a "plugin"). However, maybe we could just create a new top-level library called "ProcessUtil" (or whatever name we come up with) and move the relevant stuff there.

Anyway, TL;DR: I think this should be handled differently. However, if others are fine with this approach, then feel free to ignore me.

How would you bind a particular variant of UnixSignals to the process plugin that it goes along with in this scenario?

The same way as it is done now -- you pass in an ArchSpec, and get back a list of signals in return. The only difference would be that the implementation of "finding the right set of signals for a given ArchSpec" wouldn't be distributed over 5 subfolders, but it would happen in a single place. (I think that this code is so simple that we should shove all of it into a single file -- that would make it easier to share common stuff like signal descriptions between implementations)

source/Plugins/CMakeLists.txt

 add_subdirectory(ABI)
 add_subdirectory(Architecture)
 add_subdirectory(Disassembler)
 add_subdirectory(DynamicLoader)
 add_subdirectory(ExpressionParser)
 add_subdirectory(Instruction)
 add_subdirectory(InstrumentationRuntime)
 add_subdirectory(JITLoader)
 add_subdirectory(Language)
 add_subdirectory(LanguageRuntime)
 add_subdirectory(MemoryHistory)
 add_subdirectory(ObjectContainer)
 add_subdirectory(ObjectFile)
 add_subdirectory(OperatingSystem)
 add_subdirectory(Platform)
 add_subdirectory(Process)
+add_subdirectory(Signals)
 add_subdirectory(ScriptInterpreter)
 add_subdirectory(StructuredData)
 add_subdirectory(SymbolFile)
 add_subdirectory(SystemRuntime)
 add_subdirectory(SymbolVendor)
 add_subdirectory(UnwindAssembly)

source/Plugins/Platform/gdb-server/PlatformRemoteGDBServer.h

 //===-- PlatformRemoteGDBServer.h ----------------------------------------*- C++
 //-*-===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
 #ifndef liblldb_PlatformRemoteGDBServer_h_
 #define liblldb_PlatformRemoteGDBServer_h_
 
 #include <string>
 
 #include "Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.h"
-#include "Plugins/Process/Utility/GDBRemoteSignals.h"
 #include "lldb/Target/Platform.h"
 
 namespace lldb_private {
 namespace platform_gdb_server {
 
 class PlatformRemoteGDBServer : public Platform, private UserIDResolver {
 public:
   static void Initialize();

source/Plugins/Platform/gdb-server/PlatformRemoteGDBServer.cpp

 #include "lldb/Target/Target.h"
 #include "lldb/Utility/FileSpec.h"
 #include "lldb/Utility/Log.h"
 #include "lldb/Utility/ProcessInfo.h"
 #include "lldb/Utility/Status.h"
 #include "lldb/Utility/StreamString.h"
 #include "lldb/Utility/UriParser.h"
 
-#include "Plugins/Process/Utility/GDBRemoteSignals.h"
+#include "Plugins/Signals/GDBRemote/GDBRemoteSignals.h"
 
 using namespace lldb;
 using namespace lldb_private;
 using namespace lldb_private::platform_gdb_server;
 
 static bool g_initialized = false;
 
 void PlatformRemoteGDBServer::Initialize() {

source/Plugins/Process/Utility/CMakeLists.txt

 add_lldb_library(lldbPluginProcessUtility PLUGIN
   AuxVector.cpp
   DynamicRegisterInfo.cpp
-  FreeBSDSignals.cpp
-  GDBRemoteSignals.cpp
   HistoryThread.cpp
   HistoryUnwind.cpp
   InferiorCallPOSIX.cpp
   LinuxProcMaps.cpp
-  LinuxSignals.cpp
-  MipsLinuxSignals.cpp
   NativeRegisterContextRegisterInfo.cpp
-  NetBSDSignals.cpp
   RegisterContextDarwin_arm.cpp
   RegisterContextDarwin_arm64.cpp
   RegisterContextDarwin_i386.cpp
   RegisterContextDarwin_x86_64.cpp
   RegisterContextDummy.cpp
   RegisterContextFreeBSD_i386.cpp
   RegisterContextFreeBSD_mips64.cpp
   RegisterContextFreeBSD_powerpc.cpp

source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp

 #include "lldb/Utility/FileSpec.h"
 #include "lldb/Utility/Reproducer.h"
 #include "lldb/Utility/State.h"
 #include "lldb/Utility/StreamString.h"
 #include "lldb/Utility/Timer.h"
 
 #include "GDBRemoteRegisterContext.h"
 #include "Plugins/Platform/MacOSX/PlatformRemoteiOS.h"
-#include "Plugins/Process/Utility/GDBRemoteSignals.h"
+#include "Plugins/Signals/GDBRemote/GDBRemoteSignals.h"
 #include "Plugins/Process/Utility/InferiorCallPOSIX.h"
 #include "Plugins/Process/Utility/StopInfoMachException.h"
 #include "ProcessGDBRemote.h"
 #include "ProcessGDBRemoteLog.h"
 #include "ThreadGDBRemote.h"
 #include "lldb/Host/Host.h"
 #include "lldb/Utility/StringExtractorGDBRemote.h"
 

source/Plugins/Signals/CMakeLists.txt

+add_subdirectory(FreeBSD)
+add_subdirectory(GDBRemote)
+add_subdirectory(Linux)
+add_subdirectory(NetBSD)

source/Plugins/Signals/FreeBSD/CMakeLists.txt

+add_lldb_library(lldbPluginSignalsFreeBSD PLUGIN
+  FreeBSDSignals.cpp
+
+  LINK_LIBS
+    lldbTarget
+)

source/Plugins/Signals/FreeBSD/FreeBSDSignals.h

 //===-- FreeBSDSignals.h ----------------------------------------*- C++ -*-===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
 #ifndef liblldb_FreeBSDSignals_H_
 #define liblldb_FreeBSDSignals_H_
 
 #include "lldb/Target/UnixSignals.h"
 
 namespace lldb_private {
 
 /// FreeBSD specific set of Unix signals.
 class FreeBSDSignals : public UnixSignals {
 public:
   FreeBSDSignals();
 
 private:
   void Reset() override;
 };
 
 } // namespace lldb_private
 
 #endif // liblldb_FreeBSDSignals_H_

source/Plugins/Signals/FreeBSD/FreeBSDSignals.cpp

 //===-- FreeBSDSignals.cpp --------------------------------------*- C++ -*-===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
 #include "FreeBSDSignals.h"
 
 using namespace lldb_private;
 
 FreeBSDSignals::FreeBSDSignals() : UnixSignals() { Reset(); }
 
 void FreeBSDSignals::Reset() {
   UnixSignals::Reset();
 
   //        SIGNO   NAME            SUPPRESS STOP   NOTIFY DESCRIPTION
   //        ======  ============    ======== ====== ======
   //        ===================================================
   AddSignal(32, "SIGTHR", false, false, false, "thread interrupt");
   AddSignal(33, "SIGLIBRT", false, false, false,
             "reserved by real-time library");
   AddSignal(65, "SIGRTMIN", false, false, false, "real time signal 0");
   AddSignal(66, "SIGRTMIN+1", false, false, false, "real time signal 1");
   AddSignal(67, "SIGRTMIN+2", false, false, false, "real time signal 2");
   AddSignal(68, "SIGRTMIN+3", false, false, false, "real time signal 3");
   AddSignal(69, "SIGRTMIN+4", false, false, false, "real time signal 4");
   AddSignal(70, "SIGRTMIN+5", false, false, false, "real time signal 5");
   AddSignal(71, "SIGRTMIN+6", false, false, false, "real time signal 6");
   AddSignal(72, "SIGRTMIN+7", false, false, false, "real time signal 7");
   AddSignal(73, "SIGRTMIN+8", false, false, false, "real time signal 8");
   AddSignal(74, "SIGRTMIN+9", false, false, false, "real time signal 9");
   AddSignal(75, "SIGRTMIN+10", false, false, false, "real time signal 10");
   AddSignal(76, "SIGRTMIN+11", false, false, false, "real time signal 11");
   AddSignal(77, "SIGRTMIN+12", false, false, false, "real time signal 12");
   AddSignal(78, "SIGRTMIN+13", false, false, false, "real time signal 13");
   AddSignal(79, "SIGRTMIN+14", false, false, false, "real time signal 14");
   AddSignal(80, "SIGRTMIN+15", false, false, false, "real time signal 15");
   AddSignal(81, "SIGRTMIN+16", false, false, false, "real time signal 16");
   AddSignal(82, "SIGRTMIN+17", false, false, false, "real time signal 17");
   AddSignal(83, "SIGRTMIN+18", false, false, false, "real time signal 18");
   AddSignal(84, "SIGRTMIN+19", false, false, false, "real time signal 19");
   AddSignal(85, "SIGRTMIN+20", false, false, false, "real time signal 20");
   AddSignal(86, "SIGRTMIN+21", false, false, false, "real time signal 21");
   AddSignal(87, "SIGRTMIN+22", false, false, false, "real time signal 22");
   AddSignal(88, "SIGRTMIN+23", false, false, false, "real time signal 23");
   AddSignal(89, "SIGRTMIN+24", false, false, false, "real time signal 24");
   AddSignal(90, "SIGRTMIN+25", false, false, false, "real time signal 25");
   AddSignal(91, "SIGRTMIN+26", false, false, false, "real time signal 26");
   AddSignal(92, "SIGRTMIN+27", false, false, false, "real time signal 27");
   AddSignal(93, "SIGRTMIN+28", false, false, false, "real time signal 28");
   AddSignal(94, "SIGRTMIN+29", false, false, false, "real time signal 29");
   AddSignal(95, "SIGRTMIN+30", false, false, false, "real time signal 30");
   AddSignal(96, "SIGRTMAX-30", false, false, false, "real time signal 31");
   AddSignal(97, "SIGRTMAX-29", false, false, false, "real time signal 32");
   AddSignal(98, "SIGRTMAX-28", false, false, false, "real time signal 33");
   AddSignal(99, "SIGRTMAX-27", false, false, false, "real time signal 34");
   AddSignal(100, "SIGRTMAX-26", false, false, false, "real time signal 35");
   AddSignal(101, "SIGRTMAX-25", false, false, false, "real time signal 36");
   AddSignal(102, "SIGRTMAX-24", false, false, false, "real time signal 37");
   AddSignal(103, "SIGRTMAX-23", false, false, false, "real time signal 38");
   AddSignal(104, "SIGRTMAX-22", false, false, false, "real time signal 39");
   AddSignal(105, "SIGRTMAX-21", false, false, false, "real time signal 40");
   AddSignal(106, "SIGRTMAX-20", false, false, false, "real time signal 41");
   AddSignal(107, "SIGRTMAX-19", false, false, false, "real time signal 42");
   AddSignal(108, "SIGRTMAX-18", false, false, false, "real time signal 43");
   AddSignal(109, "SIGRTMAX-17", false, false, false, "real time signal 44");
   AddSignal(110, "SIGRTMAX-16", false, false, false, "real time signal 45");
   AddSignal(111, "SIGRTMAX-15", false, false, false, "real time signal 46");
   AddSignal(112, "SIGRTMAX-14", false, false, false, "real time signal 47");
   AddSignal(113, "SIGRTMAX-13", false, false, false, "real time signal 48");
   AddSignal(114, "SIGRTMAX-12", false, false, false, "real time signal 49");
   AddSignal(115, "SIGRTMAX-11", false, false, false, "real time signal 50");
   AddSignal(116, "SIGRTMAX-10", false, false, false, "real time signal 51");
   AddSignal(117, "SIGRTMAX-9", false, false, false, "real time signal 52");
   AddSignal(118, "SIGRTMAX-8", false, false, false, "real time signal 53");
   AddSignal(119, "SIGRTMAX-7", false, false, false, "real time signal 54");
   AddSignal(120, "SIGRTMAX-6", false, false, false, "real time signal 55");
   AddSignal(121, "SIGRTMAX-5", false, false, false, "real time signal 56");
   AddSignal(122, "SIGRTMAX-4", false, false, false, "real time signal 57");
   AddSignal(123, "SIGRTMAX-3", false, false, false, "real time signal 58");
   AddSignal(124, "SIGRTMAX-2", false, false, false, "real time signal 59");
   AddSignal(125, "SIGRTMAX-1", false, false, false, "real time signal 60");
   AddSignal(126, "SIGRTMAX", false, false, false, "real time signal 61");
 }

source/Plugins/Signals/GDBRemote/CMakeLists.txt

+add_lldb_library(lldbPluginSignalsGDBRemote PLUGIN
+  GDBRemoteSignals.cpp
+
+  LINK_LIBS
+    lldbTarget
+)

source/Plugins/Signals/GDBRemote/GDBRemoteSignals.h

 //===-- GDBRemoteSignals.h --------------------------------------*- C++ -*-===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
 #ifndef liblldb_GDBRemoteSignals_H_
 #define liblldb_GDBRemoteSignals_H_
 
 #include "lldb/Target/UnixSignals.h"
 
 namespace lldb_private {
 
 /// Empty set of Unix signals to be filled by PlatformRemoteGDBServer
 class GDBRemoteSignals : public UnixSignals {
 public:
   GDBRemoteSignals();
 
   GDBRemoteSignals(const lldb::UnixSignalsSP &rhs);
 
 private:
   void Reset() override;
 };
 
 } // namespace lldb_private
 
 #endif // liblldb_GDBRemoteSignals_H_

source/Plugins/Signals/GDBRemote/GDBRemoteSignals.cpp

 //===-- GDBRemoteSignals.cpp ------------------------------------*- C++ -*-===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
 #include "GDBRemoteSignals.h"
 
 using namespace lldb_private;
 
 GDBRemoteSignals::GDBRemoteSignals() : UnixSignals() { Reset(); }
 
 GDBRemoteSignals::GDBRemoteSignals(const lldb::UnixSignalsSP &rhs)
     : UnixSignals(*rhs) {}
 
 void GDBRemoteSignals::Reset() { m_signals.clear(); }

source/Plugins/Signals/Linux/CMakeLists.txt

+add_lldb_library(lldbPluginSignalsLinux PLUGIN
+  LinuxSignals.cpp
+  MipsLinuxSignals.cpp
+
+  LINK_LIBS
+    lldbTarget
+)

source/Plugins/Signals/Linux/LinuxSignals.h

 //===-- LinuxSignals.h ------------------------------------------*- C++ -*-===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
 #ifndef liblldb_LinuxSignals_H_
 #define liblldb_LinuxSignals_H_
 
 #include "lldb/Target/UnixSignals.h"
 
 namespace lldb_private {
 
 /// Linux specific set of Unix signals.
 class LinuxSignals : public UnixSignals {
 public:
   LinuxSignals();
 
 private:
   void Reset() override;
 };
 
 } // namespace lldb_private
 
 #endif // liblldb_LinuxSignals_H_

source/Plugins/Signals/Linux/LinuxSignals.cpp

 //===-- LinuxSignals.cpp ----------------------------------------*- C++ -*-===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
 #include "LinuxSignals.h"
 
 using namespace lldb_private;
 
 LinuxSignals::LinuxSignals() : UnixSignals() { Reset(); }
 
 void LinuxSignals::Reset() {
   m_signals.clear();
   //        SIGNO  NAME             SUPPRESS STOP   NOTIFY DESCRIPTION ALIAS
   //        =====  ===========      ======== =====  ======
   //        ======================================   ======
   AddSignal(1, "SIGHUP", false, true, true, "hangup");
   AddSignal(2, "SIGINT", true, true, true, "interrupt");
   AddSignal(3, "SIGQUIT", false, true, true, "quit");
   AddSignal(4, "SIGILL", false, true, true, "illegal instruction");
   AddSignal(5, "SIGTRAP", true, true, true,
             "trace trap (not reset when caught)");
   AddSignal(6, "SIGABRT", false, true, true, "abort()/IOT trap", "SIGIOT");
   AddSignal(7, "SIGBUS", false, true, true, "bus error");
   AddSignal(8, "SIGFPE", false, true, true, "floating point exception");
   AddSignal(9, "SIGKILL", false, true, true, "kill");
   AddSignal(10, "SIGUSR1", false, true, true, "user defined signal 1");
   AddSignal(11, "SIGSEGV", false, true, true, "segmentation violation");
   AddSignal(12, "SIGUSR2", false, true, true, "user defined signal 2");
   AddSignal(13, "SIGPIPE", false, true, true,
             "write to pipe with reading end closed");
   AddSignal(14, "SIGALRM", false, false, false, "alarm");
   AddSignal(15, "SIGTERM", false, true, true, "termination requested");
   AddSignal(16, "SIGSTKFLT", false, true, true, "stack fault");
   AddSignal(17, "SIGCHLD", false, false, true, "child status has changed",
             "SIGCLD");
   AddSignal(18, "SIGCONT", false, true, true, "process continue");
   AddSignal(19, "SIGSTOP", true, true, true, "process stop");
   AddSignal(20, "SIGTSTP", false, true, true, "tty stop");
   AddSignal(21, "SIGTTIN", false, true, true, "background tty read");
   AddSignal(22, "SIGTTOU", false, true, true, "background tty write");
   AddSignal(23, "SIGURG", false, true, true, "urgent data on socket");
   AddSignal(24, "SIGXCPU", false, true, true, "CPU resource exceeded");
   AddSignal(25, "SIGXFSZ", false, true, true, "file size limit exceeded");
   AddSignal(26, "SIGVTALRM", false, true, true, "virtual time alarm");
   AddSignal(27, "SIGPROF", false, false, false, "profiling time alarm");
   AddSignal(28, "SIGWINCH", false, true, true, "window size changes");
   AddSignal(29, "SIGIO", false, true, true, "input/output ready/Pollable event",
             "SIGPOLL");
   AddSignal(30, "SIGPWR", false, true, true, "power failure");
   AddSignal(31, "SIGSYS", false, true, true, "invalid system call");
   AddSignal(32, "SIG32", false, false, false,
             "threading library internal signal 1");
   AddSignal(33, "SIG33", false, false, false,
             "threading library internal signal 2");
   AddSignal(34, "SIGRTMIN", false, false, false, "real time signal 0");
   AddSignal(35, "SIGRTMIN+1", false, false, false, "real time signal 1");
   AddSignal(36, "SIGRTMIN+2", false, false, false, "real time signal 2");
   AddSignal(37, "SIGRTMIN+3", false, false, false, "real time signal 3");
   AddSignal(38, "SIGRTMIN+4", false, false, false, "real time signal 4");
   AddSignal(39, "SIGRTMIN+5", false, false, false, "real time signal 5");
   AddSignal(40, "SIGRTMIN+6", false, false, false, "real time signal 6");
   AddSignal(41, "SIGRTMIN+7", false, false, false, "real time signal 7");
   AddSignal(42, "SIGRTMIN+8", false, false, false, "real time signal 8");
   AddSignal(43, "SIGRTMIN+9", false, false, false, "real time signal 9");
   AddSignal(44, "SIGRTMIN+10", false, false, false, "real time signal 10");
   AddSignal(45, "SIGRTMIN+11", false, false, false, "real time signal 11");
   AddSignal(46, "SIGRTMIN+12", false, false, false, "real time signal 12");
   AddSignal(47, "SIGRTMIN+13", false, false, false, "real time signal 13");
   AddSignal(48, "SIGRTMIN+14", false, false, false, "real time signal 14");
   AddSignal(49, "SIGRTMIN+15", false, false, false, "real time signal 15");
   AddSignal(50, "SIGRTMAX-14", false, false, false,
             "real time signal 16"); // switching to SIGRTMAX-xxx to match "kill
                                     // -l" output
   AddSignal(51, "SIGRTMAX-13", false, false, false, "real time signal 17");
   AddSignal(52, "SIGRTMAX-12", false, false, false, "real time signal 18");
   AddSignal(53, "SIGRTMAX-11", false, false, false, "real time signal 19");
   AddSignal(54, "SIGRTMAX-10", false, false, false, "real time signal 20");
   AddSignal(55, "SIGRTMAX-9", false, false, false, "real time signal 21");
   AddSignal(56, "SIGRTMAX-8", false, false, false, "real time signal 22");
   AddSignal(57, "SIGRTMAX-7", false, false, false, "real time signal 23");
   AddSignal(58, "SIGRTMAX-6", false, false, false, "real time signal 24");
   AddSignal(59, "SIGRTMAX-5", false, false, false, "real time signal 25");
   AddSignal(60, "SIGRTMAX-4", false, false, false, "real time signal 26");
   AddSignal(61, "SIGRTMAX-3", false, false, false, "real time signal 27");
   AddSignal(62, "SIGRTMAX-2", false, false, false, "real time signal 28");
   AddSignal(63, "SIGRTMAX-1", false, false, false, "real time signal 29");
   AddSignal(64, "SIGRTMAX", false, false, false, "real time signal 30");
 }

source/Plugins/Signals/Linux/MipsLinuxSignals.h

 //===-- MipsLinuxSignals.h ------------------------------------------*- C++
 //-*-===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
 #ifndef liblldb_MipsLinuxSignals_H_
 #define liblldb_MipsLinuxSignals_H_
 
 #include "lldb/Target/UnixSignals.h"
 
 namespace lldb_private {
 
 /// Linux specific set of Unix signals.
 class MipsLinuxSignals : public UnixSignals {
 public:
   MipsLinuxSignals();
 
 private:
   void Reset() override;
 };
 
 } // namespace lldb_private
 
 #endif // liblldb_MipsLinuxSignals_H_

source/Plugins/Signals/Linux/MipsLinuxSignals.cpp

 //===-- MipsLinuxSignals.cpp ----------------------------------------*- C++
 //-*-===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
 #include "MipsLinuxSignals.h"
 
 using namespace lldb_private;
 
 MipsLinuxSignals::MipsLinuxSignals() : UnixSignals() { Reset(); }
 
 void MipsLinuxSignals::Reset() {
   m_signals.clear();
   //        SIGNO  NAME            SUPPRESS STOP   NOTIFY DESCRIPTION ALIAS
   //        =====  ===========     ======== =====  ======
   //        ======================================   ========
   AddSignal(1, "SIGHUP", false, true, true, "hangup");
   AddSignal(2, "SIGINT", true, true, true, "interrupt");
   AddSignal(3, "SIGQUIT", false, true, true, "quit");
   AddSignal(4, "SIGILL", false, true, true, "illegal instruction");
   AddSignal(5, "SIGTRAP", true, true, true,
             "trace trap (not reset when caught)");
   AddSignal(6, "SIGABRT", false, true, true, "abort()/IOT trap", "SIGIOT");
   AddSignal(7, "SIGEMT", false, true, true, "terminate process with core dump");
   AddSignal(8, "SIGFPE", false, true, true, "floating point exception");
   AddSignal(9, "SIGKILL", false, true, true, "kill");
   AddSignal(10, "SIGBUS", false, true, true, "bus error");
   AddSignal(11, "SIGSEGV", false, true, true, "segmentation violation");
   AddSignal(12, "SIGSYS", false, true, true, "invalid system call");
   AddSignal(13, "SIGPIPE", false, true, true,
             "write to pipe with reading end closed");
   AddSignal(14, "SIGALRM", false, false, false, "alarm");
   AddSignal(15, "SIGTERM", false, true, true, "termination requested");
   AddSignal(16, "SIGUSR1", false, true, true, "user defined signal 1");
   AddSignal(17, "SIGUSR2", false, true, true, "user defined signal 2");
   AddSignal(18, "SIGCHLD", false, false, true, "child status has changed",
             "SIGCLD");
   AddSignal(19, "SIGPWR", false, true, true, "power failure");
   AddSignal(20, "SIGWINCH", false, true, true, "window size changes");
   AddSignal(21, "SIGURG", false, true, true, "urgent data on socket");
   AddSignal(22, "SIGIO", false, true, true, "input/output ready/Pollable event",
             "SIGPOLL");
   AddSignal(23, "SIGSTOP", true, true, true, "process stop");
   AddSignal(24, "SIGTSTP", false, true, true, "tty stop");
   AddSignal(25, "SIGCONT", false, true, true, "process continue");
   AddSignal(26, "SIGTTIN", false, true, true, "background tty read");
   AddSignal(27, "SIGTTOU", false, true, true, "background tty write");
   AddSignal(28, "SIGVTALRM", false, true, true, "virtual time alarm");
   AddSignal(29, "SIGPROF", false, false, false, "profiling time alarm");
   AddSignal(30, "SIGXCPU", false, true, true, "CPU resource exceeded");
   AddSignal(31, "SIGXFSZ", false, true, true, "file size limit exceeded");
   AddSignal(32, "SIG32", false, false, false,
             "threading library internal signal 1");
   AddSignal(33, "SIG33", false, false, false,
             "threading library internal signal 2");
   AddSignal(34, "SIGRTMIN", false, false, false, "real time signal 0");
   AddSignal(35, "SIGRTMIN+1", false, false, false, "real time signal 1");
   AddSignal(36, "SIGRTMIN+2", false, false, false, "real time signal 2");
   AddSignal(37, "SIGRTMIN+3", false, false, false, "real time signal 3");
   AddSignal(38, "SIGRTMIN+4", false, false, false, "real time signal 4");
   AddSignal(39, "SIGRTMIN+5", false, false, false, "real time signal 5");
   AddSignal(40, "SIGRTMIN+6", false, false, false, "real time signal 6");
   AddSignal(41, "SIGRTMIN+7", false, false, false, "real time signal 7");
   AddSignal(42, "SIGRTMIN+8", false, false, false, "real time signal 8");
   AddSignal(43, "SIGRTMIN+9", false, false, false, "real time signal 9");
   AddSignal(44, "SIGRTMIN+10", false, false, false, "real time signal 10");
   AddSignal(45, "SIGRTMIN+11", false, false, false, "real time signal 11");
   AddSignal(46, "SIGRTMIN+12", false, false, false, "real time signal 12");
   AddSignal(47, "SIGRTMIN+13", false, false, false, "real time signal 13");
   AddSignal(48, "SIGRTMIN+14", false, false, false, "real time signal 14");
   AddSignal(49, "SIGRTMIN+15", false, false, false, "real time signal 15");
   AddSignal(50, "SIGRTMAX-14", false, false, false,
             "real time signal 16"); // switching to SIGRTMAX-xxx to match "kill
                                     // -l" output
   AddSignal(51, "SIGRTMAX-13", false, false, false, "real time signal 17");
   AddSignal(52, "SIGRTMAX-12", false, false, false, "real time signal 18");
   AddSignal(53, "SIGRTMAX-11", false, false, false, "real time signal 19");
   AddSignal(54, "SIGRTMAX-10", false, false, false, "real time signal 20");
   AddSignal(55, "SIGRTMAX-9", false, false, false, "real time signal 21");
   AddSignal(56, "SIGRTMAX-8", false, false, false, "real time signal 22");
   AddSignal(57, "SIGRTMAX-7", false, false, false, "real time signal 23");
   AddSignal(58, "SIGRTMAX-6", false, false, false, "real time signal 24");
   AddSignal(59, "SIGRTMAX-5", false, false, false, "real time signal 25");
   AddSignal(60, "SIGRTMAX-4", false, false, false, "real time signal 26");
   AddSignal(61, "SIGRTMAX-3", false, false, false, "real time signal 27");
   AddSignal(62, "SIGRTMAX-2", false, false, false, "real time signal 28");
   AddSignal(63, "SIGRTMAX-1", false, false, false, "real time signal 29");
   AddSignal(64, "SIGRTMAX", false, false, false, "real time signal 30");
 }

source/Plugins/Signals/NetBSD/CMakeLists.txt

+add_lldb_library(lldbPluginSignalsNetBSD PLUGIN
+  NetBSDSignals.cpp
+
+  LINK_LIBS
+    lldbTarget
+)

source/Plugins/Signals/NetBSD/NetBSDSignals.h

 //===-- NetBSDSignals.h ----------------------------------------*- C++ -*-===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
 #ifndef liblldb_NetBSDSignals_H_
 #define liblldb_NetBSDSignals_H_
 
 #include "lldb/Target/UnixSignals.h"
 
 namespace lldb_private {
 
 /// NetBSD specific set of Unix signals.
 class NetBSDSignals : public UnixSignals {
 public:
   NetBSDSignals();
 
 private:
   void Reset() override;
 };
 
 } // namespace lldb_private
 
 #endif // liblldb_NetBSDSignals_H_

source/Plugins/Signals/NetBSD/NetBSDSignals.cpp

 //===-- NetBSDSignals.cpp --------------------------------------*- C++ -*-===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
 #include "NetBSDSignals.h"
 
 using namespace lldb_private;
 
 NetBSDSignals::NetBSDSignals() : UnixSignals() { Reset(); }
 
 void NetBSDSignals::Reset() {
   UnixSignals::Reset();
   //        SIGNO  NAME          SUPPRESS STOP   NOTIFY DESCRIPTION
   //        ====== ============  ======== ====== ======
   //        ===================================================
   AddSignal(32, "SIGPWR", false, true, true,
             "power fail/restart (not reset when caught)");
   AddSignal(33, "SIGRTMIN", false, false, false, "real time signal 0");
   AddSignal(34, "SIGRTMIN+1", false, false, false, "real time signal 1");
   AddSignal(35, "SIGRTMIN+2", false, false, false, "real time signal 2");
   AddSignal(36, "SIGRTMIN+3", false, false, false, "real time signal 3");
   AddSignal(37, "SIGRTMIN+4", false, false, false, "real time signal 4");
   AddSignal(38, "SIGRTMIN+5", false, false, false, "real time signal 5");
   AddSignal(39, "SIGRTMIN+6", false, false, false, "real time signal 6");
   AddSignal(40, "SIGRTMIN+7", false, false, false, "real time signal 7");
   AddSignal(41, "SIGRTMIN+8", false, false, false, "real time signal 8");
   AddSignal(42, "SIGRTMIN+9", false, false, false, "real time signal 9");
   AddSignal(43, "SIGRTMIN+10", false, false, false, "real time signal 10");
   AddSignal(44, "SIGRTMIN+11", false, false, false, "real time signal 11");
   AddSignal(45, "SIGRTMIN+12", false, false, false, "real time signal 12");
   AddSignal(46, "SIGRTMIN+13", false, false, false, "real time signal 13");
   AddSignal(47, "SIGRTMIN+14", false, false, false, "real time signal 14");
   AddSignal(48, "SIGRTMIN+15", false, false, false, "real time signal 15");
   AddSignal(49, "SIGRTMIN-14", false, false, false, "real time signal 16");
   AddSignal(50, "SIGRTMAX-13", false, false, false, "real time signal 17");
   AddSignal(51, "SIGRTMAX-12", false, false, false, "real time signal 18");
   AddSignal(52, "SIGRTMAX-11", false, false, false, "real time signal 19");
   AddSignal(53, "SIGRTMAX-10", false, false, false, "real time signal 20");
   AddSignal(54, "SIGRTMAX-9", false, false, false, "real time signal 21");
   AddSignal(55, "SIGRTMAX-8", false, false, false, "real time signal 22");
   AddSignal(56, "SIGRTMAX-7", false, false, false, "real time signal 23");
   AddSignal(57, "SIGRTMAX-6", false, false, false, "real time signal 24");
   AddSignal(58, "SIGRTMAX-5", false, false, false, "real time signal 25");
   AddSignal(59, "SIGRTMAX-4", false, false, false, "real time signal 26");
   AddSignal(60, "SIGRTMAX-3", false, false, false, "real time signal 27");
   AddSignal(61, "SIGRTMAX-2", false, false, false, "real time signal 28");
   AddSignal(62, "SIGRTMAX-1", false, false, false, "real time signal 29");
   AddSignal(63, "SIGRTMAX", false, false, false, "real time signal 30");
 }

source/Target/CMakeLists.txt

LINK_LIBS
     lldbCore
     lldbExpression
     lldbHost
     lldbInterpreter
     lldbSymbol
     lldbUtility
     lldbPluginExpressionParserClang
     lldbPluginProcessUtility
+    lldbPluginSignalsFreeBSD
+    lldbPluginSignalsLinux
+    lldbPluginSignalsNetBSD
 
   LINK_COMPONENTS
     Support
   )

source/Target/UnixSignals.cpp

 //===-- UnixSignals.cpp -----------------------------------------*- C++ -*-===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
 #include "lldb/Target/UnixSignals.h"
-#include "Plugins/Process/Utility/FreeBSDSignals.h"
-#include "Plugins/Process/Utility/LinuxSignals.h"
-#include "Plugins/Process/Utility/MipsLinuxSignals.h"
-#include "Plugins/Process/Utility/NetBSDSignals.h"
+#include "Plugins/Signals/FreeBSD/FreeBSDSignals.h"
+#include "Plugins/Signals/Linux/LinuxSignals.h"
+#include "Plugins/Signals/Linux/MipsLinuxSignals.h"
+#include "Plugins/Signals/NetBSD/NetBSDSignals.h"
 #include "lldb/Host/HostInfo.h"
 #include "lldb/Host/StringConvert.h"
 #include "lldb/Utility/ArchSpec.h"
 
 using namespace lldb_private;
 
 UnixSignals::Signal::Signal(const char *name, bool default_suppress,
                             bool default_stop, bool default_notify,