- User Since
- Jun 19 2015, 4:53 AM (192 w, 1 d)
Thu, Feb 21
Sorry I didn't spot this earlier, but in future please ensure 'llvm-commits' is one of the subscribers when creating a review request for LLVM. If you add it after creating a review request, manually add it and write something in the comments field to trigger Phabricator into sending an email or abandon the review request and re-open it with the relevant -commits list as an initial subscriber.
LGTM apart from some minor nits. Please address them before committing.
Wed, Feb 13
Jan 18 2019
Dec 19 2018
I can't find rationale behind the MIPS discrepancy in the original commit. I can add the if branch back if you tell me why...
Oct 29 2018
LGTM. Just remember to upload the patches with context.
Oct 22 2018
Sep 10 2018
Aug 30 2018
Jul 6 2018
Jun 27 2018
Jun 22 2018
Jun 21 2018
Jun 20 2018
Jun 19 2018
Looking at this again and with trunk, I'm seeing two failing tests with a small change inlined:
Added tests, and corrected the definition of the rdhwr instruction.
Jun 18 2018
Jun 15 2018
Jun 14 2018
Jun 13 2018
Actually include the expansion pass.
Moved pass to after the scheduler and machine block placement.
Normalized the probabilities for the successors of modified basic blocks for sanity purposes.
Jun 12 2018
Modify implementation to produce a function attribute.
Jun 11 2018
LGTM with nit addressed.
Rebase to master.
In D48006, you can see the change for the MIPS specific assembly scrubbing to accept inline assembly. I have also included some example output of the changes of that revision. Since the blank lines around the inline assembly are not scrubbed, FileCheck fails the test case with:
Jun 9 2018
Jun 8 2018
Please rebase this.
Actually add some tests.
Edit the summary so that rather that it says:
Jun 7 2018
Jun 6 2018
The legalization of unsigned i128 addition (rL334094 for the test) looks strange to me in that the determination of the overflow from the first addition is done with setccs. They appear to be originating from the expansion of setcc of an illegal type.
This particular case is not quite testable, as GPR64s are only available when we have 64 bit registers. Adding GPR_64 predicates to these instructions is somewhat overkill, but does simplify fixing up the scheduler models later.
Jun 5 2018
Jun 4 2018
I take it that this patch is dependent on D47703 ?