sdardis (Simon Dardis)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 19 2015, 4:53 AM (126 w, 4 d)

Recent Activity

Today

sdardis accepted D40316: [mips] Set microMIPS ASE flag.

LGTM with inline nits addressed.

Wed, Nov 22, 2:57 AM

Yesterday

sdardis created D40314: [mips] Use the delay slot filler to convert branches for microMIPSR6..
Tue, Nov 21, 9:22 AM
sdardis added a comment to D35625: Removal of microMIPS64R6.

covers the parseSetArchDirective case.

Tue, Nov 21, 8:16 AM

Mon, Nov 20

sdardis created D40268: [utils, mips] Add support for mips for update_llc_checks.py.
Mon, Nov 20, 1:48 PM
sdardis committed rL318657: [mips] Reorder target specific passes.
[mips] Reorder target specific passes
Mon, Nov 20, 8:00 AM

Sat, Nov 18

sdardis updated the diff for D40193: [DAGCombine] Disable finding better chains for stores at O0.

Updating for review comments.

Sat, Nov 18, 3:12 PM

Fri, Nov 17

sdardis created D40193: [DAGCombine] Disable finding better chains for stores at O0.
Fri, Nov 17, 1:22 PM

Thu, Nov 16

sdardis added a reviewer for D6229: [mips][microMIPS] Use swm32/lwm32 instructions in function prologue/epilogue: sdardis.
Thu, Nov 16, 4:37 AM
sdardis added a comment to D38110: [libunwind][MIPS]: Add support for unwinding in O32 and N64 processes..

@compnerd, ping?

Thu, Nov 16, 3:05 AM
sdardis committed rL318389: [mips][mt] Add missing test cases from r318207.
[mips][mt] Add missing test cases from r318207
Thu, Nov 16, 2:50 AM
sdardis committed rL318386: Merging r318207:.
Merging r318207:
Thu, Nov 16, 2:14 AM

Wed, Nov 15

sdardis added a comment to D40023: [RISCV] Implement ABI lowering.

Mips is the only other implementer of shouldSignExtUnsignedType but is unaffected, as unlike classifyArgumentType, classifyReturnType will not extend i32 values (@sdardis: is this a bug?).

Wed, Nov 15, 7:59 AM
sdardis updated the diff for D39841: [CodeGenPrepare] Check that erased sunken address are not reused.

Address the failures on the sanitizer bots by reworking SunkAddrs in a <Value*, WeakTrackingVH*> map, so that if a computation is erased, the end value is not read after deletion to see if it is still live.

Wed, Nov 15, 4:28 AM

Tue, Nov 14

sdardis committed rL318207: Reland "[mips][mt][6/7] Add support for mftr, mttr instructions.".
Reland "[mips][mt][6/7] Add support for mftr, mttr instructions."
Tue, Nov 14, 2:27 PM
sdardis committed rL318172: [mips] Simplify test for 5.0.1 (NFC).
[mips] Simplify test for 5.0.1 (NFC)
Tue, Nov 14, 11:11 AM
sdardis added a comment to D35625: Removal of microMIPS64R6.

You've missed my comment:

Tue, Nov 14, 3:06 AM
sdardis reopened D39841: [CodeGenPrepare] Check that erased sunken address are not reused.

Reopening this as some changes were required to pacify some buildbots.

Tue, Nov 14, 1:47 AM

Mon, Nov 13

sdardis committed rL318049: Revert "[CodeGenPrepare] Check that erased sunken address are not reused".
Revert "[CodeGenPrepare] Check that erased sunken address are not reused"
Mon, Nov 13, 8:44 AM
sdardis committed rL318032: [CodeGenPrepare] Check that erased sunken address are not reused.
[CodeGenPrepare] Check that erased sunken address are not reused
Mon, Nov 13, 3:47 AM
sdardis closed D39841: [CodeGenPrepare] Check that erased sunken address are not reused by committing rL318032: [CodeGenPrepare] Check that erased sunken address are not reused.
Mon, Nov 13, 3:47 AM
sdardis updated the summary of D39841: [CodeGenPrepare] Check that erased sunken address are not reused.
Mon, Nov 13, 3:14 AM

Fri, Nov 10

sdardis updated the diff for D39841: [CodeGenPrepare] Check that erased sunken address are not reused.

Address review comments.

Fri, Nov 10, 5:46 AM

Thu, Nov 9

sdardis committed rL317801: [mips] Correct microMIP's jump and add unconditional branch pseudo.
[mips] Correct microMIP's jump and add unconditional branch pseudo
Thu, Nov 9, 8:02 AM
sdardis closed D39741: [mips] Correct microMIP's jump and add unconditional branch pseudo by committing rL317801: [mips] Correct microMIP's jump and add unconditional branch pseudo.
Thu, Nov 9, 8:02 AM
sdardis created D39841: [CodeGenPrepare] Check that erased sunken address are not reused.
Thu, Nov 9, 6:15 AM

Wed, Nov 8

sdardis committed rL317681: [mips] Guard indirect and tailcall pseudo instructions correctly..
[mips] Guard indirect and tailcall pseudo instructions correctly.
Wed, Nov 8, 3:14 AM
sdardis closed D39723: [mips] Guard indirect and tailcall pseudo instructions correctly. by committing rL317681: [mips] Guard indirect and tailcall pseudo instructions correctly..
Wed, Nov 8, 3:14 AM

Tue, Nov 7

sdardis created D39741: [mips] Correct microMIP's jump and add unconditional branch pseudo.
Tue, Nov 7, 9:26 AM
sdardis created D39723: [mips] Guard indirect and tailcall pseudo instructions correctly..
Tue, Nov 7, 2:24 AM

Mon, Nov 6

sdardis committed rL317523: [Support][Chrono] Use explicit cast of text output of time values..
[Support][Chrono] Use explicit cast of text output of time values.
Mon, Nov 6, 3:02 PM
sdardis closed D39597: [Support][Chrono] Use explicit cast of text output of time values. by committing rL317523: [Support][Chrono] Use explicit cast of text output of time values..
Mon, Nov 6, 3:02 PM
sdardis committed rL317507: [zorg] Update my email address.
[zorg] Update my email address
Mon, Nov 6, 1:03 PM
sdardis committed rL317475: [mips] Add movep for microMIPS32R6 and fix microMIPS32r3 version.
[mips] Add movep for microMIPS32R6 and fix microMIPS32r3 version
Mon, Nov 6, 5:00 AM
sdardis closed D39495: [mips] Add movep for microMIPS32R6 and fix microMIPS32r3 version by committing rL317475: [mips] Add movep for microMIPS32R6 and fix microMIPS32r3 version.
Mon, Nov 6, 5:00 AM
sdardis committed rL317470: [mips] Fix PR35140.
[mips] Fix PR35140
Mon, Nov 6, 2:50 AM
sdardis closed D39591: [mips] Fix PR35140 by committing rL317470: [mips] Fix PR35140.
Mon, Nov 6, 2:50 AM

Fri, Nov 3

sdardis committed rL317331: [mips] Match 'ins' and its' variants with C++ code.
[mips] Match 'ins' and its' variants with C++ code
Fri, Nov 3, 8:36 AM
sdardis closed D39117: [mips] Match 'ins' and its' variants with C++ code by committing rL317331: [mips] Match 'ins' and its' variants with C++ code.
Fri, Nov 3, 8:35 AM
sdardis created D39597: [Support][Chrono] Use explicit cast of text output of time values..
Fri, Nov 3, 7:19 AM
sdardis updated the summary of D39591: [mips] Fix PR35140.
Fri, Nov 3, 4:01 AM
sdardis created D39591: [mips] Fix PR35140.
Fri, Nov 3, 4:01 AM

Thu, Nov 2

sdardis committed rL317204: [mips] Use register scavenging with MSA..
[mips] Use register scavenging with MSA.
Thu, Nov 2, 5:48 AM
sdardis closed D39056: [mips] Use register scavenging with MSA. by committing rL317204: [mips] Use register scavenging with MSA..
Thu, Nov 2, 5:47 AM
sdardis added inline comments to D39117: [mips] Match 'ins' and its' variants with C++ code.
Thu, Nov 2, 4:02 AM
sdardis updated the diff for D39117: [mips] Match 'ins' and its' variants with C++ code.

Address review comments.

Thu, Nov 2, 4:01 AM

Wed, Nov 1

sdardis created D39495: [mips] Add movep for microMIPS32R6 and fix microMIPS32r3 version.
Wed, Nov 1, 9:33 AM

Tue, Oct 31

sdardis updated the diff for D39056: [mips] Use register scavenging with MSA..

Update before commit.

Tue, Oct 31, 2:57 AM

Thu, Oct 26

sdardis added inline comments to D39056: [mips] Use register scavenging with MSA..
Thu, Oct 26, 8:53 AM
sdardis added a comment to D39123: [mips] Fix (dis)assembly of abs.fmt for micromips.

Thanks for the review.

Thu, Oct 26, 4:38 AM
sdardis committed rL316656: [mips] Fix (dis)assembly of abs.fmt for micromips.
[mips] Fix (dis)assembly of abs.fmt for micromips
Thu, Oct 26, 4:37 AM
sdardis closed D39123: [mips] Fix (dis)assembly of abs.fmt for micromips by committing rL316656: [mips] Fix (dis)assembly of abs.fmt for micromips.
Thu, Oct 26, 4:37 AM
sdardis committed rL316654: [mips] Fix PR35071.
[mips] Fix PR35071
Thu, Oct 26, 3:59 AM
sdardis closed D39288: [mips] Fix PR35071 by committing rL316654: [mips] Fix PR35071.
Thu, Oct 26, 3:59 AM
sdardis updated the summary of D39288: [mips] Fix PR35071.
Thu, Oct 26, 3:58 AM
sdardis updated the summary of D39288: [mips] Fix PR35071.
Thu, Oct 26, 3:56 AM
sdardis updated the diff for D39056: [mips] Use register scavenging with MSA..

Update the mechanism for estimating the size of the stack.

Thu, Oct 26, 3:52 AM
sdardis committed rL316651: Update my email addresses, NFC..
Update my email addresses, NFC.
Thu, Oct 26, 3:17 AM

Wed, Oct 25

sdardis added inline comments to D39056: [mips] Use register scavenging with MSA..
Wed, Oct 25, 8:01 AM
sdardis created D39288: [mips] Fix PR35071.
Wed, Oct 25, 7:10 AM
sdardis committed rL316575: [mips] Clean up some whitespace (NFC)..
[mips] Clean up some whitespace (NFC).
Wed, Oct 25, 6:36 AM

Tue, Oct 24

sdardis updated the summary of D39056: [mips] Use register scavenging with MSA..
Tue, Oct 24, 8:17 AM
sdardis added a comment to D35625: Removal of microMIPS64R6.

I missed the AsmParser in my last reviews, can you add checks there, in the initialisation, in parseSetArchDirective and parseDirectiveSet?

Tue, Oct 24, 6:52 AM
sdardis added inline comments to D39074: [libunwind][MIPS]: Add support for unwinding in N32 processes..
Tue, Oct 24, 4:22 AM
sdardis updated the diff for D39117: [mips] Match 'ins' and its' variants with C++ code.

Address review comments.

Tue, Oct 24, 4:06 AM
sdardis added inline comments to D39117: [mips] Match 'ins' and its' variants with C++ code.
Tue, Oct 24, 4:06 AM

Oct 20 2017

sdardis created D39123: [mips] Fix (dis)assembly of abs.fmt for micromips.
Oct 20 2017, 6:51 AM
sdardis added inline comments to D39062: [MIPS] Don't assert when attempting to expand ld/sd macro with symbol reference.
Oct 20 2017, 6:40 AM
sdardis created D39117: [mips] Match 'ins' and its' variants with C++ code.
Oct 20 2017, 3:13 AM

Oct 19 2017

sdardis added inline comments to D39101: [RISCV 11.5/n] Codegen support for materializing constants.
Oct 19 2017, 11:21 AM
sdardis added inline comments to D39101: [RISCV 11.5/n] Codegen support for materializing constants.
Oct 19 2017, 10:54 AM
sdardis added inline comments to D39062: [MIPS] Don't assert when attempting to expand ld/sd macro with symbol reference.
Oct 19 2017, 5:07 AM

Oct 18 2017

sdardis committed rL316084: [mips] Fix analyzeBranch to handle debug data.
[mips] Fix analyzeBranch to handle debug data
Oct 18 2017, 7:35 AM
sdardis closed D39003: [mips] Fix analyzeBranch to handle debug data by committing rL316084: [mips] Fix analyzeBranch to handle debug data.
Oct 18 2017, 7:35 AM
sdardis created D39056: [mips] Use register scavenging with MSA..
Oct 18 2017, 7:12 AM
sdardis committed rL316081: [mips] Move test to correct directory. NFCI.
[mips] Move test to correct directory. NFCI
Oct 18 2017, 7:00 AM
sdardis accepted D38314: [mips] Adds support for R_MIPS_26, HIGHER, HIGHEST relocations in RuntimeDyld.

LGTM with inline nits addressed.

Oct 18 2017, 3:08 AM

Oct 17 2017

sdardis created D39003: [mips] Fix analyzeBranch to handle debug data.
Oct 17 2017, 8:03 AM

Oct 16 2017

sdardis updated subscribers of D35983: [mips] Introducing option -mabs=[legacy/2008].

+CCing the llvm-commits.

Oct 16 2017, 7:53 AM
sdardis added a reviewer for D38110: [libunwind][MIPS]: Add support for unwinding in O32 and N64 processes.: compnerd.

Two last inlined comments and I think that's everything. @compnerd Have I missed anything?

Oct 16 2017, 7:36 AM
sdardis committed rL315905: [mips][micromips] Fix (dis)assembly of bc1(t|f).
[mips][micromips] Fix (dis)assembly of bc1(t|f)
Oct 16 2017, 7:20 AM
sdardis closed D38847: [mips][micromips] Fix (dis)assembly of bc1(t|f) by committing rL315905: [mips][micromips] Fix (dis)assembly of bc1(t|f).
Oct 16 2017, 7:20 AM
sdardis accepted D38841: [mips] Provide alternate predicates for constant synthesis.

LGTM with inline nits addressed.

Oct 16 2017, 4:27 AM

Oct 13 2017

sdardis requested changes to D38110: [libunwind][MIPS]: Add support for unwinding in O32 and N64 processes..

Marking this as changes required to clear up my review queue - no further comments.

Oct 13 2017, 6:11 AM
sdardis requested changes to D35625: Removal of microMIPS64R6.

Probably my last round of comments on this, also can you add a trivial test case showing that microMIPS64R6 is not supported?

Oct 13 2017, 6:05 AM

Oct 12 2017

sdardis created D38847: [mips][micromips] Fix (dis)assembly of bc1(t|f).
Oct 12 2017, 8:35 AM
sdardis added a comment to D38110: [libunwind][MIPS]: Add support for unwinding in O32 and N64 processes..

I have tested this on one of my machines after removing the checks for soft float (my debian install doesn't have the necessary headers for soft-float). With the patch you've pointed out and my inline comments addressed (bar the HI / LO register comments), it passes the supplied test suite.

Oct 12 2017, 8:24 AM
sdardis added a comment to D35983: [mips] Introducing option -mabs=[legacy/2008].

The root of the problem is that many of the microMIPS FPU instructions are marked as isCodeGenOnly, which means that they aren't in the assembler matching table or disassembler table. This means that although the microMIPS32R6 definitions are used, we can't match them as those definitions have differing feature bits to what the invocation of llvm-mc has in that test. I've got a WIP patch to being addressing this. Hold off on trying to get this patch in for the moment.

Oct 12 2017, 8:07 AM
sdardis added a comment to D38841: [mips] Provide alternate predicates for constant synthesis.

Some quick inlined comments.

Oct 12 2017, 3:55 AM
sdardis added a comment to D37484: [libunwind] Always use unwind tables in tests.

I can report that this patch clears two test failures for MIPS when D38110 is applied.

Oct 12 2017, 2:23 AM

Oct 11 2017

sdardis committed rL315454: [mips] Add missing tests from rL315451.
[mips] Add missing tests from rL315451
Oct 11 2017, 4:45 AM
sdardis committed rL315451: [mips] Add support for parsing target specific flags for MIR.
[mips] Add support for parsing target specific flags for MIR
Oct 11 2017, 4:11 AM
sdardis closed D38620: [mips] Add support for parsing target specific flags for MIR by committing rL315451: [mips] Add support for parsing target specific flags for MIR.
Oct 11 2017, 4:11 AM
sdardis accepted D35983: [mips] Introducing option -mabs=[legacy/2008].

LGTM as rL315362 should fix the register allocation issue.

Oct 11 2017, 3:31 AM
sdardis committed rL315447: [llvm-rc] Fix spelling in message.
[llvm-rc] Fix spelling in message
Oct 11 2017, 3:14 AM

Oct 10 2017

sdardis committed rL315362: [mips] Correct the instruction predicates for microMIPSr3.
[mips] Correct the instruction predicates for microMIPSr3
Oct 10 2017, 1:53 PM
sdardis closed D38451: [mips] Correct the instruction predicates for microMIPSr3 by committing rL315362: [mips] Correct the instruction predicates for microMIPSr3.
Oct 10 2017, 1:53 PM
sdardis added a comment to D38110: [libunwind][MIPS]: Add support for unwinding in O32 and N64 processes..

Thanks for the pointer to that patch, I'll take a look tomorrow.

Oct 10 2017, 12:41 PM
sdardis committed rL315318: [mips] Duplicate the reciprocal instruction definitions for FP32.
[mips] Duplicate the reciprocal instruction definitions for FP32
Oct 10 2017, 7:41 AM
sdardis closed D38400: [mips] Duplicate the reciprocal instruction definitions for FP32 by committing rL315318: [mips] Duplicate the reciprocal instruction definitions for FP32.
Oct 10 2017, 7:41 AM
sdardis committed rL315310: [mips] Partially fix PR34391.
[mips] Partially fix PR34391
Oct 10 2017, 6:34 AM