Page MenuHomePhabricator

sdardis (Simon Dardis)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 19 2015, 4:53 AM (366 w, 2 d)

Recent Activity

May 15 2022

sdardis accepted D124979: [DivRemPairs][Mips] Pre-commit test for Mips target.

LGTM.

May 15 2022, 4:09 PM · Restricted Project, Restricted Project
sdardis accepted D124980: [Mips] Implement hasDivRemOp().

Nit: the summary should have the line--"This resolves PR/54991" to aid in bug tracking.

May 15 2022, 1:22 PM · Restricted Project, Restricted Project

May 12 2022

sdardis added a comment to D124723: [MIPS} Address ISel failures for 64 bit fpus in microMIPS.

Thanks for the review, @atanasyan . I went with changing the regexes back to the style in the existing file.

May 12 2022, 3:40 PM · Restricted Project, Restricted Project
sdardis committed rGe82e4fa7ef71: [MIPS} Address ISel failures for 64 bit fpus in microMIPS (authored by sdardis).
[MIPS} Address ISel failures for 64 bit fpus in microMIPS
May 12 2022, 3:36 PM · Restricted Project, Restricted Project
sdardis closed D124723: [MIPS} Address ISel failures for 64 bit fpus in microMIPS.
May 12 2022, 3:36 PM · Restricted Project, Restricted Project
sdardis added a comment to D124742: [MIPS] Correct the implementation of the msub optimization.

Thanks for the review.

May 12 2022, 2:34 PM · Restricted Project, Restricted Project
sdardis committed rGa35add4c54be: [MIPS] Correct the implementation of the msub optimization (authored by sdardis).
[MIPS] Correct the implementation of the msub optimization
May 12 2022, 2:33 PM · Restricted Project, Restricted Project
sdardis closed D124742: [MIPS] Correct the implementation of the msub optimization.
May 12 2022, 2:33 PM · Restricted Project, Restricted Project

May 11 2022

sdardis committed rGba1c70c69db8: [MIPS] Remove an incorrect microMIPS instruction alias (authored by sdardis).
[MIPS] Remove an incorrect microMIPS instruction alias
May 11 2022, 3:46 PM · Restricted Project, Restricted Project
sdardis closed D124716: [MIPS] Remove an incorrect microMIPS instruction alias.
May 11 2022, 3:46 PM · Restricted Project, Restricted Project

May 10 2022

sdardis added a comment to D124716: [MIPS] Remove an incorrect microMIPS instruction alias.

Thanks for the review, I'll try to get this committed in the next few days.

May 10 2022, 6:43 AM · Restricted Project, Restricted Project
sdardis added inline comments to D124723: [MIPS} Address ISel failures for 64 bit fpus in microMIPS.
May 10 2022, 6:25 AM · Restricted Project, Restricted Project

May 1 2022

sdardis added reviewers for D124742: [MIPS] Correct the implementation of the msub optimization: atanasyan, arichardson, theraven, djtodoro.
May 1 2022, 1:07 PM · Restricted Project, Restricted Project
sdardis requested review of D124742: [MIPS] Correct the implementation of the msub optimization.
May 1 2022, 1:06 PM · Restricted Project, Restricted Project

Apr 30 2022

sdardis added reviewers for D124723: [MIPS} Address ISel failures for 64 bit fpus in microMIPS: atanasyan, djtodoro, arichardson.
Apr 30 2022, 5:22 PM · Restricted Project, Restricted Project
sdardis updated the diff for D124723: [MIPS} Address ISel failures for 64 bit fpus in microMIPS.

NFC: Remove some extraneous test lines and a small grammar correction

Apr 30 2022, 5:21 PM · Restricted Project, Restricted Project
sdardis requested review of D124723: [MIPS} Address ISel failures for 64 bit fpus in microMIPS.
Apr 30 2022, 5:12 PM · Restricted Project, Restricted Project
sdardis added reviewers for D124716: [MIPS] Remove an incorrect microMIPS instruction alias: atanasyan, arichardson, djtodoro.
Apr 30 2022, 11:52 AM · Restricted Project, Restricted Project
sdardis requested review of D124716: [MIPS] Remove an incorrect microMIPS instruction alias.
Apr 30 2022, 10:58 AM · Restricted Project, Restricted Project

Apr 29 2022

sdardis added a comment to D124651: [MIPS] Address instruction selection failure for abs.[sd].

Thanks for the review, I've updated the bug number in the commit message.

Apr 29 2022, 3:29 PM · Restricted Project, Restricted Project
sdardis committed rG938ed8ae99f9: [MIPS] Address instruction selection failure for abs.[sd] (authored by sdardis).
[MIPS] Address instruction selection failure for abs.[sd]
Apr 29 2022, 3:28 PM · Restricted Project, Restricted Project
sdardis closed D124651: [MIPS] Address instruction selection failure for abs.[sd].
Apr 29 2022, 3:28 PM · Restricted Project, Restricted Project

Apr 28 2022

sdardis added reviewers for D124651: [MIPS] Address instruction selection failure for abs.[sd]: atanasyan, djtodoro, theraven, arichardson.
Apr 28 2022, 5:45 PM · Restricted Project, Restricted Project
sdardis requested review of D124651: [MIPS] Address instruction selection failure for abs.[sd].
Apr 28 2022, 5:39 PM · Restricted Project, Restricted Project

Apr 24 2022

sdardis accepted D123577: [MIPS][SelectionDAG] Enable TargetLowering::hasBitTest for masks that fit in ANDI..

LGTM.

Apr 24 2022, 10:49 AM · Restricted Project, Restricted Project

Apr 18 2022

sdardis added inline comments to D123577: [MIPS][SelectionDAG] Enable TargetLowering::hasBitTest for masks that fit in ANDI..
Apr 18 2022, 4:56 PM · Restricted Project, Restricted Project

Apr 15 2022

sdardis added inline comments to D123764: [llvm-objdump] Implemented PrintBranchImmAsAddress for MIPS.
Apr 15 2022, 4:01 PM · Restricted Project, Restricted Project

Apr 13 2022

sdardis accepted D123505: Mips/GlobalISel: Add stub post-legalizer combiner.

LGTM with the nit addressed.

Apr 13 2022, 2:48 PM · Restricted Project, Restricted Project

Apr 12 2022

sdardis added a reviewer for D123577: [MIPS][SelectionDAG] Enable TargetLowering::hasBitTest for masks that fit in ANDI.: sdardis.
Apr 12 2022, 7:15 PM · Restricted Project, Restricted Project

Apr 11 2022

sdardis accepted D123504: Mips/GlobalISel: Add test for atomic load.

LGTM.

Apr 11 2022, 5:20 PM · Restricted Project, Restricted Project

Apr 6 2022

sdardis added a comment to D122427: [MIPS] Initial support for MIPS-I load delay slots.

Thank you for the patch.

Apr 6 2022, 5:28 PM · Restricted Project, Restricted Project
sdardis committed rG303c180199b7: [MIPS] Initial support for MIPS-I load delay slots (authored by sdardis).
[MIPS] Initial support for MIPS-I load delay slots
Apr 6 2022, 5:04 PM · Restricted Project, Restricted Project
sdardis closed D122427: [MIPS] Initial support for MIPS-I load delay slots.
Apr 6 2022, 5:04 PM · Restricted Project, Restricted Project
sdardis committed rG8e1d9f003289: [mips] Remove stale comment (NFC) (authored by sdardis).
[mips] Remove stale comment (NFC)
Apr 6 2022, 4:01 PM · Restricted Project, Restricted Project

Apr 5 2022

sdardis added a comment to D122427: [MIPS] Initial support for MIPS-I load delay slots.

Ok, I'll see about committing this tomorrow.

Apr 5 2022, 1:34 PM · Restricted Project, Restricted Project
sdardis accepted D122427: [MIPS] Initial support for MIPS-I load delay slots.

LGTM. Do you have commit access?

Apr 5 2022, 1:07 PM · Restricted Project, Restricted Project
sdardis added a comment to D123023: [DAG] SimplifySetCC - relax fold (X^C1) == C2 --> X == C1^C2.

These MIPS changes look OK to me.

Apr 5 2022, 12:20 PM · Restricted Project, Restricted Project

Mar 29 2022

sdardis added a comment to D122427: [MIPS] Initial support for MIPS-I load delay slots.

Should that be a follow-up patch, or included in this one?

Mar 29 2022, 1:41 PM · Restricted Project, Restricted Project

Mar 25 2022

sdardis added a comment to D122427: [MIPS] Initial support for MIPS-I load delay slots.

Hi @impiaaa, thanks for looking this.

Mar 25 2022, 6:10 PM · Restricted Project, Restricted Project

Mar 26 2020

sdardis added a comment to D76842: [Mips] Make MipsBranchExpansion::replaceBranch() aware of BBIT family of branch.

Two nits inlined. Otherwise this patch looks OK, eyeballing the supplied test.

Mar 26 2020, 1:36 PM · Restricted Project

Mar 20 2020

sdardis added a comment to D76247: [MIPS] Implement MIPS3D vector instructions..

Some post commit remarks.

Mar 20 2020, 12:28 PM · Restricted Project

Aug 28 2019

sdardis accepted D66228: [mips] Fix 64-bit address loading in case of applying 32-bit mask to the result.

LGTM.

Aug 28 2019, 12:46 PM · Restricted Project

Aug 21 2019

sdardis added a comment to D66228: [mips] Fix 64-bit address loading in case of applying 32-bit mask to the result.

...
What difference does SYM_32/SYM_64 make, all selected instructions use only 16 bits of something that is resolved later?

Aug 21 2019, 10:54 AM · Restricted Project
sdardis added a comment to D66228: [mips] Fix 64-bit address loading in case of applying 32-bit mask to the result.

Thanks for review. Could you clarify some points in your comments?

The correct approach I believe is to fix the SYM_32 bug, then provide the patterns for cases of where intermediate/end nodes such as MipsHi / MipsLo can appear without an add appearing as their parent node.

  1. If we do not change the getAddrNonPICSym64 function, at some point (before lowering) we anyway(?) get the following chain of commands (add (shl (%hi(sym), 16), %lo(%sym)). How can we lower it to a correct set of instructions, if we do not have a pattern with the shl? Please correct we if I'm wrong.
Aug 21 2019, 10:49 AM · Restricted Project

Aug 15 2019

sdardis requested changes to D66228: [mips] Fix 64-bit address loading in case of applying 32-bit mask to the result.

I took a second look, and I believe this patch is the incorrect solution. The bug actually lies in the implementation of PredicateControl and SYM_32/SYM_64, @Petar.Avramovic nearly spotted it.

Aug 15 2019, 12:56 PM · Restricted Project

Aug 14 2019

sdardis added a comment to D66228: [mips] Fix 64-bit address loading in case of applying 32-bit mask to the result.

This looks OK to me, I'd like to take a hard look at what DAGCombiner is doing here.

Aug 14 2019, 5:04 PM · Restricted Project

Jun 26 2019

xiangzhai awarded D31287: [mips] Fix atomic operations at O0, v3 a Like token.
Jun 26 2019, 8:19 PM · Restricted Project

May 23 2019

sdardis accepted D62166: [mips] Always check that `shift and add` optimization is efficient.

LGTM.

May 23 2019, 2:56 PM · Restricted Project

May 21 2019

sdardis added a comment to D62166: [mips] Always check that `shift and add` optimization is efficient.

I've raised some points inline, I think (a) is most relevant to this patch but shouldn't stop it going forward but should be addressed quickly, (b) and (c) could be noted as TODO:s.

May 21 2019, 4:53 PM · Restricted Project

Apr 26 2019

sdardis added a comment to D48069: [cmake] Disable a GCC optimization when building LLVM for MIPS.

Is there a specific version range of GCC that this miscompile occurs with?

Apr 26 2019, 12:40 PM · Restricted Project

Mar 28 2019

sdardis accepted D59799: [wip][mips] Use AltOrders to prevent using odd FP-registers.

I think this is a viable approach for this issue. Based on the dumps from -debug I can see that the backend should only be selecting even register for FGR32.

Mar 28 2019, 3:18 PM · Restricted Project

Mar 26 2019

sdardis added a comment to D59799: [wip][mips] Use AltOrders to prevent using odd FP-registers.

My initial comments are that this looks ok, but I would like a longer look at it.

Mar 26 2019, 4:59 PM · Restricted Project

Mar 21 2019

sdardis accepted D59575: Mips: Don't create copy of nothing.

Good catch. LGTM.

Mar 21 2019, 11:24 AM

Mar 7 2019

sdardis accepted D58722: [MIPS] [microMIPS] Pattern match TruncIntFP.

One nit inline, but otherwise LGTM.

Mar 7 2019, 11:44 AM · Restricted Project

Mar 6 2019

sdardis requested changes to D58722: [MIPS] [microMIPS] Pattern match TruncIntFP.

Some minor nits inlined, but otherwise the patch is more or less there.

Mar 6 2019, 11:33 AM · Restricted Project

Feb 28 2019

sdardis accepted D58722: [MIPS] [microMIPS] Pattern match TruncIntFP.

Two comments, and some more inlined. Check the formatting of the commit message
body, it should be 80 cols max. Otherwise the log messages can look strange due
to wrapping (I'm using git).

Feb 28 2019, 3:49 PM · Restricted Project

Feb 23 2019

sdardis committed rG86a589e38d7f: [MIPS] Fix a incorrect test. (NFC) (authored by sdardis).
[MIPS] Fix a incorrect test. (NFC)
Feb 23 2019, 7:58 AM
sdardis committed rL354726: [MIPS] Fix a incorrect test. (NFC).
[MIPS] Fix a incorrect test. (NFC)
Feb 23 2019, 7:56 AM

Feb 21 2019

sdardis updated subscribers of D58507: [MIPS] [microMIPS] Fix for filling delay slots for PseudoIndirectBranch_MM.

Sorry I didn't spot this earlier, but in future please ensure 'llvm-commits' is one of the subscribers when creating a review request for LLVM. If you add it after creating a review request, manually add it and write something in the comments field to trigger Phabricator into sending an email or abandon the review request and re-open it with the relevant -commits list as an initial subscriber.

Feb 21 2019, 1:48 PM · Restricted Project
sdardis accepted D58507: [MIPS] [microMIPS] Fix for filling delay slots for PseudoIndirectBranch_MM.

LGTM apart from some minor nits. Please address them before committing.

Feb 21 2019, 11:19 AM · Restricted Project

Feb 13 2019

sdardis added a comment to D57718: [PPC] Adjust the computed branch offset for the possible shorter distance.

Any testcases that can show the problem and test the fix? Thanks.

It can only be triggered by a very large (>32KB) function body because the range of conditional branch is +/- 32KB.

In our case, the large function body is caused by aggressive thinlto guided inlining.

So no small test case can demonstrate the problem :(

Feb 13 2019, 10:14 AM · Restricted Project

Jan 18 2019

sdardis added inline comments to D56878: [mips] Add '-mrelax-pic-calls', '-mno-relax-pic-calls'.
Jan 18 2019, 2:23 PM

Dec 19 2018

sdardis added a comment to D55878: [Driver] Use --hash-style=gnu instead of both on FreeBSD.

I can't find rationale behind the MIPS discrepancy in the original commit. I can add the if branch back if you tell me why...

Dec 19 2018, 12:13 PM · Restricted Project

Oct 29 2018

sdardis accepted D53366: [mips][micromips] Add pattern for JmpLink to TargetExternalSymbol.

LGTM. Just remember to upload the patches with context.

Oct 29 2018, 12:49 PM

Oct 22 2018

sdardis added inline comments to D53366: [mips][micromips] Add pattern for JmpLink to TargetExternalSymbol.
Oct 22 2018, 1:06 PM

Sep 10 2018

sdardis added inline comments to D51810: [MIPS] Fix illegal type assert in single-float mode.
Sep 10 2018, 10:38 AM
sdardis added inline comments to D51810: [MIPS] Fix illegal type assert in single-float mode.
Sep 10 2018, 10:37 AM

Aug 30 2018

sdardis added inline comments to D51356: [docs][mips] Clang 7.0 Release notes.
Aug 30 2018, 2:44 AM

Jul 6 2018

sdardis updated subscribers of D47192: [utils] Reflow asm check generation to tolerate blank lines.

Ping.

Jul 6 2018, 9:11 AM · Restricted Project
sdardis added a comment to D48069: [cmake] Disable a GCC optimization when building LLVM for MIPS.

Ping.

Jul 6 2018, 9:10 AM · Restricted Project

Jun 27 2018

sdardis added reviewers for D47947: [mips] Support shrink-wrapping: atanasyan, abeserminji, smaksimovic.
Jun 27 2018, 10:24 AM

Jun 22 2018

sdardis added a reviewer for D48507: [mips] Explicitly specify the linker emulation for MIPS on FreeBSD.: atanasyan.
Jun 22 2018, 7:16 PM

Jun 21 2018

sdardis committed rL335269: [mips] Modify comment to test new email address (NFC)..
[mips] Modify comment to test new email address (NFC).
Jun 21 2018, 11:57 AM

Jun 20 2018

sdardis committed rL335185: [mips] Add microMIPS specific addressing patterns..
[mips] Add microMIPS specific addressing patterns.
Jun 20 2018, 3:44 PM
sdardis closed D48275: [mips] Add microMIPS specific addressing patterns..
Jun 20 2018, 3:44 PM
sdardis committed rL335178: Remove myself from the release testers list. (NFC).
Remove myself from the release testers list. (NFC)
Jun 20 2018, 2:30 PM
sdardis committed rL335162: [mips] Correct predicates for loads, bit manipulation instructions and some….
[mips] Correct predicates for loads, bit manipulation instructions and some…
Jun 20 2018, 1:04 PM
sdardis closed D48216: [mips] Correct predicates for loads, bit manipulation instructions and some pseudos.
Jun 20 2018, 1:04 PM
sdardis added a reviewer for D31557: [mips][ias] Enable IAS by default for OpenBSD / FreeBSD mips64/mips64el.: atanasyan.
Jun 20 2018, 1:02 PM
sdardis added a reviewer for D25622: [mips] Check that emitted instructions meet their predicates on Mips: sdardis.
Jun 20 2018, 10:37 AM
sdardis created D48379: [mips] Mark standard encoded instructions as not being in MIPS16e.
Jun 20 2018, 10:16 AM
sdardis created D48365: [mips] Eliminate the usage of hasStdEnc in MipsPat..
Jun 20 2018, 6:48 AM
sdardis committed rL335122: [mips] Fix the predicates of some DSP instructions from AdditionalPredicates to….
[mips] Fix the predicates of some DSP instructions from AdditionalPredicates to…
Jun 20 2018, 6:34 AM
sdardis closed D48166: [mips] Fix the predicates of some DSP instructions from AdditionalPredicates to ASEPredicate.
Jun 20 2018, 6:34 AM
sdardis updated the diff for D48275: [mips] Add microMIPS specific addressing patterns..

Address comment.

Jun 20 2018, 6:06 AM
sdardis added a comment to D47192: [utils] Reflow asm check generation to tolerate blank lines.

Ping.

Jun 20 2018, 5:16 AM · Restricted Project

Jun 19 2018

sdardis committed rL335057: [mips] Mark microMIPS64 as being unsupported..
[mips] Mark microMIPS64 as being unsupported.
Jun 19 2018, 9:10 AM
sdardis closed D48320: [mips] Mark microMIPS64 as being unsupported..
Jun 19 2018, 9:10 AM
sdardis committed rL335053: [mips] Fix the predicates of some aliases.
[mips] Fix the predicates of some aliases
Jun 19 2018, 8:29 AM
sdardis closed D48321: [mips] Fix the predicates of some aliases.
Jun 19 2018, 8:29 AM
sdardis created D48321: [mips] Fix the predicates of some aliases.
Jun 19 2018, 6:48 AM
sdardis created D48320: [mips] Mark microMIPS64 as being unsupported..
Jun 19 2018, 6:35 AM
sdardis updated subscribers of D25622: [mips] Check that emitted instructions meet their predicates on Mips.

Looking at this again and with trunk, I'm seeing two failing tests with a small change inlined:

Jun 19 2018, 5:42 AM
sdardis updated the diff for D48216: [mips] Correct predicates for loads, bit manipulation instructions and some pseudos.

Added tests, and corrected the definition of the rdhwr instruction.

Jun 19 2018, 2:46 AM

Jun 18 2018

sdardis created D48275: [mips] Add microMIPS specific addressing patterns..
Jun 18 2018, 4:51 AM

Jun 15 2018

sdardis created D48217: [mips][wip] Disable the selection of mixed microMIPS/MIPS code.
Jun 15 2018, 6:47 AM
sdardis committed rL334827: [mips] Add licensing information of the microMIPS tablegen files. (NFC).
[mips] Add licensing information of the microMIPS tablegen files. (NFC)
Jun 15 2018, 6:34 AM
sdardis added inline comments to D48169: [mips] Add '-mcrc', '-mno-crc' options to enable/disable CRC ASE.
Jun 15 2018, 6:31 AM
sdardis created D48216: [mips] Correct predicates for loads, bit manipulation instructions and some pseudos.
Jun 15 2018, 5:22 AM

Jun 14 2018

sdardis committed rL334720: [docs] Update CompilerWriterInfo.rst for MIPS.
[docs] Update CompilerWriterInfo.rst for MIPS
Jun 14 2018, 8:21 AM