sdardis (Simon Dardis)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 19 2015, 4:53 AM (148 w, 2 d)

Recent Activity

Fri, Apr 20

sdardis created D45908: [WIP][mips] Correct the definitions of some special control instructions.
Fri, Apr 20, 4:07 PM
sdardis created D45870: [mips] Fix the definition of sync, synci.
Fri, Apr 20, 3:55 AM

Thu, Apr 19

sdardis created D45816: [mips] Correct the patterns for bswap.
Thu, Apr 19, 7:07 AM
sdardis committed rL330326: [mips] Correct the definitions of the unaligned word memory operation….
[mips] Correct the definitions of the unaligned word memory operation…
Thu, Apr 19, 6:37 AM
sdardis closed D45626: [mips] Correct the definitions of the unaligned word memory operation instructions.
Thu, Apr 19, 6:37 AM
sdardis added a reviewer for D45691: [mips] Use libatomic instead of GCC intrinsics for 64bit: Hahnfeld.

One major comment inlined, I'd like one of the other reviewers to chime in if it's the better solution.

Thu, Apr 19, 5:34 AM
sdardis requested changes to D45768: [mips] Implement GetWriteFlag() for mips.
Thu, Apr 19, 3:42 AM · Restricted Project
sdardis requested changes to D44684: [mips] Improve handling of -fno-[pic/PIC] option.

A quick comment on the error message, inlined. It's about the quality of the diagnostics.

Thu, Apr 19, 3:42 AM
sdardis planned changes to D45364: [mips] Update the generic model not to use instruction itineraries.

Looks like I missed some instructions. I'll update this patch shortly.

Thu, Apr 19, 2:52 AM
sdardis committed rL330315: [mips] Guard some macro expansions properly.
[mips] Guard some macro expansions properly
Thu, Apr 19, 2:48 AM
sdardis closed D45565: [mips] Guard some macro expansions properly.
Thu, Apr 19, 2:48 AM
sdardis added inline comments to D45768: [mips] Implement GetWriteFlag() for mips.
Thu, Apr 19, 2:30 AM · Restricted Project
sdardis requested changes to D45760: Emit a left-shift instead of a power-of-two multiply for jump-tables.

I think we need to modify LegalizeDAG .cpp here directly to eliminate the multiplication, as the legalizer has legalized the ISD::BR_JT into an address synthesis, load and multiplication. The legalizer then recursively legalizes the multiplication into a mult/mflo pair.

Thu, Apr 19, 2:14 AM

Tue, Apr 17

sdardis added reviewers for D45691: [mips] Use libatomic instead of GCC intrinsics for 64bit: AndreyChurbanov, jlpeyton.

Can you re-upload this with full context?

Tue, Apr 17, 8:42 AM

Fri, Apr 13

sdardis committed rL330037: [mips] Materialize constants for multiplication.
[mips] Materialize constants for multiplication
Fri, Apr 13, 9:12 AM
sdardis closed D45316: [mips] Materialize constants for multiplication.
Fri, Apr 13, 9:12 AM
sdardis created D45626: [mips] Correct the definitions of the unaligned word memory operation instructions.
Fri, Apr 13, 8:35 AM
sdardis accepted D44381: [mips] Prevent PIC to be set to level 2.

LGTM.

Fri, Apr 13, 8:14 AM
sdardis added a comment to D44905: [mips] Add support for Virtualization ASE.

Only some minor nits now, inlined.

Fri, Apr 13, 3:33 AM
sdardis added a comment to D45316: [mips] Materialize constants for multiplication.

Thanks for the review.

Fri, Apr 13, 2:54 AM

Thu, Apr 12

sdardis added a comment to D45020: [mips] Accept 32-bit offsets for lb and lbu commands.

we should use the 'mem' operand for the lb and lbu instructions. That will allow the parser to match larger offsets than those instructions permit.

BTW do you suggest to escape sub-classing the 'mem' operand at all? If so, we won't be able to diagnose that an operand does not fit 32 or 64 bit range.

Thu, Apr 12, 12:20 PM
sdardis committed rL329913: [mips] Correct the predicates of the load/store (double)word for coprocessor 3..
[mips] Correct the predicates of the load/store (double)word for coprocessor 3.
Thu, Apr 12, 7:44 AM
sdardis created D45565: [mips] Guard some macro expansions properly.
Thu, Apr 12, 5:43 AM
sdardis committed rL329905: [mips] Correct the predicates for special nops, tlb ctrl instrs, software….
[mips] Correct the predicates for special nops, tlb ctrl instrs, software…
Thu, Apr 12, 5:40 AM
sdardis closed D44436: [mips] Correct the predicates for special nops, tlb ctrl instrs, software breakpoint and prefx..
Thu, Apr 12, 5:40 AM
sdardis added inline comments to D44905: [mips] Add support for Virtualization ASE.
Thu, Apr 12, 4:02 AM

Wed, Apr 11

sdardis committed rL329800: Merging r325647, r325713:.
Merging r325647, r325713:
Wed, Apr 11, 6:06 AM
sdardis committed rL329799: Merging r325651:.
Merging r325651:
Wed, Apr 11, 6:02 AM
sdardis committed rL329798: Merging r325653 with test fixups:.
Merging r325653 with test fixups:
Wed, Apr 11, 5:59 AM
sdardis accepted D44304: [MIPS GlobalISel] Select add i32, i32.

Ok. The translation is covered by the irtranslator tests, so we should catch any unexpected changes.

Wed, Apr 11, 5:10 AM
sdardis added a comment to D44304: [MIPS GlobalISel] Select add i32, i32.

The LLVM-IR in the MIR test files doesn't match the MIR below, but I haven't checked if that makes a difference.

Wed, Apr 11, 4:37 AM

Tue, Apr 10

sdardis committed rL329688: [compiler-rt][asan][mips] UnXFAIL some consistently passing tests.
[compiler-rt][asan][mips] UnXFAIL some consistently passing tests
Tue, Apr 10, 4:13 AM
sdardis committed rCRT329688: [compiler-rt][asan][mips] UnXFAIL some consistently passing tests.
[compiler-rt][asan][mips] UnXFAIL some consistently passing tests
Tue, Apr 10, 4:12 AM

Fri, Apr 6

sdardis committed rCRT329422: [compiler-rt][dfsan][mips] UnXPASS a consistently passing test.
[compiler-rt][dfsan][mips] UnXPASS a consistently passing test
Fri, Apr 6, 10:10 AM
sdardis committed rL329422: [compiler-rt][dfsan][mips] UnXPASS a consistently passing test.
[compiler-rt][dfsan][mips] UnXPASS a consistently passing test
Fri, Apr 6, 10:06 AM
sdardis created D45364: [mips] Update the generic model not to use instruction itineraries.
Fri, Apr 6, 4:50 AM
sdardis accepted D45318: [mips] Restrict certain trap instructions for micromipsr6.

LGTM.

Fri, Apr 6, 3:33 AM
sdardis requested changes to D44381: [mips] Prevent PIC to be set to level 2.

You should also update the description of the patch.

Fri, Apr 6, 3:11 AM

Thu, Apr 5

sdardis created D45316: [mips] Materialize constants for multiplication.
Thu, Apr 5, 5:54 AM
sdardis committed rL329268: [mips] Regenerate test before posting patch for constant multiplication (NFC).
[mips] Regenerate test before posting patch for constant multiplication (NFC)
Thu, Apr 5, 3:33 AM

Wed, Apr 4

sdardis added a comment to D45020: [mips] Accept 32-bit offsets for lb and lbu commands.

I don't think this is quite the correct approach, especially if you're going to be implementing support for 64-bit pointers with those instructions, as we would need to modify the existing lb64 and friends to be available to the AsmParser with a different set of operands.

Wed, Apr 4, 5:43 AM
sdardis requested changes to D44905: [mips] Add support for Virtualization ASE.

This looks mostly ok. The big changes required is that these instructions should go in the relevant base architecture .td, as I don't believe there's enough of them to warrant going into two separate files.

Wed, Apr 4, 4:26 AM
sdardis added a comment to D43509: [libcxx][cmake] Remove libatomic temporarily from CMAKE_REQUIRED_LIBRARIES when configuring.

Thanks for the review.

Wed, Apr 4, 4:12 AM
sdardis committed rCXX329167: [libcxx][cmake] Remove libatomic temporarily from CMAKE_REQUIRED_LIBRARIES when….
[libcxx][cmake] Remove libatomic temporarily from CMAKE_REQUIRED_LIBRARIES when…
Wed, Apr 4, 4:09 AM
sdardis committed rL329167: [libcxx][cmake] Remove libatomic temporarily from CMAKE_REQUIRED_LIBRARIES when….
[libcxx][cmake] Remove libatomic temporarily from CMAKE_REQUIRED_LIBRARIES when…
Wed, Apr 4, 4:09 AM
sdardis closed D43509: [libcxx][cmake] Remove libatomic temporarily from CMAKE_REQUIRED_LIBRARIES when configuring.
Wed, Apr 4, 4:09 AM
sdardis updated the summary of D45245: [mips] Update the P5600 scheduler model not to use instruction itineraries..
Wed, Apr 4, 3:28 AM
sdardis created D45245: [mips] Update the P5600 scheduler model not to use instruction itineraries..
Wed, Apr 4, 3:23 AM
sdardis added a comment to D43509: [libcxx][cmake] Remove libatomic temporarily from CMAKE_REQUIRED_LIBRARIES when configuring.

Ping.

Wed, Apr 4, 2:00 AM

Tue, Apr 3

sdardis committed rCTE329053: [clangd][cmake] Provide libatomic when there is no native support for 64bit….
[clangd][cmake] Provide libatomic when there is no native support for 64bit…
Tue, Apr 3, 2:44 AM
sdardis committed rL329053: [clangd][cmake] Provide libatomic when there is no native support for 64bit….
[clangd][cmake] Provide libatomic when there is no native support for 64bit…
Tue, Apr 3, 2:43 AM
sdardis closed D44248: [clangd][cmake] Provide libatomic when there is no native support for 64bit atomics.
Tue, Apr 3, 2:43 AM

Mon, Apr 2

sdardis added a comment to D43509: [libcxx][cmake] Remove libatomic temporarily from CMAKE_REQUIRED_LIBRARIES when configuring.

Ping.

Mon, Apr 2, 2:12 AM

Thu, Mar 29

sdardis committed rL328767: [Mips] Remove dead code.
[Mips] Remove dead code
Thu, Mar 29, 2:24 AM
sdardis closed D44867: [Mips] Remove dead code.
Thu, Mar 29, 2:24 AM
sdardis added inline comments to D44381: [mips] Prevent PIC to be set to level 2.
Thu, Mar 29, 1:59 AM
sdardis added a comment to D39115: [MIPS][MicroMIPS] Extending size reduction pass with LWP and SWP.

Hi Milena, sorry for the delay in getting back to this, I', currently on holiday but I will get back to looking at this sometime next week.

Thu, Mar 29, 1:54 AM

Mon, Mar 26

sdardis accepted D44867: [Mips] Remove dead code.

LGTM, I'm not seeing an implementation of that method or a callee.

Mon, Mar 26, 6:38 AM

Mar 20 2018

sdardis added a comment to D44016: [LiveDebugValues] Track transferring variable's value from one register to another.

Some small nits inlined, I've mostly looked at the non debug related parts. A lot of my comments are the MIPS .td parts can be summarized as: where possible, modify the underlying *_DESC or MXC1 classes where possible rather than wrapping the definition of the instruction with a 'isRegMove = 1'. There are some cases where it can't be done as the instruction description class is shared multiple other instructions which are not moves.

Mar 20 2018, 7:10 AM · debug-info

Mar 19 2018

sdardis added a comment to D43235: [SchedModel] Complete models shouldn't match against itineraries when they don't use them (PR35639) (WIP).

@RKSimon , I'm ok with this going in, I'm in process of updating our scheduler models to account for this but it may take me a few days.

Mar 19 2018, 8:23 AM
sdardis added a comment to D44248: [clangd][cmake] Provide libatomic when there is no native support for 64bit atomics.

Thanks, I wasn't sure who to add as a reviewer.

Mar 19 2018, 4:43 AM
sdardis added a comment to D44248: [clangd][cmake] Provide libatomic when there is no native support for 64bit atomics.

Ping?

Mar 19 2018, 4:27 AM

Mar 16 2018

sdardis committed rL327757: Backporting r325647 and r325713:.
Backporting r325647 and r325713:
Mar 16 2018, 3:30 PM
sdardis committed rL327755: Backporting 325651::.
Backporting 325651::
Mar 16 2018, 3:23 PM
sdardis committed rL327751: Backporting r325653:.
Backporting r325653:
Mar 16 2018, 3:17 PM

Mar 13 2018

sdardis committed rL327427: Revert "[mips] Guard traps for microMIPS correctly".
Revert "[mips] Guard traps for microMIPS correctly"
Mar 13 2018, 10:35 AM
sdardis created D44436: [mips] Correct the predicates for special nops, tlb ctrl instrs, software breakpoint and prefx..
Mar 13 2018, 9:04 AM
sdardis committed rL327409: [mips] Guard traps for microMIPS correctly.
[mips] Guard traps for microMIPS correctly
Mar 13 2018, 8:49 AM
sdardis closed D44212: [mips] Guard traps for microMIPS correctly.
Mar 13 2018, 8:49 AM
sdardis committed rL327403: [mips] Fix the definitions of the EVA instructions.
[mips] Fix the definitions of the EVA instructions
Mar 13 2018, 7:42 AM
sdardis closed D44209: [mips] Fix the definitions of the EVA instructions.
Mar 13 2018, 7:42 AM
sdardis committed rL327388: [mips] Don't create nested CALLSEQ_START..CALLSEQ_END nodes..
[mips] Don't create nested CALLSEQ_START..CALLSEQ_END nodes.
Mar 13 2018, 5:52 AM
sdardis closed D44296: [mips] Don't create nested CALLSEQ_START..CALLSEQ_END nodes..
Mar 13 2018, 5:52 AM
sdardis updated the diff for D44209: [mips] Fix the definitions of the EVA instructions.

Update to remove unrelated changes to trap instructions.

Mar 13 2018, 4:44 AM
sdardis added inline comments to D44209: [mips] Fix the definitions of the EVA instructions.
Mar 13 2018, 4:27 AM
sdardis accepted D44176: [mips] Add support for CRC ASE.

LGTM with inline nits addressed.

Mar 13 2018, 4:17 AM
sdardis added a comment to D44381: [mips] Prevent PIC to be set to level 2.

This patch looks mostly ok, but I think there are some small issues with it.

Mar 13 2018, 3:59 AM
sdardis added inline comments to D44016: [LiveDebugValues] Track transferring variable's value from one register to another.
Mar 13 2018, 3:23 AM · debug-info

Mar 12 2018

sdardis committed rL327265: [mips] Split out ASEPredicate from InsnPredicates (NFC).
[mips] Split out ASEPredicate from InsnPredicates (NFC)
Mar 12 2018, 6:19 AM
sdardis closed D44299: [mips] Split out ASEPredicate from InsnPredicates (NFC).
Mar 12 2018, 6:19 AM

Mar 9 2018

sdardis updated the diff for D44209: [mips] Fix the definitions of the EVA instructions.

Update to account for splitting out one of the changes into D44299.

Mar 9 2018, 5:58 AM
sdardis updated the diff for D44299: [mips] Split out ASEPredicate from InsnPredicates (NFC).

Minor update, incorrect predicates for (s|l)w(l|r)e, fixed the ASE_EVA class overwriting the InsnPredicates instead of the ASEPredicates.

Mar 9 2018, 5:41 AM
sdardis added a dependent revision for D44299: [mips] Split out ASEPredicate from InsnPredicates (NFC): D44209: [mips] Fix the definitions of the EVA instructions.
Mar 9 2018, 5:26 AM
sdardis added a dependency for D44209: [mips] Fix the definitions of the EVA instructions: D44299: [mips] Split out ASEPredicate from InsnPredicates (NFC).
Mar 9 2018, 5:26 AM
sdardis added a comment to D44176: [mips] Add support for CRC ASE.

If you look at the dependency, you'll see the way I've separated out the ISA level from the ASEs.

Mar 9 2018, 5:23 AM
sdardis added a dependent revision for D44299: [mips] Split out ASEPredicate from InsnPredicates (NFC): D44176: [mips] Add support for CRC ASE.
Mar 9 2018, 5:20 AM
sdardis added a dependency for D44176: [mips] Add support for CRC ASE: D44299: [mips] Split out ASEPredicate from InsnPredicates (NFC).
Mar 9 2018, 5:20 AM
sdardis created D44299: [mips] Split out ASEPredicate from InsnPredicates (NFC).
Mar 9 2018, 5:16 AM
sdardis planned changes to D44209: [mips] Fix the definitions of the EVA instructions.

Based on my comments on D44176, I'm preparing another patch which is the splitting out of the ASEPredicate from InsnPredicates in PredicateControl.

Mar 9 2018, 3:32 AM
sdardis updated the summary of D44296: [mips] Don't create nested CALLSEQ_START..CALLSEQ_END nodes..
Mar 9 2018, 3:22 AM
sdardis created D44296: [mips] Don't create nested CALLSEQ_START..CALLSEQ_END nodes..
Mar 9 2018, 3:21 AM

Mar 8 2018

sdardis added inline comments to D44176: [mips] Add support for CRC ASE.
Mar 8 2018, 7:48 AM
sdardis created D44248: [clangd][cmake] Provide libatomic when there is no native support for 64bit atomics.
Mar 8 2018, 4:57 AM

Mar 7 2018

sdardis added a comment to D43509: [libcxx][cmake] Remove libatomic temporarily from CMAKE_REQUIRED_LIBRARIES when configuring.

Ping.

Mar 7 2018, 8:54 AM
sdardis created D44212: [mips] Guard traps for microMIPS correctly.
Mar 7 2018, 8:38 AM
sdardis created D44209: [mips] Fix the definitions of the EVA instructions.
Mar 7 2018, 7:59 AM
sdardis requested changes to D44176: [mips] Add support for CRC ASE.

This looks mostly ok. There's only some small changes required, and they are somewhat minor. The recurring change is that for test cases, when there is a run-on line with '\', then the continuation of the command line should be indented by two spaces.

Mar 7 2018, 7:47 AM
sdardis committed rL326890: [mips] Correct the definition of m(f|t)c(0|2).
[mips] Correct the definition of m(f|t)c(0|2)
Mar 7 2018, 3:43 AM
sdardis closed D41662: [mips] Correct the definition of m(f|t)c(0|2).
Mar 7 2018, 3:42 AM

Mar 5 2018

sdardis added a comment to D44016: [LiveDebugValues] Track transferring variable's value from one register to another.

Some comments on the MIPS part of this patch inlined.

Mar 5 2018, 7:28 AM · debug-info