sdardis (Simon Dardis)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 19 2015, 4:53 AM (156 w, 6 d)

Recent Activity

Yesterday

sdardis committed rL335185: [mips] Add microMIPS specific addressing patterns..
[mips] Add microMIPS specific addressing patterns.
Wed, Jun 20, 3:44 PM
sdardis closed D48275: [mips] Add microMIPS specific addressing patterns..
Wed, Jun 20, 3:44 PM
sdardis committed rL335178: Remove myself from the release testers list. (NFC).
Remove myself from the release testers list. (NFC)
Wed, Jun 20, 2:30 PM
sdardis committed rL335162: [mips] Correct predicates for loads, bit manipulation instructions and some….
[mips] Correct predicates for loads, bit manipulation instructions and some…
Wed, Jun 20, 1:04 PM
sdardis closed D48216: [mips] Correct predicates for loads, bit manipulation instructions and some pseudos.
Wed, Jun 20, 1:04 PM
sdardis added a reviewer for D31557: [mips][ias] Enable IAS by default for OpenBSD / FreeBSD mips64/mips64el.: atanasyan.
Wed, Jun 20, 1:02 PM
sdardis added a reviewer for D25622: [mips] Check that emitted instructions meet their predicates on Mips: sdardis.
Wed, Jun 20, 10:37 AM
sdardis created D48379: [mips] Mark standard encoded instructions as not being in MIPS16e.
Wed, Jun 20, 10:16 AM
sdardis created D48365: [mips] Eliminate the usage of hasStdEnc in MipsPat..
Wed, Jun 20, 6:48 AM
sdardis committed rL335122: [mips] Fix the predicates of some DSP instructions from AdditionalPredicates to….
[mips] Fix the predicates of some DSP instructions from AdditionalPredicates to…
Wed, Jun 20, 6:34 AM
sdardis closed D48166: [mips] Fix the predicates of some DSP instructions from AdditionalPredicates to ASEPredicate.
Wed, Jun 20, 6:34 AM
sdardis updated the diff for D48275: [mips] Add microMIPS specific addressing patterns..

Address comment.

Wed, Jun 20, 6:06 AM
sdardis added a comment to D47192: [utils] Reflow asm check generation to tolerate blank lines.

Ping.

Wed, Jun 20, 5:16 AM

Tue, Jun 19

sdardis committed rL335057: [mips] Mark microMIPS64 as being unsupported..
[mips] Mark microMIPS64 as being unsupported.
Tue, Jun 19, 9:10 AM
sdardis closed D48320: [mips] Mark microMIPS64 as being unsupported..
Tue, Jun 19, 9:10 AM
sdardis committed rL335053: [mips] Fix the predicates of some aliases.
[mips] Fix the predicates of some aliases
Tue, Jun 19, 8:29 AM
sdardis closed D48321: [mips] Fix the predicates of some aliases.
Tue, Jun 19, 8:29 AM
sdardis added a dependency for D25622: [mips] Check that emitted instructions meet their predicates on Mips: D48321: [mips] Fix the predicates of some aliases.
Tue, Jun 19, 6:48 AM
sdardis added a dependent revision for D48321: [mips] Fix the predicates of some aliases: D25622: [mips] Check that emitted instructions meet their predicates on Mips.
Tue, Jun 19, 6:48 AM
sdardis created D48321: [mips] Fix the predicates of some aliases.
Tue, Jun 19, 6:48 AM
sdardis added a dependency for D25622: [mips] Check that emitted instructions meet their predicates on Mips: D48320: [mips] Mark microMIPS64 as being unsupported..
Tue, Jun 19, 6:36 AM
sdardis added a dependent revision for D48320: [mips] Mark microMIPS64 as being unsupported.: D25622: [mips] Check that emitted instructions meet their predicates on Mips.
Tue, Jun 19, 6:36 AM
sdardis created D48320: [mips] Mark microMIPS64 as being unsupported..
Tue, Jun 19, 6:35 AM
sdardis updated subscribers of D25622: [mips] Check that emitted instructions meet their predicates on Mips.

Looking at this again and with trunk, I'm seeing two failing tests with a small change inlined:

Tue, Jun 19, 5:42 AM
sdardis updated the diff for D48216: [mips] Correct predicates for loads, bit manipulation instructions and some pseudos.

Added tests, and corrected the definition of the rdhwr instruction.

Tue, Jun 19, 2:46 AM

Mon, Jun 18

sdardis created D48275: [mips] Add microMIPS specific addressing patterns..
Mon, Jun 18, 4:51 AM

Fri, Jun 15

sdardis added dependencies for D48217: [mips][wip] Disable the selection of mixed microMIPS/MIPS code: D48216: [mips] Correct predicates for loads, bit manipulation instructions and some pseudos, D48166: [mips] Fix the predicates of some DSP instructions from AdditionalPredicates to ASEPredicate.
Fri, Jun 15, 6:48 AM
sdardis added a dependent revision for D48216: [mips] Correct predicates for loads, bit manipulation instructions and some pseudos: D48217: [mips][wip] Disable the selection of mixed microMIPS/MIPS code.
Fri, Jun 15, 6:48 AM
sdardis added a dependent revision for D48166: [mips] Fix the predicates of some DSP instructions from AdditionalPredicates to ASEPredicate: D48217: [mips][wip] Disable the selection of mixed microMIPS/MIPS code.
Fri, Jun 15, 6:48 AM
sdardis created D48217: [mips][wip] Disable the selection of mixed microMIPS/MIPS code.
Fri, Jun 15, 6:47 AM
sdardis committed rL334827: [mips] Add licensing information of the microMIPS tablegen files. (NFC).
[mips] Add licensing information of the microMIPS tablegen files. (NFC)
Fri, Jun 15, 6:34 AM
sdardis added inline comments to D48169: [mips] Add '-mcrc', '-mno-crc' options to enable/disable CRC ASE.
Fri, Jun 15, 6:31 AM
sdardis created D48216: [mips] Correct predicates for loads, bit manipulation instructions and some pseudos.
Fri, Jun 15, 5:22 AM

Thu, Jun 14

sdardis committed rL334720: [docs] Update CompilerWriterInfo.rst for MIPS.
[docs] Update CompilerWriterInfo.rst for MIPS
Thu, Jun 14, 8:21 AM
sdardis created D48166: [mips] Fix the predicates of some DSP instructions from AdditionalPredicates to ASEPredicate.
Thu, Jun 14, 6:18 AM
sdardis committed rL334708: [mips] Correct predicates for MSA pseudo instructions.
[mips] Correct predicates for MSA pseudo instructions
Thu, Jun 14, 6:08 AM

Wed, Jun 13

sdardis updated the diff for D31287: [mips] Fix atomic operations at O0, v3.

Actually include the expansion pass.

Wed, Jun 13, 8:50 AM
sdardis added inline comments to D48019: [mips] Handle branch expansion corner cases.
Wed, Jun 13, 6:59 AM
sdardis updated the diff for D31287: [mips] Fix atomic operations at O0, v3.

Moved pass to after the scheduler and machine block placement.
Normalized the probabilities for the successors of modified basic blocks for sanity purposes.

Wed, Jun 13, 5:19 AM
sdardis added inline comments to D31287: [mips] Fix atomic operations at O0, v3.
Wed, Jun 13, 4:43 AM
sdardis retitled D31287: [mips] Fix atomic operations at O0, v3 from [mips] Fix atomic compare and swap at O0, v3 to [mips] Fix atomic operations at O0, v3.
Wed, Jun 13, 2:25 AM

Tue, Jun 12

sdardis added inline comments to D47947: [mips] Support shrink-wrapping.
Tue, Jun 12, 9:20 AM
sdardis added inline comments to D47718: [Mips] Use UADDO/ADDCARRY instead of ADDC/ADDE.
Tue, Jun 12, 9:13 AM
sdardis committed rL334491: [mips] Guard some floating point instructions correctly.
[mips] Guard some floating point instructions correctly
Tue, Jun 12, 3:32 AM
sdardis closed D47636: [mips] Guard some floating point instructions correctly.
Tue, Jun 12, 3:32 AM
sdardis added a comment to D47829: [Driver] Accept the -fno-shrink-wrap option for GCC compatibility.

Is this something which is actually useful to control? From your description, you want to add the flag to clang not because you actually want to use it, but just because you can't figure out how to pass the right flags to your clang build.

If it is useful, it should be implemented as a function attribute, not a global flag.

Tue, Jun 12, 3:28 AM
sdardis created D48069: [cmake] Disable a GCC optimization when building LLVM for MIPS.
Tue, Jun 12, 3:16 AM
sdardis updated the diff for D47829: [Driver] Accept the -fno-shrink-wrap option for GCC compatibility.

Modify implementation to produce a function attribute.

Tue, Jun 12, 2:26 AM
sdardis created D48064: [CodeGen][shrinkWrapping] Implement the no-shrink-wrap function attribute..
Tue, Jun 12, 2:24 AM

Mon, Jun 11

sdardis added inline comments to D48019: [mips] Handle branch expansion corner cases.
Mon, Jun 11, 8:05 AM
sdardis added inline comments to D47947: [mips] Support shrink-wrapping.
Mon, Jun 11, 7:07 AM
sdardis accepted D47941: [mips] Add additional parameter to LONG_BRANCH_LUi/ADDiu pseudo instructions.

LGTM with nit addressed.

Mon, Jun 11, 4:22 AM
sdardis added inline comments to D31287: [mips] Fix atomic operations at O0, v3.
Mon, Jun 11, 3:55 AM
sdardis updated the diff for D47192: [utils] Reflow asm check generation to tolerate blank lines.

Rebase to master.

Mon, Jun 11, 3:45 AM
sdardis added a comment to D47192: [utils] Reflow asm check generation to tolerate blank lines.

In D48006, you can see the change for the MIPS specific assembly scrubbing to accept inline assembly. I have also included some example output of the changes of that revision. Since the blank lines around the inline assembly are not scrubbed, FileCheck fails the test case with:

Mon, Jun 11, 3:42 AM
sdardis created D48006: [WIP][utils][mips] Modify scrubbing to handle inline ASM .
Mon, Jun 11, 3:22 AM

Sat, Jun 9

sdardis added a comment to D46577: [compiler-rt][cmake][mips] Correct the option handling for GCC 7.

Ping.

Sat, Jun 9, 5:59 AM
sdardis added a comment to D47192: [utils] Reflow asm check generation to tolerate blank lines.

Ping.

Sat, Jun 9, 5:58 AM

Fri, Jun 8

sdardis requested changes to D6229: [mips][microMIPS] Use swm32/lwm32 instructions in function prologue/epilogue.

Please rebase this.

Fri, Jun 8, 6:17 AM
sdardis updated the diff for D47636: [mips] Guard some floating point instructions correctly.

Actually add some tests.

Fri, Jun 8, 6:07 AM
sdardis updated the diff for D47636: [mips] Guard some floating point instructions correctly.

Add tests.

Fri, Jun 8, 5:58 AM
sdardis added inline comments to D47938: [mips] Fix spill slot for mips3, n64 abi.
Fri, Jun 8, 5:04 AM
sdardis accepted D47938: [mips] Fix spill slot for mips3, n64 abi.

Edit the summary so that rather that it says:

Fri, Jun 8, 5:01 AM
sdardis committed rL334280: [mips] Correct the predicates for a number of codegen only instructions.
[mips] Correct the predicates for a number of codegen only instructions
Fri, Jun 8, 4:00 AM
sdardis closed D47638: [mips] Correct the predicates for a number of codegen only instructions.
Fri, Jun 8, 3:59 AM

Thu, Jun 7

sdardis accepted D39115: [MIPS][MicroMIPS] Extending size reduction pass with LWP and SWP.

LGTM.

Thu, Jun 7, 5:55 AM
sdardis accepted D47876: [Mips] Silencing warnings in instruction info (NFC).
Thu, Jun 7, 5:23 AM

Wed, Jun 6

sdardis created D47829: [Driver] Accept the -fno-shrink-wrap option for GCC compatibility.
Wed, Jun 6, 8:31 AM
sdardis added a comment to D47718: [Mips] Use UADDO/ADDCARRY instead of ADDC/ADDE.

The legalization of unsigned i128 addition (rL334094 for the test) looks strange to me in that the determination of the overflow from the first addition is done with setccs. They appear to be originating from the expansion of setcc of an illegal type.

Wed, Jun 6, 7:45 AM
sdardis committed rL334094: [mips] Add testcase for i64, i128 addition for the DSP ASE.
[mips] Add testcase for i64, i128 addition for the DSP ASE
Wed, Jun 6, 6:34 AM
sdardis committed rL334084: [mips] Partially revert r334031.
[mips] Partially revert r334031
Wed, Jun 6, 3:58 AM
sdardis added a comment to D47638: [mips] Correct the predicates for a number of codegen only instructions.

This particular case is not quite testable, as GPR64s are only available when we have 64 bit registers. Adding GPR_64 predicates to these instructions is somewhat overkill, but does simplify fixing up the scheduler models later.

Wed, Jun 6, 2:26 AM

Tue, Jun 5

sdardis committed rL334031: [mips] Fix the predicates for arithmetic operations.
[mips] Fix the predicates for arithmetic operations
Tue, Jun 5, 10:57 AM
sdardis closed D47635: [mips] Fix the predicates for arithmetic operations.
Tue, Jun 5, 10:57 AM
sdardis accepted D47703: [Mips] Remove uneeded variants of ADDC/ADDE lowering.
Tue, Jun 5, 7:59 AM

Mon, Jun 4

sdardis added inline comments to D39115: [MIPS][MicroMIPS] Extending size reduction pass with LWP and SWP.
Mon, Jun 4, 9:24 AM
sdardis accepted D45627: [MIPS GlobalISel] Add lowerCall.

LGTM.

Mon, Jun 4, 9:00 AM
sdardis added a reviewer for D47718: [Mips] Use UADDO/ADDCARRY instead of ADDC/ADDE: sdardis.

I take it that this patch is dependent on D47703 ?

Mon, Jun 4, 7:32 AM
sdardis committed rL333895: [mips] Restore the availablity of trap for microMIPS.
[mips] Restore the availablity of trap for microMIPS
Mon, Jun 4, 5:54 AM
sdardis closed D47584: [mips] Restore the availablity of trap for microMIPS.
Mon, Jun 4, 5:54 AM
sdardis added a reviewer for D47703: [Mips] Remove uneeded variants of ADDC/ADDE lowering: sdardis.
Mon, Jun 4, 4:52 AM
sdardis added inline comments to D47703: [Mips] Remove uneeded variants of ADDC/ADDE lowering.
Mon, Jun 4, 4:49 AM
sdardis updated the diff for D47635: [mips] Fix the predicates for arithmetic operations.

Add tests.

Mon, Jun 4, 4:18 AM

Fri, Jun 1

sdardis created D47638: [mips] Correct the predicates for a number of codegen only instructions.
Fri, Jun 1, 8:20 AM
sdardis created D47636: [mips] Guard some floating point instructions correctly.
Fri, Jun 1, 8:04 AM
sdardis created D47635: [mips] Fix the predicates for arithmetic operations.
Fri, Jun 1, 8:00 AM
sdardis updated the diff for D31287: [mips] Fix atomic operations at O0, v3.

Address review comments.

Fri, Jun 1, 6:52 AM
sdardis committed rL333741: [mips] Guard more aliases correctly..
[mips] Guard more aliases correctly.
Fri, Jun 1, 4:01 AM
sdardis committed rL333739: [mips] Guard 'nop' properly and add mips16's nop instruction.
[mips] Guard 'nop' properly and add mips16's nop instruction
Fri, Jun 1, 3:50 AM
sdardis closed D47583: [mips] Guard 'nop' properly and add mips16's nop instruction.
Fri, Jun 1, 3:50 AM
sdardis committed rL333736: [mips] Select the correct instruction for computing frameindexes.
[mips] Select the correct instruction for computing frameindexes
Fri, Jun 1, 3:11 AM
sdardis closed D47582: [mips] Select the correct instruction for computing frameindexes.
Fri, Jun 1, 3:11 AM

Thu, May 31

sdardis added a comment to D46577: [compiler-rt][cmake][mips] Correct the option handling for GCC 7.

Ping.

Thu, May 31, 6:52 AM
sdardis added inline comments to D39115: [MIPS][MicroMIPS] Extending size reduction pass with LWP and SWP.
Thu, May 31, 6:22 AM
sdardis created D47584: [mips] Restore the availablity of trap for microMIPS.
Thu, May 31, 5:55 AM
sdardis committed rL333645: [mips] Guard all short instructions correctly..
[mips] Guard all short instructions correctly.
Thu, May 31, 5:51 AM
sdardis closed D47533: [mips] Guard all short instructions correctly..
Thu, May 31, 5:51 AM
sdardis updated the diff for D47192: [utils] Reflow asm check generation to tolerate blank lines.

Address review comments.

Thu, May 31, 5:35 AM
sdardis added a dependent revision for D47582: [mips] Select the correct instruction for computing frameindexes: D47583: [mips] Guard 'nop' properly and add mips16's nop instruction.
Thu, May 31, 5:26 AM
sdardis added a dependency for D47583: [mips] Guard 'nop' properly and add mips16's nop instruction: D47582: [mips] Select the correct instruction for computing frameindexes.
Thu, May 31, 5:26 AM