User Details
- User Since
- Jun 19 2015, 4:53 AM (432 w, 5 d)
Jul 2 2023
LGTM. After checking the classes removed, they fall into the cases of classes that were added for completeness' sake or were never expanded on. The microMIPS64R6 class was missed during the removal of support for that ISA variant.
May 23 2023
LGTM.
May 22 2023
Oct 23 2022
That's certainly completely wrong, and, indeed, bolsters my point that MIPS16 object file emission can't possibly have worked before.
May 15 2022
LGTM.
Nit: the summary should have the line--"This resolves PR/54991" to aid in bug tracking.
May 12 2022
Thanks for the review, @atanasyan . I went with changing the regexes back to the style in the existing file.
Thanks for the review.
May 11 2022
May 10 2022
Thanks for the review, I'll try to get this committed in the next few days.
May 1 2022
Apr 30 2022
NFC: Remove some extraneous test lines and a small grammar correction
Apr 29 2022
Thanks for the review, I've updated the bug number in the commit message.
Apr 28 2022
Apr 24 2022
LGTM.
Apr 18 2022
Apr 15 2022
Apr 13 2022
LGTM with the nit addressed.
Apr 12 2022
Apr 11 2022
LGTM.
Apr 6 2022
Thank you for the patch.
Apr 5 2022
Ok, I'll see about committing this tomorrow.
LGTM. Do you have commit access?
These MIPS changes look OK to me.
Mar 29 2022
Should that be a follow-up patch, or included in this one?
Mar 25 2022
Hi @impiaaa, thanks for looking this.
Mar 26 2020
Two nits inlined. Otherwise this patch looks OK, eyeballing the supplied test.
Mar 20 2020
Some post commit remarks.
Aug 28 2019
LGTM.
Aug 21 2019
Aug 15 2019
I took a second look, and I believe this patch is the incorrect solution. The bug actually lies in the implementation of PredicateControl and SYM_32/SYM_64, @Petar.Avramovic nearly spotted it.
Aug 14 2019
This looks OK to me, I'd like to take a hard look at what DAGCombiner is doing here.
Jun 26 2019
May 23 2019
LGTM.
May 21 2019
I've raised some points inline, I think (a) is most relevant to this patch but shouldn't stop it going forward but should be addressed quickly, (b) and (c) could be noted as TODO:s.
Apr 26 2019
Mar 28 2019
I think this is a viable approach for this issue. Based on the dumps from -debug I can see that the backend should only be selecting even register for FGR32.
Mar 26 2019
My initial comments are that this looks ok, but I would like a longer look at it.
Mar 21 2019
Mar 7 2019
One nit inline, but otherwise LGTM.
Mar 6 2019
Some minor nits inlined, but otherwise the patch is more or less there.
Feb 28 2019
Two comments, and some more inlined. Check the formatting of the commit message
body, it should be 80 cols max. Otherwise the log messages can look strange due
to wrapping (I'm using git).
Feb 23 2019
Feb 21 2019
Sorry I didn't spot this earlier, but in future please ensure 'llvm-commits' is one of the subscribers when creating a review request for LLVM. If you add it after creating a review request, manually add it and write something in the comments field to trigger Phabricator into sending an email or abandon the review request and re-open it with the relevant -commits list as an initial subscriber.
LGTM apart from some minor nits. Please address them before committing.
Feb 13 2019
Jan 18 2019
Dec 19 2018
I can't find rationale behind the MIPS discrepancy in the original commit. I can add the if branch back if you tell me why...
Oct 29 2018
LGTM. Just remember to upload the patches with context.
Oct 22 2018
Sep 10 2018
Aug 30 2018
Jul 6 2018
Ping.
Ping.
Jun 27 2018
Jun 22 2018
Jun 21 2018
Jun 20 2018
Address comment.
Ping.
Jun 19 2018
Looking at this again and with trunk, I'm seeing two failing tests with a small change inlined:
Added tests, and corrected the definition of the rdhwr instruction.