Page MenuHomePhabricator

[NFC] Refactor the systemZ scheduler strategy to adapt with the new schedule state forwarding infrastructure
Needs ReviewPublic

Authored by steven.zhang on Apr 28 2019, 7:38 PM.

Details

Summary

This refactor base on the patch https://reviews.llvm.org/D61248. Update the scheduler strategy for system Z to adapt with the schedule state forward infrastructure.

Diff Detail

Event Timeline

steven.zhang created this revision.Apr 28 2019, 7:38 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 28 2019, 7:38 PM
lei added a subscriber: lei.Wed, Jun 12, 7:43 AM
lei added inline comments.
llvm/lib/Target/SystemZ/SystemZMachineScheduler.h
139

nit: so that, its... -> so its scheduled state...

149

I find this explanation some what confusing and it's also different from the function definition below.
Should it be something similar to what was doc below originally on line 37?

amyk added a subscriber: amyk.Wed, Jun 12, 10:40 AM
amyk added inline comments.
llvm/lib/Target/SystemZ/SystemZMachineScheduler.cpp
83

when enter the MBB -> when entering the MBB

121

Should the dbgs() be on a new line?

llvm/lib/Target/SystemZ/SystemZMachineScheduler.h
138

stragegy -> strategy