Depends on: https://reviews.llvm.org/D52898
Hi @hiraditya , pardon my ignorance in this part of llvm. Most of my comments are questions about your reasoning.
|73 ↗||(On Diff #169613)|
Why did you change these to externs?
|89 ↗||(On Diff #169613)|
Where is this function defined now?
|92 ↗||(On Diff #169613)|
Was this intentional, to add this diff with the entire profile function commented out?
|1137 ↗||(On Diff #169613)|
Maybe comment here that 0 is a placeholder/invalid hash?
|1169 ↗||(On Diff #169613)|
|1228 ↗||(On Diff #169613)|
Where/how is this used by the patch? I don't see any use here. I tried finding in one of the other 4 related patches, but didn't see it being used there either.