Page MenuHomePhabricator
People evgeny777

evgeny777 (Eugene Leviant)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 1 2015, 3:36 AM (185 w, 4 d)

Recent Activity
View All

Tue, Mar 19

evgeny777 added inline comments to D59351: [llvm-objcopy] Add --update-section.
Tue, Mar 19, 3:09 AM

Mon, Mar 18

evgeny777 added a comment to D59351: [llvm-objcopy] Add --update-section.

I suspect that this is going to interact nastily with D59843.

Mon, Mar 18, 6:56 AM

Thu, Mar 14

evgeny777 accepted D57470: [ThinLTO] Restructure AliasSummary to contain ValueInfo of Aliasee.

This should be rebased against r354850. Otherwise LGTM.

Thu, Mar 14, 4:14 AM · Restricted Project
evgeny777 created D59351: [llvm-objcopy] Add --update-section.
Thu, Mar 14, 3:11 AM

Tue, Mar 12

evgeny777 committed rGc76671b23191: [llvm-objcopy] Remove unneeded checks. NFC (authored by evgeny777).
[llvm-objcopy] Remove unneeded checks. NFC
Tue, Mar 12, 5:43 AM
evgeny777 committed rL355914: [llvm-objcopy] Remove unneeded checks. NFC.
[llvm-objcopy] Remove unneeded checks. NFC
Tue, Mar 12, 5:43 AM
evgeny777 closed D59081: [llvm-objcopy] Remove unneeded checks. NFC.
Tue, Mar 12, 5:43 AM · Restricted Project
evgeny777 committed rG1e249caaec39: [CGP] Fix UB when GEP is bound to trivial PHINode (authored by evgeny777).
[CGP] Fix UB when GEP is bound to trivial PHINode
Tue, Mar 12, 3:10 AM
evgeny777 committed rL355904: [CGP] Fix UB when GEP is bound to trivial PHINode.
[CGP] Fix UB when GEP is bound to trivial PHINode
Tue, Mar 12, 3:10 AM
evgeny777 closed D59140: [CGP] Fix UB when removing trivial PHINode.
Tue, Mar 12, 3:10 AM · Restricted Project

Fri, Mar 8

evgeny777 added a reviewer for D59140: [CGP] Fix UB when removing trivial PHINode: dexonsmith.
Fri, Mar 8, 10:11 AM · Restricted Project
evgeny777 created D59140: [CGP] Fix UB when removing trivial PHINode.
Fri, Mar 8, 9:54 AM · Restricted Project

Thu, Mar 7

evgeny777 created D59081: [llvm-objcopy] Remove unneeded checks. NFC.
Thu, Mar 7, 2:01 AM · Restricted Project

Sun, Mar 3

evgeny777 committed rGdaea28ab6480: [DebugInfo] Construct nested types on behalf of owner CU (authored by evgeny777).
[DebugInfo] Construct nested types on behalf of owner CU
Sun, Mar 3, 11:16 PM
evgeny777 committed rL355303: [DebugInfo] Construct nested types on behalf of owner CU.
[DebugInfo] Construct nested types on behalf of owner CU
Sun, Mar 3, 11:14 PM
evgeny777 closed D58786: [DebugInfo] Construct nested types on behalf of owner CU.
Sun, Mar 3, 11:14 PM · Restricted Project

Fri, Mar 1

evgeny777 updated the diff for D58786: [DebugInfo] Construct nested types on behalf of owner CU.

Split getOrCreateTypeDIE

Fri, Mar 1, 5:31 AM · Restricted Project
evgeny777 added a comment to D58786: [DebugInfo] Construct nested types on behalf of owner CU.

Would it be possible/practical/reasonable to split getOrCreateTypeDIE

I think so, but I thought it's easier to do things this way, because AFAIK:

  • DIBaseType and DISubroutineType can't introduce the problem because they're either bound to variable or typedef (DIDerivedType)
  • Using type units also isn't problematic because in such case DINodes are not shareable across CUs
Fri, Mar 1, 1:22 AM · Restricted Project

Thu, Feb 28

evgeny777 created D58786: [DebugInfo] Construct nested types on behalf of owner CU.
Thu, Feb 28, 8:01 AM · Restricted Project

Wed, Feb 27

evgeny777 committed rG7f78d4712f91: [DebugInfo] Apply subprogram attributes on behalf of owner CU (authored by evgeny777).
[DebugInfo] Apply subprogram attributes on behalf of owner CU
Wed, Feb 27, 6:47 AM
evgeny777 committed rL354978: [DebugInfo] Apply subprogram attributes on behalf of owner CU.
[DebugInfo] Apply subprogram attributes on behalf of owner CU
Wed, Feb 27, 6:46 AM
evgeny777 closed D58538: [DebugInfo] Add source attributes for function declaration on behalf of owner CU.
Wed, Feb 27, 6:46 AM · Restricted Project

Tue, Feb 26

evgeny777 updated the diff for D58538: [DebugInfo] Add source attributes for function declaration on behalf of owner CU.

Shortened test case a little

Tue, Feb 26, 4:20 AM · Restricted Project
evgeny777 committed rG53350d041154: [llvm-objcopy] Add --set-start, --change-start and --adjust-start (authored by evgeny777).
[llvm-objcopy] Add --set-start, --change-start and --adjust-start
Tue, Feb 26, 1:26 AM
evgeny777 committed rL354854: [llvm-objcopy] Add --set-start, --change-start and --adjust-start.
[llvm-objcopy] Add --set-start, --change-start and --adjust-start
Tue, Feb 26, 1:26 AM
evgeny777 closed D58173: [llvm-objcopy] Add --set-start, --change-start, --adjust-start.
Tue, Feb 26, 1:25 AM · Restricted Project

Mon, Feb 25

evgeny777 committed rG24b3d258bbea: [ThinLTO] Use defined node and edge order when dumping DOT file (authored by evgeny777).
[ThinLTO] Use defined node and edge order when dumping DOT file
Mon, Feb 25, 11:38 PM
evgeny777 committed rL354850: [ThinLTO] Use defined node and edge order when dumping DOT file.
[ThinLTO] Use defined node and edge order when dumping DOT file
Mon, Feb 25, 11:38 PM
evgeny777 closed D58631: [ThinLTO] Use defined node and edge order when dumping DOT files.
Mon, Feb 25, 11:37 PM · Restricted Project
evgeny777 added inline comments to D58538: [DebugInfo] Add source attributes for function declaration on behalf of owner CU.
Mon, Feb 25, 10:17 PM · Restricted Project
evgeny777 created D58631: [ThinLTO] Use defined node and edge order when dumping DOT files.
Mon, Feb 25, 9:23 AM · Restricted Project
evgeny777 updated the diff for D58173: [llvm-objcopy] Add --set-start, --change-start, --adjust-start.

Addressed and rebased

Mon, Feb 25, 6:32 AM · Restricted Project
evgeny777 committed rG51c1f640aa41: [llvm-objcopy] Add --add-symbol (authored by evgeny777).
[llvm-objcopy] Add --add-symbol
Mon, Feb 25, 6:12 AM
evgeny777 committed rL354787: [llvm-objcopy] Add --add-symbol.
[llvm-objcopy] Add --add-symbol
Mon, Feb 25, 6:12 AM
evgeny777 closed D58234: [llvm-objcopy] Add --add-symbol.
Mon, Feb 25, 6:12 AM · Restricted Project
evgeny777 added inline comments to D58173: [llvm-objcopy] Add --set-start, --change-start, --adjust-start.
Mon, Feb 25, 2:17 AM · Restricted Project
evgeny777 updated the diff for D58538: [DebugInfo] Add source attributes for function declaration on behalf of owner CU.

I think the point where we lookup the other CU and cross over to it should probably be earlier - imagine if all attributes could potentially be CU-local (eg: we could produce a separate string_offsets section for each CU and so have separate strx indexes for each CU) & we should probably have a solution that would be correct in that situation. Does that make sense?

Mon, Feb 25, 12:41 AM · Restricted Project

Fri, Feb 22

evgeny777 updated the diff for D58173: [llvm-objcopy] Add --set-start, --change-start, --adjust-start.

Didn't realize that D58316 has been pushed. Rebased.

Fri, Feb 22, 8:18 AM · Restricted Project
evgeny777 updated the diff for D58234: [llvm-objcopy] Add --add-symbol.

Addressed

Fri, Feb 22, 8:17 AM · Restricted Project
evgeny777 updated the diff for D58173: [llvm-objcopy] Add --set-start, --change-start, --adjust-start.

Addressed

Fri, Feb 22, 4:34 AM · Restricted Project

Thu, Feb 21

evgeny777 created D58538: [DebugInfo] Add source attributes for function declaration on behalf of owner CU.
Thu, Feb 21, 11:59 PM · Restricted Project

Feb 21 2019

evgeny777 added a comment to D58173: [llvm-objcopy] Add --set-start, --change-start, --adjust-start.

Isn't it an overkill to cover all possible misuses? This is a developer tool so far ...

Feb 21 2019, 11:28 AM · Restricted Project
evgeny777 added a comment to D58234: [llvm-objcopy] Add --add-symbol.

Sorry to be the Grinch again but what is the use case for this?

Feb 21 2019, 8:25 AM · Restricted Project

Feb 20 2019

evgeny777 updated the diff for D58173: [llvm-objcopy] Add --set-start, --change-start, --adjust-start.
  • added test case for negative hexadecimal number
  • changed way error handling is done
Feb 20 2019, 2:43 AM · Restricted Project
evgeny777 added inline comments to D58234: [llvm-objcopy] Add --add-symbol.
Feb 20 2019, 2:35 AM · Restricted Project
evgeny777 updated the diff for D58234: [llvm-objcopy] Add --add-symbol.

Addressed

Feb 20 2019, 12:19 AM · Restricted Project

Feb 19 2019

evgeny777 requested changes to D58384: [ThinLTO] Fix test with reverse-iteration.

The same logic should also be done for the DOT emission I believe.

Feb 19 2019, 9:54 AM · Restricted Project
evgeny777 added a comment to D58384: [ThinLTO] Fix test with reverse-iteration.

Can you sort the edges/nodes/etc. somehow to avoid this

Feb 19 2019, 9:35 AM · Restricted Project
evgeny777 accepted D58384: [ThinLTO] Fix test with reverse-iteration.

LGTM, but please wait for a while for Teresa to take a look as well

Feb 19 2019, 9:19 AM · Restricted Project
evgeny777 added a comment to D58384: [ThinLTO] Fix test with reverse-iteration.

Summary clusters, nodes and edges are retrieved from DenseMap with arbitrary order, which doesn't make result DOT file invalid.
Reverse iteration just exposes test issues.

Feb 19 2019, 8:33 AM · Restricted Project
evgeny777 updated the diff for D58234: [llvm-objcopy] Add --add-symbol.

Addressed

Feb 19 2019, 5:45 AM · Restricted Project
evgeny777 added a comment to D58173: [llvm-objcopy] Add --set-start, --change-start, --adjust-start.

--adjust-start causes an underflow. I think this should be an error.

Feb 19 2019, 2:27 AM · Restricted Project
evgeny777 updated the diff for D58173: [llvm-objcopy] Add --set-start, --change-start, --adjust-start.

Addressed

Feb 19 2019, 2:27 AM · Restricted Project
evgeny777 added a comment to D58173: [llvm-objcopy] Add --set-start, --change-start, --adjust-start.

I don't personally have a use case for this, but I could imagine a program with multiple possible start locations, and these switches allow switching between them. I'd like to here the concrete use case though.

Feb 19 2019, 2:23 AM · Restricted Project

Feb 15 2019

evgeny777 updated the diff for D58173: [llvm-objcopy] Add --set-start, --change-start, --adjust-start.

Addressed some of review comments

Feb 15 2019, 2:20 AM · Restricted Project
evgeny777 updated the diff for D58234: [llvm-objcopy] Add --add-symbol.

Addressed some of review comments

Feb 15 2019, 2:02 AM · Restricted Project
evgeny777 added inline comments to D58234: [llvm-objcopy] Add --add-symbol.
Feb 15 2019, 12:35 AM · Restricted Project

Feb 14 2019

evgeny777 added a comment to D58116: [llvm-objcopy] Improve section removal.

Can we get an explicit real use case

Feb 14 2019, 11:51 PM
evgeny777 added inline comments to D58173: [llvm-objcopy] Add --set-start, --change-start, --adjust-start.
Feb 14 2019, 10:43 PM · Restricted Project
evgeny777 created D58234: [llvm-objcopy] Add --add-symbol.
Feb 14 2019, 6:02 AM · Restricted Project

Feb 13 2019

evgeny777 updated the diff for D58173: [llvm-objcopy] Add --set-start, --change-start, --adjust-start.

Addressed

Feb 13 2019, 8:03 AM · Restricted Project
evgeny777 created D58173: [llvm-objcopy] Add --set-start, --change-start, --adjust-start.
Feb 13 2019, 5:27 AM · Restricted Project

Feb 12 2019

evgeny777 committed rG2db10629061a: [llvm-objcopy] Add --strip-unneeded-symbol(s) (authored by evgeny777).
[llvm-objcopy] Add --strip-unneeded-symbol(s)
Feb 12 2019, 11:35 PM
evgeny777 committed rL353919: [llvm-objcopy] Add --strip-unneeded-symbol(s).
[llvm-objcopy] Add --strip-unneeded-symbol(s)
Feb 12 2019, 11:35 PM
evgeny777 closed D58027: [llvm-objcopy] Add --strip-unneeded-symbol(s).
Feb 12 2019, 11:35 PM · Restricted Project
evgeny777 updated the summary of D58116: [llvm-objcopy] Improve section removal.
Feb 12 2019, 9:59 AM
evgeny777 created D58116: [llvm-objcopy] Improve section removal.
Feb 12 2019, 6:05 AM

Feb 11 2019

evgeny777 updated the diff for D58027: [llvm-objcopy] Add --strip-unneeded-symbol(s).

Addressed

Feb 11 2019, 5:31 AM · Restricted Project
evgeny777 added inline comments to D58027: [llvm-objcopy] Add --strip-unneeded-symbol(s).
Feb 11 2019, 4:53 AM · Restricted Project
evgeny777 committed rG6bcf6358eb29: Attempt to fix buildbot after r353679 #2 (authored by evgeny777).
Attempt to fix buildbot after r353679 #2
Feb 11 2019, 2:20 AM
evgeny777 committed rL353683: Attempt to fix buildbot after r353679 #2.
Attempt to fix buildbot after r353679 #2
Feb 11 2019, 2:19 AM
evgeny777 committed rG6aaa8bfef8d8: Attempt to fix buildbot after r353679 (authored by evgeny777).
Attempt to fix buildbot after r353679
Feb 11 2019, 2:12 AM
evgeny777 committed rL353681: Attempt to fix buildbot after r353679.
Attempt to fix buildbot after r353679
Feb 11 2019, 2:12 AM
evgeny777 committed rG317f9e7ae77b: Small refactoring of FileError. NFC. (authored by evgeny777).
Small refactoring of FileError. NFC.
Feb 11 2019, 1:50 AM
evgeny777 committed rL353679: Small refactoring of FileError. NFC..
Small refactoring of FileError. NFC.
Feb 11 2019, 1:49 AM
evgeny777 closed D57945: Small refactoring of FileError. NFC.
Feb 11 2019, 1:49 AM · Restricted Project
evgeny777 created D58027: [llvm-objcopy] Add --strip-unneeded-symbol(s).
Feb 11 2019, 12:28 AM · Restricted Project

Feb 8 2019

evgeny777 committed rGe08fe35d7908: [llvm-objcopy] Add few file processing directives (authored by evgeny777).
[llvm-objcopy] Add few file processing directives
Feb 8 2019, 6:38 AM
evgeny777 committed rL353521: [llvm-objcopy] Add few file processing directives.
[llvm-objcopy] Add few file processing directives
Feb 8 2019, 6:38 AM
evgeny777 closed D57877: [llvm-objcopy] Add few file processing directives.
Feb 8 2019, 6:38 AM · Restricted Project
evgeny777 created D57945: Small refactoring of FileError. NFC.
Feb 8 2019, 5:32 AM · Restricted Project
evgeny777 committed rGfc6d29dff939: Attempt to fix build bot after r353509 (authored by evgeny777).
Attempt to fix build bot after r353509
Feb 8 2019, 2:53 AM
evgeny777 committed rL353510: Attempt to fix build bot after r353509.
Attempt to fix build bot after r353509
Feb 8 2019, 2:50 AM
evgeny777 committed rG340cb87e833b: [llvm-objcopy] Add --redefine-syms (authored by evgeny777).
[llvm-objcopy] Add --redefine-syms
Feb 8 2019, 2:34 AM
evgeny777 committed rL353509: [llvm-objcopy] Add --redefine-syms.
[llvm-objcopy] Add --redefine-syms
Feb 8 2019, 2:33 AM
evgeny777 closed D57738: [llvm-objcopy] Add --redefine-syms.
Feb 8 2019, 2:33 AM · Restricted Project
evgeny777 updated the diff for D57877: [llvm-objcopy] Add few file processing directives.

Test case fix

Feb 8 2019, 1:33 AM · Restricted Project
evgeny777 updated the diff for D57877: [llvm-objcopy] Add few file processing directives.

Better tests

Feb 8 2019, 1:06 AM · Restricted Project
evgeny777 updated the diff for D57738: [llvm-objcopy] Add --redefine-syms.

Addressed

Feb 8 2019, 12:37 AM · Restricted Project

Feb 7 2019

evgeny777 updated the diff for D57738: [llvm-objcopy] Add --redefine-syms.

Addressed

Feb 7 2019, 6:35 AM · Restricted Project
evgeny777 updated the diff for D57738: [llvm-objcopy] Add --redefine-syms.

Addressed

Feb 7 2019, 4:55 AM · Restricted Project
evgeny777 added a comment to D57738: [llvm-objcopy] Add --redefine-syms.

Actually, on second thoughts, I think this should be an error. If a user specifies a line in the file that is a bad format, that's as bad as doing the same on the command-line, so should be treated with the same severity.

Feb 7 2019, 2:18 AM · Restricted Project
evgeny777 added inline comments to D57877: [llvm-objcopy] Add few file processing directives.
Feb 7 2019, 1:32 AM · Restricted Project
evgeny777 updated the diff for D57738: [llvm-objcopy] Add --redefine-syms.

Addressed

Feb 7 2019, 12:42 AM · Restricted Project
evgeny777 created D57877: [llvm-objcopy] Add few file processing directives.
Feb 7 2019, 12:02 AM · Restricted Project

Feb 6 2019

evgeny777 added inline comments to D57680: [llvm-objdump] Implement `-Mreg-names-raw`/`-std` options..
Feb 6 2019, 10:28 AM · Restricted Project
evgeny777 added inline comments to D57680: [llvm-objdump] Implement `-Mreg-names-raw`/`-std` options..
Feb 6 2019, 10:17 AM · Restricted Project
evgeny777 added a comment to D57738: [llvm-objcopy] Add --redefine-syms.

I was actually referring to --redefine-syms, i.e. how it looks in a file. Did you mean "not allow" rather than "now allow" in that other statement?

Feb 6 2019, 7:33 AM · Restricted Project
evgeny777 added a comment to D57738: [llvm-objcopy] Add --redefine-syms.

@jhenderson

One question from me: is it possible using GNU objcopy to redefine to/from a name with a space in it this way?

Feb 6 2019, 6:56 AM · Restricted Project
evgeny777 committed rGef6eba2401bf: Attempt to fix buildbot after r353289 (authored by evgeny777).
Attempt to fix buildbot after r353289
Feb 6 2019, 5:47 AM