Depends on: https://reviews.llvm.org/D52898
Hi @hiraditya , pardon my ignorance in this part of llvm. Most of my comments are questions about your reasoning.
Why did you change these to externs?
Where is this function defined now?
Was this intentional, to add this diff with the entire profile function commented out?
Maybe comment here that 0 is a placeholder/invalid hash?
Where/how is this used by the patch? I don't see any use here. I tried finding in one of the other 4 related patches, but didn't see it being used there either.