Page MenuHomePhabricator

vish99 (Vishal Chebrolu)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 18 2020, 10:06 PM (20 w, 1 d)

Recent Activity

Tue, Aug 4

vish99 updated the diff for D82892: [NFC] Added comparision for all types in haveSameSpecialState() of Instruction.cpp.

Changed compareInstSpecificProperies() methods to protected and added comparision of elemnet types of pointers in compareTypes()

Tue, Aug 4, 8:41 AM · Restricted Project

Thu, Jul 30

vish99 added a comment to D82892: [NFC] Added comparision for all types in haveSameSpecialState() of Instruction.cpp.

Quoting the observed text segment sizes for few object files in MySQL, by enabling MergeFunctions by default and comparing them with baseline.

FILENAMEBaselineWith-mergefuncSize reduction %
none.cpp.o(ex libbinlogevents.a)91377115.5%
mysqlrouter26,81124,4548.7%
load_data_events.cpp.o (ex libbinlogstandalone.a)3,4593,1718.3%
rows_event.cpp.o (ex libbinlogstandalone.a)18,26416,7568.2%
control_events.cpp.o (ex libbinlogstandalone.a)13,82013,0185.8%
iterator.cpp.o (ex libbinlogevents.a)3,7753,5874.9%
mysqlrouter_passwd56,87554,1294.8%
mysqld55,329,09552,690,0494.7%
binlog_event.cpp.o (ex libbinlogstandalone.a)2,5252,4303.7%
rows_event.cpp.o (ex libbinlogevents.a)15,44214,8883.5%
control_events.cpp.o (ex libbinlogevents.a)12,47012,0503.3%
Thu, Jul 30, 9:25 AM · Restricted Project
vish99 added a comment to D82892: [NFC] Added comparision for all types in haveSameSpecialState() of Instruction.cpp.
Thu, Jul 30, 9:15 AM · Restricted Project

Wed, Jul 29

vish99 added a comment to D82892: [NFC] Added comparision for all types in haveSameSpecialState() of Instruction.cpp.

Ran the llvm test-suite. All the tests were going fine.

Wed, Jul 29, 8:44 AM · Restricted Project

Thu, Jul 23

vish99 updated the diff for D82892: [NFC] Added comparision for all types in haveSameSpecialState() of Instruction.cpp.

Changed name from haveSameSpecialState() to compareSpecialState()

Thu, Jul 23, 12:15 AM · Restricted Project

Sun, Jul 19

vish99 updated the diff for D82892: [NFC] Added comparision for all types in haveSameSpecialState() of Instruction.cpp.

Changed named of comparator method in each subclass to compareInstSpecificProperties()

Sun, Jul 19, 12:35 PM · Restricted Project

Sat, Jul 18

vish99 updated the diff for D82892: [NFC] Added comparision for all types in haveSameSpecialState() of Instruction.cpp.

Comment added

Sat, Jul 18, 10:30 PM · Restricted Project
vish99 updated the diff for D82892: [NFC] Added comparision for all types in haveSameSpecialState() of Instruction.cpp.

Changed hasSamePropertiesAs() method in each subclass of IR to introduce total ordering between two instructions of that subclass
and modified FunctionComparator to use haveSameSpecialState() method for IR comparision.

Sat, Jul 18, 12:58 PM · Restricted Project

Tue, Jul 14

vish99 added a comment to D82892: [NFC] Added comparision for all types in haveSameSpecialState() of Instruction.cpp.

Why not just make hasSamePropertiesAs a pure virtual on Instruction, then you don't need any switch statement in haveSameSpecialState? You'd need to do the cast on the Instruction operand within the implementations, but that would be cleaner IMO. For the ones that currently return true, you wouldn't need the cast just an opcode comparison.

Tue, Jul 14, 12:35 PM · Restricted Project
vish99 added a comment to D82892: [NFC] Added comparision for all types in haveSameSpecialState() of Instruction.cpp.

@jfb @tejohnson, just reminding you of the review as the patch has been lying dormant since a week.

Tue, Jul 14, 7:36 AM · Restricted Project

Fri, Jul 10

vish99 updated the diff for D82892: [NFC] Added comparision for all types in haveSameSpecialState() of Instruction.cpp.

Comment added

Fri, Jul 10, 10:36 AM · Restricted Project

Jul 8 2020

vish99 added a comment to D82892: [NFC] Added comparision for all types in haveSameSpecialState() of Instruction.cpp.

Is this a bug fix? If it is NFC (No Functional Change) please specify that in the title, otherwise needs a test case.

Jul 8 2020, 2:27 AM · Restricted Project
vish99 updated the summary of D82892: [NFC] Added comparision for all types in haveSameSpecialState() of Instruction.cpp.
Jul 8 2020, 2:27 AM · Restricted Project

Jul 4 2020

vish99 abandoned D76521: [MergeSimilarFunctions] D52896, D52898, D52966 and D53253 merged into LLVM trunk.
Jul 4 2020, 12:29 AM · Restricted Project, Restricted Project
vish99 abandoned D76487: [MergeSimilarFunctions] D52896 merged into LLVM trunk.
Jul 4 2020, 12:29 AM · Restricted Project
vish99 abandoned D76517: [MegreSimilarFunctions] D52896, D52898 and D52966 merged into LLVM trunk.
Jul 4 2020, 12:29 AM · Restricted Project, Restricted Project
vish99 abandoned D76488: [MergeSimilarFunctions] D52896, D52898 merged into LLVM trunk.
Jul 4 2020, 12:29 AM · Restricted Project

Jul 3 2020

vish99 updated the diff for D82892: [NFC] Added comparision for all types in haveSameSpecialState() of Instruction.cpp.

Added hasSamePropertiesAs() method in each subclass of the IR which should say how two IR instructions of that subclass should be compared.
Changed haveSameSpecialState() method to make use of the hasSamePropertiesAs() methods.
When there is a change to IR, only the hasSamePropertiesAs() method needs of that subclass need to be updated.

Jul 3 2020, 11:52 AM · Restricted Project

Jul 1 2020

vish99 updated the diff for D82892: [NFC] Added comparision for all types in haveSameSpecialState() of Instruction.cpp.

Added case for Freeze instruction.

Jul 1 2020, 9:10 AM · Restricted Project
vish99 updated the diff for D82892: [NFC] Added comparision for all types in haveSameSpecialState() of Instruction.cpp.

Added comparision for all types in haveSameSpecialState() of Instruction.cpp and changed the if-else branching to switch over the Instruction Opcode

Jul 1 2020, 8:37 AM · Restricted Project
vish99 added a comment to D82892: [NFC] Added comparision for all types in haveSameSpecialState() of Instruction.cpp.

At this point, I would recommend writing this as a switch over the instruction opcode.

Jul 1 2020, 8:37 AM · Restricted Project

Jun 30 2020

vish99 added a comment to D81369: [Alignment][NFC] Migrate AtomicExpandPass to Align.

@vish99 will your work in https://reviews.llvm.org/D82892 check alignment changes as well?

Jun 30 2020, 10:11 PM · Restricted Project
vish99 created D82892: [NFC] Added comparision for all types in haveSameSpecialState() of Instruction.cpp.
Jun 30 2020, 10:50 AM · Restricted Project

Jun 17 2020

vish99 updated the summary of D82039: Integrated cmpOperations() of FunctionComparator into tblgen.
Jun 17 2020, 12:24 PM · Restricted Project
vish99 created D82039: Integrated cmpOperations() of FunctionComparator into tblgen.
Jun 17 2020, 12:24 PM · Restricted Project

Jun 13 2020

vish99 updated the summary of D81790: Added hasSamePropertiesAs method for CmpXchgInst and FenceInst.
Jun 13 2020, 10:42 AM · Restricted Project
vish99 created D81790: Added hasSamePropertiesAs method for CmpXchgInst and FenceInst.
Jun 13 2020, 10:42 AM · Restricted Project

Jun 7 2020

vish99 updated the summary of D81349: Added checks for BinaryOperation, InsertElement, ExtractElement and changed return value in FunctionComparator.
Jun 7 2020, 12:46 PM · Restricted Project
vish99 created D81349: Added checks for BinaryOperation, InsertElement, ExtractElement and changed return value in FunctionComparator.
Jun 7 2020, 12:46 PM · Restricted Project

Mar 20 2020

vish99 retitled D76522: [MergeSimilarFunctions] D52896, D52898, D52966, D53253, D53254 merged into LLVM trunk from MergeSimilarFunctions 1/n: a code size pass to merge functions with small differences to [MergeSimilarFunctions] D52896, D52898, D52966, D53253, D53254 merged into LLVM trunk.
Mar 20 2020, 1:34 PM · Restricted Project, Restricted Project
vish99 created D76522: [MergeSimilarFunctions] D52896, D52898, D52966, D53253, D53254 merged into LLVM trunk.
Mar 20 2020, 1:34 PM · Restricted Project, Restricted Project
vish99 updated the diff for D53253: [Merge SImilar Function ThinLTO 4/n] Make merge function decisions before the thin-lto stage.

Changes to merge the 5 patches together

Mar 20 2020, 1:01 PM · Restricted Project
vish99 retitled D76521: [MergeSimilarFunctions] D52896, D52898, D52966 and D53253 merged into LLVM trunk from MergeSimilarFunctions 1/n: a code size pass to merge functions with small differences to [MergeSimilarFunctions] D52896, D52898, D52966 and D53253 merged into LLVM trunk.
Mar 20 2020, 12:28 PM · Restricted Project, Restricted Project
vish99 retitled D76517: [MegreSimilarFunctions] D52896, D52898 and D52966 merged into LLVM trunk from D52896, D52898 and D52966 merged into LLVM trunk to [MegreSimilarFunctions] D52896, D52898 and D52966 merged into LLVM trunk.
Mar 20 2020, 12:28 PM · Restricted Project, Restricted Project
vish99 created D76521: [MergeSimilarFunctions] D52896, D52898, D52966 and D53253 merged into LLVM trunk.
Mar 20 2020, 12:28 PM · Restricted Project, Restricted Project
vish99 updated the diff for D52966: [Merge SImilar Function ThinLTO 3/n] Add hash code to function summary.

Changes to the merge the 5 patches together

Mar 20 2020, 12:28 PM · Restricted Project
vish99 retitled D76517: [MegreSimilarFunctions] D52896, D52898 and D52966 merged into LLVM trunk from MergeSimilarFunctions 1/n: a code size pass to merge functions with small differences to D52896, D52898 and D52966 merged into LLVM trunk.
Mar 20 2020, 10:50 AM · Restricted Project, Restricted Project
vish99 created D76517: [MegreSimilarFunctions] D52896, D52898 and D52966 merged into LLVM trunk.
Mar 20 2020, 10:49 AM · Restricted Project, Restricted Project
vish99 updated the diff for D52898: [Porting MergeSimilarFunctions 2/n] Changes to DataLayout.

Changes to merge the 5 patches together

Mar 20 2020, 10:49 AM · Restricted Project, Restricted Project
vish99 updated the diff for D52898: [Porting MergeSimilarFunctions 2/n] Changes to DataLayout.

Reverting back to diff 222348, the previous diff was against a wrong branch

Mar 20 2020, 7:32 AM · Restricted Project, Restricted Project
vish99 updated the diff for D52898: [Porting MergeSimilarFunctions 2/n] Changes to DataLayout.

Changes to sync D52898 with D52966

Mar 20 2020, 7:32 AM · Restricted Project, Restricted Project
vish99 created D76495: Changes to sync patch D52966.
Mar 20 2020, 7:00 AM · Restricted Project
vish99 created D76488: [MergeSimilarFunctions] D52896, D52898 merged into LLVM trunk.
Mar 20 2020, 5:23 AM · Restricted Project
vish99 retitled D76488: [MergeSimilarFunctions] D52896, D52898 merged into LLVM trunk from MergeSimilarFunctions 1/n: a code size pass to merge functions with small differences to [MergeSimilarFunctions] D52896, D52898 merged into LLVM trunk.
Mar 20 2020, 5:23 AM · Restricted Project
vish99 added a reviewer for D76487: [MergeSimilarFunctions] D52896 merged into LLVM trunk: hiraditya.
Mar 20 2020, 4:51 AM · Restricted Project
vish99 updated the summary of D76487: [MergeSimilarFunctions] D52896 merged into LLVM trunk.
Mar 20 2020, 4:51 AM · Restricted Project
vish99 retitled D76487: [MergeSimilarFunctions] D52896 merged into LLVM trunk from MergeSimilarFunctions 1/n: a code size pass to merge functions with small differences to [MergeSimilarFunctions] D52896 merged into LLVM trunk.
Mar 20 2020, 4:51 AM · Restricted Project
vish99 created D76487: [MergeSimilarFunctions] D52896 merged into LLVM trunk.
Mar 20 2020, 4:51 AM · Restricted Project
vish99 abandoned D76486: Merge D52966 into D52898 and D52896.
Mar 20 2020, 4:18 AM · Restricted Project
vish99 created D76486: Merge D52966 into D52898 and D52896.
Mar 20 2020, 3:46 AM · Restricted Project