User Details
- User Since
- Mar 18 2020, 10:06 PM (125 w, 3 d)
Oct 9 2020
Are they any more improvements needed?
Aug 28 2020
Aug 18 2020
Comment Added
Aug 17 2020
clang-format fix
Clang-format fix
Testcase fix
Aug 15 2020
cmpAPInts fix
Aug 14 2020
Added TestCases
Aug 11 2020
Changed IgnoreAlignment and IgnoreMetaData to enum class instead of bool type and fixed clang-tidy warnings.
Clang-tidy warnings fix
Aug 9 2020
Aug 4 2020
Changed compareInstSpecificProperies() methods to protected and added comparision of elemnet types of pointers in compareTypes()
Jul 30 2020
Quoting the observed text segment sizes for few object files in MySQL, by enabling MergeFunctions by default and comparing them with baseline.
FILENAME | Baseline | With-mergefunc | Size reduction % |
none.cpp.o(ex libbinlogevents.a) | 913 | 771 | 15.5% |
mysqlrouter | 26,811 | 24,454 | 8.7% |
load_data_events.cpp.o (ex libbinlogstandalone.a) | 3,459 | 3,171 | 8.3% |
rows_event.cpp.o (ex libbinlogstandalone.a) | 18,264 | 16,756 | 8.2% |
control_events.cpp.o (ex libbinlogstandalone.a) | 13,820 | 13,018 | 5.8% |
iterator.cpp.o (ex libbinlogevents.a) | 3,775 | 3,587 | 4.9% |
mysqlrouter_passwd | 56,875 | 54,129 | 4.8% |
mysqld | 55,329,095 | 52,690,049 | 4.7% |
binlog_event.cpp.o (ex libbinlogstandalone.a) | 2,525 | 2,430 | 3.7% |
rows_event.cpp.o (ex libbinlogevents.a) | 15,442 | 14,888 | 3.5% |
control_events.cpp.o (ex libbinlogevents.a) | 12,470 | 12,050 | 3.3% |
Jul 29 2020
Ran the llvm test-suite. All the tests were going fine.
Jul 23 2020
Changed name from haveSameSpecialState() to compareSpecialState()
Jul 19 2020
Changed named of comparator method in each subclass to compareInstSpecificProperties()
Jul 18 2020
Comment added
Changed hasSamePropertiesAs() method in each subclass of IR to introduce total ordering between two instructions of that subclass
and modified FunctionComparator to use haveSameSpecialState() method for IR comparision.
Jul 14 2020
@jfb @tejohnson, just reminding you of the review as the patch has been lying dormant since a week.
Jul 10 2020
Comment added
Jul 8 2020
Jul 4 2020
Jul 3 2020
Added hasSamePropertiesAs() method in each subclass of the IR which should say how two IR instructions of that subclass should be compared.
Changed haveSameSpecialState() method to make use of the hasSamePropertiesAs() methods.
When there is a change to IR, only the hasSamePropertiesAs() method needs of that subclass need to be updated.
Jul 1 2020
Added case for Freeze instruction.
Added comparision for all types in haveSameSpecialState() of Instruction.cpp and changed the if-else branching to switch over the Instruction Opcode
Jun 30 2020
@vish99 will your work in https://reviews.llvm.org/D82892 check alignment changes as well?
Jun 17 2020
Jun 13 2020
Jun 7 2020
Mar 20 2020
Changes to merge the 5 patches together
Changes to the merge the 5 patches together
Changes to merge the 5 patches together
Reverting back to diff 222348, the previous diff was against a wrong branch