This is an archive of the discontinued LLVM Phabricator instance.

[Asm] Add debug tracing in table-generated assembly matcher

Authored by olista01 on Apr 10 2017, 3:20 AM.



This adds debug tracing to the table-generated assembly instruction matcher, enabled by the -debug-only=asm-matcher option.

The changes in the target AsmParsers are to add an MCInstrInfo reference under a consistent name, so that we can use it from table-generated code. This was already being used this way for targets that use deprecation warnings, but 5 targets did not have it, and Hexagon had it under a different name to the other backends.

Diff Detail


Event Timeline

olista01 created this revision.Apr 10 2017, 3:20 AM
rengolin edited edge metadata.

Adding Eric, for consistency.

Ping (also for the 3 patches dependent on this one).

echristo edited edge metadata.Oct 9 2017, 1:38 PM

Seems that having a value parameter for MII in all of these targets is a little less than desirable. Also, perhaps you could just add it to the base class if you're going to use it everywhere by default?

olista01 updated this revision to Diff 118337.Oct 10 2017, 3:03 AM


  • Move MII at the base class
  • Make MII a reference
echristo accepted this revision.Oct 10 2017, 6:00 PM

LGTM. Thanks!


This revision is now accepted and ready to land.Oct 10 2017, 6:00 PM